All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "akolli@codeaurora.org" <akolli@codeaurora.org>
Cc: "mbizon@freebox.fr" <mbizon@freebox.fr>,
	"linux-wireless-owner@vger.kernel.org"
	<linux-wireless-owner@vger.kernel.org>,
	Anilkumar Kolli <akolli@qti.qualcomm.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
Date: Fri, 1 Dec 2017 15:44:33 +0000	[thread overview]
Message-ID: <87374uxxjy.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <7792e2fb2c546d8745c65e48945f2535@codeaurora.org> (akolli@codeaurora.org's message of "Fri, 01 Dec 2017 19:18:00 +0530")

akolli@codeaurora.org writes:

>>> Parse peer stats from pktlog packets and update the tx rate
>>> information
>>> per STA. This way user space can query about transmit rate with iw:
>>
>> everything works ok, ath10k_update_per_peer_tx_stats() is called and
>> ath10k_sta fields are updated correctly
>>
>> but tx bitrate is still 6 MBit/s in station dump
>>
> Hope CONFIG_MAC80211_DEBUGFS is enabled in your build.
> Please Run ping traffic and see and 'station dump'

This feature should not depend on debugfs. Why is it needed? In patch 1
you already moved pktlog_filter to struct ath10k, does it need something
else as well?

--=20
Kalle Valo=

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "akolli@codeaurora.org" <akolli@codeaurora.org>
Cc: "linux-wireless-owner@vger.kernel.org"
	<linux-wireless-owner@vger.kernel.org>,
	"mbizon@freebox.fr" <mbizon@freebox.fr>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Anilkumar Kolli <akolli@qti.qualcomm.com>
Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
Date: Fri, 1 Dec 2017 15:44:33 +0000	[thread overview]
Message-ID: <87374uxxjy.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <7792e2fb2c546d8745c65e48945f2535@codeaurora.org> (akolli@codeaurora.org's message of "Fri, 01 Dec 2017 19:18:00 +0530")

akolli@codeaurora.org writes:

>>> Parse peer stats from pktlog packets and update the tx rate
>>> information
>>> per STA. This way user space can query about transmit rate with iw:
>>
>> everything works ok, ath10k_update_per_peer_tx_stats() is called and
>> ath10k_sta fields are updated correctly
>>
>> but tx bitrate is still 6 MBit/s in station dump
>>
> Hope CONFIG_MAC80211_DEBUGFS is enabled in your build.
> Please Run ping traffic and see and 'station dump'

This feature should not depend on debugfs. Why is it needed? In patch 1
you already moved pktlog_filter to struct ath10k, does it need something
else as well?

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2017-12-01 15:44 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 12:58 [PATCH 0/2] ath10k: tx stats for 10.2.4 akolli
2017-11-30 12:58 ` akolli
2017-11-30 12:58 ` [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug akolli
2017-11-30 12:58   ` akolli
2017-11-30 12:58 ` [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 akolli
2017-11-30 12:58   ` akolli
2017-11-30 16:14   ` Kalle Valo
2017-11-30 16:14     ` Kalle Valo
2017-11-30 16:28     ` Toke Høiland-Jørgensen
2017-11-30 16:28       ` Toke Høiland-Jørgensen
2017-11-30 16:38       ` Kalle Valo
2017-11-30 16:38         ` Kalle Valo
2017-12-01  4:23         ` akolli
2017-12-01  4:23           ` akolli
2017-12-01 13:41           ` Toke Høiland-Jørgensen
2017-12-01 13:41             ` Toke Høiland-Jørgensen
2017-12-01 14:49             ` Kalle Valo
2017-12-01 14:49               ` Kalle Valo
2017-12-01 15:29               ` Toke Høiland-Jørgensen
2017-12-01 15:29                 ` Toke Høiland-Jørgensen
2017-12-01 15:45                 ` Johannes Berg
2017-12-01 15:45                   ` Johannes Berg
2017-12-01 15:54                   ` Toke Høiland-Jørgensen
2017-12-01 15:54                     ` Toke Høiland-Jørgensen
2017-12-01 15:58                     ` Johannes Berg
2017-12-01 15:58                       ` Johannes Berg
2017-12-02  9:53                       ` Toke Høiland-Jørgensen
2017-12-02  9:53                         ` Toke Høiland-Jørgensen
2017-12-01 10:45   ` Maxime Bizon
2017-12-01 10:45     ` Maxime Bizon
2017-12-01 13:48     ` akolli
2017-12-01 13:48       ` akolli
2017-12-01 15:05       ` Maxime Bizon
2017-12-01 15:05         ` Maxime Bizon
2017-12-01 15:53         ` Christian Lamparter
2017-12-01 15:53           ` Christian Lamparter
2017-12-01 16:09           ` Maxime Bizon
2017-12-01 16:09             ` Maxime Bizon
2017-12-04 13:24         ` akolli
2017-12-04 13:24           ` akolli
2017-12-04 14:23           ` Maxime Bizon
2017-12-04 14:23             ` Maxime Bizon
2017-12-05  5:26             ` akolli
2017-12-05  5:26               ` akolli
2017-12-01 15:44       ` Kalle Valo [this message]
2017-12-01 15:44         ` Kalle Valo
2017-12-04 11:20         ` akolli
2017-12-04 11:20           ` akolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87374uxxjy.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=akolli@codeaurora.org \
    --cc=akolli@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mbizon@freebox.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.