From: Kalle Valo <kvalo@qca.qualcomm.com> To: "toke@toke.dk" <toke@toke.dk> Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>, "akolli@codeaurora.org" <akolli@codeaurora.org>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "Anilkumar Kolli" <akolli@qti.qualcomm.com> Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 Date: Thu, 30 Nov 2017 16:14:49 +0000 [thread overview] Message-ID: <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> (raw) In-Reply-To: <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Thu, 30 Nov 2017 18:28:21 +0530") <akolli@qti.qualcomm.com> writes: > From: Anilkumar Kolli <akolli@qti.qualcomm.com> > > 10.2.4 firmware branch (used in QCA988X) does not support > HTT_10_4_T2H_MSG_TYPE_PEER_STATS and that's why ath10k does not provide > tranmission rate statistics to user space, instead it just shows > hardcoded 6 Mbit/s. But pktlog firmware facility provides per peer tx > statistics. The firmware sends one pktlog event for every four > PPDUs per peer, which include: > > * successful number of packets and bytes transmitted > * number of packets and bytes dropped > * retried number of packets and bytes > * rate info per ppdu > > Firmware supports WMI_SERVICE_PEER_STATS, pktlog is enabled through > ATH10K_FLAG_PEER_STATS, which is nowadays enabled by default in ath10k. > > This patch does not impact throughput. > > Tested on QCA9880 with firmware version 10.2.4.70.48. This should also > work with firmware branch 10.2.4-1.0-00029 > > Parse peer stats from pktlog packets and update the tx rate information > per STA. This way user space can query about transmit rate with iw: > > $iw wlan0 station dump > Station 3c:a9:f4:72:bb:a4 (on wlan1) > inactive time: 8210 ms > rx bytes: 9166 > rx packets: 44 > tx bytes: 1105 > tx packets: 9 > tx retries: 0 > tx failed: 1 > rx drop misc: 3 > signal: -75 [-75, -87, -88] dBm > signal avg: -75 [-75, -85, -88] dBm > tx bitrate: 39.0 MBit/s MCS 10 > rx bitrate: 26.0 MBit/s MCS 3 > rx duration: 23250 us > authorized: yes > authenticated: yes > associated: yes > preamble: short > WMM/WME: yes > MFP: no > TDLS peer: no > DTIM period: 2 > beacon interval:100 > short preamble: yes > short slot time:yes > connected time: 22 seconds > > Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com> [...] > +struct ath10k_10_2_peer_tx_stats { > + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 flags[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le32 tx_duration; > + u8 tx_ppdu_cnt; > + u8 peer_id; > +} __packed; Toke, hopefully the tx_duration value here helps with ATF implementation using QCA988X. --=20 Kalle Valo=
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com> To: "toke@toke.dk" <toke@toke.dk> Cc: Anilkumar Kolli <akolli@qti.qualcomm.com>, "akolli@codeaurora.org" <akolli@codeaurora.org>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 Date: Thu, 30 Nov 2017 16:14:49 +0000 [thread overview] Message-ID: <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> (raw) In-Reply-To: <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Thu, 30 Nov 2017 18:28:21 +0530") <akolli@qti.qualcomm.com> writes: > From: Anilkumar Kolli <akolli@qti.qualcomm.com> > > 10.2.4 firmware branch (used in QCA988X) does not support > HTT_10_4_T2H_MSG_TYPE_PEER_STATS and that's why ath10k does not provide > tranmission rate statistics to user space, instead it just shows > hardcoded 6 Mbit/s. But pktlog firmware facility provides per peer tx > statistics. The firmware sends one pktlog event for every four > PPDUs per peer, which include: > > * successful number of packets and bytes transmitted > * number of packets and bytes dropped > * retried number of packets and bytes > * rate info per ppdu > > Firmware supports WMI_SERVICE_PEER_STATS, pktlog is enabled through > ATH10K_FLAG_PEER_STATS, which is nowadays enabled by default in ath10k. > > This patch does not impact throughput. > > Tested on QCA9880 with firmware version 10.2.4.70.48. This should also > work with firmware branch 10.2.4-1.0-00029 > > Parse peer stats from pktlog packets and update the tx rate information > per STA. This way user space can query about transmit rate with iw: > > $iw wlan0 station dump > Station 3c:a9:f4:72:bb:a4 (on wlan1) > inactive time: 8210 ms > rx bytes: 9166 > rx packets: 44 > tx bytes: 1105 > tx packets: 9 > tx retries: 0 > tx failed: 1 > rx drop misc: 3 > signal: -75 [-75, -87, -88] dBm > signal avg: -75 [-75, -85, -88] dBm > tx bitrate: 39.0 MBit/s MCS 10 > rx bitrate: 26.0 MBit/s MCS 3 > rx duration: 23250 us > authorized: yes > authenticated: yes > associated: yes > preamble: short > WMM/WME: yes > MFP: no > TDLS peer: no > DTIM period: 2 > beacon interval:100 > short preamble: yes > short slot time:yes > connected time: 22 seconds > > Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com> [...] > +struct ath10k_10_2_peer_tx_stats { > + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 flags[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le32 tx_duration; > + u8 tx_ppdu_cnt; > + u8 peer_id; > +} __packed; Toke, hopefully the tx_duration value here helps with ATF implementation using QCA988X. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-11-30 16:14 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-30 12:58 [PATCH 0/2] ath10k: tx stats for 10.2.4 akolli 2017-11-30 12:58 ` akolli 2017-11-30 12:58 ` [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug akolli 2017-11-30 12:58 ` akolli 2017-11-30 12:58 ` [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 akolli 2017-11-30 12:58 ` akolli 2017-11-30 16:14 ` Kalle Valo [this message] 2017-11-30 16:14 ` Kalle Valo 2017-11-30 16:28 ` Toke Høiland-Jørgensen 2017-11-30 16:28 ` Toke Høiland-Jørgensen 2017-11-30 16:38 ` Kalle Valo 2017-11-30 16:38 ` Kalle Valo 2017-12-01 4:23 ` akolli 2017-12-01 4:23 ` akolli 2017-12-01 13:41 ` Toke Høiland-Jørgensen 2017-12-01 13:41 ` Toke Høiland-Jørgensen 2017-12-01 14:49 ` Kalle Valo 2017-12-01 14:49 ` Kalle Valo 2017-12-01 15:29 ` Toke Høiland-Jørgensen 2017-12-01 15:29 ` Toke Høiland-Jørgensen 2017-12-01 15:45 ` Johannes Berg 2017-12-01 15:45 ` Johannes Berg 2017-12-01 15:54 ` Toke Høiland-Jørgensen 2017-12-01 15:54 ` Toke Høiland-Jørgensen 2017-12-01 15:58 ` Johannes Berg 2017-12-01 15:58 ` Johannes Berg 2017-12-02 9:53 ` Toke Høiland-Jørgensen 2017-12-02 9:53 ` Toke Høiland-Jørgensen 2017-12-01 10:45 ` Maxime Bizon 2017-12-01 10:45 ` Maxime Bizon 2017-12-01 13:48 ` akolli 2017-12-01 13:48 ` akolli 2017-12-01 15:05 ` Maxime Bizon 2017-12-01 15:05 ` Maxime Bizon 2017-12-01 15:53 ` Christian Lamparter 2017-12-01 15:53 ` Christian Lamparter 2017-12-01 16:09 ` Maxime Bizon 2017-12-01 16:09 ` Maxime Bizon 2017-12-04 13:24 ` akolli 2017-12-04 13:24 ` akolli 2017-12-04 14:23 ` Maxime Bizon 2017-12-04 14:23 ` Maxime Bizon 2017-12-05 5:26 ` akolli 2017-12-05 5:26 ` akolli 2017-12-01 15:44 ` Kalle Valo 2017-12-01 15:44 ` Kalle Valo 2017-12-04 11:20 ` akolli 2017-12-04 11:20 ` akolli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87k1y7zqtj.fsf@kamboji.qca.qualcomm.com \ --to=kvalo@qca.qualcomm.com \ --cc=akolli@codeaurora.org \ --cc=akolli@qti.qualcomm.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=toke@toke.dk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.