From: Anup Patel <anup@brainfault.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Anup Patel" <apatel@ventanamicro.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marc Zyngier" <maz@kernel.org>, "Björn Töpel" <bjorn@kernel.org>,
"Atish Patra" <atishp@atishpatra.org>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Saravana Kannan" <saravanak@google.com>,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v14 11/18] irqchip: Add RISC-V incoming MSI controller early driver
Date: Fri, 23 Feb 2024 15:22:59 +0530 [thread overview]
Message-ID: <CAAhSdy1jdHsuwRhbRgig98-AVDOGwp_XxHurg9o3Rsj1AVOqbA@mail.gmail.com> (raw)
In-Reply-To: <87a5nreg94.ffs@tglx>
On Fri, Feb 23, 2024 at 1:58 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Thu, Feb 22 2024 at 15:09, Anup Patel wrote:
> > + /*
> > + * Setup cpuhp state (must be done after setting imsic_parent_irq)
> > + *
> > + * Don't disable per-CPU IMSIC file when CPU goes offline
> > + * because this affects IPI and the masking/unmasking of
> > + * virtual IPIs is done via generic IPI-Mux
> > + */
> > + cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "irqchip/riscv/imsic:starting",
> > + imsic_starting_cpu, imsic_dying_cpu);
>
> This is not really correct. IPIs should be working right away when a CPU
> comes online and on the unplug side until it really goes offline.
>
> So this wants to be in the starting range, i.e. between CPUHP_AP_OFFLINE
> and CPUHP_AP_ONLINE. No?
Yes, it has to be as early as possible but I was not sure about
introducing yet another driver specific CPUHP_AP_xyz state
considering CPUHP_AP_ONLINE_DYN worked fine.
Since you suggested, let me introduce
CPUHP_AP_IRQ_RISCV_IMSIC_STARTING in the next revision.
Regards,
Anup
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <anup@brainfault.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Anup Patel" <apatel@ventanamicro.com>,
devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Marc Zyngier" <maz@kernel.org>,
"Atish Patra" <atishp@atishpatra.org>,
linux-kernel@vger.kernel.org, "Björn Töpel" <bjorn@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org,
"Frank Rowand" <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"Andrew Jones" <ajones@ventanamicro.com>
Subject: Re: [PATCH v14 11/18] irqchip: Add RISC-V incoming MSI controller early driver
Date: Fri, 23 Feb 2024 15:22:59 +0530 [thread overview]
Message-ID: <CAAhSdy1jdHsuwRhbRgig98-AVDOGwp_XxHurg9o3Rsj1AVOqbA@mail.gmail.com> (raw)
In-Reply-To: <87a5nreg94.ffs@tglx>
On Fri, Feb 23, 2024 at 1:58 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Thu, Feb 22 2024 at 15:09, Anup Patel wrote:
> > + /*
> > + * Setup cpuhp state (must be done after setting imsic_parent_irq)
> > + *
> > + * Don't disable per-CPU IMSIC file when CPU goes offline
> > + * because this affects IPI and the masking/unmasking of
> > + * virtual IPIs is done via generic IPI-Mux
> > + */
> > + cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "irqchip/riscv/imsic:starting",
> > + imsic_starting_cpu, imsic_dying_cpu);
>
> This is not really correct. IPIs should be working right away when a CPU
> comes online and on the unplug side until it really goes offline.
>
> So this wants to be in the starting range, i.e. between CPUHP_AP_OFFLINE
> and CPUHP_AP_ONLINE. No?
Yes, it has to be as early as possible but I was not sure about
introducing yet another driver specific CPUHP_AP_xyz state
considering CPUHP_AP_ONLINE_DYN worked fine.
Since you suggested, let me introduce
CPUHP_AP_IRQ_RISCV_IMSIC_STARTING in the next revision.
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <anup@brainfault.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Anup Patel" <apatel@ventanamicro.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marc Zyngier" <maz@kernel.org>, "Björn Töpel" <bjorn@kernel.org>,
"Atish Patra" <atishp@atishpatra.org>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Saravana Kannan" <saravanak@google.com>,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v14 11/18] irqchip: Add RISC-V incoming MSI controller early driver
Date: Fri, 23 Feb 2024 15:22:59 +0530 [thread overview]
Message-ID: <CAAhSdy1jdHsuwRhbRgig98-AVDOGwp_XxHurg9o3Rsj1AVOqbA@mail.gmail.com> (raw)
In-Reply-To: <87a5nreg94.ffs@tglx>
On Fri, Feb 23, 2024 at 1:58 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Thu, Feb 22 2024 at 15:09, Anup Patel wrote:
> > + /*
> > + * Setup cpuhp state (must be done after setting imsic_parent_irq)
> > + *
> > + * Don't disable per-CPU IMSIC file when CPU goes offline
> > + * because this affects IPI and the masking/unmasking of
> > + * virtual IPIs is done via generic IPI-Mux
> > + */
> > + cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "irqchip/riscv/imsic:starting",
> > + imsic_starting_cpu, imsic_dying_cpu);
>
> This is not really correct. IPIs should be working right away when a CPU
> comes online and on the unplug side until it really goes offline.
>
> So this wants to be in the starting range, i.e. between CPUHP_AP_OFFLINE
> and CPUHP_AP_ONLINE. No?
Yes, it has to be as early as possible but I was not sure about
introducing yet another driver specific CPUHP_AP_xyz state
considering CPUHP_AP_ONLINE_DYN worked fine.
Since you suggested, let me introduce
CPUHP_AP_IRQ_RISCV_IMSIC_STARTING in the next revision.
Regards,
Anup
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-23 9:53 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 9:39 [PATCH v14 00/18] Linux RISC-V AIA Support Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` [PATCH v14 01/18] irqchip/sifive-plic: Convert PLIC driver into a platform driver Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Anup Patel
2024-04-03 8:29 ` [PATCH v14 01/18] " Lad, Prabhakar
2024-04-03 8:29 ` Lad, Prabhakar
2024-04-03 8:29 ` Lad, Prabhakar
2024-04-03 14:16 ` Anup Patel
2024-04-03 14:16 ` Anup Patel
2024-04-03 14:16 ` Anup Patel
2024-04-03 15:49 ` Lad, Prabhakar
2024-04-03 15:49 ` Lad, Prabhakar
2024-04-03 15:49 ` Lad, Prabhakar
2024-04-03 16:28 ` Samuel Holland
2024-04-03 16:28 ` Samuel Holland
2024-04-03 16:28 ` Samuel Holland
2024-04-03 18:10 ` Lad, Prabhakar
2024-04-03 18:10 ` Lad, Prabhakar
2024-04-03 18:10 ` Lad, Prabhakar
2024-04-03 16:42 ` Anup Patel
2024-04-03 16:42 ` Anup Patel
2024-04-03 16:42 ` Anup Patel
2024-04-03 17:19 ` Anup Patel
2024-04-03 17:19 ` Anup Patel
2024-04-03 17:19 ` Anup Patel
2024-02-22 9:39 ` [PATCH v14 02/18] irqchip/sifive-plic: Use dev_xyz() in-place of pr_xyz() Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Anup Patel
2024-02-22 9:39 ` [PATCH v14 03/18] irqchip/sifive-plic: Use devm_xyz() for managed allocation Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Anup Patel
2024-02-22 9:39 ` [PATCH v14 04/18] irqchip/sifive-plic: Use riscv_get_intc_hwnode() to get parent fwnode Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Anup Patel
2024-02-22 9:39 ` [PATCH v14 05/18] irqchip/sifive-plic: Cleanup PLIC contexts upon irqdomain creation failure Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Anup Patel
2024-02-22 9:39 ` [PATCH v14 06/18] irqchip/sifive-plic: Parse number of irqs and contexts early in plic_probe Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] irqchip/sifive-plic: Parse number of interrupts and contexts early in plic_probe() tip-bot2 for Anup Patel
2024-02-22 9:39 ` [PATCH v14 07/18] irqchip/sifive-plic: Improve locking safety by using irqsave/irqrestore Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Anup Patel
2024-02-22 9:39 ` [PATCH v14 08/18] irqchip/riscv-intc: Add support for RISC-V AIA Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Anup Patel
2024-02-22 9:39 ` [PATCH v14 09/18] dt-bindings: interrupt-controller: Add RISC-V incoming MSI controller Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` [PATCH v14 10/18] genirq/matrix: Dynamic bitmap allocation Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-23 9:43 ` [tip: irq/msi] " tip-bot2 for Björn Töpel
2024-02-22 9:39 ` [PATCH v14 11/18] irqchip: Add RISC-V incoming MSI controller early driver Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 9:39 ` Anup Patel
2024-02-22 13:13 ` Björn Töpel
2024-02-22 13:13 ` Björn Töpel
2024-02-22 13:13 ` Björn Töpel
2024-02-22 13:42 ` Anup Patel
2024-02-22 13:42 ` Anup Patel
2024-02-22 13:42 ` Anup Patel
2024-02-22 14:15 ` Björn Töpel
2024-02-22 14:15 ` Björn Töpel
2024-02-22 14:15 ` Björn Töpel
2024-02-23 8:28 ` Thomas Gleixner
2024-02-23 8:28 ` Thomas Gleixner
2024-02-23 8:28 ` Thomas Gleixner
2024-02-23 9:52 ` Anup Patel [this message]
2024-02-23 9:52 ` Anup Patel
2024-02-23 9:52 ` Anup Patel
2024-02-22 9:40 ` [PATCH v14 12/18] irqchip/riscv-imsic: Add device MSI domain support for platform devices Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 13:15 ` Björn Töpel
2024-02-22 13:15 ` Björn Töpel
2024-02-22 13:15 ` Björn Töpel
2024-02-22 13:44 ` Anup Patel
2024-02-22 13:44 ` Anup Patel
2024-02-22 13:44 ` Anup Patel
2024-02-22 9:40 ` [PATCH v14 13/18] irqchip/riscv-imsic: Add device MSI domain support for PCI devices Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 13:14 ` Björn Töpel
2024-02-22 13:14 ` Björn Töpel
2024-02-22 13:14 ` Björn Töpel
2024-02-22 13:30 ` Anup Patel
2024-02-22 13:30 ` Anup Patel
2024-02-22 13:30 ` Anup Patel
2024-02-22 14:05 ` Björn Töpel
2024-02-22 14:05 ` Björn Töpel
2024-02-22 14:05 ` Björn Töpel
2024-02-22 9:40 ` [PATCH v14 14/18] dt-bindings: interrupt-controller: Add RISC-V advanced PLIC Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` [PATCH v14 15/18] irqchip: Add RISC-V advanced PLIC driver for direct-mode Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` [PATCH v14 16/18] irqchip/riscv-aplic: Add support for MSI-mode Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` [PATCH v14 17/18] RISC-V: Select APLIC and IMSIC drivers Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` [PATCH v14 18/18] MAINTAINERS: Add entry for RISC-V AIA drivers Anup Patel
2024-02-22 9:40 ` Anup Patel
2024-02-22 9:40 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy1jdHsuwRhbRgig98-AVDOGwp_XxHurg9o3Rsj1AVOqbA@mail.gmail.com \
--to=anup@brainfault.org \
--cc=ajones@ventanamicro.com \
--cc=apatel@ventanamicro.com \
--cc=atishp@atishpatra.org \
--cc=bjorn@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sunilvl@ventanamicro.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.