From: Geert Uytterhoeven <geert@linux-m68k.org> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, DRI Development <dri-devel@lists.freedesktop.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert+renesas@glider.be>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings Date: Thu, 29 Aug 2019 09:57:35 +0200 [thread overview] Message-ID: <CAMuHMdVPsT=1R7DAnmui+iaWcnoy52Xrr47zLWbgmUumBZ2sdw@mail.gmail.com> (raw) In-Reply-To: <1567017402-5895-2-git-send-email-fabrizio.castro@bp.renesas.com> Hi Fabrizio, On Wed, Aug 28, 2019 at 8:36 PM Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > Dual-LVDS connections need markers in the DT, this patch adds > some common documentation to be referenced by both panels and > bridges. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bus-timings/lvds.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bus-timings/lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Properties for bus timings of LVDS interfaces > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Fabrizio Castro <fabrizio.castro@bp.renesas.com> > + > +description: | > + This document defines device tree properties common to LVDS and dual-LVDS > + interfaces, where a dual-LVDS interface is a dual-link connection with even > + pixels traveling on one connection, and with odd pixels traveling on the other > + connection. > + This document doesn't constitue a device tree binding specification by itself > + but is meant to be referenced by device tree bindings. > + When referenced from panel or bridge device tree bindings, the properties > + defined in this document are defined as follows. The panel and bridge device > + tree bindings are responsible for defining whether each property is required > + or optional. > + > +properties: > + dual-lvds-even-pixels: > + type: boolean > + description: > + This property is specific to an input port of a sink device. When > + specified, it marks the port as recipient of even-pixels. > + > + dual-lvds-odd-pixels: > + type: boolean > + description: > + This property is specific to an input port of a sink device. When > + specified, it marks the port as recipient of odd-pixels. Do you need the "dual-" prefix? Isn't that implied by even/odd? Or is it better to keep it, for readability? I'm also thinking about a possible future extension to triple or quad LVDS. As I'm not aware of English word equivalents of even/odd for triple/quad, perhaps this should be specified using a numerical value instead? If I go too far, please just say so ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Cc: Mark Rutland <mark.rutland@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Chris Paterson <Chris.Paterson2@renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Simon Horman <horms@verge.net.au>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, DRI Development <dri-devel@lists.freedesktop.org>, Biju Das <biju.das@bp.renesas.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings Date: Thu, 29 Aug 2019 09:57:35 +0200 [thread overview] Message-ID: <CAMuHMdVPsT=1R7DAnmui+iaWcnoy52Xrr47zLWbgmUumBZ2sdw@mail.gmail.com> (raw) In-Reply-To: <1567017402-5895-2-git-send-email-fabrizio.castro@bp.renesas.com> Hi Fabrizio, On Wed, Aug 28, 2019 at 8:36 PM Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > Dual-LVDS connections need markers in the DT, this patch adds > some common documentation to be referenced by both panels and > bridges. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bus-timings/lvds.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bus-timings/lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Properties for bus timings of LVDS interfaces > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Fabrizio Castro <fabrizio.castro@bp.renesas.com> > + > +description: | > + This document defines device tree properties common to LVDS and dual-LVDS > + interfaces, where a dual-LVDS interface is a dual-link connection with even > + pixels traveling on one connection, and with odd pixels traveling on the other > + connection. > + This document doesn't constitue a device tree binding specification by itself > + but is meant to be referenced by device tree bindings. > + When referenced from panel or bridge device tree bindings, the properties > + defined in this document are defined as follows. The panel and bridge device > + tree bindings are responsible for defining whether each property is required > + or optional. > + > +properties: > + dual-lvds-even-pixels: > + type: boolean > + description: > + This property is specific to an input port of a sink device. When > + specified, it marks the port as recipient of even-pixels. > + > + dual-lvds-odd-pixels: > + type: boolean > + description: > + This property is specific to an input port of a sink device. When > + specified, it marks the port as recipient of odd-pixels. Do you need the "dual-" prefix? Isn't that implied by even/odd? Or is it better to keep it, for readability? I'm also thinking about a possible future extension to triple or quad LVDS. As I'm not aware of English word equivalents of even/odd for triple/quad, perhaps this should be specified using a numerical value instead? If I go too far, please just say so ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-29 7:57 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-28 18:36 [PATCH v3 0/8] Add dual-LVDS panel support to EK874 Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings Fabrizio Castro 2019-08-29 7:57 ` Geert Uytterhoeven [this message] 2019-08-29 7:57 ` Geert Uytterhoeven 2019-08-29 9:14 ` Fabrizio Castro 2019-08-29 9:14 ` Fabrizio Castro 2019-08-29 14:03 ` Rob Herring 2019-08-29 14:03 ` Rob Herring 2019-08-29 14:38 ` Fabrizio Castro 2019-08-29 14:38 ` Fabrizio Castro 2019-11-07 18:00 ` Laurent Pinchart 2019-11-07 18:00 ` Laurent Pinchart 2019-11-07 18:00 ` Laurent Pinchart 2019-12-06 15:11 ` Fabrizio Castro 2019-12-06 15:11 ` Fabrizio Castro 2019-12-06 15:10 ` Fabrizio Castro 2019-12-06 15:10 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding Fabrizio Castro 2019-11-07 18:12 ` Laurent Pinchart 2019-11-07 18:12 ` Laurent Pinchart 2019-12-06 15:17 ` Fabrizio Castro 2019-12-06 15:17 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 3/8] drm: Add bus timings helper Fabrizio Castro 2019-11-07 19:26 ` Laurent Pinchart 2019-11-07 19:26 ` Laurent Pinchart 2019-11-07 19:30 ` Daniel Vetter 2019-11-07 19:30 ` Daniel Vetter 2019-12-06 15:25 ` Fabrizio Castro 2019-12-06 15:25 ` Fabrizio Castro 2019-12-06 15:24 ` Fabrizio Castro 2019-12-06 15:24 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 4/8] drm: rcar-du: lvds: Add dual-LVDS panels support Fabrizio Castro 2019-11-07 19:50 ` Laurent Pinchart 2019-11-07 19:50 ` Laurent Pinchart 2019-12-06 15:35 ` Fabrizio Castro 2019-12-06 15:35 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 5/8] drm: bridge: thc63: Do not report input bus mode through bridge timings Fabrizio Castro 2019-11-07 19:52 ` Laurent Pinchart 2019-11-07 19:52 ` Laurent Pinchart 2019-12-06 15:38 ` Fabrizio Castro 2019-12-06 15:38 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 6/8] arm64: dts: renesas: Add EK874 board with idk-2121wr display support Fabrizio Castro 2019-11-07 19:55 ` Laurent Pinchart 2019-08-28 18:36 ` [PATCH v3 7/8] [HACK] arm64: dts: renesas: draak: Enable LVDS Fabrizio Castro 2019-11-07 19:57 ` Laurent Pinchart 2019-12-06 15:40 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 8/8] [HACK] arm64: dts: renesas: draak: Enable LVDS dual-link operation Fabrizio Castro 2019-08-29 15:26 ` [PATCH v3 0/8] Add dual-LVDS panel support to EK874 Rob Herring 2019-08-29 15:26 ` Rob Herring 2019-09-02 10:01 ` Fabrizio Castro 2019-09-02 10:01 ` Fabrizio Castro 2019-10-22 16:30 ` Fabrizio Castro 2019-10-22 16:30 ` Fabrizio Castro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdVPsT=1R7DAnmui+iaWcnoy52Xrr47zLWbgmUumBZ2sdw@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=Chris.Paterson2@renesas.com \ --cc=airlied@linux.ie \ --cc=biju.das@bp.renesas.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=fabrizio.castro@bp.renesas.com \ --cc=geert+renesas@glider.be \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.