From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Sam Ravnborg <sam@ravnborg.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert+renesas@glider.be>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Jacopo Mondi <jacopo+renesas@jmondi.org> Subject: RE: [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding Date: Fri, 6 Dec 2019 15:17:41 +0000 [thread overview] Message-ID: <TY1PR01MB1770973E2F6AAA74B6F6B16CC05F0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <20191107181200.GB24231@pendragon.ideasonboard.com> Hi Laurent, Thank you for your feedback! > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: 07 November 2019 18:12 > Subject: Re: [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding > > Hi Fabrizio, > > Thank you for the patch. > > On Wed, Aug 28, 2019 at 07:36:36PM +0100, Fabrizio Castro wrote: > > Add binding for the idk-2121wr LVDS panel from Advantech. > > > > Some panel-specific documentation can be found here: > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v2->v3: > > * new patch > > --- > > .../display/panel/advantech,idk-2121wr.yaml | 90 ++++++++++++++++++++++ > > 1 file changed, 90 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > new file mode 100644 > > index 0000000..b2ccdc8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/advantech,idk-2121wr.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Advantech IDK-2121WR 21.5" Full-HD dual-LVDS panel > > + > > +maintainers: > > + - Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > + - Thierry Reding <thierry.reding@gmail.com> > > + > > +description: | > > + The IDK-2121WR from Advantech is a Full-HD dual-LVDS panel. > > + > > + The panels expects odd pixels from the first port, and even pixels from > > s/panels/panel/ > Maybe s/from the/on the/g ? Will fix > > > + the second port, therefore the ports must be marked accordingly. > > + > > +allOf: > > + - $ref: lvds.yaml# > > + - $ref: ../bus-timings/lvds.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - const: advantech,idk-2121wr > > + - {} # panel-lvds, but not listed here to avoid false select > > + > > + data-mapping: > > + const: vesa-24 > > + > > + width-mm: > > + const: 476 > > + > > + height-mm: > > + const: 268 > > + > > + panel-timing: true > > + ports: true > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > Shouldn't data-mapping, width-mm, height-mm and ports be required too ? Those are required by lvds.yaml, and this file has a reference to it. Anyhow, I think the best course of action is to merge this with the generic bus-timings/lvds.yaml for the time being, and maybe split them back later on once we have another use case. Thanks, Fab > > As you mentioned in the cover letter, validating ports, port and the new > dual-lvds-*-pixels properties would be nice. I'm not YAML schema > specialist, so I'm fine with a best effort approach here, but as far as > I understand Rob proposed a way forward, could you try it ? > > Apart from that, the bindings look sne to me, so > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > once the above issues get addressed. > > > + > > +examples: > > + - |+ > > + panel-lvds { > > + compatible = "advantech,idk-2121wr", "panel-lvds"; > > + > > + width-mm = <476>; > > + height-mm = <268>; > > + > > + data-mapping = "vesa-24"; > > + > > + panel-timing { > > + clock-frequency = <148500000>; > > + hactive = <1920>; > > + vactive = <1080>; > > + hsync-len = <44>; > > + hfront-porch = <88>; > > + hback-porch = <148>; > > + vfront-porch = <4>; > > + vback-porch = <36>; > > + vsync-len = <5>; > > + }; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + dual-lvds-odd-pixels; > > + panel_in0: endpoint { > > + remote-endpoint = <&lvds0_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + dual-lvds-even-pixels; > > + panel_in1: endpoint { > > + remote-endpoint = <&lvds1_out>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > -- > Regards, > > Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Chris Paterson <Chris.Paterson2@renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Simon Horman <horms@verge.net.au>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Biju Das <biju.das@bp.renesas.com>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Sam Ravnborg <sam@ravnborg.org> Subject: RE: [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding Date: Fri, 6 Dec 2019 15:17:41 +0000 [thread overview] Message-ID: <TY1PR01MB1770973E2F6AAA74B6F6B16CC05F0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <20191107181200.GB24231@pendragon.ideasonboard.com> Hi Laurent, Thank you for your feedback! > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: 07 November 2019 18:12 > Subject: Re: [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding > > Hi Fabrizio, > > Thank you for the patch. > > On Wed, Aug 28, 2019 at 07:36:36PM +0100, Fabrizio Castro wrote: > > Add binding for the idk-2121wr LVDS panel from Advantech. > > > > Some panel-specific documentation can be found here: > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v2->v3: > > * new patch > > --- > > .../display/panel/advantech,idk-2121wr.yaml | 90 ++++++++++++++++++++++ > > 1 file changed, 90 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > new file mode 100644 > > index 0000000..b2ccdc8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/advantech,idk-2121wr.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Advantech IDK-2121WR 21.5" Full-HD dual-LVDS panel > > + > > +maintainers: > > + - Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > + - Thierry Reding <thierry.reding@gmail.com> > > + > > +description: | > > + The IDK-2121WR from Advantech is a Full-HD dual-LVDS panel. > > + > > + The panels expects odd pixels from the first port, and even pixels from > > s/panels/panel/ > Maybe s/from the/on the/g ? Will fix > > > + the second port, therefore the ports must be marked accordingly. > > + > > +allOf: > > + - $ref: lvds.yaml# > > + - $ref: ../bus-timings/lvds.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - const: advantech,idk-2121wr > > + - {} # panel-lvds, but not listed here to avoid false select > > + > > + data-mapping: > > + const: vesa-24 > > + > > + width-mm: > > + const: 476 > > + > > + height-mm: > > + const: 268 > > + > > + panel-timing: true > > + ports: true > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > Shouldn't data-mapping, width-mm, height-mm and ports be required too ? Those are required by lvds.yaml, and this file has a reference to it. Anyhow, I think the best course of action is to merge this with the generic bus-timings/lvds.yaml for the time being, and maybe split them back later on once we have another use case. Thanks, Fab > > As you mentioned in the cover letter, validating ports, port and the new > dual-lvds-*-pixels properties would be nice. I'm not YAML schema > specialist, so I'm fine with a best effort approach here, but as far as > I understand Rob proposed a way forward, could you try it ? > > Apart from that, the bindings look sne to me, so > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > once the above issues get addressed. > > > + > > +examples: > > + - |+ > > + panel-lvds { > > + compatible = "advantech,idk-2121wr", "panel-lvds"; > > + > > + width-mm = <476>; > > + height-mm = <268>; > > + > > + data-mapping = "vesa-24"; > > + > > + panel-timing { > > + clock-frequency = <148500000>; > > + hactive = <1920>; > > + vactive = <1080>; > > + hsync-len = <44>; > > + hfront-porch = <88>; > > + hback-porch = <148>; > > + vfront-porch = <4>; > > + vback-porch = <36>; > > + vsync-len = <5>; > > + }; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + dual-lvds-odd-pixels; > > + panel_in0: endpoint { > > + remote-endpoint = <&lvds0_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + dual-lvds-even-pixels; > > + panel_in1: endpoint { > > + remote-endpoint = <&lvds1_out>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > -- > Regards, > > Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-06 15:17 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-28 18:36 [PATCH v3 0/8] Add dual-LVDS panel support to EK874 Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings Fabrizio Castro 2019-08-29 7:57 ` Geert Uytterhoeven 2019-08-29 7:57 ` Geert Uytterhoeven 2019-08-29 9:14 ` Fabrizio Castro 2019-08-29 9:14 ` Fabrizio Castro 2019-08-29 14:03 ` Rob Herring 2019-08-29 14:03 ` Rob Herring 2019-08-29 14:38 ` Fabrizio Castro 2019-08-29 14:38 ` Fabrizio Castro 2019-11-07 18:00 ` Laurent Pinchart 2019-11-07 18:00 ` Laurent Pinchart 2019-11-07 18:00 ` Laurent Pinchart 2019-12-06 15:11 ` Fabrizio Castro 2019-12-06 15:11 ` Fabrizio Castro 2019-12-06 15:10 ` Fabrizio Castro 2019-12-06 15:10 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding Fabrizio Castro 2019-11-07 18:12 ` Laurent Pinchart 2019-11-07 18:12 ` Laurent Pinchart 2019-12-06 15:17 ` Fabrizio Castro [this message] 2019-12-06 15:17 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 3/8] drm: Add bus timings helper Fabrizio Castro 2019-11-07 19:26 ` Laurent Pinchart 2019-11-07 19:26 ` Laurent Pinchart 2019-11-07 19:30 ` Daniel Vetter 2019-11-07 19:30 ` Daniel Vetter 2019-12-06 15:25 ` Fabrizio Castro 2019-12-06 15:25 ` Fabrizio Castro 2019-12-06 15:24 ` Fabrizio Castro 2019-12-06 15:24 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 4/8] drm: rcar-du: lvds: Add dual-LVDS panels support Fabrizio Castro 2019-11-07 19:50 ` Laurent Pinchart 2019-11-07 19:50 ` Laurent Pinchart 2019-12-06 15:35 ` Fabrizio Castro 2019-12-06 15:35 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 5/8] drm: bridge: thc63: Do not report input bus mode through bridge timings Fabrizio Castro 2019-11-07 19:52 ` Laurent Pinchart 2019-11-07 19:52 ` Laurent Pinchart 2019-12-06 15:38 ` Fabrizio Castro 2019-12-06 15:38 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 6/8] arm64: dts: renesas: Add EK874 board with idk-2121wr display support Fabrizio Castro 2019-11-07 19:55 ` Laurent Pinchart 2019-08-28 18:36 ` [PATCH v3 7/8] [HACK] arm64: dts: renesas: draak: Enable LVDS Fabrizio Castro 2019-11-07 19:57 ` Laurent Pinchart 2019-12-06 15:40 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 8/8] [HACK] arm64: dts: renesas: draak: Enable LVDS dual-link operation Fabrizio Castro 2019-08-29 15:26 ` [PATCH v3 0/8] Add dual-LVDS panel support to EK874 Rob Herring 2019-08-29 15:26 ` Rob Herring 2019-09-02 10:01 ` Fabrizio Castro 2019-09-02 10:01 ` Fabrizio Castro 2019-10-22 16:30 ` Fabrizio Castro 2019-10-22 16:30 ` Fabrizio Castro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TY1PR01MB1770973E2F6AAA74B6F6B16CC05F0@TY1PR01MB1770.jpnprd01.prod.outlook.com \ --to=fabrizio.castro@bp.renesas.com \ --cc=Chris.Paterson2@renesas.com \ --cc=airlied@linux.ie \ --cc=biju.das@bp.renesas.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.