From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> To: Rob Herring <robh+dt@kernel.org> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Mark Rutland <mark.rutland@arm.com>, dri-devel <dri-devel@lists.freedesktop.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert+renesas@glider.be>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com>, "open list:MEDIA DRIVERS FOR RENESAS - FCP" <linux-renesas-soc@vger.kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Sam Ravnborg <sam@ravnborg.org> Subject: RE: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings Date: Fri, 6 Dec 2019 15:10:46 +0000 [thread overview] Message-ID: <TY1PR01MB1770295520291BECDC4D4A1BC05F0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAL_JsqKWWCpEeBd4UFaqBVffS-OxUNAHfvtJKcGsLDR+f=Uytg@mail.gmail.com> Hi Rob, > From: Rob Herring <robh+dt@kernel.org> > Sent: 29 August 2019 15:03 > Subject: Re: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings > > On Wed, Aug 28, 2019 at 1:36 PM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > > > Dual-LVDS connections need markers in the DT, this patch adds > > some common documentation to be referenced by both panels and > > bridges. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v2->v3: > > * new patch > > --- > > .../bindings/display/bus-timings/lvds.yaml | 38 ++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bus-timings/lvds.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bus-timings/lvds.yaml b/Documentation/devicetree/bindings/display/bus- > timings/lvds.yaml > > new file mode 100644 > > index 0000000..f35b55a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bus-timings/lvds.yaml > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > (GPL-2.0-only OR BSD-2-Clause) is preferred for new bindings. > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bus-timings/lvds.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Common Properties for bus timings of LVDS interfaces > > + > > +maintainers: > > + - Thierry Reding <thierry.reding@gmail.com> > > + - Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > + > > +description: | > > + This document defines device tree properties common to LVDS and dual-LVDS > > + interfaces, where a dual-LVDS interface is a dual-link connection with even > > + pixels traveling on one connection, and with odd pixels traveling on the other > > + connection. > > + This document doesn't constitue a device tree binding specification by itself > > typo: constitute > > > + but is meant to be referenced by device tree bindings. > > + When referenced from panel or bridge device tree bindings, the properties > > + defined in this document are defined as follows. The panel and bridge device > > + tree bindings are responsible for defining whether each property is required > > + or optional. > > + > > +properties: > > + dual-lvds-even-pixels: > > + type: boolean > > + description: > > + This property is specific to an input port of a sink device. When > > The schema should define what nodes these go in. The description seems > to indicate in 'port' nodes (or endpoint?), but your use in the panel > binding puts them in the parent. > > > + specified, it marks the port as recipient of even-pixels. > > + > > + dual-lvds-odd-pixels: > > + type: boolean > > + description: > > + This property is specific to an input port of a sink device. When > > + specified, it marks the port as recipient of odd-pixels. > > However, I don't think you even need these. A panel's port numbers are > fixed can imply even or odd. For example port@0 can be even and port@1 > can be odd. The port numbering is typically panel specific, but we may > be able to define the numbering generically if we don't already have > panels with multiple ports. The ports on the receiving end of the link can be identified by any number, not necessarily 0 and 1. Since at this point in time we only have 1 use case for this I'll merge the generic and panel specific dt-schemas together, for simplicity. Perhaps we can split them back once we have a second use case? I'll send a new patch shortly. Thank you very much for your help and your patience! Fab > > Also, aren't there dual link DSI panels? > > Rob
WARNING: multiple messages have this Message-ID (diff)
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> To: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Chris Paterson <Chris.Paterson2@renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Biju Das <biju.das@bp.renesas.com>, "open list:MEDIA DRIVERS FOR RENESAS - FCP" <linux-renesas-soc@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sam Ravnborg <sam@ravnborg.org> Subject: RE: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings Date: Fri, 6 Dec 2019 15:10:46 +0000 [thread overview] Message-ID: <TY1PR01MB1770295520291BECDC4D4A1BC05F0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAL_JsqKWWCpEeBd4UFaqBVffS-OxUNAHfvtJKcGsLDR+f=Uytg@mail.gmail.com> Hi Rob, > From: Rob Herring <robh+dt@kernel.org> > Sent: 29 August 2019 15:03 > Subject: Re: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings > > On Wed, Aug 28, 2019 at 1:36 PM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > > > Dual-LVDS connections need markers in the DT, this patch adds > > some common documentation to be referenced by both panels and > > bridges. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v2->v3: > > * new patch > > --- > > .../bindings/display/bus-timings/lvds.yaml | 38 ++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bus-timings/lvds.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bus-timings/lvds.yaml b/Documentation/devicetree/bindings/display/bus- > timings/lvds.yaml > > new file mode 100644 > > index 0000000..f35b55a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bus-timings/lvds.yaml > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > (GPL-2.0-only OR BSD-2-Clause) is preferred for new bindings. > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bus-timings/lvds.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Common Properties for bus timings of LVDS interfaces > > + > > +maintainers: > > + - Thierry Reding <thierry.reding@gmail.com> > > + - Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > + > > +description: | > > + This document defines device tree properties common to LVDS and dual-LVDS > > + interfaces, where a dual-LVDS interface is a dual-link connection with even > > + pixels traveling on one connection, and with odd pixels traveling on the other > > + connection. > > + This document doesn't constitue a device tree binding specification by itself > > typo: constitute > > > + but is meant to be referenced by device tree bindings. > > + When referenced from panel or bridge device tree bindings, the properties > > + defined in this document are defined as follows. The panel and bridge device > > + tree bindings are responsible for defining whether each property is required > > + or optional. > > + > > +properties: > > + dual-lvds-even-pixels: > > + type: boolean > > + description: > > + This property is specific to an input port of a sink device. When > > The schema should define what nodes these go in. The description seems > to indicate in 'port' nodes (or endpoint?), but your use in the panel > binding puts them in the parent. > > > + specified, it marks the port as recipient of even-pixels. > > + > > + dual-lvds-odd-pixels: > > + type: boolean > > + description: > > + This property is specific to an input port of a sink device. When > > + specified, it marks the port as recipient of odd-pixels. > > However, I don't think you even need these. A panel's port numbers are > fixed can imply even or odd. For example port@0 can be even and port@1 > can be odd. The port numbering is typically panel specific, but we may > be able to define the numbering generically if we don't already have > panels with multiple ports. The ports on the receiving end of the link can be identified by any number, not necessarily 0 and 1. Since at this point in time we only have 1 use case for this I'll merge the generic and panel specific dt-schemas together, for simplicity. Perhaps we can split them back once we have a second use case? I'll send a new patch shortly. Thank you very much for your help and your patience! Fab > > Also, aren't there dual link DSI panels? > > Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-06 15:10 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-28 18:36 [PATCH v3 0/8] Add dual-LVDS panel support to EK874 Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings Fabrizio Castro 2019-08-29 7:57 ` Geert Uytterhoeven 2019-08-29 7:57 ` Geert Uytterhoeven 2019-08-29 9:14 ` Fabrizio Castro 2019-08-29 9:14 ` Fabrizio Castro 2019-08-29 14:03 ` Rob Herring 2019-08-29 14:03 ` Rob Herring 2019-08-29 14:38 ` Fabrizio Castro 2019-08-29 14:38 ` Fabrizio Castro 2019-11-07 18:00 ` Laurent Pinchart 2019-11-07 18:00 ` Laurent Pinchart 2019-11-07 18:00 ` Laurent Pinchart 2019-12-06 15:11 ` Fabrizio Castro 2019-12-06 15:11 ` Fabrizio Castro 2019-12-06 15:10 ` Fabrizio Castro [this message] 2019-12-06 15:10 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding Fabrizio Castro 2019-11-07 18:12 ` Laurent Pinchart 2019-11-07 18:12 ` Laurent Pinchart 2019-12-06 15:17 ` Fabrizio Castro 2019-12-06 15:17 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 3/8] drm: Add bus timings helper Fabrizio Castro 2019-11-07 19:26 ` Laurent Pinchart 2019-11-07 19:26 ` Laurent Pinchart 2019-11-07 19:30 ` Daniel Vetter 2019-11-07 19:30 ` Daniel Vetter 2019-12-06 15:25 ` Fabrizio Castro 2019-12-06 15:25 ` Fabrizio Castro 2019-12-06 15:24 ` Fabrizio Castro 2019-12-06 15:24 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 4/8] drm: rcar-du: lvds: Add dual-LVDS panels support Fabrizio Castro 2019-11-07 19:50 ` Laurent Pinchart 2019-11-07 19:50 ` Laurent Pinchart 2019-12-06 15:35 ` Fabrizio Castro 2019-12-06 15:35 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 5/8] drm: bridge: thc63: Do not report input bus mode through bridge timings Fabrizio Castro 2019-11-07 19:52 ` Laurent Pinchart 2019-11-07 19:52 ` Laurent Pinchart 2019-12-06 15:38 ` Fabrizio Castro 2019-12-06 15:38 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 6/8] arm64: dts: renesas: Add EK874 board with idk-2121wr display support Fabrizio Castro 2019-11-07 19:55 ` Laurent Pinchart 2019-08-28 18:36 ` [PATCH v3 7/8] [HACK] arm64: dts: renesas: draak: Enable LVDS Fabrizio Castro 2019-11-07 19:57 ` Laurent Pinchart 2019-12-06 15:40 ` Fabrizio Castro 2019-08-28 18:36 ` [PATCH v3 8/8] [HACK] arm64: dts: renesas: draak: Enable LVDS dual-link operation Fabrizio Castro 2019-08-29 15:26 ` [PATCH v3 0/8] Add dual-LVDS panel support to EK874 Rob Herring 2019-08-29 15:26 ` Rob Herring 2019-09-02 10:01 ` Fabrizio Castro 2019-09-02 10:01 ` Fabrizio Castro 2019-10-22 16:30 ` Fabrizio Castro 2019-10-22 16:30 ` Fabrizio Castro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TY1PR01MB1770295520291BECDC4D4A1BC05F0@TY1PR01MB1770.jpnprd01.prod.outlook.com \ --to=fabrizio.castro@bp.renesas.com \ --cc=Chris.Paterson2@renesas.com \ --cc=airlied@linux.ie \ --cc=biju.das@bp.renesas.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.