From: Thierry Reding <thierry.reding@gmail.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev
Date: Thu, 13 Jul 2023 09:18:02 +0200 [thread overview]
Message-ID: <ZK-kw7cnpeAxf1Yp@orome> (raw)
In-Reply-To: <87fs5tgpvv.fsf@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3061 bytes --]
Shortening the absurdly long recipient list, Google won't let me send
this otherwise.
On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote:
> On Wed, 12 Jul 2023, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > Hello,
> >
> > while I debugged an issue in the imx-lcdc driver I was constantly
> > irritated about struct drm_device pointer variables being named "dev"
> > because with that name I usually expect a struct device pointer.
> >
> > I think there is a big benefit when these are all renamed to "drm_dev".
> > I have no strong preference here though, so "drmdev" or "drm" are fine
> > for me, too. Let the bikesheding begin!
> >
> > Some statistics:
> >
> > $ git grep -ohE 'struct drm_device *\* *[^ (),;]*' v6.5-rc1 | sort | uniq -c | sort -n
> > 1 struct drm_device *adev_to_drm
> > 1 struct drm_device *drm_
> > 1 struct drm_device *drm_dev
> > 1 struct drm_device *drm_dev
> > 1 struct drm_device *pdev
> > 1 struct drm_device *rdev
> > 1 struct drm_device *vdev
> > 2 struct drm_device *dcss_drv_dev_to_drm
> > 2 struct drm_device **ddev
> > 2 struct drm_device *drm_dev_alloc
> > 2 struct drm_device *mock
> > 2 struct drm_device *p_ddev
> > 5 struct drm_device *device
> > 9 struct drm_device * dev
> > 25 struct drm_device *d
> > 95 struct drm_device *
> > 216 struct drm_device *ddev
> > 234 struct drm_device *drm_dev
> > 611 struct drm_device *drm
> > 4190 struct drm_device *dev
> >
> > This series starts with renaming struct drm_crtc::dev to drm_dev. If
> > it's not only me and others like the result of this effort it should be
> > followed up by adapting the other structs and the individual usages in
> > the different drivers.
>
> I think this is an unnecessary change. In drm, a dev is usually a drm
> device, i.e. struct drm_device *. As shown by the numbers above.
I fully agree with this. I can understand that this is potentially
confusing to people that work across subsystems and aren't used to
seeing this. But to most DRM/KMS developers this is quite familiar
and since they spend much more time on this than the occasional
cross-kernel patch, it outweighs the minor nuisance that this may
be for everyone else.
Since Uwe has already shown that "dev" is the consensus, I think if we
really must have this kind of patch the logical choice would be to
change any struct drm_device * to be named "dev" rather than trying to
establish a new consensus.
> If folks insist on following through with this anyway, I'm firmly in the
> camp the name should be "drm" and nothing else.
Same here. If people can't live with "dev", then simply "drm" seems like
the next best choice. It's short and to the point. A _dev suffix is
redundant because any other DRM structure variables will typically be
named something else anyway (i.e. crtc, connector, encoder, plane, ...
or a corresponding abbreviated form).
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-13 7:18 UTC|newest]
Thread overview: 255+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 9:46 [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev Uwe Kleine-König
2023-07-12 9:46 ` [Nouveau] " Uwe Kleine-König
2023-07-12 9:46 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 01/52] drm/crtc: Start renaming " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 02/52] drm/core: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 03/52] drm/amd: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 04/52] drm/armada: " Uwe Kleine-König
2023-07-12 19:13 ` Russell King (Oracle)
2023-07-12 9:46 ` [PATCH RFC v1 05/52] drm/arm: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 06/52] drm/aspeed: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 07/52] drm/ast: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 08/52] drm/atmel-hlcdc: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 09/52] drm/exynos: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 10/52] drm/fsl-dcu: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 11/52] drm/gma500: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 12/52] drm/gud: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 13/52] drm/hisilicon: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 14/52] drm/hyperv: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 15/52] drm/i915: " Uwe Kleine-König
2023-07-12 9:46 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 16/52] drm/imx: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 17/52] drm/ingenic: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 18/52] drm/kmb: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 19/52] drm/logicvc: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 20/52] drm/mcde: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 21/52] drm/mediatek: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 22/52] drm/meson: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 23/52] drm/mgag200: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 24/52] drm/msm: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 25/52] drm/mxsfb: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [Nouveau] [PATCH RFC v1 26/52] drm/nouveau: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 27/52] drm/omapdrm: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 28/52] drm/panel-ili9341: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 29/52] drm/pl111: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 30/52] drm/qxl: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 31/52] drm/radeon: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 32/52] drm/renesas: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 33/52] drm/rockchip: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 34/52] drm/solomon: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 35/52] drm/sprd: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 36/52] drm/sti: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 37/52] drm/stm: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 38/52] drm/sun4i: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 39/52] drm/tegra: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 40/52] drm/tidss: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 41/52] drm/tilcdc: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 42/52] drm/tiny: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 43/52] drm/tve200: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 44/52] drm/udl: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 45/52] drm/vboxvideo: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 46/52] drm/vc4: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 47/52] drm/virtio: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 48/52] drm/vkms: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 49/52] drm/vmwgfx: " Uwe Kleine-König
2023-07-12 9:47 ` [PATCH RFC v1 50/52] drm/xen: " Uwe Kleine-König
2023-07-12 9:47 ` Uwe Kleine-König
2023-07-12 9:47 ` [PATCH RFC v1 51/52] drm/xlnx: " Uwe Kleine-König
2023-07-12 9:47 ` Uwe Kleine-König
2023-07-12 9:47 ` [PATCH RFC v1 52/52] drm/crtc: Complete renaming struct drm_crtc::dev to drm_dev Uwe Kleine-König
2023-07-12 10:13 ` [PATCH RFC v1 00/52] drm/crtc: Rename " Paul Kocialkowski
2023-07-12 10:13 ` [Nouveau] " Paul Kocialkowski
2023-07-12 10:13 ` [Intel-gfx] " Paul Kocialkowski
2023-07-12 10:13 ` Paul Kocialkowski
2023-07-12 10:13 ` Paul Kocialkowski
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:19 ` [Nouveau] " Thomas Zimmermann
2023-07-12 10:19 ` [Intel-gfx] " Thomas Zimmermann
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:54 ` Uwe Kleine-König
2023-07-12 10:54 ` [Nouveau] " Uwe Kleine-König
2023-07-12 10:54 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 10:54 ` Uwe Kleine-König
2023-07-12 10:54 ` Uwe Kleine-König
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` [Intel-gfx] " Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 10:46 ` Christian König
2023-07-12 10:46 ` [Nouveau] " Christian König
2023-07-12 10:46 ` [Intel-gfx] " Christian König
2023-07-12 10:46 ` Christian König
2023-07-12 10:46 ` Christian König
2023-07-12 10:46 ` Christian König via Virtualization
2023-07-12 11:02 ` Uwe Kleine-König
2023-07-12 11:02 ` [Nouveau] " Uwe Kleine-König
2023-07-12 11:02 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 11:02 ` Uwe Kleine-König
2023-07-12 11:02 ` Uwe Kleine-König
2023-07-12 11:07 ` Julia Lawall
2023-07-12 11:07 ` [Nouveau] " Julia Lawall
2023-07-12 11:07 ` [Intel-gfx] " Julia Lawall
2023-07-12 11:07 ` Julia Lawall
2023-07-12 11:07 ` Julia Lawall
2023-07-12 11:13 ` Andrzej Hajda
2023-07-12 11:13 ` [Nouveau] " Andrzej Hajda
2023-07-12 11:13 ` [Intel-gfx] " Andrzej Hajda
2023-07-12 11:13 ` Andrzej Hajda
2023-07-12 11:13 ` Andrzej Hajda
2023-07-12 12:52 ` Maxime Ripard
2023-07-12 12:52 ` [Nouveau] " Maxime Ripard
2023-07-12 12:52 ` [Intel-gfx] " Maxime Ripard
2023-07-12 12:52 ` Maxime Ripard
2023-07-12 12:52 ` Maxime Ripard
2023-07-12 13:38 ` Uwe Kleine-König
2023-07-12 13:38 ` [Nouveau] " Uwe Kleine-König
2023-07-12 13:38 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 13:38 ` Uwe Kleine-König
2023-07-12 13:38 ` Uwe Kleine-König
2023-07-12 13:51 ` Javier Martinez Canillas
2023-07-12 13:53 ` Maxime Ripard
2023-07-12 13:53 ` [Nouveau] " Maxime Ripard
2023-07-12 13:53 ` [Intel-gfx] " Maxime Ripard
2023-07-12 13:53 ` Maxime Ripard
2023-07-12 13:53 ` Maxime Ripard
2023-07-12 13:53 ` Christian König
2023-07-12 13:53 ` [Nouveau] " Christian König
2023-07-12 13:53 ` [Intel-gfx] " Christian König
2023-07-12 13:53 ` Christian König
2023-07-12 13:53 ` Christian König
2023-07-12 13:53 ` Christian König via Virtualization
2023-07-13 0:06 ` Luben Tuikov
2023-07-13 0:06 ` [Nouveau] " Luben Tuikov
2023-07-13 0:06 ` [Intel-gfx] " Luben Tuikov
2023-07-13 0:06 ` Luben Tuikov
2023-07-13 0:06 ` Luben Tuikov
2023-07-12 16:23 ` Sui Jingfeng
2023-07-12 14:34 ` Jani Nikula
2023-07-12 14:34 ` [Nouveau] " Jani Nikula
2023-07-12 14:34 ` [Intel-gfx] " Jani Nikula
2023-07-12 14:34 ` Jani Nikula
2023-07-12 14:34 ` Jani Nikula
2023-07-12 16:10 ` Uwe Kleine-König
2023-07-12 16:10 ` [Nouveau] " Uwe Kleine-König
2023-07-12 16:10 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 16:10 ` Uwe Kleine-König
2023-07-12 16:10 ` Uwe Kleine-König
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 6:52 ` [Nouveau] " Geert Uytterhoeven
2023-07-13 6:52 ` [Intel-gfx] " Geert Uytterhoeven
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 10:03 ` Uwe Kleine-König
2023-07-13 10:03 ` [Nouveau] " Uwe Kleine-König
2023-07-13 10:03 ` Uwe Kleine-König
2023-07-13 10:03 ` Uwe Kleine-König
2023-07-13 10:03 ` [Intel-gfx] " Uwe Kleine-König
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 7:47 ` [Nouveau] " Thomas Zimmermann
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 7:47 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 9:03 ` Jani Nikula
2023-07-13 9:03 ` [Nouveau] " Jani Nikula
2023-07-13 9:03 ` Jani Nikula
2023-07-13 9:03 ` [Intel-gfx] " Jani Nikula
2023-07-13 9:29 ` Geert Uytterhoeven
2023-07-13 9:29 ` [Nouveau] " Geert Uytterhoeven
2023-07-13 9:29 ` Geert Uytterhoeven
2023-07-13 9:29 ` [Intel-gfx] " Geert Uytterhoeven
2023-07-13 9:29 ` Geert Uytterhoeven
2023-07-13 9:54 ` Uwe Kleine-König
2023-07-13 9:54 ` [Nouveau] " Uwe Kleine-König
2023-07-13 9:54 ` Uwe Kleine-König
2023-07-13 9:54 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 18:31 ` [Freedreno] " Sean Paul
2023-07-12 18:31 ` [Nouveau] " Sean Paul
2023-07-12 18:31 ` [Intel-gfx] " Sean Paul
2023-07-12 18:31 ` Sean Paul
2023-07-12 18:31 ` Sean Paul
2023-07-12 18:31 ` Sean Paul
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-12 19:22 ` [Nouveau] " Krzysztof Kozlowski
2023-07-12 19:22 ` [Intel-gfx] " Krzysztof Kozlowski
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-13 7:48 ` Thomas Zimmermann
2023-07-13 7:48 ` [Nouveau] " Thomas Zimmermann
2023-07-13 7:48 ` Thomas Zimmermann
2023-07-13 7:48 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 7:48 ` Thomas Zimmermann
2023-07-13 13:03 ` Uwe Kleine-König
2023-07-13 13:03 ` [Nouveau] " Uwe Kleine-König
2023-07-13 13:03 ` [Intel-gfx] " Uwe Kleine-König
2023-07-13 13:03 ` Uwe Kleine-König
2023-07-13 13:03 ` Uwe Kleine-König
2023-07-13 14:41 ` Sean Paul
2023-07-13 14:41 ` [Nouveau] " Sean Paul
2023-07-13 14:41 ` [Intel-gfx] " Sean Paul
2023-07-13 14:41 ` Sean Paul
2023-07-13 14:41 ` Sean Paul
2023-07-13 14:41 ` Sean Paul
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:09 ` [Nouveau] " Thomas Zimmermann
2023-07-13 15:09 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:14 ` Tvrtko Ursulin
2023-07-13 15:14 ` [Nouveau] " Tvrtko Ursulin
2023-07-13 15:14 ` Tvrtko Ursulin
2023-07-13 15:14 ` Tvrtko Ursulin
2023-07-13 15:30 ` Maxime Ripard
2023-07-13 15:30 ` [Nouveau] " Maxime Ripard
2023-07-13 15:30 ` [Intel-gfx] " Maxime Ripard
2023-07-13 15:30 ` Maxime Ripard
2023-07-13 15:30 ` Maxime Ripard
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-14 7:38 ` [Nouveau] " Thomas Zimmermann
2023-07-14 7:38 ` [Intel-gfx] " Thomas Zimmermann
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-13 15:39 ` Uwe Kleine-König
2023-07-13 15:39 ` [Nouveau] " Uwe Kleine-König
2023-07-13 15:39 ` [Intel-gfx] " Uwe Kleine-König
2023-07-13 15:39 ` Uwe Kleine-König
2023-07-13 15:39 ` Uwe Kleine-König
2023-07-13 17:06 ` Thierry Reding
2023-07-13 7:18 ` Thierry Reding [this message]
2023-07-13 7:54 ` Thomas Zimmermann
2023-07-13 7:54 ` [Nouveau] " Thomas Zimmermann
2023-07-13 7:54 ` Thomas Zimmermann
2023-07-13 7:54 ` Thomas Zimmermann
2023-07-13 7:54 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 7:54 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK-kw7cnpeAxf1Yp@orome \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.