Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

From: Maxime Ripard <mripard@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Christian König" <christian.koenig@amd.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Hamza Mahfooz" <hamza.mahfooz@amd.com>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Guchun Chen" <guchun.chen@amd.com>,
	"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
	"Evan Quan" <evan.quan@amd.com>, "Likun Gao" <Likun.Gao@amd.com>,
	"Marek Olšák" <marek.olsak@amd.com>,
	"David Francis" <David.Francis@amd.com>,
	"Hawking Zhang" <Hawking.Zhang@amd.com>,
	"Lang Yu" <Lang.Yu@amd.com>, "Philip Yang" <Philip.Yang@amd.com>,
	"Yifan Zhang" <yifan1.zhang@amd.com>,
	"Tim Huang" <Tim.Huang@amd.com>, "Zack Rusin" <zackr@vmware.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Hersen Wu" <hersenxs.wu@amd.com>,
	"Fangzhi Zuo" <jerry.zuo@amd.com>,
	"Stylon Wang" <stylon.wang@amd.com>,
	"Alan Liu" <haoping.liu@amd.com>, "Wayne Lin" <Wayne.Lin@amd.com>,
	"Aaron Liu" <aaron.liu@amd.com>, "Melissa Wen" <mwen@igalia.com>,
	"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
	"David Tadokoro" <davidbtadokoro@usp.br>,
	"Wenjing Liu" <wenjing.liu@amd.com>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Alexey Kodanev" <aleksei.kodanev@bell-sw.com>,
	"Roman Li" <roman.li@amd.com>,
	"Joaquín Ignacio Aramendía" <samsagax@gmail.com>,
	"Dave Airlie" <airlied@redhat.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Inki Dae" <inki.dae@samsung.com>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Stefan Agner" <stefan@agner.ch>,
	"Alison Wang" <alison.wang@nxp.com>,
	"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Xinliang Liu" <xinliang.liu@linaro.org>,
	"Tian Tao" <tiantao6@hisilicon.com>,
	"Danilo Krummrich" <dakr@redhat.com>,
	"Deepak Rawat" <drawat.floss@gmail.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Ankit Nautiyal" <ankit.k.nautiyal@intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Stanislav Lisovskiy" <stanislav.lisovskiy@intel.com>,
	"Radhakrishna Sripada" <radhakrishna.sripada@intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Luca Coelho" <luciano.coelho@intel.com>,
	"Niranjana Vishwanathapura" <niranjana.vishwanathapura@intel.com>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Vinod Govindapillai" <vinod.govindapillai@intel.com>,
	"Łukasz Bartosik" <lb@semihalf.com>,
	"Anusha Srivatsa" <anusha.srivatsa@intel.com>,
	"Chaitanya Kumar Borah" <chaitanya.kumar.borah@intel.com>,
	"Uma Shankar" <uma.shankar@intel.com>,
	"Imre Deak" <imre.deak@intel.com>,
	"Mitul Golani" <mitulkumar.ajitkumar.golani@intel.com>,
	"Swati Sharma" <swati2.sharma@intel.com>,
	"Jouni Högander" <jouni.hogander@intel.com>,
	"Mika Kahola" <mika.kahola@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	"Arun R Murthy" <arun.r.murthy@intel.com>,
	"Gustavo Sousa" <gustavo.sousa@intel.com>,
	"Khaled Almahallawy" <khaled.almahallawy@intel.com>,
	"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>,
	"Andi Shyti" <andi.shyti@linux.intel.com>,
	"Nirmoy Das" <nirmoy.das@intel.com>,
	"Fei Yang" <fei.yang@intel.com>,
	"Animesh Manna" <animesh.manna@intel.com>,
	"Deepak R Varma" <drv@mailo.com>,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Vandita Kulkarni" <vandita.kulkarni@intel.com>,
	"Suraj Kandpal" <suraj.kandpal@intel.com>,
	"Drew Davenport" <ddavenport@chromium.org>,
	"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Dan Carpenter" <error27@gmail.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Anitha Chrisanthus" <anitha.chrisanthus@intel.com>,
	"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Vinod Polimera" <quic_vpolimer@quicinc.com>,
	"Jiasheng Jiang" <jiasheng@iscas.ac.cn>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Jessica Zhang" <quic_jesszhan@quicinc.com>,
	"Liu Shixin" <liushixin2@huawei.com>,
	"Marek Vasut" <marex@denx.de>, "Ben Skeggs" <bskeggs@redhat.com>,
	"Karol Herbst" <kherbst@redhat.com>,
	"Lyude Paul" <lyude@redhat.com>,
	"Tomi Valkeinen" <tomba@kernel.org>,
	"Emma Anholt" <emma@anholt.net>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Tomi Valkeinen" <tomi.valkeinen+renesas@ideasonboard.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Alain Volmat" <alain.volmat@foss.st.com>,
	"Yannick Fertre" <yannick.fertre@foss.st.com>,
	"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
	"Philippe Cornu" <philippe.cornu@foss.st.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Jyri Sarha" <jyri.sarha@iki.fi>,
	"David Lechner" <david@lechnology.com>,
	"Kamlesh Gurudasani" <kamlesh.gurudasani@gmail.com>,
	"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
	"Melissa Wen" <melissa.srw@gmail.com>,
	"Oleksandr Andrushchenko" <oleksandr_andrushchenko@epam.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Haneen Mohammed" <hamohammed.sa@gmail.com>,
	linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	"Yongqin Liu" <yongqin.liu@linaro.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-rockchip@lists.infradead.org,
	"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
	"VMware Graphics Reviewers"
	<linux-graphics-maintainer@vmware.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	spice-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Sean Paul" <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	linux-mips@vger.kernel.org, "Chia-I Wu" <olvaffe@gmail.com>,
	linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de,
	"John Stultz" <jstultz@google.com>,
	freedreno@lists.freedesktop.org,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Julia Lawall" <Julia.Lawall@inria.fr>
Subject: Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev
Date: Wed, 12 Jul 2023 14:52:38 +0200	[thread overview]
Message-ID: <o3dc4q27ap6rajsvpfwfvs3z3afekkwbhnclvswkaietciy2kc@unjf67gz5tur> (raw)
In-Reply-To: <20230712110253.paoyrmcbvlhpfxbf@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

On Wed, Jul 12, 2023 at 01:02:53PM +0200, Uwe Kleine-König wrote:
> > Background is that this makes merge conflicts easier to handle and detect.
> 
> Really?

FWIW, I agree with Christian here.

> Each file (apart from include/drm/drm_crtc.h) is only touched once. So
> unless I'm missing something you don't get less or easier conflicts by
> doing it all in a single patch. But you gain the freedom to drop a
> patch for one driver without having to drop the rest with it.

Not really, because the last patch removed the union anyway. So you have
to revert both the last patch, plus that driver one. And then you need
to add a TODO to remove that union eventually.

> So I still like the split version better, but I'm open to a more
> verbose reasoning from your side.

You're doing only one thing here, really: you change the name of a
structure field. If it was shared between multiple maintainers, then
sure, splitting that up is easier for everyone, but this will go through
drm-misc, so I can't see the benefit it brings.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]