From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev
Date: Thu, 13 Jul 2023 19:06:12 +0200 [thread overview]
Message-ID: <ZLAu5fy7bCUJjvMs@orome> (raw)
In-Reply-To: <20230713153936.k2m6aj34vptj5vf7@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]
On Thu, Jul 13, 2023 at 05:39:36PM +0200, Uwe Kleine-König wrote:
> On Thu, Jul 13, 2023 at 10:41:45AM -0400, Sean Paul wrote:
> > On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König
> > > But even with the one-patch-per-rename approach I'd consider the
> > > renaming a net win, because ease of understanding code has a big value.
> > > It's value is not so easy measurable as "conflicts when backporting",
> > > but it also matters in say two years from now, while backporting
> > > shouldn't be an issue then any more.
> >
> > You've rightly identified the conjecture in your statement. I've been
> > on both sides of the argument, having written/maintained drm code
> > upstream and cherry-picked changes to a downstream kernel. Perhaps
> > it's because drm's definition of dev is ingrained in my muscle memory,
> > or maybe it's because I don't do a lot of upstream development these
> > days, but I just have a hard time seeing the benefit here.
>
> I see that my change doesn't immediately benefit those who are already
> at home in drivers/gpu/drm. So it's quite understandable that someone in
> a senior role (long time contributor or maintainer) doesn't see a big
> upside.
>
> In contrast I think my change (with its indisputable cost) lowers the
> bar for new contributors to drm. IMHO that's something a maintainer has
> to have on their radar, too, and that's easily undervalued in my
> experience.
To be honest, DRM/KMS is quite a complex subsystem, so whether dev is
struct device or struct drm_device doesn't really do anything to move
the bar in either direction.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-13 17:06 UTC|newest]
Thread overview: 255+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 9:46 [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev Uwe Kleine-König
2023-07-12 9:46 ` [Nouveau] " Uwe Kleine-König
2023-07-12 9:46 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 01/52] drm/crtc: Start renaming " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 02/52] drm/core: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 03/52] drm/amd: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 04/52] drm/armada: " Uwe Kleine-König
2023-07-12 19:13 ` Russell King (Oracle)
2023-07-12 9:46 ` [PATCH RFC v1 05/52] drm/arm: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 06/52] drm/aspeed: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 07/52] drm/ast: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 08/52] drm/atmel-hlcdc: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 09/52] drm/exynos: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 10/52] drm/fsl-dcu: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 11/52] drm/gma500: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 12/52] drm/gud: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 13/52] drm/hisilicon: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 14/52] drm/hyperv: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 15/52] drm/i915: " Uwe Kleine-König
2023-07-12 9:46 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 16/52] drm/imx: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 17/52] drm/ingenic: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 18/52] drm/kmb: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 19/52] drm/logicvc: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 20/52] drm/mcde: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 21/52] drm/mediatek: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 22/52] drm/meson: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 23/52] drm/mgag200: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 24/52] drm/msm: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 25/52] drm/mxsfb: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [Nouveau] [PATCH RFC v1 26/52] drm/nouveau: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 27/52] drm/omapdrm: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 28/52] drm/panel-ili9341: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 29/52] drm/pl111: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 30/52] drm/qxl: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 31/52] drm/radeon: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 32/52] drm/renesas: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 33/52] drm/rockchip: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 34/52] drm/solomon: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 35/52] drm/sprd: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 36/52] drm/sti: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 37/52] drm/stm: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 38/52] drm/sun4i: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 39/52] drm/tegra: " Uwe Kleine-König
2023-07-12 9:46 ` Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 40/52] drm/tidss: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 41/52] drm/tilcdc: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 42/52] drm/tiny: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 43/52] drm/tve200: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 44/52] drm/udl: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 45/52] drm/vboxvideo: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 46/52] drm/vc4: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 47/52] drm/virtio: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 48/52] drm/vkms: " Uwe Kleine-König
2023-07-12 9:46 ` [PATCH RFC v1 49/52] drm/vmwgfx: " Uwe Kleine-König
2023-07-12 9:47 ` [PATCH RFC v1 50/52] drm/xen: " Uwe Kleine-König
2023-07-12 9:47 ` Uwe Kleine-König
2023-07-12 9:47 ` [PATCH RFC v1 51/52] drm/xlnx: " Uwe Kleine-König
2023-07-12 9:47 ` Uwe Kleine-König
2023-07-12 9:47 ` [PATCH RFC v1 52/52] drm/crtc: Complete renaming struct drm_crtc::dev to drm_dev Uwe Kleine-König
2023-07-12 10:13 ` [PATCH RFC v1 00/52] drm/crtc: Rename " Paul Kocialkowski
2023-07-12 10:13 ` [Nouveau] " Paul Kocialkowski
2023-07-12 10:13 ` [Intel-gfx] " Paul Kocialkowski
2023-07-12 10:13 ` Paul Kocialkowski
2023-07-12 10:13 ` Paul Kocialkowski
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:19 ` [Nouveau] " Thomas Zimmermann
2023-07-12 10:19 ` [Intel-gfx] " Thomas Zimmermann
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:19 ` Thomas Zimmermann
2023-07-12 10:54 ` Uwe Kleine-König
2023-07-12 10:54 ` [Nouveau] " Uwe Kleine-König
2023-07-12 10:54 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 10:54 ` Uwe Kleine-König
2023-07-12 10:54 ` Uwe Kleine-König
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` [Intel-gfx] " Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 11:18 ` Javier Martinez Canillas
2023-07-12 10:46 ` Christian König
2023-07-12 10:46 ` [Nouveau] " Christian König
2023-07-12 10:46 ` [Intel-gfx] " Christian König
2023-07-12 10:46 ` Christian König
2023-07-12 10:46 ` Christian König
2023-07-12 10:46 ` Christian König via Virtualization
2023-07-12 11:02 ` Uwe Kleine-König
2023-07-12 11:02 ` [Nouveau] " Uwe Kleine-König
2023-07-12 11:02 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 11:02 ` Uwe Kleine-König
2023-07-12 11:02 ` Uwe Kleine-König
2023-07-12 11:07 ` Julia Lawall
2023-07-12 11:07 ` [Nouveau] " Julia Lawall
2023-07-12 11:07 ` [Intel-gfx] " Julia Lawall
2023-07-12 11:07 ` Julia Lawall
2023-07-12 11:07 ` Julia Lawall
2023-07-12 11:13 ` Andrzej Hajda
2023-07-12 11:13 ` [Nouveau] " Andrzej Hajda
2023-07-12 11:13 ` [Intel-gfx] " Andrzej Hajda
2023-07-12 11:13 ` Andrzej Hajda
2023-07-12 11:13 ` Andrzej Hajda
2023-07-12 12:52 ` Maxime Ripard
2023-07-12 12:52 ` [Nouveau] " Maxime Ripard
2023-07-12 12:52 ` [Intel-gfx] " Maxime Ripard
2023-07-12 12:52 ` Maxime Ripard
2023-07-12 12:52 ` Maxime Ripard
2023-07-12 13:38 ` Uwe Kleine-König
2023-07-12 13:38 ` [Nouveau] " Uwe Kleine-König
2023-07-12 13:38 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 13:38 ` Uwe Kleine-König
2023-07-12 13:38 ` Uwe Kleine-König
2023-07-12 13:51 ` Javier Martinez Canillas
2023-07-12 13:53 ` Maxime Ripard
2023-07-12 13:53 ` [Nouveau] " Maxime Ripard
2023-07-12 13:53 ` [Intel-gfx] " Maxime Ripard
2023-07-12 13:53 ` Maxime Ripard
2023-07-12 13:53 ` Maxime Ripard
2023-07-12 13:53 ` Christian König
2023-07-12 13:53 ` [Nouveau] " Christian König
2023-07-12 13:53 ` [Intel-gfx] " Christian König
2023-07-12 13:53 ` Christian König
2023-07-12 13:53 ` Christian König
2023-07-12 13:53 ` Christian König via Virtualization
2023-07-13 0:06 ` Luben Tuikov
2023-07-13 0:06 ` [Nouveau] " Luben Tuikov
2023-07-13 0:06 ` [Intel-gfx] " Luben Tuikov
2023-07-13 0:06 ` Luben Tuikov
2023-07-13 0:06 ` Luben Tuikov
2023-07-12 16:23 ` Sui Jingfeng
2023-07-12 14:34 ` Jani Nikula
2023-07-12 14:34 ` [Nouveau] " Jani Nikula
2023-07-12 14:34 ` [Intel-gfx] " Jani Nikula
2023-07-12 14:34 ` Jani Nikula
2023-07-12 14:34 ` Jani Nikula
2023-07-12 16:10 ` Uwe Kleine-König
2023-07-12 16:10 ` [Nouveau] " Uwe Kleine-König
2023-07-12 16:10 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 16:10 ` Uwe Kleine-König
2023-07-12 16:10 ` Uwe Kleine-König
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 6:52 ` [Nouveau] " Geert Uytterhoeven
2023-07-13 6:52 ` [Intel-gfx] " Geert Uytterhoeven
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 6:52 ` Geert Uytterhoeven
2023-07-13 10:03 ` Uwe Kleine-König
2023-07-13 10:03 ` [Nouveau] " Uwe Kleine-König
2023-07-13 10:03 ` Uwe Kleine-König
2023-07-13 10:03 ` Uwe Kleine-König
2023-07-13 10:03 ` [Intel-gfx] " Uwe Kleine-König
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 7:47 ` [Nouveau] " Thomas Zimmermann
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 7:47 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 7:47 ` Thomas Zimmermann
2023-07-13 9:03 ` Jani Nikula
2023-07-13 9:03 ` [Nouveau] " Jani Nikula
2023-07-13 9:03 ` Jani Nikula
2023-07-13 9:03 ` [Intel-gfx] " Jani Nikula
2023-07-13 9:29 ` Geert Uytterhoeven
2023-07-13 9:29 ` [Nouveau] " Geert Uytterhoeven
2023-07-13 9:29 ` Geert Uytterhoeven
2023-07-13 9:29 ` [Intel-gfx] " Geert Uytterhoeven
2023-07-13 9:29 ` Geert Uytterhoeven
2023-07-13 9:54 ` Uwe Kleine-König
2023-07-13 9:54 ` [Nouveau] " Uwe Kleine-König
2023-07-13 9:54 ` Uwe Kleine-König
2023-07-13 9:54 ` [Intel-gfx] " Uwe Kleine-König
2023-07-12 18:31 ` [Freedreno] " Sean Paul
2023-07-12 18:31 ` [Nouveau] " Sean Paul
2023-07-12 18:31 ` [Intel-gfx] " Sean Paul
2023-07-12 18:31 ` Sean Paul
2023-07-12 18:31 ` Sean Paul
2023-07-12 18:31 ` Sean Paul
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-12 19:22 ` [Nouveau] " Krzysztof Kozlowski
2023-07-12 19:22 ` [Intel-gfx] " Krzysztof Kozlowski
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-12 19:22 ` Krzysztof Kozlowski
2023-07-13 7:48 ` Thomas Zimmermann
2023-07-13 7:48 ` [Nouveau] " Thomas Zimmermann
2023-07-13 7:48 ` Thomas Zimmermann
2023-07-13 7:48 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 7:48 ` Thomas Zimmermann
2023-07-13 13:03 ` Uwe Kleine-König
2023-07-13 13:03 ` [Nouveau] " Uwe Kleine-König
2023-07-13 13:03 ` [Intel-gfx] " Uwe Kleine-König
2023-07-13 13:03 ` Uwe Kleine-König
2023-07-13 13:03 ` Uwe Kleine-König
2023-07-13 14:41 ` Sean Paul
2023-07-13 14:41 ` [Nouveau] " Sean Paul
2023-07-13 14:41 ` [Intel-gfx] " Sean Paul
2023-07-13 14:41 ` Sean Paul
2023-07-13 14:41 ` Sean Paul
2023-07-13 14:41 ` Sean Paul
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:09 ` [Nouveau] " Thomas Zimmermann
2023-07-13 15:09 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:09 ` Thomas Zimmermann
2023-07-13 15:14 ` Tvrtko Ursulin
2023-07-13 15:14 ` [Nouveau] " Tvrtko Ursulin
2023-07-13 15:14 ` Tvrtko Ursulin
2023-07-13 15:14 ` Tvrtko Ursulin
2023-07-13 15:30 ` Maxime Ripard
2023-07-13 15:30 ` [Nouveau] " Maxime Ripard
2023-07-13 15:30 ` [Intel-gfx] " Maxime Ripard
2023-07-13 15:30 ` Maxime Ripard
2023-07-13 15:30 ` Maxime Ripard
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-14 7:38 ` [Nouveau] " Thomas Zimmermann
2023-07-14 7:38 ` [Intel-gfx] " Thomas Zimmermann
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-14 7:38 ` Thomas Zimmermann
2023-07-13 15:39 ` Uwe Kleine-König
2023-07-13 15:39 ` [Nouveau] " Uwe Kleine-König
2023-07-13 15:39 ` [Intel-gfx] " Uwe Kleine-König
2023-07-13 15:39 ` Uwe Kleine-König
2023-07-13 15:39 ` Uwe Kleine-König
2023-07-13 17:06 ` Thierry Reding [this message]
2023-07-13 7:18 ` Thierry Reding
2023-07-13 7:54 ` Thomas Zimmermann
2023-07-13 7:54 ` [Nouveau] " Thomas Zimmermann
2023-07-13 7:54 ` Thomas Zimmermann
2023-07-13 7:54 ` Thomas Zimmermann
2023-07-13 7:54 ` [Intel-gfx] " Thomas Zimmermann
2023-07-13 7:54 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLAu5fy7bCUJjvMs@orome \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.