Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sean Paul <seanpaul@chromium.org>
Cc: "Jani Nikula" <jani.nikula@intel.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Xinliang Liu" <xinliang.liu@linaro.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Tomi Valkeinen" <tomi.valkeinen+renesas@ideasonboard.com>,
	"Alexey Kodanev" <aleksei.kodanev@bell-sw.com>,
	dri-devel@lists.freedesktop.org,
	"Vandita Kulkarni" <vandita.kulkarni@intel.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Anitha Chrisanthus" <anitha.chrisanthus@intel.com>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Arun R Murthy" <arun.r.murthy@intel.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Liu Shixin" <liushixin2@huawei.com>,
	linux-samsung-soc@vger.kernel.org,
	"Samuel Holland" <samuel@sholland.org>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Wenjing Liu" <wenjing.liu@amd.com>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Stanislav Lisovskiy" <stanislav.lisovskiy@intel.com>,
	"Danilo Krummrich" <dakr@redhat.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	spice-devel@lists.freedesktop.org,
	"Niranjana Vishwanathapura" <niranjana.vishwanathapura@intel.com>,
	linux-sunxi@lists.linux.dev, "Stylon Wang" <stylon.wang@amd.com>,
	"Tim Huang" <Tim.Huang@amd.com>,
	"Suraj Kandpal" <suraj.kandpal@intel.com>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Andi Shyti" <andi.shyti@linux.intel.com>,
	"Yifan Zhang" <yifan1.zhang@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Inki Dae" <inki.dae@samsung.com>,
	"Hersen Wu" <hersenxs.wu@amd.com>,
	"Jessica Zhang" <quic_jesszhan@quicinc.com>,
	"Kamlesh Gurudasani" <kamlesh.gurudasani@gmail.com>,
	"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
	"Łukasz Bartosik" <lb@semihalf.com>,
	"Radhakrishna Sripada" <radhakrishna.sripada@intel.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	kernel@pengutronix.de, "Alex Deucher" <alexander.deucher@amd.com>,
	freedreno@lists.freedesktop.org,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Zack Rusin" <zackr@vmware.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
	"Mitul Golani" <mitulkumar.ajitkumar.golani@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	virtualization@lists.linux-foundation.org,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Yongqin Liu" <yongqin.liu@linaro.org>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Fei Yang" <fei.yang@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"David Lechner" <david@lechnology.com>,
	"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
	"David Francis" <David.Francis@amd.com>,
	"Aaron Liu" <aaron.liu@amd.com>,
	"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
	"Vinod Polimera" <quic_vpolimer@quicinc.com>,
	linux-rockchip@lists.infradead.org,
	"Fangzhi Zuo" <jerry.zuo@amd.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"VMware Graphics Reviewers"
	<linux-graphics-maintainer@vmware.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Jouni Högander" <jouni.hogander@intel.com>,
	"Dave Airlie" <airlied@redhat.com>,
	linux-mips@vger.kernel.org,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	linux-arm-msm@vger.kernel.org,
	"Animesh Manna" <animesh.manna@intel.com>,
	linux-renesas-soc@vger.kernel.org,
	"Maxime Ripard" <mripard@kernel.org>,
	"Chaitanya Kumar Borah" <chaitanya.kumar.borah@intel.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	linux-amlogic@lists.infradead.org,
	"Evan Quan" <evan.quan@amd.com>,
	"Michal Simek" <michal.simek@amd.com>,
	linux-arm-kernel@lists.infradead.org,
	"Sean Paul" <sean@poorly.run>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Swati Sharma" <swati2.sharma@intel.com>,
	"John Stultz" <jstultz@google.com>,
	"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Drew Davenport" <ddavenport@chromium.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Hawking Zhang" <Hawking.Zhang@amd.com>,
	"Haneen Mohammed" <hamohammed.sa@gmail.com>,
	"Anusha Srivatsa" <anusha.srivatsa@intel.com>,
	"Dan Carpenter" <error27@gmail.com>,
	"Karol Herbst" <kherbst@redhat.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	linux-hyperv@vger.kernel.org, "Stefan Agner" <stefan@agner.ch>,
	"Melissa Wen" <melissa.srw@gmail.com>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"Luca Coelho" <luciano.coelho@intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Likun Gao" <Likun.Gao@amd.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Alain Volmat" <alain.volmat@foss.st.com>,
	"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Deepak Rawat" <drawat.floss@gmail.com>,
	"Chen-Yu Tsai" <wens@csie.org>, "Joel Stanley" <joel@jms.id.au>,
	"Ankit Nautiyal" <ankit.k.nautiyal@intel.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Alan Liu" <haoping.liu@amd.com>,
	"Philip Yang" <Philip.Yang@amd.com>,
	"Lyude Paul" <lyude@redhat.com>,
	intel-gfx@lists.freedesktop.org,
	"Alison Wang" <alison.wang@nxp.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Gustavo Sousa" <gustavo.sousa@intel.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
	"Tomi Valkeinen" <tomba@kernel.org>,
	"Deepak R Varma" <drv@mailo.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Chia-I Wu" <olvaffe@gmail.com>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Tian Tao" <tiantao6@hisilicon.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Khaled Almahallawy" <khaled.almahallawy@intel.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Emma Anholt" <emma@anholt.net>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Imre Deak" <imre.deak@intel.com>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Roman Li" <roman.li@amd.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Rob Clark" <robdclark@gmail.com>,
	"Hamza Mahfooz" <hamza.mahfooz@amd.com>,
	"David Airlie" <airlied@gmail.com>, "Marek Vasut" <marex@denx.de>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	xen-devel@lists.xenproject.org,
	"Guchun Chen" <guchun.chen@amd.com>,
	"Oleksandr Andrushchenko" <oleksandr_andrushchenko@epam.com>,
	"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Uma Shankar" <uma.shankar@intel.com>,
	"Mika Kahola" <mika.kahola@intel.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Jiasheng Jiang" <jiasheng@iscas.ac.cn>,
	"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Vinod Govindapillai" <vinod.govindapillai@intel.com>,
	linux-tegra@vger.kernel.org, "Marek Olšák" <marek.olsak@amd.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Joaquín Ignacio Aramendía" <samsagax@gmail.com>,
	"Melissa Wen" <mwen@igalia.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	linux-mediatek@lists.infradead.org,
	"Fabio Estevam" <festevam@gmail.com>,
	"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"David Tadokoro" <davidbtadokoro@usp.br>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	amd-gfx@lists.freedesktop.org, "Jyri Sarha" <jyri.sarha@iki.fi>,
	"Yannick Fertre" <yannick.fertre@foss.st.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Philippe Cornu" <philippe.cornu@foss.st.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Wayne Lin" <Wayne.Lin@amd.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Nirmoy Das" <nirmoy.das@intel.com>, "Lang Yu" <Lang.Yu@amd.com>,
	"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev
Date: Thu, 13 Jul 2023 15:03:37 +0200	[thread overview]
Message-ID: <20230713130337.fd2l67r23g2irifx@pengutronix.de> (raw)
In-Reply-To: <CAOw6vbLO_UaXDbTCtAQJgthXOUMPqEV+c2MQhP-1DuK44OhGxw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

hello Sean,

On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote:
> I'd really prefer this patch (series or single) is not accepted. This
> will cause problems for everyone cherry-picking patches to a
> downstream kernel (LTS or distro tree). I usually wouldn't expect
> sympathy here, but the questionable benefit does not outweigh the cost
> IM[biased]O.

I agree that for backports this isn't so nice. However with the split
approach (that was argumented against here) it's not soo bad. Patch #1
(and similar changes for the other affected structures) could be
trivially backported and with that it doesn't matter if you write dev or
drm (or whatever name is chosen in the end); both work in the same way.

But even with the one-patch-per-rename approach I'd consider the
renaming a net win, because ease of understanding code has a big value.
It's value is not so easy measurable as "conflicts when backporting",
but it also matters in say two years from now, while backporting
shouldn't be an issue then any more.

Thanks for your input, best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]