All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Sergei Shtylyov' <sergei.shtylyov@cogentembedded.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"wg@grandegger.com" <wg@grandegger.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Pavel Kiryukhin <vksavl@gmail.com>
Subject: RE: [PATCH v5] can: add Renesas R-Car CAN driver
Date: Fri, 28 Feb 2014 12:17:16 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6CDC95@AcuExch.aculab.com> (raw)
In-Reply-To: <53107B7B.8040800@cogentembedded.com>

RnJvbTogU2VyZ2VpIFNodHlseW92DQo+ICAgICBUaGlzIGlzIG5vdCBhIDMyLWJpdCByZWdpc3Rl
ciBidXQgMjQtIGFuZCA4LWJpdCBvbmUuIEknbSBhZnJhaWQgd2Ugd29uJ3QNCj4gYmUgYWJsZSB0
byB0ZXN0IG9uIEJFIHNvb24gYXMgdGhlIG1hY2hpbmUgd2UncmUgZGVidWdnaW5nIG9uIGlzIExF
IG9ubHkuDQo+IEFueXdheSwgZm9yIHRoZSBiaWctZW5kaWFuIGNvbmZpZ3VyZWQgU3VwZXJoeXdh
eSBidXMgdGhlIGJpZy1lbmRpYW4gSFBCIGJ1cw0KPiB0aGUgQ0FOIGNvbnRyb2xsZXIgcmVzaWRl
cyBvbiBzaG91bGRuJ3Qgc3dhcCBieXRlcy4NCg0KRXhjZXB0IHRoYXQgeW91IGFyZW4ndCBnb2lu
ZyB0byBnZXQgYW55IGNwdSBJIGtub3cgYWJvdXQgdG8gZG8gYSBidXMNCmFjY2VzcyB3aXRoIG9u
bHkgdGhyZWUgb2YgdGhlIGZvdXIgYnl0ZSBlbmFibGVzIGFzc2VydGVkIChleGNlcHQgYXMgcGFy
dA0Kb2YgYSBtaXNhbGlnbmVkIDMyIGJpdCB0cmFuc2ZlcikuDQoNClNvIHlvdSBlaXRoZXIgaGF2
ZSBmb3VyIDgtYml0IHJlZ2lzdGVycywgb3Igb25lIDMyLWJpdCBvbmUuDQoNCkknZCBzdWdnZXN0
IGtlZXBpbmcgYm90aCBwYXJ0cyBpbiB0aGUgZHJpdmVyIGRhdGEgYXJlYSBhbmQgb3JpbmcNCnRo
ZW0gdG9nZXRoZXIgYmVmb3JlIHdyaXRpbmcgdG8gdGhlIGRldmljZS4NCg0KCURhdmlkDQoNCg=

WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Sergei Shtylyov' <sergei.shtylyov@cogentembedded.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"wg@grandegger.com" <wg@grandegger.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Pavel Kiryukhin <vksavl@gmail.com>
Subject: RE: [PATCH v5] can: add Renesas R-Car CAN driver
Date: Fri, 28 Feb 2014 12:17:16 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6CDC95@AcuExch.aculab.com> (raw)
In-Reply-To: <53107B7B.8040800@cogentembedded.com>

From: Sergei Shtylyov
>     This is not a 32-bit register but 24- and 8-bit one. I'm afraid we won't
> be able to test on BE soon as the machine we're debugging on is LE only.
> Anyway, for the big-endian configured Superhyway bus the big-endian HPB bus
> the CAN controller resides on shouldn't swap bytes.

Except that you aren't going to get any cpu I know about to do a bus
access with only three of the four byte enables asserted (except as part
of a misaligned 32 bit transfer).

So you either have four 8-bit registers, or one 32-bit one.

I'd suggest keeping both parts in the driver data area and oring
them together before writing to the device.

	David


  reply	other threads:[~2014-02-28 12:17 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-26 20:37 [PATCH v5] can: add Renesas R-Car CAN driver Sergei Shtylyov
2013-12-26 21:37 ` Sergei Shtylyov
2014-01-13 13:46 ` Sergei Shtylyov
2014-01-13 13:46   ` Sergei Shtylyov
2014-01-20  9:18 ` Marc Kleine-Budde
2014-01-20  9:18   ` Marc Kleine-Budde
2014-01-25  0:34   ` Sergei Shtylyov
2014-01-25  1:34     ` Sergei Shtylyov
2014-02-13 12:12     ` Marc Kleine-Budde
2014-02-13 12:12       ` Marc Kleine-Budde
2014-02-20 22:48       ` Sergei Shtylyov
2014-02-20 23:48         ` Sergei Shtylyov
2014-02-28  9:08         ` Marc Kleine-Budde
2014-02-28  9:08           ` Marc Kleine-Budde
2014-02-28 11:16           ` Sergei Shtylyov
2014-02-28 11:16             ` Sergei Shtylyov
2014-02-28 11:37             ` Marc Kleine-Budde
2014-02-28 11:37               ` Marc Kleine-Budde
2014-02-28 11:41               ` Geert Uytterhoeven
2014-02-28 11:41                 ` Geert Uytterhoeven
2014-02-28 11:47                 ` David Laight
2014-02-28 11:47                   ` David Laight
2014-02-28 11:50                   ` Marc Kleine-Budde
2014-02-28 11:50                     ` Marc Kleine-Budde
2014-02-28 12:02                     ` David Laight
2014-02-28 12:02                       ` David Laight
2014-02-28 11:49                 ` Marc Kleine-Budde
2014-02-28 11:49                   ` Marc Kleine-Budde
2014-02-28 12:05                   ` Sergei Shtylyov
2014-02-28 12:05                     ` Sergei Shtylyov
2014-02-28 12:17                     ` David Laight [this message]
2014-02-28 12:17                       ` David Laight
2014-02-28 12:34                       ` Sergei Shtylyov
2014-02-28 12:34                         ` Sergei Shtylyov
2014-01-20 11:43 ` Geert Uytterhoeven
2014-01-20 11:43   ` Geert Uytterhoeven
2014-01-20 11:47   ` Marc Kleine-Budde
2014-01-20 11:47     ` Marc Kleine-Budde
2014-01-20 11:52     ` Geert Uytterhoeven
2014-01-20 11:52       ` Geert Uytterhoeven
2014-01-20 11:58       ` Marc Kleine-Budde
2014-01-20 11:58         ` Marc Kleine-Budde
2014-01-20 12:02         ` Ben Dooks
2014-01-20 12:05           ` Geert Uytterhoeven
2014-01-20 12:05             ` Geert Uytterhoeven
2014-01-20 12:08             ` Marc Kleine-Budde
2014-01-20 12:08               ` Marc Kleine-Budde
2014-01-20 12:05           ` Marc Kleine-Budde
2014-01-20 12:05             ` Marc Kleine-Budde
2014-01-20 12:13           ` David Laight
2014-01-20 12:13             ` David Laight
2014-01-20 12:35             ` Marc Kleine-Budde
2014-01-20 12:35               ` Marc Kleine-Budde
2014-01-20 19:16         ` David Miller
2014-01-20 19:16           ` David Miller
2014-01-20 21:12           ` Sergei Shtylyov
2014-01-20 22:12             ` Sergei Shtylyov
2014-01-20 21:17             ` Marc Kleine-Budde
2014-01-20 21:17               ` Marc Kleine-Budde
2014-01-22 11:52               ` Ben Dooks
2014-01-22 11:54                 ` Geert Uytterhoeven
2014-01-22 11:54                   ` Geert Uytterhoeven
2014-01-22 11:58                 ` David Laight
2014-01-22 11:58                   ` David Laight
2014-01-20 12:12   ` Sergei Shtylyov
2014-01-20 12:12     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063D6719AE5E284EB5DD2968C1650D6D0F6CDC95@AcuExch.aculab.com \
    --to=david.laight@aculab.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=vksavl@gmail.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.