From: Robin Murphy <robin.murphy@arm.com> To: John Garry <john.garry@huawei.com>, Lu Baolu <baolu.lu@linux.intel.com>, joro@8bytes.org, will@kernel.org, dwmw2@infradead.org Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linuxarm@huawei.com, thunder.leizhen@huawei.com, chenxiang66@hisilicon.com Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options Date: Mon, 14 Jun 2021 15:11:46 +0100 [thread overview] Message-ID: <0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com> (raw) In-Reply-To: <6055cd0d-a1d3-a73a-6831-3837021f3c9c@huawei.com> On 2021-06-14 08:53, John Garry wrote: > On 12/06/2021 03:22, Lu Baolu wrote: >> On 2021/6/11 20:20, John Garry wrote: >>> @@ -453,8 +452,7 @@ static int __init intel_iommu_setup(char *str) >>> pr_warn("intel_iommu=forcedac deprecated; use >>> iommu.forcedac instead\n"); >>> iommu_dma_forcedac = true; >>> } else if (!strncmp(str, "strict", 6)) { >>> - pr_info("Disable batched IOTLB flush\n"); >>> - intel_iommu_strict = 1; >>> + iommu_set_dma_strict(true); >> >> I would like to deprecate this command line and ask users to use >> iommu.strict instead. > > ok, but then I should probably make the AMD driver also officially > support this. Oops, I should have documented that "iommu.strict" already applies to x86 as well. The interaction with the driver-specific parameters is a bit weird and unintuitive, but it was done knowingly. Let me quickly spin a kernel-parameters.txt fix for that... Cheers, Robin. >> >> --- a/drivers/iommu/intel/iommu.c >> +++ b/drivers/iommu/intel/iommu.c >> @@ -436,7 +436,7 @@ static int __init intel_iommu_setup(char *str) >> pr_warn("intel_iommu=forcedac deprecated; use >> iommu.forcedac instead\n"); >> iommu_dma_forcedac = true; >> } else if (!strncmp(str, "strict", 6)) { >> - pr_info("Disable batched IOTLB flush\n"); >> + pr_warn("intel_iommu=strict deprecated; use >> iommu.strict instead\n"); >> intel_iommu_strict = 1; >> >> Also update Documentation/admin-guide/kernel-parameters.txt accordingly. > > Thanks, > John
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com> To: John Garry <john.garry@huawei.com>, Lu Baolu <baolu.lu@linux.intel.com>, joro@8bytes.org, will@kernel.org, dwmw2@infradead.org Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options Date: Mon, 14 Jun 2021 15:11:46 +0100 [thread overview] Message-ID: <0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com> (raw) In-Reply-To: <6055cd0d-a1d3-a73a-6831-3837021f3c9c@huawei.com> On 2021-06-14 08:53, John Garry wrote: > On 12/06/2021 03:22, Lu Baolu wrote: >> On 2021/6/11 20:20, John Garry wrote: >>> @@ -453,8 +452,7 @@ static int __init intel_iommu_setup(char *str) >>> pr_warn("intel_iommu=forcedac deprecated; use >>> iommu.forcedac instead\n"); >>> iommu_dma_forcedac = true; >>> } else if (!strncmp(str, "strict", 6)) { >>> - pr_info("Disable batched IOTLB flush\n"); >>> - intel_iommu_strict = 1; >>> + iommu_set_dma_strict(true); >> >> I would like to deprecate this command line and ask users to use >> iommu.strict instead. > > ok, but then I should probably make the AMD driver also officially > support this. Oops, I should have documented that "iommu.strict" already applies to x86 as well. The interaction with the driver-specific parameters is a bit weird and unintuitive, but it was done knowingly. Let me quickly spin a kernel-parameters.txt fix for that... Cheers, Robin. >> >> --- a/drivers/iommu/intel/iommu.c >> +++ b/drivers/iommu/intel/iommu.c >> @@ -436,7 +436,7 @@ static int __init intel_iommu_setup(char *str) >> pr_warn("intel_iommu=forcedac deprecated; use >> iommu.forcedac instead\n"); >> iommu_dma_forcedac = true; >> } else if (!strncmp(str, "strict", 6)) { >> - pr_info("Disable batched IOTLB flush\n"); >> + pr_warn("intel_iommu=strict deprecated; use >> iommu.strict instead\n"); >> intel_iommu_strict = 1; >> >> Also update Documentation/admin-guide/kernel-parameters.txt accordingly. > > Thanks, > John _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-14 14:11 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-11 12:20 [PATCH v12 0/5] Enhance IOMMU default DMA mode build options John Garry 2021-06-11 12:20 ` John Garry 2021-06-11 12:20 ` [PATCH v12 1/5] iommu: Print strict or lazy mode at init time John Garry 2021-06-11 12:20 ` John Garry 2021-06-14 15:54 ` Robin Murphy 2021-06-14 15:54 ` Robin Murphy 2021-06-11 12:20 ` [PATCH v12 2/5] iommu: Enhance IOMMU default DMA mode build options John Garry 2021-06-11 12:20 ` John Garry 2021-06-12 1:21 ` Lu Baolu 2021-06-12 1:21 ` Lu Baolu 2021-06-14 8:11 ` John Garry 2021-06-14 8:11 ` John Garry 2021-06-12 2:12 ` Lu Baolu 2021-06-12 2:12 ` Lu Baolu 2021-06-14 16:03 ` Robin Murphy 2021-06-14 16:03 ` Robin Murphy 2021-06-11 12:20 ` [PATCH v12 3/5] iommu/vt-d: Add support for " John Garry 2021-06-11 12:20 ` John Garry 2021-06-12 2:14 ` Lu Baolu 2021-06-12 2:14 ` Lu Baolu 2021-06-14 8:03 ` John Garry 2021-06-14 8:03 ` John Garry 2021-06-15 7:26 ` Lu Baolu 2021-06-15 7:26 ` Lu Baolu 2021-06-15 8:25 ` Robin Murphy 2021-06-15 8:25 ` Robin Murphy 2021-06-16 8:42 ` Lu Baolu 2021-06-16 8:42 ` Lu Baolu 2021-06-12 2:22 ` Lu Baolu 2021-06-12 2:22 ` Lu Baolu 2021-06-14 7:53 ` John Garry 2021-06-14 7:53 ` John Garry 2021-06-14 14:11 ` Robin Murphy [this message] 2021-06-14 14:11 ` Robin Murphy 2021-06-14 14:19 ` John Garry 2021-06-14 14:19 ` John Garry 2021-06-14 15:05 ` Robin Murphy 2021-06-14 15:05 ` Robin Murphy 2021-06-11 12:20 ` [PATCH v12 4/5] iommu/amd: " John Garry 2021-06-11 12:20 ` John Garry 2021-06-11 12:20 ` [PATCH v12 5/5] iommu: Remove mode argument from iommu_set_dma_strict() John Garry 2021-06-11 12:20 ` John Garry 2021-06-12 2:23 ` Lu Baolu 2021-06-12 2:23 ` Lu Baolu 2021-06-14 7:46 ` John Garry 2021-06-14 7:46 ` John Garry 2021-06-14 16:25 ` Robin Murphy 2021-06-14 16:25 ` Robin Murphy 2021-06-14 17:03 ` John Garry 2021-06-14 17:03 ` John Garry 2021-06-14 17:19 ` Robin Murphy 2021-06-14 17:19 ` Robin Murphy 2021-06-14 17:24 ` John Garry 2021-06-14 17:24 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com \ --to=robin.murphy@arm.com \ --cc=baolu.lu@linux.intel.com \ --cc=chenxiang66@hisilicon.com \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=john.garry@huawei.com \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=thunder.leizhen@huawei.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.