All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, <joro@8bytes.org>,
	<will@kernel.org>, <dwmw2@infradead.org>, <robin.murphy@arm.com>
Cc: <linux-kernel@vger.kernel.org>,
	<iommu@lists.linux-foundation.org>, <linuxarm@huawei.com>,
	<thunder.leizhen@huawei.com>, <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options
Date: Mon, 14 Jun 2021 09:03:43 +0100	[thread overview]
Message-ID: <03675e2f-c3a6-ce33-ef96-f9ae544b2d13@huawei.com> (raw)
In-Reply-To: <f3940a3f-d1c1-148d-e4b5-51cecf924ff5@linux.intel.com>

On 12/06/2021 03:14, Lu Baolu wrote:
> On 2021/6/11 20:20, John Garry wrote:
>> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
>> index 2a71347611d4..4467353f981b 100644
>> --- a/drivers/iommu/Kconfig
>> +++ b/drivers/iommu/Kconfig
>> @@ -94,6 +94,7 @@ choice
>>       prompt "IOMMU default DMA mode"
>>       depends on IOMMU_DMA
>> +    default IOMMU_DEFAULT_LAZY if INTEL_IOMMU
>>       default IOMMU_DEFAULT_STRICT
> 
> If two default values are different. Which one will be overridden?

If I understand your question correctly, I think you are asking if both 
are set:
CONFIG_IOMMU_DEFAULT_LAZY=y
CONFIG_IOMMU_DEFAULT_STRICT=y

If this happens, then make defconfig complains about both being set, and 
selects the 2nd, whatever that is.

If neither are set, then IOMMU_DEFAULT_LAZY is set if INTEL_IOMMU is 
set, otherwise IOMMU_DEFAULT_STRICT.

Thanks,
John

WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, <joro@8bytes.org>,
	<will@kernel.org>,  <dwmw2@infradead.org>, <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com
Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options
Date: Mon, 14 Jun 2021 09:03:43 +0100	[thread overview]
Message-ID: <03675e2f-c3a6-ce33-ef96-f9ae544b2d13@huawei.com> (raw)
In-Reply-To: <f3940a3f-d1c1-148d-e4b5-51cecf924ff5@linux.intel.com>

On 12/06/2021 03:14, Lu Baolu wrote:
> On 2021/6/11 20:20, John Garry wrote:
>> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
>> index 2a71347611d4..4467353f981b 100644
>> --- a/drivers/iommu/Kconfig
>> +++ b/drivers/iommu/Kconfig
>> @@ -94,6 +94,7 @@ choice
>>       prompt "IOMMU default DMA mode"
>>       depends on IOMMU_DMA
>> +    default IOMMU_DEFAULT_LAZY if INTEL_IOMMU
>>       default IOMMU_DEFAULT_STRICT
> 
> If two default values are different. Which one will be overridden?

If I understand your question correctly, I think you are asking if both 
are set:
CONFIG_IOMMU_DEFAULT_LAZY=y
CONFIG_IOMMU_DEFAULT_STRICT=y

If this happens, then make defconfig complains about both being set, and 
selects the 2nd, whatever that is.

If neither are set, then IOMMU_DEFAULT_LAZY is set if INTEL_IOMMU is 
set, otherwise IOMMU_DEFAULT_STRICT.

Thanks,
John
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-06-14  8:09 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 12:20 [PATCH v12 0/5] Enhance IOMMU default DMA mode build options John Garry
2021-06-11 12:20 ` John Garry
2021-06-11 12:20 ` [PATCH v12 1/5] iommu: Print strict or lazy mode at init time John Garry
2021-06-11 12:20   ` John Garry
2021-06-14 15:54   ` Robin Murphy
2021-06-14 15:54     ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 2/5] iommu: Enhance IOMMU default DMA mode build options John Garry
2021-06-11 12:20   ` John Garry
2021-06-12  1:21   ` Lu Baolu
2021-06-12  1:21     ` Lu Baolu
2021-06-14  8:11     ` John Garry
2021-06-14  8:11       ` John Garry
2021-06-12  2:12   ` Lu Baolu
2021-06-12  2:12     ` Lu Baolu
2021-06-14 16:03   ` Robin Murphy
2021-06-14 16:03     ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 3/5] iommu/vt-d: Add support for " John Garry
2021-06-11 12:20   ` John Garry
2021-06-12  2:14   ` Lu Baolu
2021-06-12  2:14     ` Lu Baolu
2021-06-14  8:03     ` John Garry [this message]
2021-06-14  8:03       ` John Garry
2021-06-15  7:26       ` Lu Baolu
2021-06-15  7:26         ` Lu Baolu
2021-06-15  8:25         ` Robin Murphy
2021-06-15  8:25           ` Robin Murphy
2021-06-16  8:42           ` Lu Baolu
2021-06-16  8:42             ` Lu Baolu
2021-06-12  2:22   ` Lu Baolu
2021-06-12  2:22     ` Lu Baolu
2021-06-14  7:53     ` John Garry
2021-06-14  7:53       ` John Garry
2021-06-14 14:11       ` Robin Murphy
2021-06-14 14:11         ` Robin Murphy
2021-06-14 14:19         ` John Garry
2021-06-14 14:19           ` John Garry
2021-06-14 15:05           ` Robin Murphy
2021-06-14 15:05             ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 4/5] iommu/amd: " John Garry
2021-06-11 12:20   ` John Garry
2021-06-11 12:20 ` [PATCH v12 5/5] iommu: Remove mode argument from iommu_set_dma_strict() John Garry
2021-06-11 12:20   ` John Garry
2021-06-12  2:23   ` Lu Baolu
2021-06-12  2:23     ` Lu Baolu
2021-06-14  7:46     ` John Garry
2021-06-14  7:46       ` John Garry
2021-06-14 16:25   ` Robin Murphy
2021-06-14 16:25     ` Robin Murphy
2021-06-14 17:03     ` John Garry
2021-06-14 17:03       ` John Garry
2021-06-14 17:19       ` Robin Murphy
2021-06-14 17:19         ` Robin Murphy
2021-06-14 17:24         ` John Garry
2021-06-14 17:24           ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03675e2f-c3a6-ce33-ef96-f9ae544b2d13@huawei.com \
    --to=john.garry@huawei.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=robin.murphy@arm.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.