All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: John Garry <john.garry@huawei.com>,
	joro@8bytes.org, will@kernel.org, dwmw2@infradead.org,
	baolu.lu@linux.intel.com
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linuxarm@huawei.com, thunder.leizhen@huawei.com,
	chenxiang66@hisilicon.com
Subject: Re: [PATCH v12 1/5] iommu: Print strict or lazy mode at init time
Date: Mon, 14 Jun 2021 16:54:35 +0100	[thread overview]
Message-ID: <5d98ab53-2ff0-fcbb-3177-bb04a9d2b554@arm.com> (raw)
In-Reply-To: <1623414043-40745-2-git-send-email-john.garry@huawei.com>

On 2021-06-11 13:20, John Garry wrote:
> As well as the default domain type, it's useful to know whether strict
> or lazy for DMA domains, so add this info in a separate print.
> 
> The (stict/lazy) mode may be also set via iommu.strict earlyparm, but
> this will be processed prior to iommu_subsys_init(), so that print will be
> accurate for drivers which don't set the mode via custom means.
> 
> For the drivers which do set the mode via custom means - the AMD and Intel
> drivers - they still maintain prints to notify the change in policy.

Note that you then start removing said prints later in the series, but 
if we repurpose then as deprecation warnings instead as Baolu suggests 
then I reckon it all works out OK. Assuming that,

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>   drivers/iommu/iommu.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 5419c4b9f27a..cf58949cc2f3 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -138,6 +138,11 @@ static int __init iommu_subsys_init(void)
>   		(iommu_cmd_line & IOMMU_CMD_LINE_DMA_API) ?
>   			"(set via kernel command line)" : "");
>   
> +	pr_info("DMA domain TLB invalidation policy: %s mode %s\n",
> +		iommu_dma_strict ? "strict" : "lazy",
> +		(iommu_cmd_line & IOMMU_CMD_LINE_STRICT) ?
> +			"(set via kernel command line)" : "");
> +
>   	return 0;
>   }
>   subsys_initcall(iommu_subsys_init);
> 

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: John Garry <john.garry@huawei.com>,
	joro@8bytes.org, will@kernel.org, dwmw2@infradead.org,
	baolu.lu@linux.intel.com
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com
Subject: Re: [PATCH v12 1/5] iommu: Print strict or lazy mode at init time
Date: Mon, 14 Jun 2021 16:54:35 +0100	[thread overview]
Message-ID: <5d98ab53-2ff0-fcbb-3177-bb04a9d2b554@arm.com> (raw)
In-Reply-To: <1623414043-40745-2-git-send-email-john.garry@huawei.com>

On 2021-06-11 13:20, John Garry wrote:
> As well as the default domain type, it's useful to know whether strict
> or lazy for DMA domains, so add this info in a separate print.
> 
> The (stict/lazy) mode may be also set via iommu.strict earlyparm, but
> this will be processed prior to iommu_subsys_init(), so that print will be
> accurate for drivers which don't set the mode via custom means.
> 
> For the drivers which do set the mode via custom means - the AMD and Intel
> drivers - they still maintain prints to notify the change in policy.

Note that you then start removing said prints later in the series, but 
if we repurpose then as deprecation warnings instead as Baolu suggests 
then I reckon it all works out OK. Assuming that,

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>   drivers/iommu/iommu.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 5419c4b9f27a..cf58949cc2f3 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -138,6 +138,11 @@ static int __init iommu_subsys_init(void)
>   		(iommu_cmd_line & IOMMU_CMD_LINE_DMA_API) ?
>   			"(set via kernel command line)" : "");
>   
> +	pr_info("DMA domain TLB invalidation policy: %s mode %s\n",
> +		iommu_dma_strict ? "strict" : "lazy",
> +		(iommu_cmd_line & IOMMU_CMD_LINE_STRICT) ?
> +			"(set via kernel command line)" : "");
> +
>   	return 0;
>   }
>   subsys_initcall(iommu_subsys_init);
> 
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-06-14 15:54 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 12:20 [PATCH v12 0/5] Enhance IOMMU default DMA mode build options John Garry
2021-06-11 12:20 ` John Garry
2021-06-11 12:20 ` [PATCH v12 1/5] iommu: Print strict or lazy mode at init time John Garry
2021-06-11 12:20   ` John Garry
2021-06-14 15:54   ` Robin Murphy [this message]
2021-06-14 15:54     ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 2/5] iommu: Enhance IOMMU default DMA mode build options John Garry
2021-06-11 12:20   ` John Garry
2021-06-12  1:21   ` Lu Baolu
2021-06-12  1:21     ` Lu Baolu
2021-06-14  8:11     ` John Garry
2021-06-14  8:11       ` John Garry
2021-06-12  2:12   ` Lu Baolu
2021-06-12  2:12     ` Lu Baolu
2021-06-14 16:03   ` Robin Murphy
2021-06-14 16:03     ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 3/5] iommu/vt-d: Add support for " John Garry
2021-06-11 12:20   ` John Garry
2021-06-12  2:14   ` Lu Baolu
2021-06-12  2:14     ` Lu Baolu
2021-06-14  8:03     ` John Garry
2021-06-14  8:03       ` John Garry
2021-06-15  7:26       ` Lu Baolu
2021-06-15  7:26         ` Lu Baolu
2021-06-15  8:25         ` Robin Murphy
2021-06-15  8:25           ` Robin Murphy
2021-06-16  8:42           ` Lu Baolu
2021-06-16  8:42             ` Lu Baolu
2021-06-12  2:22   ` Lu Baolu
2021-06-12  2:22     ` Lu Baolu
2021-06-14  7:53     ` John Garry
2021-06-14  7:53       ` John Garry
2021-06-14 14:11       ` Robin Murphy
2021-06-14 14:11         ` Robin Murphy
2021-06-14 14:19         ` John Garry
2021-06-14 14:19           ` John Garry
2021-06-14 15:05           ` Robin Murphy
2021-06-14 15:05             ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 4/5] iommu/amd: " John Garry
2021-06-11 12:20   ` John Garry
2021-06-11 12:20 ` [PATCH v12 5/5] iommu: Remove mode argument from iommu_set_dma_strict() John Garry
2021-06-11 12:20   ` John Garry
2021-06-12  2:23   ` Lu Baolu
2021-06-12  2:23     ` Lu Baolu
2021-06-14  7:46     ` John Garry
2021-06-14  7:46       ` John Garry
2021-06-14 16:25   ` Robin Murphy
2021-06-14 16:25     ` Robin Murphy
2021-06-14 17:03     ` John Garry
2021-06-14 17:03       ` John Garry
2021-06-14 17:19       ` Robin Murphy
2021-06-14 17:19         ` Robin Murphy
2021-06-14 17:24         ` John Garry
2021-06-14 17:24           ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d98ab53-2ff0-fcbb-3177-bb04a9d2b554@arm.com \
    --to=robin.murphy@arm.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=john.garry@huawei.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.