All of lore.kernel.org
 help / color / mirror / Atom feed
From: Faiz Abbas <faiz_abbas@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-clk@vger.kernel.org>, <robh+dt@kernel.org>,
	<bcousson@baylibre.com>, <paul@pwsan.com>, <t-kristo@ti.com>
Subject: Re: [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x
Date: Thu, 31 May 2018 15:46:18 +0530	[thread overview]
Message-ID: <0b627ab6-59f1-4a4f-42d2-5d6846adfe0b@ti.com> (raw)
In-Reply-To: <20180530145726.GD5705@atomide.com>

Hi,

On Wednesday 30 May 2018 08:27 PM, Tony Lindgren wrote:
> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]:
>> The dra76x MCAN generic interconnect module has a its own
>> format for the bits in the control registers.
...
>>  static int sysc_init_pdata(struct sysc *ddata)
>>  {
>>  	struct ti_sysc_platform_data *pdata = dev_get_platdata(ddata->dev);
>> @@ -1441,6 +1457,7 @@ static const struct of_device_id sysc_match[] = {
>>  	{ .compatible = "ti,sysc-mcasp", .data = &sysc_omap4_mcasp, },
>>  	{ .compatible = "ti,sysc-usb-host-fs",
>>  	  .data = &sysc_omap4_usb_host_fs, },
>> +	{ .compatible = "ti,sysc-dra7-mcan", .data = &sysc_dra7_mcan, },
>>  	{  },
>>  };
> 
> Looks good to me. And presumably you checked that no other dra7 modules
> use sysconfig register bit layout like this?
> 

As far as I could see, Yes.

Thanks,
Faiz

WARNING: multiple messages have this Message-ID (diff)
From: Faiz Abbas <faiz_abbas@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, paul@pwsan.com,
	linux-kernel@vger.kernel.org, t-kristo@ti.com,
	robh+dt@kernel.org, bcousson@baylibre.com,
	linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x
Date: Thu, 31 May 2018 15:46:18 +0530	[thread overview]
Message-ID: <0b627ab6-59f1-4a4f-42d2-5d6846adfe0b@ti.com> (raw)
In-Reply-To: <20180530145726.GD5705@atomide.com>

Hi,

On Wednesday 30 May 2018 08:27 PM, Tony Lindgren wrote:
> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]:
>> The dra76x MCAN generic interconnect module has a its own
>> format for the bits in the control registers.
...
>>  static int sysc_init_pdata(struct sysc *ddata)
>>  {
>>  	struct ti_sysc_platform_data *pdata = dev_get_platdata(ddata->dev);
>> @@ -1441,6 +1457,7 @@ static const struct of_device_id sysc_match[] = {
>>  	{ .compatible = "ti,sysc-mcasp", .data = &sysc_omap4_mcasp, },
>>  	{ .compatible = "ti,sysc-usb-host-fs",
>>  	  .data = &sysc_omap4_usb_host_fs, },
>> +	{ .compatible = "ti,sysc-dra7-mcan", .data = &sysc_dra7_mcan, },
>>  	{  },
>>  };
> 
> Looks good to me. And presumably you checked that no other dra7 modules
> use sysconfig register bit layout like this?
> 

As far as I could see, Yes.

Thanks,
Faiz

WARNING: multiple messages have this Message-ID (diff)
From: faiz_abbas@ti.com (Faiz Abbas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x
Date: Thu, 31 May 2018 15:46:18 +0530	[thread overview]
Message-ID: <0b627ab6-59f1-4a4f-42d2-5d6846adfe0b@ti.com> (raw)
In-Reply-To: <20180530145726.GD5705@atomide.com>

Hi,

On Wednesday 30 May 2018 08:27 PM, Tony Lindgren wrote:
> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]:
>> The dra76x MCAN generic interconnect module has a its own
>> format for the bits in the control registers.
...
>>  static int sysc_init_pdata(struct sysc *ddata)
>>  {
>>  	struct ti_sysc_platform_data *pdata = dev_get_platdata(ddata->dev);
>> @@ -1441,6 +1457,7 @@ static const struct of_device_id sysc_match[] = {
>>  	{ .compatible = "ti,sysc-mcasp", .data = &sysc_omap4_mcasp, },
>>  	{ .compatible = "ti,sysc-usb-host-fs",
>>  	  .data = &sysc_omap4_usb_host_fs, },
>> +	{ .compatible = "ti,sysc-dra7-mcan", .data = &sysc_dra7_mcan, },
>>  	{  },
>>  };
> 
> Looks good to me. And presumably you checked that no other dra7 modules
> use sysconfig register bit layout like this?
> 

As far as I could see, Yes.

Thanks,
Faiz

  reply	other threads:[~2018-05-31 10:15 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 14:11 [PATCH v2 0/6] Add MCAN Support for dra76x Faiz Abbas
2018-05-30 14:11 ` Faiz Abbas
2018-05-30 14:11 ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:50   ` Tony Lindgren
2018-05-30 14:50     ` Tony Lindgren
2018-05-30 15:15     ` Tero Kristo
2018-05-30 15:15       ` Tero Kristo
2018-05-30 15:15       ` Tero Kristo
2018-05-30 15:28       ` Tony Lindgren
2018-05-30 15:28         ` Tony Lindgren
2018-05-30 15:41         ` Tero Kristo
2018-05-30 15:41           ` Tero Kristo
2018-05-30 15:41           ` Tero Kristo
2018-05-30 15:54           ` Tony Lindgren
2018-05-30 15:54             ` Tony Lindgren
2018-05-31  6:15             ` Tero Kristo
2018-05-31  6:15               ` Tero Kristo
2018-05-31  6:15               ` Tero Kristo
2018-05-31 15:26               ` Tony Lindgren
2018-05-31 15:26                 ` Tony Lindgren
2018-05-31 16:35                 ` Faiz Abbas
2018-05-31 16:35                   ` Faiz Abbas
2018-05-31 16:35                   ` Faiz Abbas
2018-05-31 16:39                   ` Tony Lindgren
2018-05-31 16:39                     ` Tony Lindgren
2018-05-30 14:11 ` [PATCH v2 2/6] ARM: dts: dra762: Add MCAN clock support Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-31  4:03   ` Rob Herring
2018-05-31  4:03     ` Rob Herring
2018-05-31 10:14     ` Faiz Abbas
2018-05-31 10:14       ` Faiz Abbas
2018-05-31 10:14       ` Faiz Abbas
2018-05-31 13:29       ` Tero Kristo
2018-05-31 13:29         ` Tero Kristo
2018-05-31 13:29         ` Tero Kristo
2018-06-01  6:48         ` Faiz Abbas
2018-06-01  6:48           ` Faiz Abbas
2018-06-01  6:48           ` Faiz Abbas
2018-06-01 14:26           ` Tony Lindgren
2018-06-01 14:26             ` Tony Lindgren
2018-06-04 13:58             ` Faiz Abbas
2018-06-04 13:58               ` Faiz Abbas
2018-06-04 13:58               ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:57   ` Tony Lindgren
2018-05-30 14:57     ` Tony Lindgren
2018-05-31 10:16     ` Faiz Abbas [this message]
2018-05-31 10:16       ` Faiz Abbas
2018-05-31 10:16       ` Faiz Abbas
2018-05-31 13:50       ` Tony Lindgren
2018-05-31 13:50         ` Tony Lindgren
2018-05-31  4:08   ` Rob Herring
2018-05-31  4:08     ` Rob Herring
2018-05-30 14:11 ` [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 15:04   ` Tony Lindgren
2018-05-30 15:04     ` Tony Lindgren
2018-05-31 10:21     ` Faiz Abbas
2018-05-31 10:21       ` Faiz Abbas
2018-05-31 10:21       ` Faiz Abbas
2018-05-31 13:45       ` Tony Lindgren
2018-05-31 13:45         ` Tony Lindgren
2018-05-31 16:38         ` Faiz Abbas
2018-05-31 16:38           ` Faiz Abbas
2018-05-31 16:38           ` Faiz Abbas
2018-05-31  4:06   ` Rob Herring
2018-05-31  4:06     ` Rob Herring
2018-05-31 11:26     ` Faiz Abbas
2018-05-31 11:26       ` Faiz Abbas
2018-05-31 11:26       ` Faiz Abbas
2018-05-31 13:41       ` Tony Lindgren
2018-05-31 13:41         ` Tony Lindgren
2018-06-02  6:32   ` Stephen Boyd
2018-06-02  6:32     ` Stephen Boyd
2018-06-02  6:32     ` Stephen Boyd
2018-06-02  6:32     ` Stephen Boyd
2018-06-04  5:49     ` Faiz Abbas
2018-06-04  5:49       ` Faiz Abbas
2018-06-04  5:49       ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 14:11   ` Faiz Abbas
2018-05-30 15:07   ` Tony Lindgren
2018-05-30 15:07     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b627ab6-59f1-4a4f-42d2-5d6846adfe0b@ti.com \
    --to=faiz_abbas@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.