From: Tony Lindgren <tony@atomide.com> To: Faiz Abbas <faiz_abbas@ti.com> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, paul@pwsan.com, t-kristo@ti.com Subject: Re: [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Date: Wed, 30 May 2018 08:07:57 -0700 [thread overview] Message-ID: <20180530150757.GF5705@atomide.com> (raw) In-Reply-To: <20180530141133.3711-7-faiz_abbas@ti.com> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]: > From: Franklin S Cooper Jr <fcooper@ti.com> > > Add support for the MCAN peripheral which supports both classic > CAN messages along with the new CAN-FD message. ... > --- a/arch/arm/boot/dts/dra76x.dtsi > +++ b/arch/arm/boot/dts/dra76x.dtsi > @@ -27,6 +27,21 @@ > ti,syss-mask = <1>; > clocks = <&wkupaon_clkctrl DRA7_ADC_CLKCTRL 0>; > clock-names = "fck"; > + > + m_can0: mcan@42c01a00 { > + compatible = "bosch,m_can"; > + reg = <0x1a00 0x4000>, <0x0 0x18FC>; > + reg-names = "m_can", "message_ram"; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "int0", "int1"; > + ti,hwmods = "mcan"; The "ti,hwmods" should be in the parent node now. But you may not even need it, see the reset comment I made for the parent node patch. > + clocks = <&mcan_clk>, <&l3_iclk_div>; > + clock-names = "cclk", "hclk"; > + bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>; > + status = "disabled"; And then you should be able to also leave out status = "disabled" as the hardware is there for sure and we can idle it. Then a board specific dts file can set it to "disabled" if reallly needed. Setting everything manually to "disabled" and then again to "enabled" is the wrong way around, the default is "enabled". Regards, Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Date: Wed, 30 May 2018 08:07:57 -0700 [thread overview] Message-ID: <20180530150757.GF5705@atomide.com> (raw) In-Reply-To: <20180530141133.3711-7-faiz_abbas@ti.com> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]: > From: Franklin S Cooper Jr <fcooper@ti.com> > > Add support for the MCAN peripheral which supports both classic > CAN messages along with the new CAN-FD message. ... > --- a/arch/arm/boot/dts/dra76x.dtsi > +++ b/arch/arm/boot/dts/dra76x.dtsi > @@ -27,6 +27,21 @@ > ti,syss-mask = <1>; > clocks = <&wkupaon_clkctrl DRA7_ADC_CLKCTRL 0>; > clock-names = "fck"; > + > + m_can0: mcan at 42c01a00 { > + compatible = "bosch,m_can"; > + reg = <0x1a00 0x4000>, <0x0 0x18FC>; > + reg-names = "m_can", "message_ram"; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "int0", "int1"; > + ti,hwmods = "mcan"; The "ti,hwmods" should be in the parent node now. But you may not even need it, see the reset comment I made for the parent node patch. > + clocks = <&mcan_clk>, <&l3_iclk_div>; > + clock-names = "cclk", "hclk"; > + bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>; > + status = "disabled"; And then you should be able to also leave out status = "disabled" as the hardware is there for sure and we can idle it. Then a board specific dts file can set it to "disabled" if reallly needed. Setting everything manually to "disabled" and then again to "enabled" is the wrong way around, the default is "enabled". Regards, Tony
next prev parent reply other threads:[~2018-05-30 15:08 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-30 14:11 [PATCH v2 0/6] Add MCAN Support for dra76x Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:50 ` Tony Lindgren 2018-05-30 14:50 ` Tony Lindgren 2018-05-30 15:15 ` Tero Kristo 2018-05-30 15:15 ` Tero Kristo 2018-05-30 15:15 ` Tero Kristo 2018-05-30 15:28 ` Tony Lindgren 2018-05-30 15:28 ` Tony Lindgren 2018-05-30 15:41 ` Tero Kristo 2018-05-30 15:41 ` Tero Kristo 2018-05-30 15:41 ` Tero Kristo 2018-05-30 15:54 ` Tony Lindgren 2018-05-30 15:54 ` Tony Lindgren 2018-05-31 6:15 ` Tero Kristo 2018-05-31 6:15 ` Tero Kristo 2018-05-31 6:15 ` Tero Kristo 2018-05-31 15:26 ` Tony Lindgren 2018-05-31 15:26 ` Tony Lindgren 2018-05-31 16:35 ` Faiz Abbas 2018-05-31 16:35 ` Faiz Abbas 2018-05-31 16:35 ` Faiz Abbas 2018-05-31 16:39 ` Tony Lindgren 2018-05-31 16:39 ` Tony Lindgren 2018-05-30 14:11 ` [PATCH v2 2/6] ARM: dts: dra762: Add MCAN clock support Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-31 4:03 ` Rob Herring 2018-05-31 4:03 ` Rob Herring 2018-05-31 10:14 ` Faiz Abbas 2018-05-31 10:14 ` Faiz Abbas 2018-05-31 10:14 ` Faiz Abbas 2018-05-31 13:29 ` Tero Kristo 2018-05-31 13:29 ` Tero Kristo 2018-05-31 13:29 ` Tero Kristo 2018-06-01 6:48 ` Faiz Abbas 2018-06-01 6:48 ` Faiz Abbas 2018-06-01 6:48 ` Faiz Abbas 2018-06-01 14:26 ` Tony Lindgren 2018-06-01 14:26 ` Tony Lindgren 2018-06-04 13:58 ` Faiz Abbas 2018-06-04 13:58 ` Faiz Abbas 2018-06-04 13:58 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:57 ` Tony Lindgren 2018-05-30 14:57 ` Tony Lindgren 2018-05-31 10:16 ` Faiz Abbas 2018-05-31 10:16 ` Faiz Abbas 2018-05-31 10:16 ` Faiz Abbas 2018-05-31 13:50 ` Tony Lindgren 2018-05-31 13:50 ` Tony Lindgren 2018-05-31 4:08 ` Rob Herring 2018-05-31 4:08 ` Rob Herring 2018-05-30 14:11 ` [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 15:04 ` Tony Lindgren 2018-05-30 15:04 ` Tony Lindgren 2018-05-31 10:21 ` Faiz Abbas 2018-05-31 10:21 ` Faiz Abbas 2018-05-31 10:21 ` Faiz Abbas 2018-05-31 13:45 ` Tony Lindgren 2018-05-31 13:45 ` Tony Lindgren 2018-05-31 16:38 ` Faiz Abbas 2018-05-31 16:38 ` Faiz Abbas 2018-05-31 16:38 ` Faiz Abbas 2018-05-31 4:06 ` Rob Herring 2018-05-31 4:06 ` Rob Herring 2018-05-31 11:26 ` Faiz Abbas 2018-05-31 11:26 ` Faiz Abbas 2018-05-31 11:26 ` Faiz Abbas 2018-05-31 13:41 ` Tony Lindgren 2018-05-31 13:41 ` Tony Lindgren 2018-06-02 6:32 ` Stephen Boyd 2018-06-02 6:32 ` Stephen Boyd 2018-06-02 6:32 ` Stephen Boyd 2018-06-02 6:32 ` Stephen Boyd 2018-06-04 5:49 ` Faiz Abbas 2018-06-04 5:49 ` Faiz Abbas 2018-06-04 5:49 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 15:07 ` Tony Lindgren [this message] 2018-05-30 15:07 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180530150757.GF5705@atomide.com \ --to=tony@atomide.com \ --cc=bcousson@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=faiz_abbas@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=robh+dt@kernel.org \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.