From: Tony Lindgren <tony@atomide.com> To: Faiz Abbas <faiz_abbas@ti.com> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, paul@pwsan.com, t-kristo@ti.com Subject: Re: [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Date: Wed, 30 May 2018 07:50:47 -0700 [thread overview] Message-ID: <20180530145047.GC5705@atomide.com> (raw) In-Reply-To: <20180530141133.3711-2-faiz_abbas@ti.com> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]: > From: Lokesh Vutla <lokeshvutla@ti.com> > > Add MCAN hwmod data and register it for dra762 silicons. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 32 +++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > index 62352d1e6361..a2cd7f865a60 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > @@ -1355,6 +1355,29 @@ static struct omap_hwmod dra7xx_mailbox13_hwmod = { > }, > }; > > +/* > + * 'mcan' class > + * > + */ > +static struct omap_hwmod_class dra76x_mcan_hwmod_class = { > + .name = "mcan", > +}; > + > +/* mcan */ > +static struct omap_hwmod dra76x_mcan_hwmod = { > + .name = "mcan", > + .class = &dra76x_mcan_hwmod_class, > + .clkdm_name = "wkupaon_clkdm", > + .main_clk = "mcan_clk", > + .prcm = { > + .omap4 = { > + .clkctrl_offs = DRA7XX_CM_WKUPAON_ADC_CLKCTRL_OFFSET, > + .context_offs = DRA7XX_RM_WKUPAON_ADC_CONTEXT_OFFSET, > + .modulemode = MODULEMODE_SWCTRL, > + }, > + }, > +}; You should be now able to leave out at least the clkctrl_offs and modulemode here. Please also check if leaving out clkdm_name and main_clk now works :) > @@ -3818,6 +3841,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per2__epwmss2 = { > .user = OCP_USER_MPU, > }; > > +/* l3_main_1 -> mcan */ > +static struct omap_hwmod_ocp_if dra76x_l3_main_1__mcan = { > + .master = &dra7xx_l3_main_1_hwmod, > + .slave = &dra76x_mcan_hwmod, > + .clk = "l3_iclk_div", > + .user = OCP_USER_MPU | OCP_USER_SDMA, > +}; I think this we still need though for the clk. Tero, do you have any comments on what all clocks can now be left out? Regards, Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Date: Wed, 30 May 2018 07:50:47 -0700 [thread overview] Message-ID: <20180530145047.GC5705@atomide.com> (raw) In-Reply-To: <20180530141133.3711-2-faiz_abbas@ti.com> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]: > From: Lokesh Vutla <lokeshvutla@ti.com> > > Add MCAN hwmod data and register it for dra762 silicons. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 32 +++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > index 62352d1e6361..a2cd7f865a60 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > @@ -1355,6 +1355,29 @@ static struct omap_hwmod dra7xx_mailbox13_hwmod = { > }, > }; > > +/* > + * 'mcan' class > + * > + */ > +static struct omap_hwmod_class dra76x_mcan_hwmod_class = { > + .name = "mcan", > +}; > + > +/* mcan */ > +static struct omap_hwmod dra76x_mcan_hwmod = { > + .name = "mcan", > + .class = &dra76x_mcan_hwmod_class, > + .clkdm_name = "wkupaon_clkdm", > + .main_clk = "mcan_clk", > + .prcm = { > + .omap4 = { > + .clkctrl_offs = DRA7XX_CM_WKUPAON_ADC_CLKCTRL_OFFSET, > + .context_offs = DRA7XX_RM_WKUPAON_ADC_CONTEXT_OFFSET, > + .modulemode = MODULEMODE_SWCTRL, > + }, > + }, > +}; You should be now able to leave out at least the clkctrl_offs and modulemode here. Please also check if leaving out clkdm_name and main_clk now works :) > @@ -3818,6 +3841,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per2__epwmss2 = { > .user = OCP_USER_MPU, > }; > > +/* l3_main_1 -> mcan */ > +static struct omap_hwmod_ocp_if dra76x_l3_main_1__mcan = { > + .master = &dra7xx_l3_main_1_hwmod, > + .slave = &dra76x_mcan_hwmod, > + .clk = "l3_iclk_div", > + .user = OCP_USER_MPU | OCP_USER_SDMA, > +}; I think this we still need though for the clk. Tero, do you have any comments on what all clocks can now be left out? Regards, Tony
next prev parent reply other threads:[~2018-05-30 14:50 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-30 14:11 [PATCH v2 0/6] Add MCAN Support for dra76x Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:50 ` Tony Lindgren [this message] 2018-05-30 14:50 ` Tony Lindgren 2018-05-30 15:15 ` Tero Kristo 2018-05-30 15:15 ` Tero Kristo 2018-05-30 15:15 ` Tero Kristo 2018-05-30 15:28 ` Tony Lindgren 2018-05-30 15:28 ` Tony Lindgren 2018-05-30 15:41 ` Tero Kristo 2018-05-30 15:41 ` Tero Kristo 2018-05-30 15:41 ` Tero Kristo 2018-05-30 15:54 ` Tony Lindgren 2018-05-30 15:54 ` Tony Lindgren 2018-05-31 6:15 ` Tero Kristo 2018-05-31 6:15 ` Tero Kristo 2018-05-31 6:15 ` Tero Kristo 2018-05-31 15:26 ` Tony Lindgren 2018-05-31 15:26 ` Tony Lindgren 2018-05-31 16:35 ` Faiz Abbas 2018-05-31 16:35 ` Faiz Abbas 2018-05-31 16:35 ` Faiz Abbas 2018-05-31 16:39 ` Tony Lindgren 2018-05-31 16:39 ` Tony Lindgren 2018-05-30 14:11 ` [PATCH v2 2/6] ARM: dts: dra762: Add MCAN clock support Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-31 4:03 ` Rob Herring 2018-05-31 4:03 ` Rob Herring 2018-05-31 10:14 ` Faiz Abbas 2018-05-31 10:14 ` Faiz Abbas 2018-05-31 10:14 ` Faiz Abbas 2018-05-31 13:29 ` Tero Kristo 2018-05-31 13:29 ` Tero Kristo 2018-05-31 13:29 ` Tero Kristo 2018-06-01 6:48 ` Faiz Abbas 2018-06-01 6:48 ` Faiz Abbas 2018-06-01 6:48 ` Faiz Abbas 2018-06-01 14:26 ` Tony Lindgren 2018-06-01 14:26 ` Tony Lindgren 2018-06-04 13:58 ` Faiz Abbas 2018-06-04 13:58 ` Faiz Abbas 2018-06-04 13:58 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:57 ` Tony Lindgren 2018-05-30 14:57 ` Tony Lindgren 2018-05-31 10:16 ` Faiz Abbas 2018-05-31 10:16 ` Faiz Abbas 2018-05-31 10:16 ` Faiz Abbas 2018-05-31 13:50 ` Tony Lindgren 2018-05-31 13:50 ` Tony Lindgren 2018-05-31 4:08 ` Rob Herring 2018-05-31 4:08 ` Rob Herring 2018-05-30 14:11 ` [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 15:04 ` Tony Lindgren 2018-05-30 15:04 ` Tony Lindgren 2018-05-31 10:21 ` Faiz Abbas 2018-05-31 10:21 ` Faiz Abbas 2018-05-31 10:21 ` Faiz Abbas 2018-05-31 13:45 ` Tony Lindgren 2018-05-31 13:45 ` Tony Lindgren 2018-05-31 16:38 ` Faiz Abbas 2018-05-31 16:38 ` Faiz Abbas 2018-05-31 16:38 ` Faiz Abbas 2018-05-31 4:06 ` Rob Herring 2018-05-31 4:06 ` Rob Herring 2018-05-31 11:26 ` Faiz Abbas 2018-05-31 11:26 ` Faiz Abbas 2018-05-31 11:26 ` Faiz Abbas 2018-05-31 13:41 ` Tony Lindgren 2018-05-31 13:41 ` Tony Lindgren 2018-06-02 6:32 ` Stephen Boyd 2018-06-02 6:32 ` Stephen Boyd 2018-06-02 6:32 ` Stephen Boyd 2018-06-02 6:32 ` Stephen Boyd 2018-06-04 5:49 ` Faiz Abbas 2018-06-04 5:49 ` Faiz Abbas 2018-06-04 5:49 ` Faiz Abbas 2018-05-30 14:11 ` [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 14:11 ` Faiz Abbas 2018-05-30 15:07 ` Tony Lindgren 2018-05-30 15:07 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180530145047.GC5705@atomide.com \ --to=tony@atomide.com \ --cc=bcousson@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=faiz_abbas@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=robh+dt@kernel.org \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.