From: Erik Stromdahl <erik.stromdahl@gmail.com> To: "Valo, Kalle" <kvalo@qca.qualcomm.com>, "michal.kazior@tieto.com" <michal.kazior@tieto.com> Cc: linux-wireless <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [RFC 10/12] ath10k: Added QCA65XX hw definition Date: Tue, 15 Nov 2016 19:34:28 +0100 [thread overview] Message-ID: <0c1172f0-2e3b-6147-646c-adb98b9ea3b7@gmail.com> (raw) In-Reply-To: <87wpg5qai1.fsf@qca.qualcomm.com> On 11/15/2016 11:54 AM, Valo, Kalle wrote: > Michal Kazior <michal.kazior@tieto.com> writes: > >> On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wrote: >>> Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com> >>> --- >>> drivers/net/wireless/ath/ath10k/hw.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h >>> index 46142e9..ef45ecf 100644 >>> --- a/drivers/net/wireless/ath/ath10k/hw.h >>> +++ b/drivers/net/wireless/ath/ath10k/hw.h >>> @@ -224,6 +224,7 @@ enum ath10k_hw_rev { >>> ATH10K_HW_QCA9377, >>> ATH10K_HW_QCA4019, >>> ATH10K_HW_QCA9887, >>> + ATH10K_HW_QCA65XX, >> >> Are you 100% positive that you're supporting all QCA65XX chips? The >> rule of thumb is to avoid Xs as much as possible unless totally >> perfectly completely sure. > I admit that I am definitely not totally perfectly completely sure about this :) In fact, I don't have a clue what does numbers really mean. All I know is that the chipset I am using is called QCA6584 which I think is an automotive version of another chipses called QCA6574. I have tried to google these numbers up, but it is really hard to find anything useful. So I thought, hey, why don't I just add a few X'es in there and I have support for both! > But the thing is that nobody can't be absolutely sure as we never know > what marketing comes up within few years again. So I would say that XX > in chip names should be completely avoided to avoid any confusion. We > already suffer from this in ath10k with QCA988X and QCA9888 which are > different designs but the names overlap. > > I haven't reviewed Erik's patches yet but I'm surprised why even a new > enum value is needed here. I was assuming we could use ATH10K_HW_QCA6174 > because AFAIK they share the same design. Any particular reason for > this? > The reason for this was that the switch(hw_rev)-statement in ath10k_core_create assigns ar->regs and ar->hw_values to structures containing values that are not applicable for SDIO. I though that I would potentially need other structures, but after investigating the qca6174_regs struct, it seems that the values that are applicable for SDIO are the same. I will remove this enum and use ATH10K_HW_QCA6174 instead as you propose. If for some reason I would need other regs and hw_values structs in the future, we can figure out appropriate names then.
WARNING: multiple messages have this Message-ID (diff)
From: Erik Stromdahl <erik.stromdahl@gmail.com> To: "Valo, Kalle" <kvalo@qca.qualcomm.com>, "michal.kazior@tieto.com" <michal.kazior@tieto.com> Cc: linux-wireless <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [RFC 10/12] ath10k: Added QCA65XX hw definition Date: Tue, 15 Nov 2016 19:34:28 +0100 [thread overview] Message-ID: <0c1172f0-2e3b-6147-646c-adb98b9ea3b7@gmail.com> (raw) In-Reply-To: <87wpg5qai1.fsf@qca.qualcomm.com> On 11/15/2016 11:54 AM, Valo, Kalle wrote: > Michal Kazior <michal.kazior@tieto.com> writes: > >> On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wrote: >>> Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com> >>> --- >>> drivers/net/wireless/ath/ath10k/hw.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h >>> index 46142e9..ef45ecf 100644 >>> --- a/drivers/net/wireless/ath/ath10k/hw.h >>> +++ b/drivers/net/wireless/ath/ath10k/hw.h >>> @@ -224,6 +224,7 @@ enum ath10k_hw_rev { >>> ATH10K_HW_QCA9377, >>> ATH10K_HW_QCA4019, >>> ATH10K_HW_QCA9887, >>> + ATH10K_HW_QCA65XX, >> >> Are you 100% positive that you're supporting all QCA65XX chips? The >> rule of thumb is to avoid Xs as much as possible unless totally >> perfectly completely sure. > I admit that I am definitely not totally perfectly completely sure about this :) In fact, I don't have a clue what does numbers really mean. All I know is that the chipset I am using is called QCA6584 which I think is an automotive version of another chipses called QCA6574. I have tried to google these numbers up, but it is really hard to find anything useful. So I thought, hey, why don't I just add a few X'es in there and I have support for both! > But the thing is that nobody can't be absolutely sure as we never know > what marketing comes up within few years again. So I would say that XX > in chip names should be completely avoided to avoid any confusion. We > already suffer from this in ath10k with QCA988X and QCA9888 which are > different designs but the names overlap. > > I haven't reviewed Erik's patches yet but I'm surprised why even a new > enum value is needed here. I was assuming we could use ATH10K_HW_QCA6174 > because AFAIK they share the same design. Any particular reason for > this? > The reason for this was that the switch(hw_rev)-statement in ath10k_core_create assigns ar->regs and ar->hw_values to structures containing values that are not applicable for SDIO. I though that I would potentially need other structures, but after investigating the qca6174_regs struct, it seems that the values that are applicable for SDIO are the same. I will remove this enum and use ATH10K_HW_QCA6174 instead as you propose. If for some reason I would need other regs and hw_values structs in the future, we can figure out appropriate names then. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-11-15 18:34 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-14 16:33 [RFC 00/12] ath10k sdio support Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 01/12] ath10k: htc: made static function public Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 02/12] ath10k: htc: rx trailer lookahead support Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 9:57 ` Michal Kazior 2016-11-15 9:57 ` Michal Kazior 2016-11-15 17:31 ` Erik Stromdahl 2016-11-15 17:31 ` Erik Stromdahl 2016-11-16 13:53 ` Valo, Kalle 2016-11-16 13:53 ` Valo, Kalle 2016-11-14 16:33 ` [RFC 03/12] ath10k: htc: Changed order of wait target and ep connect Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:13 ` Michal Kazior 2016-11-15 10:13 ` Michal Kazior 2016-11-15 17:07 ` Erik Stromdahl 2016-11-15 17:07 ` Erik Stromdahl 2016-11-16 14:29 ` Michal Kazior 2016-11-16 14:29 ` Michal Kazior 2016-11-14 16:33 ` [RFC 04/12] ath10k: htc: refactorization Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:19 ` Michal Kazior 2016-11-15 10:19 ` Michal Kazior 2016-11-17 16:32 ` Erik Stromdahl 2016-11-17 16:32 ` Erik Stromdahl 2016-11-18 14:49 ` Michal Kazior 2016-11-18 14:49 ` Michal Kazior 2016-11-14 16:33 ` [RFC 05/12] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:25 ` Michal Kazior 2016-11-15 10:25 ` Michal Kazior 2016-11-15 10:46 ` Valo, Kalle 2016-11-15 10:46 ` Valo, Kalle 2016-11-14 16:33 ` [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:28 ` Michal Kazior 2016-11-15 10:28 ` Michal Kazior 2016-11-15 17:11 ` Erik Stromdahl 2016-11-15 17:11 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 07/12] ath10k: Added SDIO dbg masks Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 08/12] ath10k: Added ATH10K_BUS_SDIO enum Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 09/12] ath10k: Mailbox address definitions Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:31 ` Michal Kazior 2016-11-15 10:31 ` Michal Kazior 2016-11-15 10:48 ` Valo, Kalle 2016-11-15 10:48 ` Valo, Kalle 2016-11-14 16:33 ` [RFC 10/12] ath10k: Added QCA65XX hw definition Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:34 ` Michal Kazior 2016-11-15 10:34 ` Michal Kazior 2016-11-15 10:54 ` Valo, Kalle 2016-11-15 10:54 ` Valo, Kalle 2016-11-15 18:34 ` Erik Stromdahl [this message] 2016-11-15 18:34 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 11/12] ath10k: Added more host_interest members Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 12/12] ath10k: Added sdio support Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0c1172f0-2e3b-6147-646c-adb98b9ea3b7@gmail.com \ --to=erik.stromdahl@gmail.com \ --cc=ath10k@lists.infradead.org \ --cc=kvalo@qca.qualcomm.com \ --cc=linux-wireless@vger.kernel.org \ --cc=michal.kazior@tieto.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.