From: Michal Kazior <michal.kazior@tieto.com> To: Erik Stromdahl <erik.stromdahl@gmail.com> Cc: Kalle Valo <kvalo@qca.qualcomm.com>, linux-wireless <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions Date: Tue, 15 Nov 2016 11:28:38 +0100 [thread overview] Message-ID: <CA+BoTQ=jSun0Je6sVsZz-SaiDA6+nZxSTJF_5OH0unPkjm1gvw@mail.gmail.com> (raw) In-Reply-To: <1479141222-8493-7-git-send-email-erik.stromdahl@gmail.com> On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wro= te: > Added functions implementing the following BMI commands: > > BMI_READ_SOC_REGISTER > BMI_WRITE_SOC_REGISTER > > Reading and writing BMI registers is sometimes needed for > SDIO chipsets. I didn't see ath10k_bmi_write_soc_reg nor ath10k_bmi_read_soc_reg being used in your Patch 12. Is this patch really necessary? [...] > diff --git a/drivers/net/wireless/ath/ath10k/bmi.c b/drivers/net/wireless= /ath/ath10k/bmi.c > index 2872d34..1c378a2 100644 > --- a/drivers/net/wireless/ath/ath10k/bmi.c > +++ b/drivers/net/wireless/ath/ath10k/bmi.c > @@ -97,7 +97,8 @@ int ath10k_bmi_read_memory(struct ath10k *ar, > u32 rxlen; > int ret; > > - ath10k_dbg(ar, ATH10K_DBG_BMI, "bmi read address 0x%x length %d\n= ", > + ath10k_dbg(ar, ATH10K_DBG_BMI, > + "bmi read memory address 0x%x length %d\n", > address, length); > > if (ar->bmi.done_sent) { > @@ -137,7 +138,8 @@ int ath10k_bmi_write_memory(struct ath10k *ar, > u32 txlen; > int ret; > > - ath10k_dbg(ar, ATH10K_DBG_BMI, "bmi write address 0x%x length %d\= n", > + ath10k_dbg(ar, ATH10K_DBG_BMI, > + "bmi write memory address 0x%x length %d\n", > address, length); > These 2 hunks shouldn't be modified in this patch. If you want to do a clean up this warrants a separate patch :) Micha=C5=82
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com> To: Erik Stromdahl <erik.stromdahl@gmail.com> Cc: Kalle Valo <kvalo@qca.qualcomm.com>, linux-wireless <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions Date: Tue, 15 Nov 2016 11:28:38 +0100 [thread overview] Message-ID: <CA+BoTQ=jSun0Je6sVsZz-SaiDA6+nZxSTJF_5OH0unPkjm1gvw@mail.gmail.com> (raw) In-Reply-To: <1479141222-8493-7-git-send-email-erik.stromdahl@gmail.com> On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wrote: > Added functions implementing the following BMI commands: > > BMI_READ_SOC_REGISTER > BMI_WRITE_SOC_REGISTER > > Reading and writing BMI registers is sometimes needed for > SDIO chipsets. I didn't see ath10k_bmi_write_soc_reg nor ath10k_bmi_read_soc_reg being used in your Patch 12. Is this patch really necessary? [...] > diff --git a/drivers/net/wireless/ath/ath10k/bmi.c b/drivers/net/wireless/ath/ath10k/bmi.c > index 2872d34..1c378a2 100644 > --- a/drivers/net/wireless/ath/ath10k/bmi.c > +++ b/drivers/net/wireless/ath/ath10k/bmi.c > @@ -97,7 +97,8 @@ int ath10k_bmi_read_memory(struct ath10k *ar, > u32 rxlen; > int ret; > > - ath10k_dbg(ar, ATH10K_DBG_BMI, "bmi read address 0x%x length %d\n", > + ath10k_dbg(ar, ATH10K_DBG_BMI, > + "bmi read memory address 0x%x length %d\n", > address, length); > > if (ar->bmi.done_sent) { > @@ -137,7 +138,8 @@ int ath10k_bmi_write_memory(struct ath10k *ar, > u32 txlen; > int ret; > > - ath10k_dbg(ar, ATH10K_DBG_BMI, "bmi write address 0x%x length %d\n", > + ath10k_dbg(ar, ATH10K_DBG_BMI, > + "bmi write memory address 0x%x length %d\n", > address, length); > These 2 hunks shouldn't be modified in this patch. If you want to do a clean up this warrants a separate patch :) Michał _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-11-15 10:28 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-14 16:33 [RFC 00/12] ath10k sdio support Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 01/12] ath10k: htc: made static function public Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 02/12] ath10k: htc: rx trailer lookahead support Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 9:57 ` Michal Kazior 2016-11-15 9:57 ` Michal Kazior 2016-11-15 17:31 ` Erik Stromdahl 2016-11-15 17:31 ` Erik Stromdahl 2016-11-16 13:53 ` Valo, Kalle 2016-11-16 13:53 ` Valo, Kalle 2016-11-14 16:33 ` [RFC 03/12] ath10k: htc: Changed order of wait target and ep connect Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:13 ` Michal Kazior 2016-11-15 10:13 ` Michal Kazior 2016-11-15 17:07 ` Erik Stromdahl 2016-11-15 17:07 ` Erik Stromdahl 2016-11-16 14:29 ` Michal Kazior 2016-11-16 14:29 ` Michal Kazior 2016-11-14 16:33 ` [RFC 04/12] ath10k: htc: refactorization Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:19 ` Michal Kazior 2016-11-15 10:19 ` Michal Kazior 2016-11-17 16:32 ` Erik Stromdahl 2016-11-17 16:32 ` Erik Stromdahl 2016-11-18 14:49 ` Michal Kazior 2016-11-18 14:49 ` Michal Kazior 2016-11-14 16:33 ` [RFC 05/12] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:25 ` Michal Kazior 2016-11-15 10:25 ` Michal Kazior 2016-11-15 10:46 ` Valo, Kalle 2016-11-15 10:46 ` Valo, Kalle 2016-11-14 16:33 ` [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:28 ` Michal Kazior [this message] 2016-11-15 10:28 ` Michal Kazior 2016-11-15 17:11 ` Erik Stromdahl 2016-11-15 17:11 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 07/12] ath10k: Added SDIO dbg masks Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 08/12] ath10k: Added ATH10K_BUS_SDIO enum Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 09/12] ath10k: Mailbox address definitions Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:31 ` Michal Kazior 2016-11-15 10:31 ` Michal Kazior 2016-11-15 10:48 ` Valo, Kalle 2016-11-15 10:48 ` Valo, Kalle 2016-11-14 16:33 ` [RFC 10/12] ath10k: Added QCA65XX hw definition Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-15 10:34 ` Michal Kazior 2016-11-15 10:34 ` Michal Kazior 2016-11-15 10:54 ` Valo, Kalle 2016-11-15 10:54 ` Valo, Kalle 2016-11-15 18:34 ` Erik Stromdahl 2016-11-15 18:34 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 11/12] ath10k: Added more host_interest members Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl 2016-11-14 16:33 ` [RFC 12/12] ath10k: Added sdio support Erik Stromdahl 2016-11-14 16:33 ` Erik Stromdahl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+BoTQ=jSun0Je6sVsZz-SaiDA6+nZxSTJF_5OH0unPkjm1gvw@mail.gmail.com' \ --to=michal.kazior@tieto.com \ --cc=ath10k@lists.infradead.org \ --cc=erik.stromdahl@gmail.com \ --cc=kvalo@qca.qualcomm.com \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.