From: Michal Kazior <michal.kazior@tieto.com>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC 09/12] ath10k: Mailbox address definitions
Date: Tue, 15 Nov 2016 11:31:28 +0100 [thread overview]
Message-ID: <CA+BoTQnohNffDOt_mYRuATv9wBAvOy=t6hGdS9MVRkZuwRE1nA@mail.gmail.com> (raw)
In-Reply-To: <1479141222-8493-10-git-send-email-erik.stromdahl@gmail.com>
On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wro=
te:
> Address definitions for SDIO/mbox based chipsets.
>
> Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 53 ++++++++++++++++++++++++++++=
++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/=
ath/ath10k/hw.h
> index 883547f..46142e9 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -814,6 +814,59 @@ struct ath10k_hw_ops {
> #define QCA9887_EEPROM_ADDR_LO_MASK 0x00ff0000
> #define QCA9887_EEPROM_ADDR_LO_LSB 16
>
> +#define MBOX_RESET_CONTROL_ADDRESS 0x00000000
> +#define MBOX_HOST_INT_STATUS_ADDRESS 0x00000800
> +#define MBOX_HOST_INT_STATUS_ERROR_LSB 7
> +#define MBOX_HOST_INT_STATUS_ERROR_MASK 0x00000080
I would again suggest using Jakub's bitfield GET_FIELD stuff to get
rid of MASK+LSB and just have single define per register field. Kalle,
thoughts?
Micha=C5=82
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC 09/12] ath10k: Mailbox address definitions
Date: Tue, 15 Nov 2016 11:31:28 +0100 [thread overview]
Message-ID: <CA+BoTQnohNffDOt_mYRuATv9wBAvOy=t6hGdS9MVRkZuwRE1nA@mail.gmail.com> (raw)
In-Reply-To: <1479141222-8493-10-git-send-email-erik.stromdahl@gmail.com>
On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@gmail.com> wrote:
> Address definitions for SDIO/mbox based chipsets.
>
> Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 53 ++++++++++++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
> index 883547f..46142e9 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -814,6 +814,59 @@ struct ath10k_hw_ops {
> #define QCA9887_EEPROM_ADDR_LO_MASK 0x00ff0000
> #define QCA9887_EEPROM_ADDR_LO_LSB 16
>
> +#define MBOX_RESET_CONTROL_ADDRESS 0x00000000
> +#define MBOX_HOST_INT_STATUS_ADDRESS 0x00000800
> +#define MBOX_HOST_INT_STATUS_ERROR_LSB 7
> +#define MBOX_HOST_INT_STATUS_ERROR_MASK 0x00000080
I would again suggest using Jakub's bitfield GET_FIELD stuff to get
rid of MASK+LSB and just have single define per register field. Kalle,
thoughts?
Michał
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-11-15 10:31 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 16:33 [RFC 00/12] ath10k sdio support Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 01/12] ath10k: htc: made static function public Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 02/12] ath10k: htc: rx trailer lookahead support Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-15 9:57 ` Michal Kazior
2016-11-15 9:57 ` Michal Kazior
2016-11-15 17:31 ` Erik Stromdahl
2016-11-15 17:31 ` Erik Stromdahl
2016-11-16 13:53 ` Valo, Kalle
2016-11-16 13:53 ` Valo, Kalle
2016-11-14 16:33 ` [RFC 03/12] ath10k: htc: Changed order of wait target and ep connect Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-15 10:13 ` Michal Kazior
2016-11-15 10:13 ` Michal Kazior
2016-11-15 17:07 ` Erik Stromdahl
2016-11-15 17:07 ` Erik Stromdahl
2016-11-16 14:29 ` Michal Kazior
2016-11-16 14:29 ` Michal Kazior
2016-11-14 16:33 ` [RFC 04/12] ath10k: htc: refactorization Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-15 10:19 ` Michal Kazior
2016-11-15 10:19 ` Michal Kazior
2016-11-17 16:32 ` Erik Stromdahl
2016-11-17 16:32 ` Erik Stromdahl
2016-11-18 14:49 ` Michal Kazior
2016-11-18 14:49 ` Michal Kazior
2016-11-14 16:33 ` [RFC 05/12] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-15 10:25 ` Michal Kazior
2016-11-15 10:25 ` Michal Kazior
2016-11-15 10:46 ` Valo, Kalle
2016-11-15 10:46 ` Valo, Kalle
2016-11-14 16:33 ` [RFC 06/12] ath10k: bmi: Added SOC reg read/write functions Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-15 10:28 ` Michal Kazior
2016-11-15 10:28 ` Michal Kazior
2016-11-15 17:11 ` Erik Stromdahl
2016-11-15 17:11 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 07/12] ath10k: Added SDIO dbg masks Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 08/12] ath10k: Added ATH10K_BUS_SDIO enum Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 09/12] ath10k: Mailbox address definitions Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-15 10:31 ` Michal Kazior [this message]
2016-11-15 10:31 ` Michal Kazior
2016-11-15 10:48 ` Valo, Kalle
2016-11-15 10:48 ` Valo, Kalle
2016-11-14 16:33 ` [RFC 10/12] ath10k: Added QCA65XX hw definition Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-15 10:34 ` Michal Kazior
2016-11-15 10:34 ` Michal Kazior
2016-11-15 10:54 ` Valo, Kalle
2016-11-15 10:54 ` Valo, Kalle
2016-11-15 18:34 ` Erik Stromdahl
2016-11-15 18:34 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 11/12] ath10k: Added more host_interest members Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
2016-11-14 16:33 ` [RFC 12/12] ath10k: Added sdio support Erik Stromdahl
2016-11-14 16:33 ` Erik Stromdahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+BoTQnohNffDOt_mYRuATv9wBAvOy=t6hGdS9MVRkZuwRE1nA@mail.gmail.com' \
--to=michal.kazior@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=erik.stromdahl@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.