All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: linuxppc-dev@ozlabs.org, dwmw2@infradead.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Mon, 22 Aug 2011 13:53:08 +0300	[thread overview]
Message-ID: <1314010393.2644.110.camel@sauron> (raw)
In-Reply-To: <1313634783-8855-1-git-send-email-b35362@freescale.com>

On Thu, 2011-08-18 at 10:33 +0800, b35362@freescale.com wrote:
> From: Liu Shuo <b35362@freescale.com>
> 
> Freescale FCM controller has a 2K size limitation of buffer RAM. In order
> to support the Nand flash chip whose page size is larger than 2K bytes,
> we divide a page into multi-2K pages for MTD layer driver. In that case,
> we force to set the page size to 2K bytes. We convert the page address of
> MTD layer driver to a real page address in flash chips and a column index
> in fsl_elbc driver. We can issue any column address by UA instruction of
> elbc controller.
> 
> NOTE: Due to there is a limitation of 'Number of Partial Program Cycles in
> the Same Page (NOP)', the flash chip which is supported by this workaround 
> have to meet below conditions.
> 	1. page size is not greater than 4KB 
> 	2.	1) if main area and spare area have independent NOPs:
> 			  main  area NOP    :    >=3
> 			  spare area NOP    :    >=2
> 		2) if main area and spare area have a common NOP: 
> 			  NOP               :    >=4

Could you please also add this kind of info to the driver code comments?

Does it also make sense to print a message if you do the emulation,
like:

	pr_info("attention! emulating 2KiB NAND pages!");

-- 
Best Regards,
Artem Bityutskiy

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: linuxppc-dev@ozlabs.org, Li Yang <leoli@freescale.com>,
	dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Mon, 22 Aug 2011 13:53:08 +0300	[thread overview]
Message-ID: <1314010393.2644.110.camel@sauron> (raw)
In-Reply-To: <1313634783-8855-1-git-send-email-b35362@freescale.com>

On Thu, 2011-08-18 at 10:33 +0800, b35362@freescale.com wrote:
> From: Liu Shuo <b35362@freescale.com>
> 
> Freescale FCM controller has a 2K size limitation of buffer RAM. In order
> to support the Nand flash chip whose page size is larger than 2K bytes,
> we divide a page into multi-2K pages for MTD layer driver. In that case,
> we force to set the page size to 2K bytes. We convert the page address of
> MTD layer driver to a real page address in flash chips and a column index
> in fsl_elbc driver. We can issue any column address by UA instruction of
> elbc controller.
> 
> NOTE: Due to there is a limitation of 'Number of Partial Program Cycles in
> the Same Page (NOP)', the flash chip which is supported by this workaround 
> have to meet below conditions.
> 	1. page size is not greater than 4KB 
> 	2.	1) if main area and spare area have independent NOPs:
> 			  main  area NOP    :    >=3
> 			  spare area NOP    :    >=2
> 		2) if main area and spare area have a common NOP: 
> 			  NOP               :    >=4

Could you please also add this kind of info to the driver code comments?

Does it also make sense to print a message if you do the emulation,
like:

	pr_info("attention! emulating 2KiB NAND pages!");

-- 
Best Regards,
Artem Bityutskiy

  parent reply	other threads:[~2011-08-22 10:51 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-18  2:33 [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-08-18  2:33 ` b35362
2011-08-18 16:25 ` Scott Wood
2011-08-18 18:27   ` Scott Wood
2011-08-23  8:37   ` LiuShuo
2011-08-23  8:37     ` LiuShuo
2011-08-23 10:02     ` Matthieu CASTET
2011-08-23 16:12       ` Scott Wood
2011-08-23 16:12         ` Scott Wood
2011-08-25 11:18         ` Artem Bityutskiy
2011-08-24  2:48       ` LiuShuo
2011-08-24  2:48         ` LiuShuo
2011-08-25 11:25         ` Matthieu CASTET
2011-09-01  9:41           ` LiuShuo
2011-09-01  9:41             ` LiuShuo
2011-09-01 22:30             ` Scott Wood
2011-08-18 17:00 ` Matthieu CASTET
2011-08-18 17:00   ` Matthieu CASTET
2011-08-18 18:24   ` Scott Wood
2011-08-18 18:24     ` Scott Wood
2011-08-19  3:20   ` LiuShuo
2011-08-19  3:20     ` LiuShuo
2011-08-19  8:57     ` Matthieu CASTET
2011-08-19  8:57       ` Matthieu CASTET
2011-08-19 18:10       ` Scott Wood
2011-08-19 18:10         ` Scott Wood
2011-08-22 10:58         ` Artem Bityutskiy
2011-08-22 15:25           ` Ivan Djelic
2011-08-22 16:04             ` Scott Wood
2011-08-22 16:13               ` Matthieu CASTET
2011-08-22 16:19                 ` Scott Wood
2011-08-22 16:19                   ` Scott Wood
2011-08-22 17:05                   ` Matthieu CASTET
2011-08-23  3:09                   ` LiuShuo
2011-08-23  3:09                     ` LiuShuo
2011-08-23  8:14                     ` Matthieu CASTET
2011-08-23  9:57                       ` LiuShuo
2011-08-23  9:57                         ` LiuShuo
2011-08-23 10:13                         ` Matthieu CASTET
2011-08-22 15:58           ` Scott Wood
2011-08-25 11:06             ` Artem Bityutskiy
2011-08-22 10:53 ` Artem Bityutskiy [this message]
2011-08-22 10:53   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314010393.2644.110.camel@sauron \
    --to=dedekind1@gmail.com \
    --cc=b35362@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.