From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, arm@kernel.org,
Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Axel Lin <axel.lin@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 2/9] ARM: imx: MACH_MX31ADS_WM1133_EV1 needs REGULATOR_WM8350
Date: Thu, 14 Feb 2013 23:47:44 +0100 [thread overview]
Message-ID: <1360882071-4072668-3-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1360882071-4072668-1-git-send-email-arnd@arndb.de>
MACH_MX31ADS_WM1133_EV1 already depends on REGULATOR_WM8350,
but that still allows REGULATOR_WM8350 to be a loadable
module. Depending on REGULATOR_WM8350 to be built-in
ensures we cannot create a broken configuration.
Without this patch, building allmodconfig results in:
arch/arm/mach-imx/built-in.o: In function `mx31_wm8350_init':
arch/arm/mach-imx/mach-mx31ads.c:461: undefined reference to `wm8350_register_regulator'
arch/arm/mach-imx/mach-mx31ads.c:471: undefined reference to `wm8350_dcdc_set_slot'
arch/arm/mach-imx/mach-mx31ads.c:473: undefined reference to `wm8350_isink_set_flash'
arch/arm/mach-imx/mach-mx31ads.c:480: undefined reference to `wm8350_dcdc25_set_mode'
arch/arm/mach-imx/mach-mx31ads.c:485: undefined reference to `wm8350_register_led'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Axel Lin <axel.lin@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
arch/arm/mach-imx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 7b11d33..4c9c6f9 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -480,7 +480,7 @@ config MACH_MX31ADS_WM1133_EV1
bool "Support Wolfson Microelectronics 1133-EV1 module"
depends on MACH_MX31ADS
depends on MFD_WM8350_I2C
- depends on REGULATOR_WM8350
+ depends on REGULATOR_WM8350 = y
select MFD_WM8350_CONFIG_MODE_0
select MFD_WM8352_CONFIG_MODE_0
help
--
1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] ARM: imx: MACH_MX31ADS_WM1133_EV1 needs REGULATOR_WM8350
Date: Thu, 14 Feb 2013 23:47:44 +0100 [thread overview]
Message-ID: <1360882071-4072668-3-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1360882071-4072668-1-git-send-email-arnd@arndb.de>
MACH_MX31ADS_WM1133_EV1 already depends on REGULATOR_WM8350,
but that still allows REGULATOR_WM8350 to be a loadable
module. Depending on REGULATOR_WM8350 to be built-in
ensures we cannot create a broken configuration.
Without this patch, building allmodconfig results in:
arch/arm/mach-imx/built-in.o: In function `mx31_wm8350_init':
arch/arm/mach-imx/mach-mx31ads.c:461: undefined reference to `wm8350_register_regulator'
arch/arm/mach-imx/mach-mx31ads.c:471: undefined reference to `wm8350_dcdc_set_slot'
arch/arm/mach-imx/mach-mx31ads.c:473: undefined reference to `wm8350_isink_set_flash'
arch/arm/mach-imx/mach-mx31ads.c:480: undefined reference to `wm8350_dcdc25_set_mode'
arch/arm/mach-imx/mach-mx31ads.c:485: undefined reference to `wm8350_register_led'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Axel Lin <axel.lin@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
arch/arm/mach-imx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 7b11d33..4c9c6f9 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -480,7 +480,7 @@ config MACH_MX31ADS_WM1133_EV1
bool "Support Wolfson Microelectronics 1133-EV1 module"
depends on MACH_MX31ADS
depends on MFD_WM8350_I2C
- depends on REGULATOR_WM8350
+ depends on REGULATOR_WM8350 = y
select MFD_WM8350_CONFIG_MODE_0
select MFD_WM8352_CONFIG_MODE_0
help
--
1.8.1.2
next prev parent reply other threads:[~2013-02-14 22:47 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 22:47 [PATCH 0/9] arm-soc/for-next allyesconfig build regressions Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 22:47 ` [PATCH 1/9] ARM: arch_timer: include linux/errno.h Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-15 10:26 ` Mark Rutland
2013-02-15 10:26 ` Mark Rutland
2013-02-15 18:33 ` Arnd Bergmann
2013-02-15 18:33 ` Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann [this message]
2013-02-14 22:47 ` [PATCH 2/9] ARM: imx: MACH_MX31ADS_WM1133_EV1 needs REGULATOR_WM8350 Arnd Bergmann
2013-02-15 17:21 ` Sascha Hauer
2013-02-15 17:21 ` Sascha Hauer
2013-02-14 22:47 ` [PATCH 3/9] ARM: omap2: include linux/errno.h in hwmod_reset Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 22:51 ` Tony Lindgren
2013-02-14 22:51 ` Tony Lindgren
2013-02-15 12:38 ` Arnd Bergmann
2013-02-15 12:38 ` Arnd Bergmann
2013-02-14 22:58 ` Paul Walmsley
2013-02-14 22:58 ` Paul Walmsley
2013-02-14 22:47 ` [PATCH 4/9] ARM: omap: add include guard for soc.h Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 22:55 ` Tony Lindgren
2013-02-14 22:55 ` Tony Lindgren
2013-02-14 23:11 ` Arnd Bergmann
2013-02-14 23:11 ` Arnd Bergmann
2013-02-15 12:40 ` Arnd Bergmann
2013-02-15 12:40 ` Arnd Bergmann
2013-02-14 22:47 ` [PATCH 5/9] drm: export drm_vm_open_locked Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 22:47 ` [PATCH 6/9] net: cwdavinci_cpdma: export symbols for cpsw Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 22:52 ` David Miller
2013-02-14 22:52 ` David Miller
2013-02-14 22:47 ` [PATCH 7/9] remoteproc: omap: depend on OMAP_MBOX_FWK Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 22:55 ` Tony Lindgren
2013-02-14 22:55 ` Tony Lindgren
2013-02-15 6:56 ` Ohad Ben-Cohen
2013-02-15 6:56 ` Ohad Ben-Cohen
2013-02-14 22:47 ` [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 23:45 ` Stephen Warren
2013-02-14 23:45 ` Stephen Warren
2013-02-15 11:05 ` Arnd Bergmann
2013-02-15 11:05 ` Arnd Bergmann
2013-02-15 11:13 ` Russell King - ARM Linux
2013-02-15 11:13 ` Russell King - ARM Linux
2013-02-15 15:49 ` Arnd Bergmann
2013-02-15 15:49 ` Arnd Bergmann
2013-02-15 11:07 ` Russell King - ARM Linux
2013-02-15 11:07 ` Russell King - ARM Linux
2013-02-16 5:14 ` Nicolas Pitre
2013-02-16 5:14 ` Nicolas Pitre
2013-02-18 5:55 ` Shawn Guo
2013-02-18 5:55 ` Shawn Guo
2013-02-18 17:06 ` Nicolas Pitre
2013-02-18 17:06 ` Nicolas Pitre
2013-02-19 1:42 ` Shawn Guo
2013-02-19 1:42 ` Shawn Guo
2013-02-19 4:11 ` Nicolas Pitre
2013-02-19 4:11 ` Nicolas Pitre
2013-02-19 5:10 ` Shawn Guo
2013-02-19 5:10 ` Shawn Guo
2013-02-14 22:47 ` [PATCH 9/9] [media] davinci: do not include mach/hardware.h Arnd Bergmann
2013-02-14 22:47 ` Arnd Bergmann
2013-02-14 22:57 ` Tony Lindgren
2013-02-14 22:57 ` Tony Lindgren
2013-02-15 5:06 ` Prabhakar Lad
2013-02-15 5:06 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360882071-4072668-3-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.