From: Arnd Bergmann <arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Arnd Bergmann <arnd@arndb.de>, Mugunthan V N <mugunthanvnm@ti.com>, Vaibhav Hiremath <hvaibhav@ti.com>, Richard Cochran <richardcochran@gmail.com>, netdev@vger.kernel.org Subject: [PATCH 6/9] net: cwdavinci_cpdma: export symbols for cpsw Date: Thu, 14 Feb 2013 23:47:48 +0100 [thread overview] Message-ID: <1360882071-4072668-7-git-send-email-arnd@arndb.de> (raw) In-Reply-To: <1360882071-4072668-1-git-send-email-arnd@arndb.de> With the support for ARM AM33xx in multiplatform kernels in 3.9, an older bug appears in ARM allmodconfig: When the cpsw driver is built as a module with cpdma support enabled, it uses symbols that the cpdma driver does not export. Without this patch, building allmodconfig results in: ERROR: "cpdma_ctlr_int_ctrl" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined! ERROR: "cpdma_control_set" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined! ERROR: "cpdma_ctlr_eoi" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined! Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Mugunthan V N <mugunthanvnm@ti.com> Cc: Vaibhav Hiremath <hvaibhav@ti.com> Cc: Richard Cochran <richardcochran@gmail.com> Cc: netdev@vger.kernel.org --- drivers/net/ethernet/ti/davinci_cpdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index 7d3bffd..8eeb7c9 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -492,11 +492,13 @@ int cpdma_ctlr_int_ctrl(struct cpdma_ctlr *ctlr, bool enable) spin_unlock_irqrestore(&ctlr->lock, flags); return 0; } +EXPORT_SYMBOL_GPL(cpdma_ctlr_int_ctrl); void cpdma_ctlr_eoi(struct cpdma_ctlr *ctlr) { dma_reg_write(ctlr, CPDMA_MACEOIVECTOR, 0); } +EXPORT_SYMBOL_GPL(cpdma_ctlr_eoi); struct cpdma_chan *cpdma_chan_create(struct cpdma_ctlr *ctlr, int chan_num, cpdma_handler_fn handler) @@ -1028,3 +1030,4 @@ unlock_ret: spin_unlock_irqrestore(&ctlr->lock, flags); return ret; } +EXPORT_SYMBOL_GPL(cpdma_control_set); -- 1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/9] net: cwdavinci_cpdma: export symbols for cpsw Date: Thu, 14 Feb 2013 23:47:48 +0100 [thread overview] Message-ID: <1360882071-4072668-7-git-send-email-arnd@arndb.de> (raw) In-Reply-To: <1360882071-4072668-1-git-send-email-arnd@arndb.de> With the support for ARM AM33xx in multiplatform kernels in 3.9, an older bug appears in ARM allmodconfig: When the cpsw driver is built as a module with cpdma support enabled, it uses symbols that the cpdma driver does not export. Without this patch, building allmodconfig results in: ERROR: "cpdma_ctlr_int_ctrl" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined! ERROR: "cpdma_control_set" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined! ERROR: "cpdma_ctlr_eoi" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined! Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Mugunthan V N <mugunthanvnm@ti.com> Cc: Vaibhav Hiremath <hvaibhav@ti.com> Cc: Richard Cochran <richardcochran@gmail.com> Cc: netdev at vger.kernel.org --- drivers/net/ethernet/ti/davinci_cpdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index 7d3bffd..8eeb7c9 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -492,11 +492,13 @@ int cpdma_ctlr_int_ctrl(struct cpdma_ctlr *ctlr, bool enable) spin_unlock_irqrestore(&ctlr->lock, flags); return 0; } +EXPORT_SYMBOL_GPL(cpdma_ctlr_int_ctrl); void cpdma_ctlr_eoi(struct cpdma_ctlr *ctlr) { dma_reg_write(ctlr, CPDMA_MACEOIVECTOR, 0); } +EXPORT_SYMBOL_GPL(cpdma_ctlr_eoi); struct cpdma_chan *cpdma_chan_create(struct cpdma_ctlr *ctlr, int chan_num, cpdma_handler_fn handler) @@ -1028,3 +1030,4 @@ unlock_ret: spin_unlock_irqrestore(&ctlr->lock, flags); return ret; } +EXPORT_SYMBOL_GPL(cpdma_control_set); -- 1.8.1.2
next prev parent reply other threads:[~2013-02-14 22:49 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-14 22:47 [PATCH 0/9] arm-soc/for-next allyesconfig build regressions Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-14 22:47 ` [PATCH 1/9] ARM: arch_timer: include linux/errno.h Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-15 10:26 ` Mark Rutland 2013-02-15 10:26 ` Mark Rutland 2013-02-15 18:33 ` Arnd Bergmann 2013-02-15 18:33 ` Arnd Bergmann 2013-02-14 22:47 ` [PATCH 2/9] ARM: imx: MACH_MX31ADS_WM1133_EV1 needs REGULATOR_WM8350 Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-15 17:21 ` Sascha Hauer 2013-02-15 17:21 ` Sascha Hauer 2013-02-14 22:47 ` [PATCH 3/9] ARM: omap2: include linux/errno.h in hwmod_reset Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-14 22:51 ` Tony Lindgren 2013-02-14 22:51 ` Tony Lindgren 2013-02-15 12:38 ` Arnd Bergmann 2013-02-15 12:38 ` Arnd Bergmann 2013-02-14 22:58 ` Paul Walmsley 2013-02-14 22:58 ` Paul Walmsley 2013-02-14 22:47 ` [PATCH 4/9] ARM: omap: add include guard for soc.h Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-14 22:55 ` Tony Lindgren 2013-02-14 22:55 ` Tony Lindgren 2013-02-14 23:11 ` Arnd Bergmann 2013-02-14 23:11 ` Arnd Bergmann 2013-02-15 12:40 ` Arnd Bergmann 2013-02-15 12:40 ` Arnd Bergmann 2013-02-14 22:47 ` [PATCH 5/9] drm: export drm_vm_open_locked Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann [this message] 2013-02-14 22:47 ` [PATCH 6/9] net: cwdavinci_cpdma: export symbols for cpsw Arnd Bergmann 2013-02-14 22:52 ` David Miller 2013-02-14 22:52 ` David Miller 2013-02-14 22:47 ` [PATCH 7/9] remoteproc: omap: depend on OMAP_MBOX_FWK Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-14 22:55 ` Tony Lindgren 2013-02-14 22:55 ` Tony Lindgren 2013-02-15 6:56 ` Ohad Ben-Cohen 2013-02-15 6:56 ` Ohad Ben-Cohen 2013-02-14 22:47 ` [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-14 23:45 ` Stephen Warren 2013-02-14 23:45 ` Stephen Warren 2013-02-15 11:05 ` Arnd Bergmann 2013-02-15 11:05 ` Arnd Bergmann 2013-02-15 11:13 ` Russell King - ARM Linux 2013-02-15 11:13 ` Russell King - ARM Linux 2013-02-15 15:49 ` Arnd Bergmann 2013-02-15 15:49 ` Arnd Bergmann 2013-02-15 11:07 ` Russell King - ARM Linux 2013-02-15 11:07 ` Russell King - ARM Linux 2013-02-16 5:14 ` Nicolas Pitre 2013-02-16 5:14 ` Nicolas Pitre 2013-02-18 5:55 ` Shawn Guo 2013-02-18 5:55 ` Shawn Guo 2013-02-18 17:06 ` Nicolas Pitre 2013-02-18 17:06 ` Nicolas Pitre 2013-02-19 1:42 ` Shawn Guo 2013-02-19 1:42 ` Shawn Guo 2013-02-19 4:11 ` Nicolas Pitre 2013-02-19 4:11 ` Nicolas Pitre 2013-02-19 5:10 ` Shawn Guo 2013-02-19 5:10 ` Shawn Guo 2013-02-14 22:47 ` [PATCH 9/9] [media] davinci: do not include mach/hardware.h Arnd Bergmann 2013-02-14 22:47 ` Arnd Bergmann 2013-02-14 22:57 ` Tony Lindgren 2013-02-14 22:57 ` Tony Lindgren 2013-02-15 5:06 ` Prabhakar Lad 2013-02-15 5:06 ` Prabhakar Lad
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1360882071-4072668-7-git-send-email-arnd@arndb.de \ --to=arnd@arndb.de \ --cc=arm@kernel.org \ --cc=hvaibhav@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mugunthanvnm@ti.com \ --cc=netdev@vger.kernel.org \ --cc=richardcochran@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.