* [PATCH] soc: qcom: socinfo: Add another ID for sc7180
@ 2022-05-03 0:33 Douglas Anderson
2022-05-04 2:14 ` Sai Prakash Ranjan
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Douglas Anderson @ 2022-05-03 0:33 UTC (permalink / raw)
To: Bjorn Andersson, Sai Prakash Ranjan
Cc: matvore, Reviewed-by : Stephen Boyd, Douglas Anderson,
Andy Gross, linux-arm-msm, linux-kernel
It appears the some sc7180 devices, like the one in my
sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
another ID into the list.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/soc/qcom/socinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index cee579a267a6..2ef1dc2a1dd3 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -318,6 +318,7 @@ static const struct soc_id soc_id[] = {
{ 396, "IPQ8071A" },
{ 402, "IPQ6018" },
{ 403, "IPQ6028" },
+ { 407, "SC7180" },
{ 421, "IPQ6000" },
{ 422, "IPQ6010" },
{ 425, "SC7180" },
--
2.36.0.464.gb9c8b46e94-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Add another ID for sc7180
2022-05-03 0:33 [PATCH] soc: qcom: socinfo: Add another ID for sc7180 Douglas Anderson
@ 2022-05-04 2:14 ` Sai Prakash Ranjan
2022-05-04 3:30 ` Doug Anderson
2022-05-04 17:20 ` patchwork-bot+linux-arm-msm
2022-05-04 17:21 ` (subset) " Bjorn Andersson
2 siblings, 1 reply; 8+ messages in thread
From: Sai Prakash Ranjan @ 2022-05-04 2:14 UTC (permalink / raw)
To: Douglas Anderson, Bjorn Andersson
Cc: matvore, Reviewed-by : Stephen Boyd, Andy Gross, linux-arm-msm,
linux-kernel
Hi,
On 5/3/2022 6:03 AM, Douglas Anderson wrote:
> It appears the some sc7180 devices, like the one in my
> sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
> another ID into the list.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/soc/qcom/socinfo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index cee579a267a6..2ef1dc2a1dd3 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -318,6 +318,7 @@ static const struct soc_id soc_id[] = {
> { 396, "IPQ8071A" },
> { 402, "IPQ6018" },
> { 403, "IPQ6028" },
> + { 407, "SC7180" },
> { 421, "IPQ6000" },
> { 422, "IPQ6010" },
> { 425, "SC7180" },
Hmm, this ID maps to SM6250 which is a mobile variant. Not sure we should
use it for SC7180 which already has 425 ID assigned, perks of marketing :)
Thanks,
Sai
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Add another ID for sc7180
2022-05-04 2:14 ` Sai Prakash Ranjan
@ 2022-05-04 3:30 ` Doug Anderson
2022-05-04 10:52 ` Sai Prakash Ranjan
0 siblings, 1 reply; 8+ messages in thread
From: Doug Anderson @ 2022-05-04 3:30 UTC (permalink / raw)
To: Sai Prakash Ranjan
Cc: Bjorn Andersson, matvore, Stephen Boyd, Andy Gross, linux-arm-msm, LKML
Hi,
On Tue, May 3, 2022 at 7:14 PM Sai Prakash Ranjan
<quic_saipraka@quicinc.com> wrote:
>
> Hi,
>
> On 5/3/2022 6:03 AM, Douglas Anderson wrote:
> > It appears the some sc7180 devices, like the one in my
> > sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
> > another ID into the list.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> > drivers/soc/qcom/socinfo.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> > index cee579a267a6..2ef1dc2a1dd3 100644
> > --- a/drivers/soc/qcom/socinfo.c
> > +++ b/drivers/soc/qcom/socinfo.c
> > @@ -318,6 +318,7 @@ static const struct soc_id soc_id[] = {
> > { 396, "IPQ8071A" },
> > { 402, "IPQ6018" },
> > { 403, "IPQ6028" },
> > + { 407, "SC7180" },
> > { 421, "IPQ6000" },
> > { 422, "IPQ6010" },
> > { 425, "SC7180" },
>
> Hmm, this ID maps to SM6250 which is a mobile variant. Not sure we should
> use it for SC7180 which already has 425 ID assigned, perks of marketing :)
That's super weird. Any idea why my strongbad reports 407 then? Is it
a firmware bug, or someone misprogrammed something? What can we do to
make the CPU recognized in strongbad?
...and just for extra info, I believe strongbad actually has the
slightly faster version of sc7180. It has a higher GPU/CPU speed. In
some places I've heard it called sc7185, but in other places I've
heard it called just sc7180 with a faster clock speed...
-Doug
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Add another ID for sc7180
2022-05-04 3:30 ` Doug Anderson
@ 2022-05-04 10:52 ` Sai Prakash Ranjan
0 siblings, 0 replies; 8+ messages in thread
From: Sai Prakash Ranjan @ 2022-05-04 10:52 UTC (permalink / raw)
To: Doug Anderson
Cc: Bjorn Andersson, matvore, Stephen Boyd, Andy Gross, linux-arm-msm, LKML
Hi,
On 5/4/2022 9:00 AM, Doug Anderson wrote:
> Hi,
>
> On Tue, May 3, 2022 at 7:14 PM Sai Prakash Ranjan
> <quic_saipraka@quicinc.com> wrote:
>> Hi,
>>
>> On 5/3/2022 6:03 AM, Douglas Anderson wrote:
>>> It appears the some sc7180 devices, like the one in my
>>> sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
>>> another ID into the list.
>>>
>>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>>> ---
>>>
>>> drivers/soc/qcom/socinfo.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>>> index cee579a267a6..2ef1dc2a1dd3 100644
>>> --- a/drivers/soc/qcom/socinfo.c
>>> +++ b/drivers/soc/qcom/socinfo.c
>>> @@ -318,6 +318,7 @@ static const struct soc_id soc_id[] = {
>>> { 396, "IPQ8071A" },
>>> { 402, "IPQ6018" },
>>> { 403, "IPQ6028" },
>>> + { 407, "SC7180" },
>>> { 421, "IPQ6000" },
>>> { 422, "IPQ6010" },
>>> { 425, "SC7180" },
>> Hmm, this ID maps to SM6250 which is a mobile variant. Not sure we should
>> use it for SC7180 which already has 425 ID assigned, perks of marketing :)
> That's super weird. Any idea why my strongbad reports 407 then? Is it
> a firmware bug, or someone misprogrammed something? What can we do to
> make the CPU recognized in strongbad?
Let me check with coretech folks as to why the ID is reused.
> ...and just for extra info, I believe strongbad actually has the
> slightly faster version of sc7180. It has a higher GPU/CPU speed. In
> some places I've heard it called sc7185, but in other places I've
> heard it called just sc7180 with a faster clock speed...
The only other variant of SC7180 I see in the document is SC7180P
which has 495 soc_id and is an APQ variant.
Thanks,
Sai
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Add another ID for sc7180
2022-05-03 0:33 [PATCH] soc: qcom: socinfo: Add another ID for sc7180 Douglas Anderson
2022-05-04 2:14 ` Sai Prakash Ranjan
@ 2022-05-04 17:20 ` patchwork-bot+linux-arm-msm
2022-05-04 17:21 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2022-05-04 17:20 UTC (permalink / raw)
To: Doug Anderson; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (for-next)
by Bjorn Andersson <bjorn.andersson@linaro.org>:
On Mon, 2 May 2022 17:33:45 -0700 you wrote:
> It appears the some sc7180 devices, like the one in my
> sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
> another ID into the list.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> [...]
Here is the summary with links:
- soc: qcom: socinfo: Add another ID for sc7180
https://git.kernel.org/qcom/c/c35886d60560
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH] soc: qcom: socinfo: Add another ID for sc7180
2022-05-03 0:33 [PATCH] soc: qcom: socinfo: Add another ID for sc7180 Douglas Anderson
2022-05-04 2:14 ` Sai Prakash Ranjan
2022-05-04 17:20 ` patchwork-bot+linux-arm-msm
@ 2022-05-04 17:21 ` Bjorn Andersson
2022-05-04 17:51 ` Doug Anderson
2 siblings, 1 reply; 8+ messages in thread
From: Bjorn Andersson @ 2022-05-04 17:21 UTC (permalink / raw)
To: Douglas Anderson, Sai Prakash Ranjan
Cc: matvore, Andy Gross, Reviewed-by : Stephen Boyd, linux-kernel,
linux-arm-msm
On Mon, 2 May 2022 17:33:45 -0700, Douglas Anderson wrote:
> It appears the some sc7180 devices, like the one in my
> sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
> another ID into the list.
>
>
Applied, thanks!
[1/1] soc: qcom: socinfo: Add another ID for sc7180
commit: c35886d605604e0b03cdd835ae3249dc1fe0cc2a
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH] soc: qcom: socinfo: Add another ID for sc7180
2022-05-04 17:21 ` (subset) " Bjorn Andersson
@ 2022-05-04 17:51 ` Doug Anderson
2022-05-04 18:30 ` Bjorn Andersson
0 siblings, 1 reply; 8+ messages in thread
From: Doug Anderson @ 2022-05-04 17:51 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Sai Prakash Ranjan, matvore, Andy Gross,
Reviewed-by : Stephen Boyd, LKML, linux-arm-msm
Hi,
On Wed, May 4, 2022 at 10:21 AM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Mon, 2 May 2022 17:33:45 -0700, Douglas Anderson wrote:
> > It appears the some sc7180 devices, like the one in my
> > sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
> > another ID into the list.
> >
> >
>
> Applied, thanks!
>
> [1/1] soc: qcom: socinfo: Add another ID for sc7180
> commit: c35886d605604e0b03cdd835ae3249dc1fe0cc2a
Hmm. Did you see the responses from Sai [1] about this? He seemed to
indicate that there might be some issue here because he thought 407
was supposed to be a different SoC. Are we sure we want to land this
patch while we're sorting it out?
[1] https://lore.kernel.org/r/13819b2d-26f0-14f4-9cb9-affb6b18f13d@quicinc.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH] soc: qcom: socinfo: Add another ID for sc7180
2022-05-04 17:51 ` Doug Anderson
@ 2022-05-04 18:30 ` Bjorn Andersson
0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2022-05-04 18:30 UTC (permalink / raw)
To: Doug Anderson
Cc: Sai Prakash Ranjan, matvore, Andy Gross,
Reviewed-by : Stephen Boyd, LKML, linux-arm-msm
On Wed 04 May 10:51 PDT 2022, Doug Anderson wrote:
> Hi,
>
> On Wed, May 4, 2022 at 10:21 AM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > On Mon, 2 May 2022 17:33:45 -0700, Douglas Anderson wrote:
> > > It appears the some sc7180 devices, like the one in my
> > > sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
> > > another ID into the list.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [1/1] soc: qcom: socinfo: Add another ID for sc7180
> > commit: c35886d605604e0b03cdd835ae3249dc1fe0cc2a
>
> Hmm. Did you see the responses from Sai [1] about this? He seemed to
> indicate that there might be some issue here because he thought 407
> was supposed to be a different SoC. Are we sure we want to land this
> patch while we're sorting it out?
>
I stared at the thread but didn't see his reply for some reason.
Congrats on the getting the random SoC in your device ;) As this was the
top patch on drivers-for-5.19, I just popped that off and pushed the
branch again.
Let me know when you've figured the numbering out (and if it turns out
to be the mobile id I wouldn't mind carrying that in the table)
Regards,
Bjorn
> [1] https://lore.kernel.org/r/13819b2d-26f0-14f4-9cb9-affb6b18f13d@quicinc.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-04 18:38 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 0:33 [PATCH] soc: qcom: socinfo: Add another ID for sc7180 Douglas Anderson
2022-05-04 2:14 ` Sai Prakash Ranjan
2022-05-04 3:30 ` Doug Anderson
2022-05-04 10:52 ` Sai Prakash Ranjan
2022-05-04 17:20 ` patchwork-bot+linux-arm-msm
2022-05-04 17:21 ` (subset) " Bjorn Andersson
2022-05-04 17:51 ` Doug Anderson
2022-05-04 18:30 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.