* [PATCH v2 0/2] tools/configure: Add QEMU dependencies
@ 2015-01-15 21:06 Julien Grall
2015-01-15 21:06 ` [PATCH v2 1/2] tools/configure: Check if Glib is present only when building QEMU Julien Grall
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Julien Grall @ 2015-01-15 21:06 UTC (permalink / raw)
To: xen-devel
Cc: ian.jackson, Julien Grall, wei.liu2, ian.campbell, stefano.stabellini
Hello,
This small patch series replaces the patch [1] sent earlier.
Sincerely yours,
[1] https://patches.linaro.org/43077/
Julien Grall (2):
tools/configure: Check if Glib is present only when building QEMU
tools/configure: Check if pixman is present on the system when
building QEMU
tools/configure.ac | 5 +++++
1 file changed, 5 insertions(+)
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 1/2] tools/configure: Check if Glib is present only when building QEMU 2015-01-15 21:06 [PATCH v2 0/2] tools/configure: Add QEMU dependencies Julien Grall @ 2015-01-15 21:06 ` Julien Grall 2015-01-15 21:06 ` [PATCH v2 2/2] tools/configure: Check if pixman is present on the system " Julien Grall 2015-01-16 11:41 ` [PATCH v2 0/2] tools/configure: Add QEMU dependencies Ian Jackson 2 siblings, 0 replies; 8+ messages in thread From: Julien Grall @ 2015-01-15 21:06 UTC (permalink / raw) To: xen-devel Cc: ian.jackson, Julien Grall, wei.liu2, ian.campbell, stefano.stabellini Signed-off-by: Julien Grall <julien.grall@linaro.org> --- This patch requires to regenerate tools/configure Changes in v2: - Patch added --- tools/configure.ac | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/configure.ac b/tools/configure.ac index 72e2465..2aff18d 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -322,7 +322,11 @@ i[[3456]]86|x86_64) esac AX_CHECK_UUID AX_CHECK_CURSES + +dnl Glib 2.0 is only required when QEMU is built +AS_IF([test "x$qemu_xen" = "xy"], [ PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12]) +]) AX_CHECK_FETCHER # Checks for libraries. -- 2.1.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU 2015-01-15 21:06 [PATCH v2 0/2] tools/configure: Add QEMU dependencies Julien Grall 2015-01-15 21:06 ` [PATCH v2 1/2] tools/configure: Check if Glib is present only when building QEMU Julien Grall @ 2015-01-15 21:06 ` Julien Grall 2015-01-16 10:05 ` Ian Campbell 2015-01-16 11:41 ` [PATCH v2 0/2] tools/configure: Add QEMU dependencies Ian Jackson 2 siblings, 1 reply; 8+ messages in thread From: Julien Grall @ 2015-01-15 21:06 UTC (permalink / raw) To: xen-devel Cc: ian.jackson, Julien Grall, wei.liu2, ian.campbell, stefano.stabellini QEMU upstream requires the use of pixman. When pixman is not present the system, the configure of QEMU will fail with: ERROR: pixman not present. Your options: (1) Preferred: Install the pixman devel package (any recent distro should have packages as Xorg needs pixman too). (2) Fetch the pixman submodule, using: git submodule update --init pixman I think we can use by default the version on the system. So check it a Xen configuration time to avoid a build issue later. Signed-off-by: Julien Grall <julien.grall@linaro.org> --- This patch requires to regenerate tools/configure. Changes in v2: - Only check if pixman is present when building QEMU --- tools/configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/configure.ac b/tools/configure.ac index 2aff18d..64dc75c 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -323,9 +323,10 @@ esac AX_CHECK_UUID AX_CHECK_CURSES -dnl Glib 2.0 is only required when QEMU is built +dnl Glib 2.0 and pixman are only required when QEMU is built AS_IF([test "x$qemu_xen" = "xy"], [ PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12]) +PKG_CHECK_MODULES(pixman, pixman-1) ]) AX_CHECK_FETCHER -- 2.1.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU 2015-01-15 21:06 ` [PATCH v2 2/2] tools/configure: Check if pixman is present on the system " Julien Grall @ 2015-01-16 10:05 ` Ian Campbell 2015-01-16 11:43 ` Ian Jackson 2015-01-16 12:02 ` Julien Grall 0 siblings, 2 replies; 8+ messages in thread From: Ian Campbell @ 2015-01-16 10:05 UTC (permalink / raw) To: Julien Grall; +Cc: xen-devel, wei.liu2, ian.jackson, stefano.stabellini On Thu, 2015-01-15 at 21:06 +0000, Julien Grall wrote: > QEMU upstream requires the use of pixman. When pixman is not present the > system, the configure of QEMU will fail with: > > ERROR: pixman not present. Your options: > (1) Preferred: Install the pixman devel package (any recent > distro should have packages as Xorg needs pixman too). > (2) Fetch the pixman submodule, using: > git submodule update --init pixman > > I think we can use by default the version on the system. So check it > a Xen configuration time to avoid a build issue later. > > Signed-off-by: Julien Grall <julien.grall@linaro.org> > > --- > This patch requires to regenerate tools/configure. > > Changes in v2: > - Only check if pixman is present when building QEMU > --- > tools/configure.ac | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/configure.ac b/tools/configure.ac > index 2aff18d..64dc75c 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -323,9 +323,10 @@ esac > AX_CHECK_UUID > AX_CHECK_CURSES > > -dnl Glib 2.0 is only required when QEMU is built > +dnl Glib 2.0 and pixman are only required when QEMU is built Rather than an ever increasing list here I propose to say "The following are only...", and perhaps insert an "upstream" before QEMU, unless these are needed for trad too (in which case the condition isn't quite right). I think glib and pixman are only for upstream though. I can do that on commit though if you like. > AS_IF([test "x$qemu_xen" = "xy"], [ > PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12]) > +PKG_CHECK_MODULES(pixman, pixman-1) > ]) > AX_CHECK_FETCHER > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU 2015-01-16 10:05 ` Ian Campbell @ 2015-01-16 11:43 ` Ian Jackson 2015-01-16 12:02 ` Julien Grall 1 sibling, 0 replies; 8+ messages in thread From: Ian Jackson @ 2015-01-16 11:43 UTC (permalink / raw) To: Ian Campbell; +Cc: xen-devel, Julien Grall, wei.liu2, stefano.stabellini Ian Campbell writes ("Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU"): > On Thu, 2015-01-15 at 21:06 +0000, Julien Grall wrote: > > -dnl Glib 2.0 is only required when QEMU is built > > +dnl Glib 2.0 and pixman are only required when QEMU is built > > Rather than an ever increasing list here I propose to say "The following > are only...", and perhaps insert an "upstream" before QEMU, unless these > are needed for trad too (in which case the condition isn't quite right). > I think glib and pixman are only for upstream though. > > I can do that on commit though if you like. Either way is fine by me. Ian. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU 2015-01-16 10:05 ` Ian Campbell 2015-01-16 11:43 ` Ian Jackson @ 2015-01-16 12:02 ` Julien Grall 2015-01-19 17:01 ` Ian Campbell 1 sibling, 1 reply; 8+ messages in thread From: Julien Grall @ 2015-01-16 12:02 UTC (permalink / raw) To: Ian Campbell; +Cc: xen-devel, wei.liu2, ian.jackson, stefano.stabellini Hi Ian, On 16/01/15 10:05, Ian Campbell wrote: > On Thu, 2015-01-15 at 21:06 +0000, Julien Grall wrote: >> QEMU upstream requires the use of pixman. When pixman is not present the >> system, the configure of QEMU will fail with: >> >> ERROR: pixman not present. Your options: >> (1) Preferred: Install the pixman devel package (any recent >> distro should have packages as Xorg needs pixman too). >> (2) Fetch the pixman submodule, using: >> git submodule update --init pixman >> >> I think we can use by default the version on the system. So check it >> a Xen configuration time to avoid a build issue later. >> >> Signed-off-by: Julien Grall <julien.grall@linaro.org> >> >> --- >> This patch requires to regenerate tools/configure. >> >> Changes in v2: >> - Only check if pixman is present when building QEMU >> --- >> tools/configure.ac | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/configure.ac b/tools/configure.ac >> index 2aff18d..64dc75c 100644 >> --- a/tools/configure.ac >> +++ b/tools/configure.ac >> @@ -323,9 +323,10 @@ esac >> AX_CHECK_UUID >> AX_CHECK_CURSES >> >> -dnl Glib 2.0 is only required when QEMU is built >> +dnl Glib 2.0 and pixman are only required when QEMU is built > > Rather than an ever increasing list here I propose to say "The following > are only...", and perhaps insert an "upstream" before QEMU, unless these > are needed for trad too (in which case the condition isn't quite right). > I think glib and pixman are only for upstream though. Right. > I can do that on commit though if you like. Yes please. Regards, -- Julien Grall ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU 2015-01-16 12:02 ` Julien Grall @ 2015-01-19 17:01 ` Ian Campbell 0 siblings, 0 replies; 8+ messages in thread From: Ian Campbell @ 2015-01-19 17:01 UTC (permalink / raw) To: Julien Grall; +Cc: xen-devel, wei.liu2, ian.jackson, stefano.stabellini On Fri, 2015-01-16 at 12:02 +0000, Julien Grall wrote: > Hi Ian, > > On 16/01/15 10:05, Ian Campbell wrote: > > On Thu, 2015-01-15 at 21:06 +0000, Julien Grall wrote: > >> QEMU upstream requires the use of pixman. When pixman is not present the > >> system, the configure of QEMU will fail with: > >> > >> ERROR: pixman not present. Your options: > >> (1) Preferred: Install the pixman devel package (any recent > >> distro should have packages as Xorg needs pixman too). > >> (2) Fetch the pixman submodule, using: > >> git submodule update --init pixman > >> > >> I think we can use by default the version on the system. So check it > >> a Xen configuration time to avoid a build issue later. > >> > >> Signed-off-by: Julien Grall <julien.grall@linaro.org> > >> > >> --- > >> This patch requires to regenerate tools/configure. > >> > >> Changes in v2: > >> - Only check if pixman is present when building QEMU > >> --- > >> tools/configure.ac | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/tools/configure.ac b/tools/configure.ac > >> index 2aff18d..64dc75c 100644 > >> --- a/tools/configure.ac > >> +++ b/tools/configure.ac > >> @@ -323,9 +323,10 @@ esac > >> AX_CHECK_UUID > >> AX_CHECK_CURSES > >> > >> -dnl Glib 2.0 is only required when QEMU is built > >> +dnl Glib 2.0 and pixman are only required when QEMU is built > > > > Rather than an ever increasing list here I propose to say "The following > > are only...", and perhaps insert an "upstream" before QEMU, unless these > > are needed for trad too (in which case the condition isn't quite right). > > I think glib and pixman are only for upstream though. > > Right. > > > I can do that on commit though if you like. > Yes please. Applied and done, with Ian and my acks. I also reran autogen.sh after each patch. I happened to notice in the diff against configure: +Alternatively, you may set the environment variables pixman_CFLAGS +and pixman_LIBS to avoid the need to call pkg-config. +See the pkg-config man page for more details." "$LINENO" 5 I'm imagining this is true even though we don't use pixman ourselves, since we don't censor the envvars we pass to qemu's real configure. Assuming qemu uses pkg-config I suppose. I don't propose we need to do anything except keep this in mind if people start saying they were told to uxe pixman_CFLAGS and it didn't do what they has been told it would. Ian. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 0/2] tools/configure: Add QEMU dependencies 2015-01-15 21:06 [PATCH v2 0/2] tools/configure: Add QEMU dependencies Julien Grall 2015-01-15 21:06 ` [PATCH v2 1/2] tools/configure: Check if Glib is present only when building QEMU Julien Grall 2015-01-15 21:06 ` [PATCH v2 2/2] tools/configure: Check if pixman is present on the system " Julien Grall @ 2015-01-16 11:41 ` Ian Jackson 2 siblings, 0 replies; 8+ messages in thread From: Ian Jackson @ 2015-01-16 11:41 UTC (permalink / raw) To: Julien Grall; +Cc: xen-devel, wei.liu2, ian.campbell, stefano.stabellini Julien Grall writes ("[PATCH v2 0/2] tools/configure: Add QEMU dependencies"): > This small patch series replaces the patch [1] sent earlier. Both: Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Thanks, Ian. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-01-19 17:05 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-01-15 21:06 [PATCH v2 0/2] tools/configure: Add QEMU dependencies Julien Grall 2015-01-15 21:06 ` [PATCH v2 1/2] tools/configure: Check if Glib is present only when building QEMU Julien Grall 2015-01-15 21:06 ` [PATCH v2 2/2] tools/configure: Check if pixman is present on the system " Julien Grall 2015-01-16 10:05 ` Ian Campbell 2015-01-16 11:43 ` Ian Jackson 2015-01-16 12:02 ` Julien Grall 2015-01-19 17:01 ` Ian Campbell 2015-01-16 11:41 ` [PATCH v2 0/2] tools/configure: Add QEMU dependencies Ian Jackson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.