[v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

From: Igal Liberman <Igal.Liberman@freescale.com>

v3: Addressed feedback from Scott:
	- Removed clock specifier description.

v2: Addressed feedback from Scott:
	- Moved the "fman-clk-mux" clock provider details
	  under "clocks" property.

Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
---
 .../devicetree/bindings/clock/qoriq-clock.txt      |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
index b0d7b73..2bb3b38 100644
--- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
+++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
@@ -65,9 +65,10 @@ Required properties:
 		It takes parent's clock-frequency as its clock.
 	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
 	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
+	* "fsl,fman-clk-mux" for the Frame Manager clock.
 - #clock-cells: From common clock binding. The number of cells in a
-	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
-	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
+	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
+	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
 	For "fsl,qoriq-core-pll-1.0" clocks, the single
 	clock-specifier cell may take the following values:
 	* 0 - equal to the PLL frequency
@@ -145,6 +146,18 @@ Example for clock block and clock provider:
 			clocks = <&sysclk>;
 			clock-output-names = "platform-pll", "platform-pll-div2";
 		};
+
+		fm0clk: fm0-clk-mux {
+			#clock-cells = <0>;
+			reg = <0x10 4>
+			compatible = "fsl,fman-clk-mux";
+			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
+				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
+			clock-names = "pll0", "pll0-div2", "pll0-div3",
+				      "pll0-div4", "platform-pll", "pll1-div2",
+				      "pll1-div3";
+			clock-output-names = "fm0-clk";
+		};
 	};
 };
 
-- 
1.7.9.5

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

From: Igal Liberman <Igal.Liberman@freescale.com>

v3: Addressed feedback from Scott:
	- Removed clock specifier description.

v2: Addressed feedback from Scott:
	- Moved the "fman-clk-mux" clock provider details
	  under "clocks" property.

Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
---
 .../devicetree/bindings/clock/qoriq-clock.txt      |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
index b0d7b73..2bb3b38 100644
--- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
+++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
@@ -65,9 +65,10 @@ Required properties:
 		It takes parent's clock-frequency as its clock.
 	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
 	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
+	* "fsl,fman-clk-mux" for the Frame Manager clock.
 - #clock-cells: From common clock binding. The number of cells in a
-	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
-	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
+	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
+	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
 	For "fsl,qoriq-core-pll-1.0" clocks, the single
 	clock-specifier cell may take the following values:
 	* 0 - equal to the PLL frequency
@@ -145,6 +146,18 @@ Example for clock block and clock provider:
 			clocks = <&sysclk>;
 			clock-output-names = "platform-pll", "platform-pll-div2";
 		};
+
+		fm0clk: fm0-clk-mux {
+			#clock-cells = <0>;
+			reg = <0x10 4>
+			compatible = "fsl,fman-clk-mux";
+			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
+				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
+			clock-names = "pll0", "pll0-div2", "pll0-div3",
+				      "pll0-div4", "platform-pll", "pll1-div2",
+				      "pll1-div3";
+			clock-output-names = "fm0-clk";
+		};
 	};
 };
 
-- 
1.7.9.5

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> v3: Addressed feedback from Scott:
> 	- Removed clock specifier description.
> 
> v2: Addressed feedback from Scott:
> 	- Moved the "fman-clk-mux" clock provider details
> 	  under "clocks" property.
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  .../devicetree/bindings/clock/qoriq-clock.txt      |   17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> index b0d7b73..2bb3b38 100644
> --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> @@ -65,9 +65,10 @@ Required properties:
>  		It takes parent's clock-frequency as its clock.
>  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
>  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> +	* "fsl,fman-clk-mux" for the Frame Manager clock.
>  - #clock-cells: From common clock binding. The number of cells in a
> -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
> +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
>  	For "fsl,qoriq-core-pll-1.0" clocks, the single
>  	clock-specifier cell may take the following values:
>  	* 0 - equal to the PLL frequency
> @@ -145,6 +146,18 @@ Example for clock block and clock provider:
>  			clocks = <&sysclk>;
>  			clock-output-names = "platform-pll", "platform-pll-div2";
>  		};
> +
> +		fm0clk: fm0-clk-mux {
> +			#clock-cells = <0>;
> +			reg = <0x10 4>
> +			compatible = "fsl,fman-clk-mux";
> +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
> +				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
> +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> +				      "pll0-div4", "platform-pll", "pll1-div2",
> +				      "pll1-div3";
> +			clock-output-names = "fm0-clk";
> +		};
>  	};
>  };
>  

I don't see this register in the manuals for older DPAA chips, such as
p4080 or p3041.  Is it present but undocumented?  Should I be looking
somewhere other than "Clocking Memory Map"?

-Scott


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> v3: Addressed feedback from Scott:
> 	- Removed clock specifier description.
> 
> v2: Addressed feedback from Scott:
> 	- Moved the "fman-clk-mux" clock provider details
> 	  under "clocks" property.
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  .../devicetree/bindings/clock/qoriq-clock.txt      |   17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> index b0d7b73..2bb3b38 100644
> --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> @@ -65,9 +65,10 @@ Required properties:
>  		It takes parent's clock-frequency as its clock.
>  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
>  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> +	* "fsl,fman-clk-mux" for the Frame Manager clock.
>  - #clock-cells: From common clock binding. The number of cells in a
> -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
> +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
>  	For "fsl,qoriq-core-pll-1.0" clocks, the single
>  	clock-specifier cell may take the following values:
>  	* 0 - equal to the PLL frequency
> @@ -145,6 +146,18 @@ Example for clock block and clock provider:
>  			clocks = <&sysclk>;
>  			clock-output-names = "platform-pll", "platform-pll-div2";
>  		};
> +
> +		fm0clk: fm0-clk-mux {
> +			#clock-cells = <0>;
> +			reg = <0x10 4>
> +			compatible = "fsl,fman-clk-mux";
> +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
> +				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
> +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> +				      "pll0-div4", "platform-pll", "pll1-div2",
> +				      "pll1-div3";
> +			clock-output-names = "fm0-clk";
> +		};
>  	};
>  };
>  

I don't see this register in the manuals for older DPAA chips, such as
p4080 or p3041.  Is it present but undocumented?  Should I be looking
somewhere other than "Clocking Memory Map"?

-Scott

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman-KZfg59tc24xl57MIdRCFDg]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, April 15, 2015 8:36 PM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > From: Igal Liberman <Igal.Liberman@freescale.com>
> >
> > v3: Addressed feedback from Scott:
> > 	- Removed clock specifier description.
> >
> > v2: Addressed feedback from Scott:
> > 	- Moved the "fman-clk-mux" clock provider details
> > 	  under "clocks" property.
> >
> > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > ---
> >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17 +++++++++++++++--
> >  1 file changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > index b0d7b73..2bb3b38 100644
> > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > @@ -65,9 +65,10 @@ Required properties:
> >  		It takes parent's clock-frequency as its clock.
> >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> >  - #clock-cells: From common clock binding. The number of cells in a
> > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
> > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
> >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> >  	clock-specifier cell may take the following values:
> >  	* 0 - equal to the PLL frequency
> > @@ -145,6 +146,18 @@ Example for clock block and clock provider:
> >  			clocks = <&sysclk>;
> >  			clock-output-names = "platform-pll", "platform-pll-
> div2";
> >  		};
> > +
> > +		fm0clk: fm0-clk-mux {
> > +			#clock-cells = <0>;
> > +			reg = <0x10 4>
> > +			compatible = "fsl,fman-clk-mux";
> > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
> > +				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
> > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > +				      "pll0-div4", "platform-pll", "pll1-div2",
> > +				      "pll1-div3";
> > +			clock-output-names = "fm0-clk";
> > +		};
> >  	};
> >  };
> >
> 
> I don't see this register in the manuals for older DPAA chips, such as
> p4080 or p3041.  Is it present but undocumented?  Should I be looking
> somewhere other than "Clocking Memory Map"?
> 

It's available only in part of the new chips (T4, T2, B4).
In T1024/T1040 there's only one option for FMan clock so this register is not available.

> -Scott
> 

Igal.

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFdlZG5lc2RheSwgQXByaWwg
MTUsIDIwMTUgODozNiBQTQ0KPiBUbzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gQ2M6IGRldmlj
ZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBT
dWJqZWN0OiBSZTogW3YzXSBkdC9iaW5kaW5nczogcW9yaXEtY2xvY2s6IEFkZCBiaW5kaW5nIGZv
ciBGTWFuIGNsb2NrIG11eA0KPiANCj4gT24gVHVlLCAyMDE1LTA0LTE0IGF0IDEzOjU2ICswMzAw
LCBJZ2FsLkxpYmVybWFuIHdyb3RlOg0KPiA+IEZyb206IElnYWwgTGliZXJtYW4gPElnYWwuTGli
ZXJtYW5AZnJlZXNjYWxlLmNvbT4NCj4gPg0KPiA+IHYzOiBBZGRyZXNzZWQgZmVlZGJhY2sgZnJv
bSBTY290dDoNCj4gPiAJLSBSZW1vdmVkIGNsb2NrIHNwZWNpZmllciBkZXNjcmlwdGlvbi4NCj4g
Pg0KPiA+IHYyOiBBZGRyZXNzZWQgZmVlZGJhY2sgZnJvbSBTY290dDoNCj4gPiAJLSBNb3ZlZCB0
aGUgImZtYW4tY2xrLW11eCIgY2xvY2sgcHJvdmlkZXIgZGV0YWlscw0KPiA+IAkgIHVuZGVyICJj
bG9ja3MiIHByb3BlcnR5Lg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogSWdhbCBMaWJlcm1hbiA8
SWdhbC5MaWJlcm1hbkBmcmVlc2NhbGUuY29tPg0KPiA+IC0tLQ0KPiA+ICAuLi4vZGV2aWNldHJl
ZS9iaW5kaW5ncy9jbG9jay9xb3JpcS1jbG9jay50eHQgICAgICB8ICAgMTcgKysrKysrKysrKysr
KysrLS0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z
KC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp
bmdzL2Nsb2NrL3FvcmlxLWNsb2NrLnR4dA0KPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl
L2JpbmRpbmdzL2Nsb2NrL3FvcmlxLWNsb2NrLnR4dA0KPiA+IGluZGV4IGIwZDdiNzMuLjJiYjNi
MzggMTAwNjQ0DQo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Ns
b2NrL3FvcmlxLWNsb2NrLnR4dA0KPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i
aW5kaW5ncy9jbG9jay9xb3JpcS1jbG9jay50eHQNCj4gPiBAQCAtNjUsOSArNjUsMTAgQEAgUmVx
dWlyZWQgcHJvcGVydGllczoNCj4gPiAgCQlJdCB0YWtlcyBwYXJlbnQncyBjbG9jay1mcmVxdWVu
Y3kgYXMgaXRzIGNsb2NrLg0KPiA+ICAJKiAiZnNsLHFvcmlxLXBsYXRmb3JtLXBsbC0xLjAiIGZv
ciB0aGUgcGxhdGZvcm0gUExMIGNsb2NrICh2MS4wKQ0KPiA+ICAJKiAiZnNsLHFvcmlxLXBsYXRm
b3JtLXBsbC0yLjAiIGZvciB0aGUgcGxhdGZvcm0gUExMIGNsb2NrICh2Mi4wKQ0KPiA+ICsJKiAi
ZnNsLGZtYW4tY2xrLW11eCIgZm9yIHRoZSBGcmFtZSBNYW5hZ2VyIGNsb2NrLg0KPiA+ICAtICNj
bG9jay1jZWxsczogRnJvbSBjb21tb24gY2xvY2sgYmluZGluZy4gVGhlIG51bWJlciBvZiBjZWxs
cyBpbiBhDQo+ID4gLQljbG9jay1zcGVjaWZpZXIuIFNob3VsZCBiZSA8MD4gZm9yICJmc2wscW9y
aXEtc3lzY2xrLVsxLDJdLjAiDQo+ID4gLQljbG9ja3MsIG9yIDwxPiBmb3IgImZzbCxxb3JpcS1j
b3JlLXBsbC1bMSwyXS4wIiBjbG9ja3MuDQo+ID4gKwljbG9jay1zcGVjaWZpZXIuIFNob3VsZCBi
ZSA8MD4gZm9yICJmc2wscW9yaXEtc3lzY2xrLVsxLDJdLjAiIGFuZA0KPiA+ICsJImZzbCxmbWFu
LWNsay1tdXgiIGNsb2NrcyBvciA8MT4gZm9yICJmc2wscW9yaXEtY29yZS1wbGwtWzEsMl0uMCIu
DQo+ID4gIAlGb3IgImZzbCxxb3JpcS1jb3JlLXBsbC0xLjAiIGNsb2NrcywgdGhlIHNpbmdsZQ0K
PiA+ICAJY2xvY2stc3BlY2lmaWVyIGNlbGwgbWF5IHRha2UgdGhlIGZvbGxvd2luZyB2YWx1ZXM6
DQo+ID4gIAkqIDAgLSBlcXVhbCB0byB0aGUgUExMIGZyZXF1ZW5jeQ0KPiA+IEBAIC0xNDUsNiAr
MTQ2LDE4IEBAIEV4YW1wbGUgZm9yIGNsb2NrIGJsb2NrIGFuZCBjbG9jayBwcm92aWRlcjoNCj4g
PiAgCQkJY2xvY2tzID0gPCZzeXNjbGs+Ow0KPiA+ICAJCQljbG9jay1vdXRwdXQtbmFtZXMgPSAi
cGxhdGZvcm0tcGxsIiwgInBsYXRmb3JtLXBsbC0NCj4gZGl2MiI7DQo+ID4gIAkJfTsNCj4gPiAr
DQo+ID4gKwkJZm0wY2xrOiBmbTAtY2xrLW11eCB7DQo+ID4gKwkJCSNjbG9jay1jZWxscyA9IDww
PjsNCj4gPiArCQkJcmVnID0gPDB4MTAgND4NCj4gPiArCQkJY29tcGF0aWJsZSA9ICJmc2wsZm1h
bi1jbGstbXV4IjsNCj4gPiArCQkJY2xvY2tzID0gPCZwbGwwIDA+LCA8JnBsbDAgMT4sIDwmcGxs
MCAyPiwgPCZwbGwwIDM+LA0KPiA+ICsJCQkJIDwmcGxhdGZvcm1fcGxsIDA+LCA8JnBsbDEgMT4s
IDwmcGxsMSAyPjsNCj4gPiArCQkJY2xvY2stbmFtZXMgPSAicGxsMCIsICJwbGwwLWRpdjIiLCAi
cGxsMC1kaXYzIiwNCj4gPiArCQkJCSAgICAgICJwbGwwLWRpdjQiLCAicGxhdGZvcm0tcGxsIiwg
InBsbDEtZGl2MiIsDQo+ID4gKwkJCQkgICAgICAicGxsMS1kaXYzIjsNCj4gPiArCQkJY2xvY2st
b3V0cHV0LW5hbWVzID0gImZtMC1jbGsiOw0KPiA+ICsJCX07DQo+ID4gIAl9Ow0KPiA+ICB9Ow0K
PiA+DQo+IA0KPiBJIGRvbid0IHNlZSB0aGlzIHJlZ2lzdGVyIGluIHRoZSBtYW51YWxzIGZvciBv
bGRlciBEUEFBIGNoaXBzLCBzdWNoIGFzDQo+IHA0MDgwIG9yIHAzMDQxLiAgSXMgaXQgcHJlc2Vu
dCBidXQgdW5kb2N1bWVudGVkPyAgU2hvdWxkIEkgYmUgbG9va2luZw0KPiBzb21ld2hlcmUgb3Ro
ZXIgdGhhbiAiQ2xvY2tpbmcgTWVtb3J5IE1hcCI/DQo+IA0KDQpJdCdzIGF2YWlsYWJsZSBvbmx5
IGluIHBhcnQgb2YgdGhlIG5ldyBjaGlwcyAoVDQsIFQyLCBCNCkuDQpJbiBUMTAyNC9UMTA0MCB0
aGVyZSdzIG9ubHkgb25lIG9wdGlvbiBmb3IgRk1hbiBjbG9jayBzbyB0aGlzIHJlZ2lzdGVyIGlz
IG5vdCBhdmFpbGFibGUuDQoNCj4gLVNjb3R0DQo+IA0KDQpJZ2FsLg0KDQo=

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, April 15, 2015 8:36 PM
> > To: Liberman Igal-B31950
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > From: Igal Liberman <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > >
> > > v3: Addressed feedback from Scott:
> > > 	- Removed clock specifier description.
> > >
> > > v2: Addressed feedback from Scott:
> > > 	- Moved the "fman-clk-mux" clock provider details
> > > 	  under "clocks" property.
> > >
> > > Signed-off-by: Igal Liberman <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > ---
> > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17 +++++++++++++++--
> > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > index b0d7b73..2bb3b38 100644
> > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > @@ -65,9 +65,10 @@ Required properties:
> > >  		It takes parent's clock-frequency as its clock.
> > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > >  - #clock-cells: From common clock binding. The number of cells in a
> > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
> > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
> > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > >  	clock-specifier cell may take the following values:
> > >  	* 0 - equal to the PLL frequency
> > > @@ -145,6 +146,18 @@ Example for clock block and clock provider:
> > >  			clocks = <&sysclk>;
> > >  			clock-output-names = "platform-pll", "platform-pll-
> > div2";
> > >  		};
> > > +
> > > +		fm0clk: fm0-clk-mux {
> > > +			#clock-cells = <0>;
> > > +			reg = <0x10 4>
> > > +			compatible = "fsl,fman-clk-mux";
> > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
> > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
> > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > +				      "pll0-div4", "platform-pll", "pll1-div2",
> > > +				      "pll1-div3";
> > > +			clock-output-names = "fm0-clk";
> > > +		};
> > >  	};
> > >  };
> > >
> > 
> > I don't see this register in the manuals for older DPAA chips, such as
> > p4080 or p3041.  Is it present but undocumented?  Should I be looking
> > somewhere other than "Clocking Memory Map"?
> > 
> 
> It's available only in part of the new chips (T4, T2, B4).
> In T1024/T1040 there's only one option for FMan clock so this register is not available.

So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.  Who
knows what we may see in the future.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, April 15, 2015 8:36 PM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > >
> > > v3: Addressed feedback from Scott:
> > > 	- Removed clock specifier description.
> > >
> > > v2: Addressed feedback from Scott:
> > > 	- Moved the "fman-clk-mux" clock provider details
> > > 	  under "clocks" property.
> > >
> > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > ---
> > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17 +++++++++++++++--
> > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > index b0d7b73..2bb3b38 100644
> > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > @@ -65,9 +65,10 @@ Required properties:
> > >  		It takes parent's clock-frequency as its clock.
> > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > >  - #clock-cells: From common clock binding. The number of cells in a
> > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
> > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
> > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > >  	clock-specifier cell may take the following values:
> > >  	* 0 - equal to the PLL frequency
> > > @@ -145,6 +146,18 @@ Example for clock block and clock provider:
> > >  			clocks = <&sysclk>;
> > >  			clock-output-names = "platform-pll", "platform-pll-
> > div2";
> > >  		};
> > > +
> > > +		fm0clk: fm0-clk-mux {
> > > +			#clock-cells = <0>;
> > > +			reg = <0x10 4>
> > > +			compatible = "fsl,fman-clk-mux";
> > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
> > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
> > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > +				      "pll0-div4", "platform-pll", "pll1-div2",
> > > +				      "pll1-div3";
> > > +			clock-output-names = "fm0-clk";
> > > +		};
> > >  	};
> > >  };
> > >
> > 
> > I don't see this register in the manuals for older DPAA chips, such as
> > p4080 or p3041.  Is it present but undocumented?  Should I be looking
> > somewhere other than "Clocking Memory Map"?
> > 
> 
> It's available only in part of the new chips (T4, T2, B4).
> In T1024/T1040 there's only one option for FMan clock so this register is not available.

So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.  Who
knows what we may see in the future.

-Scott

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman-KZfg59tc24xl57MIdRCFDg]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, April 17, 2015 8:41 AM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> >
> >
> > Regards,
> > Igal Liberman.
> >
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > To: Liberman Igal-B31950
> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > clock mux
> > >
> > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > > >
> > > > v3: Addressed feedback from Scott:
> > > > 	- Removed clock specifier description.
> > > >
> > > > v2: Addressed feedback from Scott:
> > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > 	  under "clocks" property.
> > > >
> > > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > > ---
> > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> +++++++++++++++--
> > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > index b0d7b73..2bb3b38 100644
> > > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > @@ -65,9 +65,10 @@ Required properties:
> > > >  		It takes parent's clock-frequency as its clock.
> > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > >  - #clock-cells: From common clock binding. The number of cells in a
> > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
> > > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
> > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > >  	clock-specifier cell may take the following values:
> > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@ Example
> > > > for clock block and clock provider:
> > > >  			clocks = <&sysclk>;
> > > >  			clock-output-names = "platform-pll", "platform-pll-
> > > div2";
> > > >  		};
> > > > +
> > > > +		fm0clk: fm0-clk-mux {
> > > > +			#clock-cells = <0>;
> > > > +			reg = <0x10 4>
> > > > +			compatible = "fsl,fman-clk-mux";
> > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
> > > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
> > > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > > +				      "pll0-div4", "platform-pll", "pll1-div2",
> > > > +				      "pll1-div3";
> > > > +			clock-output-names = "fm0-clk";
> > > > +		};
> > > >  	};
> > > >  };
> > > >
> > >
> > > I don't see this register in the manuals for older DPAA chips, such
> > > as
> > > p4080 or p3041.  Is it present but undocumented?  Should I be
> > > looking somewhere other than "Clocking Memory Map"?
> > >
> >
> > It's available only in part of the new chips (T4, T2, B4).
> > In T1024/T1040 there's only one option for FMan clock so this register is not
> available.
> 
> So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.  Who knows what
> we may see in the future.
> 

OK,
We can go with "fsl,fman-clk-mux-1/2-0.".
In that case, we need to update FMan nodes and the clock driver:
https://patchwork.ozlabs.org/patch/443973/
https://patchwork.ozlabs.org/patch/461813/
I will update those patches separately.

> -Scott
> 

Igal

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IEZyaWRheSwgQXByaWwgMTcs
IDIwMTUgODo0MSBBTQ0KPiBUbzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gQ2M6IGRldmljZXRy
ZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJq
ZWN0OiBSZTogW3YzXSBkdC9iaW5kaW5nczogcW9yaXEtY2xvY2s6IEFkZCBiaW5kaW5nIGZvciBG
TWFuIGNsb2NrIG11eA0KPiANCj4gT24gVGh1LCAyMDE1LTA0LTE2IGF0IDAxOjExIC0wNTAwLCBM
aWJlcm1hbiBJZ2FsLUIzMTk1MCB3cm90ZToNCj4gPg0KPiA+DQo+ID4gUmVnYXJkcywNCj4gPiBJ
Z2FsIExpYmVybWFuLg0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+
ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+IFNlbnQ6IFdlZG5lc2RheSwgQXByaWwg
MTUsIDIwMTUgODozNiBQTQ0KPiA+ID4gVG86IExpYmVybWFuIElnYWwtQjMxOTUwDQo+ID4gPiBD
YzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMu
b3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogW3YzXSBkdC9iaW5kaW5nczogcW9yaXEtY2xvY2s6IEFk
ZCBiaW5kaW5nIGZvciBGTWFuDQo+ID4gPiBjbG9jayBtdXgNCj4gPiA+DQo+ID4gPiBPbiBUdWUs
IDIwMTUtMDQtMTQgYXQgMTM6NTYgKzAzMDAsIElnYWwuTGliZXJtYW4gd3JvdGU6DQo+ID4gPiA+
IEZyb206IElnYWwgTGliZXJtYW4gPElnYWwuTGliZXJtYW5AZnJlZXNjYWxlLmNvbT4NCj4gPiA+
ID4NCj4gPiA+ID4gdjM6IEFkZHJlc3NlZCBmZWVkYmFjayBmcm9tIFNjb3R0Og0KPiA+ID4gPiAJ
LSBSZW1vdmVkIGNsb2NrIHNwZWNpZmllciBkZXNjcmlwdGlvbi4NCj4gPiA+ID4NCj4gPiA+ID4g
djI6IEFkZHJlc3NlZCBmZWVkYmFjayBmcm9tIFNjb3R0Og0KPiA+ID4gPiAJLSBNb3ZlZCB0aGUg
ImZtYW4tY2xrLW11eCIgY2xvY2sgcHJvdmlkZXIgZGV0YWlscw0KPiA+ID4gPiAJICB1bmRlciAi
Y2xvY2tzIiBwcm9wZXJ0eS4NCj4gPiA+ID4NCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSWdhbCBM
aWJlcm1hbiA8SWdhbC5MaWJlcm1hbkBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiAtLS0NCj4gPiA+
ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3FvcmlxLWNsb2NrLnR4dCAgICAgIHwg
ICAxNw0KPiArKysrKysrKysrKysrKystLQ0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE1IGlu
c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+ID4gPiA+DQo+ID4gPiA+IGRpZmYgLS1naXQN
Cj4gPiA+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcW9yaXEt
Y2xvY2sudHh0DQo+ID4gPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Ns
b2NrL3FvcmlxLWNsb2NrLnR4dA0KPiA+ID4gPiBpbmRleCBiMGQ3YjczLi4yYmIzYjM4IDEwMDY0
NA0KPiA+ID4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2sv
cW9yaXEtY2xvY2sudHh0DQo+ID4gPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i
aW5kaW5ncy9jbG9jay9xb3JpcS1jbG9jay50eHQNCj4gPiA+ID4gQEAgLTY1LDkgKzY1LDEwIEBA
IFJlcXVpcmVkIHByb3BlcnRpZXM6DQo+ID4gPiA+ICAJCUl0IHRha2VzIHBhcmVudCdzIGNsb2Nr
LWZyZXF1ZW5jeSBhcyBpdHMgY2xvY2suDQo+ID4gPiA+ICAJKiAiZnNsLHFvcmlxLXBsYXRmb3Jt
LXBsbC0xLjAiIGZvciB0aGUgcGxhdGZvcm0gUExMIGNsb2NrICh2MS4wKQ0KPiA+ID4gPiAgCSog
ImZzbCxxb3JpcS1wbGF0Zm9ybS1wbGwtMi4wIiBmb3IgdGhlIHBsYXRmb3JtIFBMTCBjbG9jayAo
djIuMCkNCj4gPiA+ID4gKwkqICJmc2wsZm1hbi1jbGstbXV4IiBmb3IgdGhlIEZyYW1lIE1hbmFn
ZXIgY2xvY2suDQo+ID4gPiA+ICAtICNjbG9jay1jZWxsczogRnJvbSBjb21tb24gY2xvY2sgYmlu
ZGluZy4gVGhlIG51bWJlciBvZiBjZWxscyBpbiBhDQo+ID4gPiA+IC0JY2xvY2stc3BlY2lmaWVy
LiBTaG91bGQgYmUgPDA+IGZvciAiZnNsLHFvcmlxLXN5c2Nsay1bMSwyXS4wIg0KPiA+ID4gPiAt
CWNsb2Nrcywgb3IgPDE+IGZvciAiZnNsLHFvcmlxLWNvcmUtcGxsLVsxLDJdLjAiIGNsb2Nrcy4N
Cj4gPiA+ID4gKwljbG9jay1zcGVjaWZpZXIuIFNob3VsZCBiZSA8MD4gZm9yICJmc2wscW9yaXEt
c3lzY2xrLVsxLDJdLjAiIGFuZA0KPiA+ID4gPiArCSJmc2wsZm1hbi1jbGstbXV4IiBjbG9ja3Mg
b3IgPDE+IGZvciAiZnNsLHFvcmlxLWNvcmUtcGxsLVsxLDJdLjAiLg0KPiA+ID4gPiAgCUZvciAi
ZnNsLHFvcmlxLWNvcmUtcGxsLTEuMCIgY2xvY2tzLCB0aGUgc2luZ2xlDQo+ID4gPiA+ICAJY2xv
Y2stc3BlY2lmaWVyIGNlbGwgbWF5IHRha2UgdGhlIGZvbGxvd2luZyB2YWx1ZXM6DQo+ID4gPiA+
ICAJKiAwIC0gZXF1YWwgdG8gdGhlIFBMTCBmcmVxdWVuY3kgQEAgLTE0NSw2ICsxNDYsMTggQEAg
RXhhbXBsZQ0KPiA+ID4gPiBmb3IgY2xvY2sgYmxvY2sgYW5kIGNsb2NrIHByb3ZpZGVyOg0KPiA+
ID4gPiAgCQkJY2xvY2tzID0gPCZzeXNjbGs+Ow0KPiA+ID4gPiAgCQkJY2xvY2stb3V0cHV0LW5h
bWVzID0gInBsYXRmb3JtLXBsbCIsICJwbGF0Zm9ybS1wbGwtDQo+ID4gPiBkaXYyIjsNCj4gPiA+
ID4gIAkJfTsNCj4gPiA+ID4gKw0KPiA+ID4gPiArCQlmbTBjbGs6IGZtMC1jbGstbXV4IHsNCj4g
PiA+ID4gKwkJCSNjbG9jay1jZWxscyA9IDwwPjsNCj4gPiA+ID4gKwkJCXJlZyA9IDwweDEwIDQ+
DQo+ID4gPiA+ICsJCQljb21wYXRpYmxlID0gImZzbCxmbWFuLWNsay1tdXgiOw0KPiA+ID4gPiAr
CQkJY2xvY2tzID0gPCZwbGwwIDA+LCA8JnBsbDAgMT4sIDwmcGxsMCAyPiwgPCZwbGwwIDM+LA0K
PiA+ID4gPiArCQkJCSA8JnBsYXRmb3JtX3BsbCAwPiwgPCZwbGwxIDE+LCA8JnBsbDEgMj47DQo+
ID4gPiA+ICsJCQljbG9jay1uYW1lcyA9ICJwbGwwIiwgInBsbDAtZGl2MiIsICJwbGwwLWRpdjMi
LA0KPiA+ID4gPiArCQkJCSAgICAgICJwbGwwLWRpdjQiLCAicGxhdGZvcm0tcGxsIiwgInBsbDEt
ZGl2MiIsDQo+ID4gPiA+ICsJCQkJICAgICAgInBsbDEtZGl2MyI7DQo+ID4gPiA+ICsJCQljbG9j
ay1vdXRwdXQtbmFtZXMgPSAiZm0wLWNsayI7DQo+ID4gPiA+ICsJCX07DQo+ID4gPiA+ICAJfTsN
Cj4gPiA+ID4gIH07DQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gSSBkb24ndCBzZWUgdGhpcyByZWdp
c3RlciBpbiB0aGUgbWFudWFscyBmb3Igb2xkZXIgRFBBQSBjaGlwcywgc3VjaA0KPiA+ID4gYXMN
Cj4gPiA+IHA0MDgwIG9yIHAzMDQxLiAgSXMgaXQgcHJlc2VudCBidXQgdW5kb2N1bWVudGVkPyAg
U2hvdWxkIEkgYmUNCj4gPiA+IGxvb2tpbmcgc29tZXdoZXJlIG90aGVyIHRoYW4gIkNsb2NraW5n
IE1lbW9yeSBNYXAiPw0KPiA+ID4NCj4gPg0KPiA+IEl0J3MgYXZhaWxhYmxlIG9ubHkgaW4gcGFy
dCBvZiB0aGUgbmV3IGNoaXBzIChUNCwgVDIsIEI0KS4NCj4gPiBJbiBUMTAyNC9UMTA0MCB0aGVy
ZSdzIG9ubHkgb25lIG9wdGlvbiBmb3IgRk1hbiBjbG9jayBzbyB0aGlzIHJlZ2lzdGVyIGlzIG5v
dA0KPiBhdmFpbGFibGUuDQo+IA0KPiBTbyBpdCdzIHBhcnQgb2YgdGhlIDIuMCBjaGFzc2lzPyAg
SSdkIHN0aWNrIGEgMi4wIGluIHRoZXJlLCB0aGVuLiAgV2hvIGtub3dzIHdoYXQNCj4gd2UgbWF5
IHNlZSBpbiB0aGUgZnV0dXJlLg0KPiANCg0KT0ssDQpXZSBjYW4gZ28gd2l0aCAiZnNsLGZtYW4t
Y2xrLW11eC0xLzItMC4iLg0KSW4gdGhhdCBjYXNlLCB3ZSBuZWVkIHRvIHVwZGF0ZSBGTWFuIG5v
ZGVzIGFuZCB0aGUgY2xvY2sgZHJpdmVyOg0KaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9w
YXRjaC80NDM5NzMvDQpodHRwczovL3BhdGNod29yay5vemxhYnMub3JnL3BhdGNoLzQ2MTgxMy8N
Ckkgd2lsbCB1cGRhdGUgdGhvc2UgcGF0Y2hlcyBzZXBhcmF0ZWx5Lg0KDQo+IC1TY290dA0KPiAN
Cg0KSWdhbA0KDQo=

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman-KZfg59tc24xl57MIdRCFDg]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 5420 bytes --]



Regards,
Igal Liberman.

> -----Original Message-----
> From: Liberman Igal-B31950
> Sent: Monday, April 20, 2015 2:07 PM
> To: Wood Scott-B07421
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, April 17, 2015 8:41 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock
> > mux
> >
> > On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> > >
> > >
> > > Regards,
> > > Igal Liberman.
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > > To: Liberman Igal-B31950
> > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > > > >
> > > > > v3: Addressed feedback from Scott:
> > > > > 	- Removed clock specifier description.
> > > > >
> > > > > v2: Addressed feedback from Scott:
> > > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > > 	  under "clocks" property.
> > > > >
> > > > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > ---
> > > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> > +++++++++++++++--
> > > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > index b0d7b73..2bb3b38 100644
> > > > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > @@ -65,9 +65,10 @@ Required properties:
> > > > >  		It takes parent's clock-frequency as its clock.
> > > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock
> > > > > (v2.0)
> > > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > > >  - #clock-cells: From common clock binding. The number of cells in a
> > > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> and
> > > > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-
> [1,2].0".
> > > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > > >  	clock-specifier cell may take the following values:
> > > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@
> Example
> > > > > for clock block and clock provider:
> > > > >  			clocks = <&sysclk>;
> > > > >  			clock-output-names = "platform-pll",
> "platform-pll-
> > > > div2";
> > > > >  		};
> > > > > +
> > > > > +		fm0clk: fm0-clk-mux {
> > > > > +			#clock-cells = <0>;
> > > > > +			reg = <0x10 4>
> > > > > +			compatible = "fsl,fman-clk-mux";
> > > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> <&pll0 3>,
> > > > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1
> 2>;
> > > > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > > > +				      "pll0-div4", "platform-pll", "pll1-
> div2",
> > > > > +				      "pll1-div3";
> > > > > +			clock-output-names = "fm0-clk";
> > > > > +		};
> > > > >  	};
> > > > >  };
> > > > >
> > > >
> > > > I don't see this register in the manuals for older DPAA chips,
> > > > such as
> > > > p4080 or p3041.  Is it present but undocumented?  Should I be
> > > > looking somewhere other than "Clocking Memory Map"?
> > > >
> > >
> > > It's available only in part of the new chips (T4, T2, B4).
> > > In T1024/T1040 there's only one option for FMan clock so this
> > > register is not
> > available.
> >
> > So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.  Who
> > knows what we may see in the future.
> >
> 
> OK,
> We can go with "fsl,fman-clk-mux-1/2-0.".
> In that case, we need to update FMan nodes and the clock driver:
> https://patchwork.ozlabs.org/patch/443973/
> https://patchwork.ozlabs.org/patch/461813/
> I will update those patches separately.
> 

Scott,
There are 2 options:
Use "fsl,fman-clk-mux-1.0" for SoC without CLKCGnHWACSR register.
Use "fsl,fman-clk-mux-2.0" for SoC with CLKCGnHWACSR register.
Or
Use "fsl,fman-clk-mux-1.0" for SoC which support FMan V2 (Pxxxx)
Use "fsl,fman-clk-mux-2.0" for SoC which support FMan V3 (B/T)

Using the 1st option might be confusing because core pll/mux 2.0 represents B/T devices and 1.0 represent Pxxxx.
In this case, T1040 uses "fsl,qoriq-core-pll/mux-2.0" and "fsl,fman-clk-mux-1.0".
On the other hand, the second option doesn't distinguishes between T4 and T1 (for example), as T1 doesn't have reg property while T4 has.

What do you think?
 
> > -Scott
> >
> 
> Igal

Igal

N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·zøœzÚÞz)í…æèw*\x1fjg¬±¨\x1e¶‰šŽŠÝ¢j.ïÛ°\½½MŽúgjÌæa×\x02››–' ™©Þ¢¸\f¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾\a«‘êçzZ+ƒùšŽŠÝ¢j"ú!¶i

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IExpYmVybWFuIElnYWwtQjMxOTUwDQo+IFNlbnQ6IE1vbmRheSwgQXByaWwg
MjAsIDIwMTUgMjowNyBQTQ0KPiBUbzogV29vZCBTY290dC1CMDc0MjENCj4gQ2M6IGRldmljZXRy
ZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJq
ZWN0OiBSRTogW3YzXSBkdC9iaW5kaW5nczogcW9yaXEtY2xvY2s6IEFkZCBiaW5kaW5nIGZvciBG
TWFuIGNsb2NrIG11eA0KPiANCj4gDQo+IA0KPiBSZWdhcmRzLA0KPiBJZ2FsIExpYmVybWFuLg0K
PiANCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IFdvb2QgU2NvdHQt
QjA3NDIxDQo+ID4gU2VudDogRnJpZGF5LCBBcHJpbCAxNywgMjAxNSA4OjQxIEFNDQo+ID4gVG86
IExpYmVybWFuIElnYWwtQjMxOTUwDQo+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3Jn
OyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiA+IFN1YmplY3Q6IFJlOiBbdjNdIGR0
L2JpbmRpbmdzOiBxb3JpcS1jbG9jazogQWRkIGJpbmRpbmcgZm9yIEZNYW4gY2xvY2sNCj4gPiBt
dXgNCj4gPg0KPiA+IE9uIFRodSwgMjAxNS0wNC0xNiBhdCAwMToxMSAtMDUwMCwgTGliZXJtYW4g
SWdhbC1CMzE5NTAgd3JvdGU6DQo+ID4gPg0KPiA+ID4NCj4gPiA+IFJlZ2FyZHMsDQo+ID4gPiBJ
Z2FsIExpYmVybWFuLg0KPiA+ID4NCj4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N
Cj4gPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4gU2VudDogV2VkbmVzZGF5
LCBBcHJpbCAxNSwgMjAxNSA4OjM2IFBNDQo+ID4gPiA+IFRvOiBMaWJlcm1hbiBJZ2FsLUIzMTk1
MA0KPiA+ID4gPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBs
aXN0cy5vemxhYnMub3JnDQo+ID4gPiA+IFN1YmplY3Q6IFJlOiBbdjNdIGR0L2JpbmRpbmdzOiBx
b3JpcS1jbG9jazogQWRkIGJpbmRpbmcgZm9yIEZNYW4NCj4gPiA+ID4gY2xvY2sgbXV4DQo+ID4g
PiA+DQo+ID4gPiA+IE9uIFR1ZSwgMjAxNS0wNC0xNCBhdCAxMzo1NiArMDMwMCwgSWdhbC5MaWJl
cm1hbiB3cm90ZToNCj4gPiA+ID4gPiBGcm9tOiBJZ2FsIExpYmVybWFuIDxJZ2FsLkxpYmVybWFu
QGZyZWVzY2FsZS5jb20+DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiB2MzogQWRkcmVzc2VkIGZlZWRi
YWNrIGZyb20gU2NvdHQ6DQo+ID4gPiA+ID4gCS0gUmVtb3ZlZCBjbG9jayBzcGVjaWZpZXIgZGVz
Y3JpcHRpb24uDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiB2MjogQWRkcmVzc2VkIGZlZWRiYWNrIGZy
b20gU2NvdHQ6DQo+ID4gPiA+ID4gCS0gTW92ZWQgdGhlICJmbWFuLWNsay1tdXgiIGNsb2NrIHBy
b3ZpZGVyIGRldGFpbHMNCj4gPiA+ID4gPiAJICB1bmRlciAiY2xvY2tzIiBwcm9wZXJ0eS4NCj4g
PiA+ID4gPg0KPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IElnYWwgTGliZXJtYW4gPElnYWwuTGli
ZXJtYW5AZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4gPiAtLS0NCj4gPiA+ID4gPiAgLi4uL2Rldmlj
ZXRyZWUvYmluZGluZ3MvY2xvY2svcW9yaXEtY2xvY2sudHh0ICAgICAgfCAgIDE3DQo+ID4gKysr
KysrKysrKysrKysrLS0NCj4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMo
KyksIDIgZGVsZXRpb25zKC0pDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBkaWZmIC0tZ2l0DQo+ID4g
PiA+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcW9yaXEtY2xv
Y2sudHh0DQo+ID4gPiA+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xv
Y2svcW9yaXEtY2xvY2sudHh0DQo+ID4gPiA+ID4gaW5kZXggYjBkN2I3My4uMmJiM2IzOCAxMDA2
NDQNCj4gPiA+ID4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xv
Y2svcW9yaXEtY2xvY2sudHh0DQo+ID4gPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0
cmVlL2JpbmRpbmdzL2Nsb2NrL3FvcmlxLWNsb2NrLnR4dA0KPiA+ID4gPiA+IEBAIC02NSw5ICs2
NSwxMCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOg0KPiA+ID4gPiA+ICAJCUl0IHRha2VzIHBhcmVu
dCdzIGNsb2NrLWZyZXF1ZW5jeSBhcyBpdHMgY2xvY2suDQo+ID4gPiA+ID4gIAkqICJmc2wscW9y
aXEtcGxhdGZvcm0tcGxsLTEuMCIgZm9yIHRoZSBwbGF0Zm9ybSBQTEwgY2xvY2sgKHYxLjApDQo+
ID4gPiA+ID4gIAkqICJmc2wscW9yaXEtcGxhdGZvcm0tcGxsLTIuMCIgZm9yIHRoZSBwbGF0Zm9y
bSBQTEwgY2xvY2sNCj4gPiA+ID4gPiAodjIuMCkNCj4gPiA+ID4gPiArCSogImZzbCxmbWFuLWNs
ay1tdXgiIGZvciB0aGUgRnJhbWUgTWFuYWdlciBjbG9jay4NCj4gPiA+ID4gPiAgLSAjY2xvY2st
Y2VsbHM6IEZyb20gY29tbW9uIGNsb2NrIGJpbmRpbmcuIFRoZSBudW1iZXIgb2YgY2VsbHMgaW4g
YQ0KPiA+ID4gPiA+IC0JY2xvY2stc3BlY2lmaWVyLiBTaG91bGQgYmUgPDA+IGZvciAiZnNsLHFv
cmlxLXN5c2Nsay1bMSwyXS4wIg0KPiA+ID4gPiA+IC0JY2xvY2tzLCBvciA8MT4gZm9yICJmc2ws
cW9yaXEtY29yZS1wbGwtWzEsMl0uMCIgY2xvY2tzLg0KPiA+ID4gPiA+ICsJY2xvY2stc3BlY2lm
aWVyLiBTaG91bGQgYmUgPDA+IGZvciAiZnNsLHFvcmlxLXN5c2Nsay1bMSwyXS4wIg0KPiBhbmQN
Cj4gPiA+ID4gPiArCSJmc2wsZm1hbi1jbGstbXV4IiBjbG9ja3Mgb3IgPDE+IGZvciAiZnNsLHFv
cmlxLWNvcmUtcGxsLQ0KPiBbMSwyXS4wIi4NCj4gPiA+ID4gPiAgCUZvciAiZnNsLHFvcmlxLWNv
cmUtcGxsLTEuMCIgY2xvY2tzLCB0aGUgc2luZ2xlDQo+ID4gPiA+ID4gIAljbG9jay1zcGVjaWZp
ZXIgY2VsbCBtYXkgdGFrZSB0aGUgZm9sbG93aW5nIHZhbHVlczoNCj4gPiA+ID4gPiAgCSogMCAt
IGVxdWFsIHRvIHRoZSBQTEwgZnJlcXVlbmN5IEBAIC0xNDUsNiArMTQ2LDE4IEBADQo+IEV4YW1w
bGUNCj4gPiA+ID4gPiBmb3IgY2xvY2sgYmxvY2sgYW5kIGNsb2NrIHByb3ZpZGVyOg0KPiA+ID4g
PiA+ICAJCQljbG9ja3MgPSA8JnN5c2Nsaz47DQo+ID4gPiA+ID4gIAkJCWNsb2NrLW91dHB1dC1u
YW1lcyA9ICJwbGF0Zm9ybS1wbGwiLA0KPiAicGxhdGZvcm0tcGxsLQ0KPiA+ID4gPiBkaXYyIjsN
Cj4gPiA+ID4gPiAgCQl9Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArCQlmbTBjbGs6IGZtMC1j
bGstbXV4IHsNCj4gPiA+ID4gPiArCQkJI2Nsb2NrLWNlbGxzID0gPDA+Ow0KPiA+ID4gPiA+ICsJ
CQlyZWcgPSA8MHgxMCA0Pg0KPiA+ID4gPiA+ICsJCQljb21wYXRpYmxlID0gImZzbCxmbWFuLWNs
ay1tdXgiOw0KPiA+ID4gPiA+ICsJCQljbG9ja3MgPSA8JnBsbDAgMD4sIDwmcGxsMCAxPiwgPCZw
bGwwIDI+LA0KPiA8JnBsbDAgMz4sDQo+ID4gPiA+ID4gKwkJCQkgPCZwbGF0Zm9ybV9wbGwgMD4s
IDwmcGxsMSAxPiwgPCZwbGwxDQo+IDI+Ow0KPiA+ID4gPiA+ICsJCQljbG9jay1uYW1lcyA9ICJw
bGwwIiwgInBsbDAtZGl2MiIsICJwbGwwLWRpdjMiLA0KPiA+ID4gPiA+ICsJCQkJICAgICAgInBs
bDAtZGl2NCIsICJwbGF0Zm9ybS1wbGwiLCAicGxsMS0NCj4gZGl2MiIsDQo+ID4gPiA+ID4gKwkJ
CQkgICAgICAicGxsMS1kaXYzIjsNCj4gPiA+ID4gPiArCQkJY2xvY2stb3V0cHV0LW5hbWVzID0g
ImZtMC1jbGsiOw0KPiA+ID4gPiA+ICsJCX07DQo+ID4gPiA+ID4gIAl9Ow0KPiA+ID4gPiA+ICB9
Ow0KPiA+ID4gPiA+DQo+ID4gPiA+DQo+ID4gPiA+IEkgZG9uJ3Qgc2VlIHRoaXMgcmVnaXN0ZXIg
aW4gdGhlIG1hbnVhbHMgZm9yIG9sZGVyIERQQUEgY2hpcHMsDQo+ID4gPiA+IHN1Y2ggYXMNCj4g
PiA+ID4gcDQwODAgb3IgcDMwNDEuICBJcyBpdCBwcmVzZW50IGJ1dCB1bmRvY3VtZW50ZWQ/ICBT
aG91bGQgSSBiZQ0KPiA+ID4gPiBsb29raW5nIHNvbWV3aGVyZSBvdGhlciB0aGFuICJDbG9ja2lu
ZyBNZW1vcnkgTWFwIj8NCj4gPiA+ID4NCj4gPiA+DQo+ID4gPiBJdCdzIGF2YWlsYWJsZSBvbmx5
IGluIHBhcnQgb2YgdGhlIG5ldyBjaGlwcyAoVDQsIFQyLCBCNCkuDQo+ID4gPiBJbiBUMTAyNC9U
MTA0MCB0aGVyZSdzIG9ubHkgb25lIG9wdGlvbiBmb3IgRk1hbiBjbG9jayBzbyB0aGlzDQo+ID4g
PiByZWdpc3RlciBpcyBub3QNCj4gPiBhdmFpbGFibGUuDQo+ID4NCj4gPiBTbyBpdCdzIHBhcnQg
b2YgdGhlIDIuMCBjaGFzc2lzPyAgSSdkIHN0aWNrIGEgMi4wIGluIHRoZXJlLCB0aGVuLiAgV2hv
DQo+ID4ga25vd3Mgd2hhdCB3ZSBtYXkgc2VlIGluIHRoZSBmdXR1cmUuDQo+ID4NCj4gDQo+IE9L
LA0KPiBXZSBjYW4gZ28gd2l0aCAiZnNsLGZtYW4tY2xrLW11eC0xLzItMC4iLg0KPiBJbiB0aGF0
IGNhc2UsIHdlIG5lZWQgdG8gdXBkYXRlIEZNYW4gbm9kZXMgYW5kIHRoZSBjbG9jayBkcml2ZXI6
DQo+IGh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvNDQzOTczLw0KPiBodHRwczov
L3BhdGNod29yay5vemxhYnMub3JnL3BhdGNoLzQ2MTgxMy8NCj4gSSB3aWxsIHVwZGF0ZSB0aG9z
ZSBwYXRjaGVzIHNlcGFyYXRlbHkuDQo+IA0KDQpTY290dCwNClRoZXJlIGFyZSAyIG9wdGlvbnM6
DQpVc2UgImZzbCxmbWFuLWNsay1tdXgtMS4wIiBmb3IgU29DIHdpdGhvdXQgQ0xLQ0duSFdBQ1NS
IHJlZ2lzdGVyLg0KVXNlICJmc2wsZm1hbi1jbGstbXV4LTIuMCIgZm9yIFNvQyB3aXRoIENMS0NH
bkhXQUNTUiByZWdpc3Rlci4NCk9yDQpVc2UgImZzbCxmbWFuLWNsay1tdXgtMS4wIiBmb3IgU29D
IHdoaWNoIHN1cHBvcnQgRk1hbiBWMiAoUHh4eHgpDQpVc2UgImZzbCxmbWFuLWNsay1tdXgtMi4w
IiBmb3IgU29DIHdoaWNoIHN1cHBvcnQgRk1hbiBWMyAoQi9UKQ0KDQpVc2luZyB0aGUgMXN0IG9w
dGlvbiBtaWdodCBiZSBjb25mdXNpbmcgYmVjYXVzZSBjb3JlIHBsbC9tdXggMi4wIHJlcHJlc2Vu
dHMgQi9UIGRldmljZXMgYW5kIDEuMCByZXByZXNlbnQgUHh4eHguDQpJbiB0aGlzIGNhc2UsIFQx
MDQwIHVzZXMgImZzbCxxb3JpcS1jb3JlLXBsbC9tdXgtMi4wIiBhbmQgImZzbCxmbWFuLWNsay1t
dXgtMS4wIi4NCk9uIHRoZSBvdGhlciBoYW5kLCB0aGUgc2Vjb25kIG9wdGlvbiBkb2Vzbid0IGRp
c3Rpbmd1aXNoZXMgYmV0d2VlbiBUNCBhbmQgVDEgKGZvciBleGFtcGxlKSwgYXMgVDEgZG9lc24n
dCBoYXZlIHJlZyBwcm9wZXJ0eSB3aGlsZSBUNCBoYXMuDQoNCldoYXQgZG8geW91IHRoaW5rPw0K
IA0KPiA+IC1TY290dA0KPiA+DQo+IA0KPiBJZ2FsDQoNCklnYWwNCg0K

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Mon, 2015-04-20 at 06:40 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Liberman Igal-B31950
> > Sent: Monday, April 20, 2015 2:07 PM
> > To: Wood Scott-B07421
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > 
> > 
> > Regards,
> > Igal Liberman.
> > 
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Friday, April 17, 2015 8:41 AM
> > > To: Liberman Igal-B31950
> > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock
> > > mux
> > >
> > > On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> > > >
> > > >
> > > > Regards,
> > > > Igal Liberman.
> > > >
> > > > > -----Original Message-----
> > > > > From: Wood Scott-B07421
> > > > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > > > To: Liberman Igal-B31950
> > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > > clock mux
> > > > >
> > > > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > > > From: Igal Liberman <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > > > >
> > > > > > v3: Addressed feedback from Scott:
> > > > > > 	- Removed clock specifier description.
> > > > > >
> > > > > > v2: Addressed feedback from Scott:
> > > > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > > > 	  under "clocks" property.
> > > > > >
> > > > > > Signed-off-by: Igal Liberman <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > > > > ---
> > > > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> > > +++++++++++++++--
> > > > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > index b0d7b73..2bb3b38 100644
> > > > > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > @@ -65,9 +65,10 @@ Required properties:
> > > > > >  		It takes parent's clock-frequency as its clock.
> > > > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock
> > > > > > (v2.0)
> > > > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > > > >  - #clock-cells: From common clock binding. The number of cells in a
> > > > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > and
> > > > > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-
> > [1,2].0".
> > > > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > > > >  	clock-specifier cell may take the following values:
> > > > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@
> > Example
> > > > > > for clock block and clock provider:
> > > > > >  			clocks = <&sysclk>;
> > > > > >  			clock-output-names = "platform-pll",
> > "platform-pll-
> > > > > div2";
> > > > > >  		};
> > > > > > +
> > > > > > +		fm0clk: fm0-clk-mux {
> > > > > > +			#clock-cells = <0>;
> > > > > > +			reg = <0x10 4>
> > > > > > +			compatible = "fsl,fman-clk-mux";
> > > > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> > <&pll0 3>,
> > > > > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1
> > 2>;
> > > > > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > > > > +				      "pll0-div4", "platform-pll", "pll1-
> > div2",
> > > > > > +				      "pll1-div3";
> > > > > > +			clock-output-names = "fm0-clk";
> > > > > > +		};
> > > > > >  	};
> > > > > >  };
> > > > > >
> > > > >
> > > > > I don't see this register in the manuals for older DPAA chips,
> > > > > such as
> > > > > p4080 or p3041.  Is it present but undocumented?  Should I be
> > > > > looking somewhere other than "Clocking Memory Map"?
> > > > >
> > > >
> > > > It's available only in part of the new chips (T4, T2, B4).
> > > > In T1024/T1040 there's only one option for FMan clock so this
> > > > register is not
> > > available.
> > >
> > > So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.  Who
> > > knows what we may see in the future.
> > >
> > 
> > OK,
> > We can go with "fsl,fman-clk-mux-1/2-0.".
> > In that case, we need to update FMan nodes and the clock driver:
> > https://patchwork.ozlabs.org/patch/443973/
> > https://patchwork.ozlabs.org/patch/461813/
> > I will update those patches separately.
> > 
> 
> Scott,
> There are 2 options:
> Use "fsl,fman-clk-mux-1.0" for SoC without CLKCGnHWACSR register.
> Use "fsl,fman-clk-mux-2.0" for SoC with CLKCGnHWACSR register.
> Or
> Use "fsl,fman-clk-mux-1.0" for SoC which support FMan V2 (Pxxxx)
> Use "fsl,fman-clk-mux-2.0" for SoC which support FMan V3 (B/T)

1.0/2.0 in the clockgen node refers to chassis version.  It has nothing
to do with FMan version.

In fact, fman should not be in the compatible because, now that I found
the documentation for this, I see that it's more generic than that.
"fman-clk-mux" should be replaced with "qoriq-hwacsr".

> Using the 1st option might be confusing because core pll/mux 2.0 represents B/T devices and 1.0 represent Pxxxx.
> In this case, T1040 uses "fsl,qoriq-core-pll/mux-2.0" and "fsl,fman-clk-mux-1.0".
> On the other hand, the second option doesn't distinguishes between T4 and T1 (for example), as T1 doesn't have reg property while T4 has.

How would t1040 have a so-called "fman-clk-mux" node at all if it
doesn't have this register?

I think we've made a mess of the clock bindings and this is only going
to make it worse.  We need to stay compatible with the mess we've made,
but I'm inclined to say that we shouldn't add more nodes to it.  

Instead, have the toplevel clockgen node have a chip-based compatible in
addition to version (e.g. compatible = "fsl,t4240-clockgen",
"fsl,qoriq-clockgen-2.0") and have the toplevel node export whatever
clocks are needed.  Put the logic to deal with all the different
dividers, register values, and such in code, not the device tree.  The
binding should be focused on how to encode the specifier of the exported
clocks.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Mon, 2015-04-20 at 06:40 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Liberman Igal-B31950
> > Sent: Monday, April 20, 2015 2:07 PM
> > To: Wood Scott-B07421
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > 
> > 
> > Regards,
> > Igal Liberman.
> > 
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Friday, April 17, 2015 8:41 AM
> > > To: Liberman Igal-B31950
> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock
> > > mux
> > >
> > > On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> > > >
> > > >
> > > > Regards,
> > > > Igal Liberman.
> > > >
> > > > > -----Original Message-----
> > > > > From: Wood Scott-B07421
> > > > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > > > To: Liberman Igal-B31950
> > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > > clock mux
> > > > >
> > > > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > >
> > > > > > v3: Addressed feedback from Scott:
> > > > > > 	- Removed clock specifier description.
> > > > > >
> > > > > > v2: Addressed feedback from Scott:
> > > > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > > > 	  under "clocks" property.
> > > > > >
> > > > > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > > ---
> > > > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> > > +++++++++++++++--
> > > > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > index b0d7b73..2bb3b38 100644
> > > > > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > @@ -65,9 +65,10 @@ Required properties:
> > > > > >  		It takes parent's clock-frequency as its clock.
> > > > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock
> > > > > > (v2.0)
> > > > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > > > >  - #clock-cells: From common clock binding. The number of cells in a
> > > > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > and
> > > > > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-
> > [1,2].0".
> > > > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > > > >  	clock-specifier cell may take the following values:
> > > > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@
> > Example
> > > > > > for clock block and clock provider:
> > > > > >  			clocks = <&sysclk>;
> > > > > >  			clock-output-names = "platform-pll",
> > "platform-pll-
> > > > > div2";
> > > > > >  		};
> > > > > > +
> > > > > > +		fm0clk: fm0-clk-mux {
> > > > > > +			#clock-cells = <0>;
> > > > > > +			reg = <0x10 4>
> > > > > > +			compatible = "fsl,fman-clk-mux";
> > > > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> > <&pll0 3>,
> > > > > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1
> > 2>;
> > > > > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > > > > +				      "pll0-div4", "platform-pll", "pll1-
> > div2",
> > > > > > +				      "pll1-div3";
> > > > > > +			clock-output-names = "fm0-clk";
> > > > > > +		};
> > > > > >  	};
> > > > > >  };
> > > > > >
> > > > >
> > > > > I don't see this register in the manuals for older DPAA chips,
> > > > > such as
> > > > > p4080 or p3041.  Is it present but undocumented?  Should I be
> > > > > looking somewhere other than "Clocking Memory Map"?
> > > > >
> > > >
> > > > It's available only in part of the new chips (T4, T2, B4).
> > > > In T1024/T1040 there's only one option for FMan clock so this
> > > > register is not
> > > available.
> > >
> > > So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.  Who
> > > knows what we may see in the future.
> > >
> > 
> > OK,
> > We can go with "fsl,fman-clk-mux-1/2-0.".
> > In that case, we need to update FMan nodes and the clock driver:
> > https://patchwork.ozlabs.org/patch/443973/
> > https://patchwork.ozlabs.org/patch/461813/
> > I will update those patches separately.
> > 
> 
> Scott,
> There are 2 options:
> Use "fsl,fman-clk-mux-1.0" for SoC without CLKCGnHWACSR register.
> Use "fsl,fman-clk-mux-2.0" for SoC with CLKCGnHWACSR register.
> Or
> Use "fsl,fman-clk-mux-1.0" for SoC which support FMan V2 (Pxxxx)
> Use "fsl,fman-clk-mux-2.0" for SoC which support FMan V3 (B/T)

1.0/2.0 in the clockgen node refers to chassis version.  It has nothing
to do with FMan version.

In fact, fman should not be in the compatible because, now that I found
the documentation for this, I see that it's more generic than that.
"fman-clk-mux" should be replaced with "qoriq-hwacsr".

> Using the 1st option might be confusing because core pll/mux 2.0 represents B/T devices and 1.0 represent Pxxxx.
> In this case, T1040 uses "fsl,qoriq-core-pll/mux-2.0" and "fsl,fman-clk-mux-1.0".
> On the other hand, the second option doesn't distinguishes between T4 and T1 (for example), as T1 doesn't have reg property while T4 has.

How would t1040 have a so-called "fman-clk-mux" node at all if it
doesn't have this register?

I think we've made a mess of the clock bindings and this is only going
to make it worse.  We need to stay compatible with the mess we've made,
but I'm inclined to say that we shouldn't add more nodes to it.  

Instead, have the toplevel clockgen node have a chip-based compatible in
addition to version (e.g. compatible = "fsl,t4240-clockgen",
"fsl,qoriq-clockgen-2.0") and have the toplevel node export whatever
clocks are needed.  Put the logic to deal with all the different
dividers, register values, and such in code, not the device tree.  The
binding should be focused on how to encode the specifier of the exported
clocks.

-Scott

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman-KZfg59tc24xl57MIdRCFDg]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, April 21, 2015 3:52 AM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> Yuantian-B29983
> Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> On Mon, 2015-04-20 at 06:40 -0500, Liberman Igal-B31950 wrote:
> >
> >
> > Regards,
> > Igal Liberman.
> >
> > > -----Original Message-----
> > > From: Liberman Igal-B31950
> > > Sent: Monday, April 20, 2015 2:07 PM
> > > To: Wood Scott-B07421
> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > clock mux
> > >
> > >
> > >
> > > Regards,
> > > Igal Liberman.
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Friday, April 17, 2015 8:41 AM
> > > > To: Liberman Igal-B31950
> > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > > On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> > > > >
> > > > >
> > > > > Regards,
> > > > > Igal Liberman.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > > > > To: Liberman Igal-B31950
> > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for
> > > > > > FMan clock mux
> > > > > >
> > > > > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > > > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > > >
> > > > > > > v3: Addressed feedback from Scott:
> > > > > > > 	- Removed clock specifier description.
> > > > > > >
> > > > > > > v2: Addressed feedback from Scott:
> > > > > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > > > > 	  under "clocks" property.
> > > > > > >
> > > > > > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > > > ---
> > > > > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> > > > +++++++++++++++--
> > > > > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > > > >
> > > > > > > diff --git
> > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > index b0d7b73..2bb3b38 100644
> > > > > > > ---
> > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.tx
> > > > > > > +++ t
> > > > > > > @@ -65,9 +65,10 @@ Required properties:
> > > > > > >  		It takes parent's clock-frequency as its clock.
> > > > > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > > > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock
> > > > > > > (v2.0)
> > > > > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > > > > >  - #clock-cells: From common clock binding. The number of cells in
> a
> > > > > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > and
> > > > > > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-
> > > [1,2].0".
> > > > > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > > > > >  	clock-specifier cell may take the following values:
> > > > > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@
> > > Example
> > > > > > > for clock block and clock provider:
> > > > > > >  			clocks = <&sysclk>;
> > > > > > >  			clock-output-names = "platform-pll",
> > > "platform-pll-
> > > > > > div2";
> > > > > > >  		};
> > > > > > > +
> > > > > > > +		fm0clk: fm0-clk-mux {
> > > > > > > +			#clock-cells = <0>;
> > > > > > > +			reg = <0x10 4>
> > > > > > > +			compatible = "fsl,fman-clk-mux";
> > > > > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> > > <&pll0 3>,
> > > > > > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1
> > > 2>;
> > > > > > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > > > > > +				      "pll0-div4", "platform-pll", "pll1-
> > > div2",
> > > > > > > +				      "pll1-div3";
> > > > > > > +			clock-output-names = "fm0-clk";
> > > > > > > +		};
> > > > > > >  	};
> > > > > > >  };
> > > > > > >
> > > > > >
> > > > > > I don't see this register in the manuals for older DPAA chips,
> > > > > > such as
> > > > > > p4080 or p3041.  Is it present but undocumented?  Should I be
> > > > > > looking somewhere other than "Clocking Memory Map"?
> > > > > >
> > > > >
> > > > > It's available only in part of the new chips (T4, T2, B4).
> > > > > In T1024/T1040 there's only one option for FMan clock so this
> > > > > register is not
> > > > available.
> > > >
> > > > So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.
> > > > Who knows what we may see in the future.
> > > >
> > >
> > > OK,
> > > We can go with "fsl,fman-clk-mux-1/2-0.".
> > > In that case, we need to update FMan nodes and the clock driver:
> > > https://patchwork.ozlabs.org/patch/443973/
> > > https://patchwork.ozlabs.org/patch/461813/
> > > I will update those patches separately.
> > >
> >
> > Scott,
> > There are 2 options:
> > Use "fsl,fman-clk-mux-1.0" for SoC without CLKCGnHWACSR register.
> > Use "fsl,fman-clk-mux-2.0" for SoC with CLKCGnHWACSR register.
> > Or
> > Use "fsl,fman-clk-mux-1.0" for SoC which support FMan V2 (Pxxxx) Use
> > "fsl,fman-clk-mux-2.0" for SoC which support FMan V3 (B/T)
> 
> 1.0/2.0 in the clockgen node refers to chassis version.  It has nothing to do
> with FMan version.
> 

I know. However there's a match: 1.0 chassis used in SoC with FMan v2 and 2.0 chassis in SoC with FMan v3.

> In fact, fman should not be in the compatible because, now that I found the
> documentation for this, I see that it's more generic than that.
> "fman-clk-mux" should be replaced with "qoriq-hwacsr".
> 
> > Using the 1st option might be confusing because core pll/mux 2.0
> represents B/T devices and 1.0 represent Pxxxx.
> > In this case, T1040 uses "fsl,qoriq-core-pll/mux-2.0" and "fsl,fman-clk-mux-
> 1.0".
> > On the other hand, the second option doesn't distinguishes between T4
> and T1 (for example), as T1 doesn't have reg property while T4 has.
> 
> How would t1040 have a so-called "fman-clk-mux" node at all if it doesn't
> have this register?
> 
> I think we've made a mess of the clock bindings and this is only going to make
> it worse.  We need to stay compatible with the mess we've made, but I'm
> inclined to say that we shouldn't add more nodes to it.
> 
> Instead, have the toplevel clockgen node have a chip-based compatible in
> addition to version (e.g. compatible = "fsl,t4240-clockgen",
> "fsl,qoriq-clockgen-2.0") and have the toplevel node export whatever clocks
> are needed.  Put the logic to deal with all the different dividers, register
> values, and such in code, not the device tree.  The binding should be focused
> on how to encode the specifier of the exported clocks.
> 

We have 2 cases:
	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx devices have many options, T1 has only one option)

For the first group, we can have " qoriq-hwacsr" property in the clock node.
Currently T4 FMan clock mux node is the following:
	fm1clk: fm1-clk-mux {
		#clock-cells = <0>;
		compatible = "fsl,fman-clk-mux";
		clocks = <&pll1 1>, <&pll1 2>, <&pll1 3>,
			 <&platform_pll 0>, <&pll0 1>, <&pll0 2>;
		clock-names = "pll1-div2", "pll1-div3", "pll1-div4",
			      "platform-pll", "pll0-div2", "pll0-div3";
		clock-output-names = "fm1-clk";
	};
As far as I understand we need to move the node to the top level clock node.
In addition we need to add reg property and change the name of the node and the compatible.
In that case, the driver can read this register instead of parsing the RCW.

What about the devices of the second group?
In this case we don't have a register to determine the source clock. So we need access to guts registers, like we have currently.
The suggestion above doesn’t suit for those devices. 

> -Scott
> 

Igal

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFR1ZXNkYXksIEFwcmlsIDIx
LCAyMDE1IDM6NTIgQU0NCj4gVG86IExpYmVybWFuIElnYWwtQjMxOTUwDQo+IENjOiBkZXZpY2V0
cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IFRhbmcN
Cj4gWXVhbnRpYW4tQjI5OTgzDQo+IFN1YmplY3Q6IFJlOiBbdjNdIGR0L2JpbmRpbmdzOiBxb3Jp
cS1jbG9jazogQWRkIGJpbmRpbmcgZm9yIEZNYW4gY2xvY2sgbXV4DQo+IA0KPiBPbiBNb24sIDIw
MTUtMDQtMjAgYXQgMDY6NDAgLTA1MDAsIExpYmVybWFuIElnYWwtQjMxOTUwIHdyb3RlOg0KPiA+
DQo+ID4NCj4gPiBSZWdhcmRzLA0KPiA+IElnYWwgTGliZXJtYW4uDQo+ID4NCj4gPiA+IC0tLS0t
T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBMaWJlcm1hbiBJZ2FsLUIzMTk1MA0K
PiA+ID4gU2VudDogTW9uZGF5LCBBcHJpbCAyMCwgMjAxNSAyOjA3IFBNDQo+ID4gPiBUbzogV29v
ZCBTY290dC1CMDc0MjENCj4gPiA+IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGlu
dXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcNCj4gPiA+IFN1YmplY3Q6IFJFOiBbdjNdIGR0L2Jp
bmRpbmdzOiBxb3JpcS1jbG9jazogQWRkIGJpbmRpbmcgZm9yIEZNYW4NCj4gPiA+IGNsb2NrIG11
eA0KPiA+ID4NCj4gPiA+DQo+ID4gPg0KPiA+ID4gUmVnYXJkcywNCj4gPiA+IElnYWwgTGliZXJt
YW4uDQo+ID4gPg0KPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiBG
cm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gPiBTZW50OiBGcmlkYXksIEFwcmlsIDE3LCAy
MDE1IDg6NDEgQU0NCj4gPiA+ID4gVG86IExpYmVybWFuIElnYWwtQjMxOTUwDQo+ID4gPiA+IENj
OiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5v
cmcNCj4gPiA+ID4gU3ViamVjdDogUmU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlxLWNsb2NrOiBB
ZGQgYmluZGluZyBmb3IgRk1hbg0KPiA+ID4gPiBjbG9jayBtdXgNCj4gPiA+ID4NCj4gPiA+ID4g
T24gVGh1LCAyMDE1LTA0LTE2IGF0IDAxOjExIC0wNTAwLCBMaWJlcm1hbiBJZ2FsLUIzMTk1MCB3
cm90ZToNCj4gPiA+ID4gPg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gUmVnYXJkcywNCj4gPiA+ID4g
PiBJZ2FsIExpYmVybWFuLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1l
c3NhZ2UtLS0tLQ0KPiA+ID4gPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4g
PiA+IFNlbnQ6IFdlZG5lc2RheSwgQXByaWwgMTUsIDIwMTUgODozNiBQTQ0KPiA+ID4gPiA+ID4g
VG86IExpYmVybWFuIElnYWwtQjMxOTUwDQo+ID4gPiA+ID4gPiBDYzogZGV2aWNldHJlZUB2Z2Vy
Lmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+ID4gPiA+ID4gPiBT
dWJqZWN0OiBSZTogW3YzXSBkdC9iaW5kaW5nczogcW9yaXEtY2xvY2s6IEFkZCBiaW5kaW5nIGZv
cg0KPiA+ID4gPiA+ID4gRk1hbiBjbG9jayBtdXgNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBP
biBUdWUsIDIwMTUtMDQtMTQgYXQgMTM6NTYgKzAzMDAsIElnYWwuTGliZXJtYW4gd3JvdGU6DQo+
ID4gPiA+ID4gPiA+IEZyb206IElnYWwgTGliZXJtYW4gPElnYWwuTGliZXJtYW5AZnJlZXNjYWxl
LmNvbT4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gdjM6IEFkZHJlc3NlZCBmZWVkYmFj
ayBmcm9tIFNjb3R0Og0KPiA+ID4gPiA+ID4gPiAJLSBSZW1vdmVkIGNsb2NrIHNwZWNpZmllciBk
ZXNjcmlwdGlvbi4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gdjI6IEFkZHJlc3NlZCBm
ZWVkYmFjayBmcm9tIFNjb3R0Og0KPiA+ID4gPiA+ID4gPiAJLSBNb3ZlZCB0aGUgImZtYW4tY2xr
LW11eCIgY2xvY2sgcHJvdmlkZXIgZGV0YWlscw0KPiA+ID4gPiA+ID4gPiAJICB1bmRlciAiY2xv
Y2tzIiBwcm9wZXJ0eS4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1i
eTogSWdhbCBMaWJlcm1hbiA8SWdhbC5MaWJlcm1hbkBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+
ID4gPiAtLS0NCj4gPiA+ID4gPiA+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3Fv
cmlxLWNsb2NrLnR4dCAgICAgIHwgICAxNw0KPiA+ID4gPiArKysrKysrKysrKysrKystLQ0KPiA+
ID4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z
KC0pDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQNCj4gPiA+ID4gPiA+
ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcW9yaXEtY2xvY2su
dHh0DQo+ID4gPiA+ID4gPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Ns
b2NrL3FvcmlxLWNsb2NrLnR4dA0KPiA+ID4gPiA+ID4gPiBpbmRleCBiMGQ3YjczLi4yYmIzYjM4
IDEwMDY0NA0KPiA+ID4gPiA+ID4gPiAtLS0NCj4gPiA+ID4gPiA+ID4gYS9Eb2N1bWVudGF0aW9u
L2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcW9yaXEtY2xvY2sudHh0DQo+ID4gPiA+ID4gPiA+
ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9xb3JpcS1jbG9j
ay50eA0KPiA+ID4gPiA+ID4gPiArKysgdA0KPiA+ID4gPiA+ID4gPiBAQCAtNjUsOSArNjUsMTAg
QEAgUmVxdWlyZWQgcHJvcGVydGllczoNCj4gPiA+ID4gPiA+ID4gIAkJSXQgdGFrZXMgcGFyZW50
J3MgY2xvY2stZnJlcXVlbmN5IGFzIGl0cyBjbG9jay4NCj4gPiA+ID4gPiA+ID4gIAkqICJmc2ws
cW9yaXEtcGxhdGZvcm0tcGxsLTEuMCIgZm9yIHRoZSBwbGF0Zm9ybSBQTEwgY2xvY2sgKHYxLjAp
DQo+ID4gPiA+ID4gPiA+ICAJKiAiZnNsLHFvcmlxLXBsYXRmb3JtLXBsbC0yLjAiIGZvciB0aGUg
cGxhdGZvcm0gUExMIGNsb2NrDQo+ID4gPiA+ID4gPiA+ICh2Mi4wKQ0KPiA+ID4gPiA+ID4gPiAr
CSogImZzbCxmbWFuLWNsay1tdXgiIGZvciB0aGUgRnJhbWUgTWFuYWdlciBjbG9jay4NCj4gPiA+
ID4gPiA+ID4gIC0gI2Nsb2NrLWNlbGxzOiBGcm9tIGNvbW1vbiBjbG9jayBiaW5kaW5nLiBUaGUg
bnVtYmVyIG9mIGNlbGxzIGluDQo+IGENCj4gPiA+ID4gPiA+ID4gLQljbG9jay1zcGVjaWZpZXIu
IFNob3VsZCBiZSA8MD4gZm9yICJmc2wscW9yaXEtc3lzY2xrLVsxLDJdLjAiDQo+ID4gPiA+ID4g
PiA+IC0JY2xvY2tzLCBvciA8MT4gZm9yICJmc2wscW9yaXEtY29yZS1wbGwtWzEsMl0uMCIgY2xv
Y2tzLg0KPiA+ID4gPiA+ID4gPiArCWNsb2NrLXNwZWNpZmllci4gU2hvdWxkIGJlIDwwPiBmb3Ig
ImZzbCxxb3JpcS1zeXNjbGstWzEsMl0uMCINCj4gPiA+IGFuZA0KPiA+ID4gPiA+ID4gPiArCSJm
c2wsZm1hbi1jbGstbXV4IiBjbG9ja3Mgb3IgPDE+IGZvciAiZnNsLHFvcmlxLWNvcmUtcGxsLQ0K
PiA+ID4gWzEsMl0uMCIuDQo+ID4gPiA+ID4gPiA+ICAJRm9yICJmc2wscW9yaXEtY29yZS1wbGwt
MS4wIiBjbG9ja3MsIHRoZSBzaW5nbGUNCj4gPiA+ID4gPiA+ID4gIAljbG9jay1zcGVjaWZpZXIg
Y2VsbCBtYXkgdGFrZSB0aGUgZm9sbG93aW5nIHZhbHVlczoNCj4gPiA+ID4gPiA+ID4gIAkqIDAg
LSBlcXVhbCB0byB0aGUgUExMIGZyZXF1ZW5jeSBAQCAtMTQ1LDYgKzE0NiwxOCBAQA0KPiA+ID4g
RXhhbXBsZQ0KPiA+ID4gPiA+ID4gPiBmb3IgY2xvY2sgYmxvY2sgYW5kIGNsb2NrIHByb3ZpZGVy
Og0KPiA+ID4gPiA+ID4gPiAgCQkJY2xvY2tzID0gPCZzeXNjbGs+Ow0KPiA+ID4gPiA+ID4gPiAg
CQkJY2xvY2stb3V0cHV0LW5hbWVzID0gInBsYXRmb3JtLXBsbCIsDQo+ID4gPiAicGxhdGZvcm0t
cGxsLQ0KPiA+ID4gPiA+ID4gZGl2MiI7DQo+ID4gPiA+ID4gPiA+ICAJCX07DQo+ID4gPiA+ID4g
PiA+ICsNCj4gPiA+ID4gPiA+ID4gKwkJZm0wY2xrOiBmbTAtY2xrLW11eCB7DQo+ID4gPiA+ID4g
PiA+ICsJCQkjY2xvY2stY2VsbHMgPSA8MD47DQo+ID4gPiA+ID4gPiA+ICsJCQlyZWcgPSA8MHgx
MCA0Pg0KPiA+ID4gPiA+ID4gPiArCQkJY29tcGF0aWJsZSA9ICJmc2wsZm1hbi1jbGstbXV4IjsN
Cj4gPiA+ID4gPiA+ID4gKwkJCWNsb2NrcyA9IDwmcGxsMCAwPiwgPCZwbGwwIDE+LCA8JnBsbDAg
Mj4sDQo+ID4gPiA8JnBsbDAgMz4sDQo+ID4gPiA+ID4gPiA+ICsJCQkJIDwmcGxhdGZvcm1fcGxs
IDA+LCA8JnBsbDEgMT4sIDwmcGxsMQ0KPiA+ID4gMj47DQo+ID4gPiA+ID4gPiA+ICsJCQljbG9j
ay1uYW1lcyA9ICJwbGwwIiwgInBsbDAtZGl2MiIsICJwbGwwLWRpdjMiLA0KPiA+ID4gPiA+ID4g
PiArCQkJCSAgICAgICJwbGwwLWRpdjQiLCAicGxhdGZvcm0tcGxsIiwgInBsbDEtDQo+ID4gPiBk
aXYyIiwNCj4gPiA+ID4gPiA+ID4gKwkJCQkgICAgICAicGxsMS1kaXYzIjsNCj4gPiA+ID4gPiA+
ID4gKwkJCWNsb2NrLW91dHB1dC1uYW1lcyA9ICJmbTAtY2xrIjsNCj4gPiA+ID4gPiA+ID4gKwkJ
fTsNCj4gPiA+ID4gPiA+ID4gIAl9Ow0KPiA+ID4gPiA+ID4gPiAgfTsNCj4gPiA+ID4gPiA+ID4N
Cj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBJIGRvbid0IHNlZSB0aGlzIHJlZ2lzdGVyIGluIHRo
ZSBtYW51YWxzIGZvciBvbGRlciBEUEFBIGNoaXBzLA0KPiA+ID4gPiA+ID4gc3VjaCBhcw0KPiA+
ID4gPiA+ID4gcDQwODAgb3IgcDMwNDEuICBJcyBpdCBwcmVzZW50IGJ1dCB1bmRvY3VtZW50ZWQ/
ICBTaG91bGQgSSBiZQ0KPiA+ID4gPiA+ID4gbG9va2luZyBzb21ld2hlcmUgb3RoZXIgdGhhbiAi
Q2xvY2tpbmcgTWVtb3J5IE1hcCI/DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4g
SXQncyBhdmFpbGFibGUgb25seSBpbiBwYXJ0IG9mIHRoZSBuZXcgY2hpcHMgKFQ0LCBUMiwgQjQp
Lg0KPiA+ID4gPiA+IEluIFQxMDI0L1QxMDQwIHRoZXJlJ3Mgb25seSBvbmUgb3B0aW9uIGZvciBG
TWFuIGNsb2NrIHNvIHRoaXMNCj4gPiA+ID4gPiByZWdpc3RlciBpcyBub3QNCj4gPiA+ID4gYXZh
aWxhYmxlLg0KPiA+ID4gPg0KPiA+ID4gPiBTbyBpdCdzIHBhcnQgb2YgdGhlIDIuMCBjaGFzc2lz
PyAgSSdkIHN0aWNrIGEgMi4wIGluIHRoZXJlLCB0aGVuLg0KPiA+ID4gPiBXaG8ga25vd3Mgd2hh
dCB3ZSBtYXkgc2VlIGluIHRoZSBmdXR1cmUuDQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gT0ssDQo+
ID4gPiBXZSBjYW4gZ28gd2l0aCAiZnNsLGZtYW4tY2xrLW11eC0xLzItMC4iLg0KPiA+ID4gSW4g
dGhhdCBjYXNlLCB3ZSBuZWVkIHRvIHVwZGF0ZSBGTWFuIG5vZGVzIGFuZCB0aGUgY2xvY2sgZHJp
dmVyOg0KPiA+ID4gaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC80NDM5NzMvDQo+
ID4gPiBodHRwczovL3BhdGNod29yay5vemxhYnMub3JnL3BhdGNoLzQ2MTgxMy8NCj4gPiA+IEkg
d2lsbCB1cGRhdGUgdGhvc2UgcGF0Y2hlcyBzZXBhcmF0ZWx5Lg0KPiA+ID4NCj4gPg0KPiA+IFNj
b3R0LA0KPiA+IFRoZXJlIGFyZSAyIG9wdGlvbnM6DQo+ID4gVXNlICJmc2wsZm1hbi1jbGstbXV4
LTEuMCIgZm9yIFNvQyB3aXRob3V0IENMS0NHbkhXQUNTUiByZWdpc3Rlci4NCj4gPiBVc2UgImZz
bCxmbWFuLWNsay1tdXgtMi4wIiBmb3IgU29DIHdpdGggQ0xLQ0duSFdBQ1NSIHJlZ2lzdGVyLg0K
PiA+IE9yDQo+ID4gVXNlICJmc2wsZm1hbi1jbGstbXV4LTEuMCIgZm9yIFNvQyB3aGljaCBzdXBw
b3J0IEZNYW4gVjIgKFB4eHh4KSBVc2UNCj4gPiAiZnNsLGZtYW4tY2xrLW11eC0yLjAiIGZvciBT
b0Mgd2hpY2ggc3VwcG9ydCBGTWFuIFYzIChCL1QpDQo+IA0KPiAxLjAvMi4wIGluIHRoZSBjbG9j
a2dlbiBub2RlIHJlZmVycyB0byBjaGFzc2lzIHZlcnNpb24uICBJdCBoYXMgbm90aGluZyB0byBk
bw0KPiB3aXRoIEZNYW4gdmVyc2lvbi4NCj4gDQoNCkkga25vdy4gSG93ZXZlciB0aGVyZSdzIGEg
bWF0Y2g6IDEuMCBjaGFzc2lzIHVzZWQgaW4gU29DIHdpdGggRk1hbiB2MiBhbmQgMi4wIGNoYXNz
aXMgaW4gU29DIHdpdGggRk1hbiB2My4NCg0KPiBJbiBmYWN0LCBmbWFuIHNob3VsZCBub3QgYmUg
aW4gdGhlIGNvbXBhdGlibGUgYmVjYXVzZSwgbm93IHRoYXQgSSBmb3VuZCB0aGUNCj4gZG9jdW1l
bnRhdGlvbiBmb3IgdGhpcywgSSBzZWUgdGhhdCBpdCdzIG1vcmUgZ2VuZXJpYyB0aGFuIHRoYXQu
DQo+ICJmbWFuLWNsay1tdXgiIHNob3VsZCBiZSByZXBsYWNlZCB3aXRoICJxb3JpcS1od2Fjc3Ii
Lg0KPiANCj4gPiBVc2luZyB0aGUgMXN0IG9wdGlvbiBtaWdodCBiZSBjb25mdXNpbmcgYmVjYXVz
ZSBjb3JlIHBsbC9tdXggMi4wDQo+IHJlcHJlc2VudHMgQi9UIGRldmljZXMgYW5kIDEuMCByZXBy
ZXNlbnQgUHh4eHguDQo+ID4gSW4gdGhpcyBjYXNlLCBUMTA0MCB1c2VzICJmc2wscW9yaXEtY29y
ZS1wbGwvbXV4LTIuMCIgYW5kICJmc2wsZm1hbi1jbGstbXV4LQ0KPiAxLjAiLg0KPiA+IE9uIHRo
ZSBvdGhlciBoYW5kLCB0aGUgc2Vjb25kIG9wdGlvbiBkb2Vzbid0IGRpc3Rpbmd1aXNoZXMgYmV0
d2VlbiBUNA0KPiBhbmQgVDEgKGZvciBleGFtcGxlKSwgYXMgVDEgZG9lc24ndCBoYXZlIHJlZyBw
cm9wZXJ0eSB3aGlsZSBUNCBoYXMuDQo+IA0KPiBIb3cgd291bGQgdDEwNDAgaGF2ZSBhIHNvLWNh
bGxlZCAiZm1hbi1jbGstbXV4IiBub2RlIGF0IGFsbCBpZiBpdCBkb2Vzbid0DQo+IGhhdmUgdGhp
cyByZWdpc3Rlcj8NCj4gDQo+IEkgdGhpbmsgd2UndmUgbWFkZSBhIG1lc3Mgb2YgdGhlIGNsb2Nr
IGJpbmRpbmdzIGFuZCB0aGlzIGlzIG9ubHkgZ29pbmcgdG8gbWFrZQ0KPiBpdCB3b3JzZS4gIFdl
IG5lZWQgdG8gc3RheSBjb21wYXRpYmxlIHdpdGggdGhlIG1lc3Mgd2UndmUgbWFkZSwgYnV0IEkn
bQ0KPiBpbmNsaW5lZCB0byBzYXkgdGhhdCB3ZSBzaG91bGRuJ3QgYWRkIG1vcmUgbm9kZXMgdG8g
aXQuDQo+IA0KPiBJbnN0ZWFkLCBoYXZlIHRoZSB0b3BsZXZlbCBjbG9ja2dlbiBub2RlIGhhdmUg
YSBjaGlwLWJhc2VkIGNvbXBhdGlibGUgaW4NCj4gYWRkaXRpb24gdG8gdmVyc2lvbiAoZS5nLiBj
b21wYXRpYmxlID0gImZzbCx0NDI0MC1jbG9ja2dlbiIsDQo+ICJmc2wscW9yaXEtY2xvY2tnZW4t
Mi4wIikgYW5kIGhhdmUgdGhlIHRvcGxldmVsIG5vZGUgZXhwb3J0IHdoYXRldmVyIGNsb2Nrcw0K
PiBhcmUgbmVlZGVkLiAgUHV0IHRoZSBsb2dpYyB0byBkZWFsIHdpdGggYWxsIHRoZSBkaWZmZXJl
bnQgZGl2aWRlcnMsIHJlZ2lzdGVyDQo+IHZhbHVlcywgYW5kIHN1Y2ggaW4gY29kZSwgbm90IHRo
ZSBkZXZpY2UgdHJlZS4gIFRoZSBiaW5kaW5nIHNob3VsZCBiZSBmb2N1c2VkDQo+IG9uIGhvdyB0
byBlbmNvZGUgdGhlIHNwZWNpZmllciBvZiB0aGUgZXhwb3J0ZWQgY2xvY2tzLg0KPiANCg0KV2Ug
aGF2ZSAyIGNhc2VzOg0KCS0gRGV2aWNlcyAoVDIvVDQvQjQpIHdpdGggQ0xLQ0cxSFdBQ1NSIHJl
Z2lzdGVyLg0KCS0gRGV2aWNlcyAoUHh4eHgsIFQxKSB3aXRob3V0IENMS0NHMUhXQUNTUiByZWdp
c3RlciAoUHh4eHggZGV2aWNlcyBoYXZlIG1hbnkgb3B0aW9ucywgVDEgaGFzIG9ubHkgb25lIG9w
dGlvbikNCg0KRm9yIHRoZSBmaXJzdCBncm91cCwgd2UgY2FuIGhhdmUgIiBxb3JpcS1od2Fjc3Ii
IHByb3BlcnR5IGluIHRoZSBjbG9jayBub2RlLg0KQ3VycmVudGx5IFQ0IEZNYW4gY2xvY2sgbXV4
IG5vZGUgaXMgdGhlIGZvbGxvd2luZzoNCglmbTFjbGs6IGZtMS1jbGstbXV4IHsNCgkJI2Nsb2Nr
LWNlbGxzID0gPDA+Ow0KCQljb21wYXRpYmxlID0gImZzbCxmbWFuLWNsay1tdXgiOw0KCQljbG9j
a3MgPSA8JnBsbDEgMT4sIDwmcGxsMSAyPiwgPCZwbGwxIDM+LA0KCQkJIDwmcGxhdGZvcm1fcGxs
IDA+LCA8JnBsbDAgMT4sIDwmcGxsMCAyPjsNCgkJY2xvY2stbmFtZXMgPSAicGxsMS1kaXYyIiwg
InBsbDEtZGl2MyIsICJwbGwxLWRpdjQiLA0KCQkJICAgICAgInBsYXRmb3JtLXBsbCIsICJwbGww
LWRpdjIiLCAicGxsMC1kaXYzIjsNCgkJY2xvY2stb3V0cHV0LW5hbWVzID0gImZtMS1jbGsiOw0K
CX07DQpBcyBmYXIgYXMgSSB1bmRlcnN0YW5kIHdlIG5lZWQgdG8gbW92ZSB0aGUgbm9kZSB0byB0
aGUgdG9wIGxldmVsIGNsb2NrIG5vZGUuDQpJbiBhZGRpdGlvbiB3ZSBuZWVkIHRvIGFkZCByZWcg
cHJvcGVydHkgYW5kIGNoYW5nZSB0aGUgbmFtZSBvZiB0aGUgbm9kZSBhbmQgdGhlIGNvbXBhdGli
bGUuDQpJbiB0aGF0IGNhc2UsIHRoZSBkcml2ZXIgY2FuIHJlYWQgdGhpcyByZWdpc3RlciBpbnN0
ZWFkIG9mIHBhcnNpbmcgdGhlIFJDVy4NCg0KV2hhdCBhYm91dCB0aGUgZGV2aWNlcyBvZiB0aGUg
c2Vjb25kIGdyb3VwPw0KSW4gdGhpcyBjYXNlIHdlIGRvbid0IGhhdmUgYSByZWdpc3RlciB0byBk
ZXRlcm1pbmUgdGhlIHNvdXJjZSBjbG9jay4gU28gd2UgbmVlZCBhY2Nlc3MgdG8gZ3V0cyByZWdp
c3RlcnMsIGxpa2Ugd2UgaGF2ZSBjdXJyZW50bHkuDQpUaGUgc3VnZ2VzdGlvbiBhYm92ZSBkb2Vz
buKAmXQgc3VpdCBmb3IgdGhvc2UgZGV2aWNlcy4gDQoNCj4gLVNjb3R0DQo+IA0KDQpJZ2FsDQoN
Cg==

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, April 21, 2015 3:52 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Tang
> > Yuantian-B29983
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Mon, 2015-04-20 at 06:40 -0500, Liberman Igal-B31950 wrote:
> > >
> > >
> > > Regards,
> > > Igal Liberman.
> > >
> > > > -----Original Message-----
> > > > From: Liberman Igal-B31950
> > > > Sent: Monday, April 20, 2015 2:07 PM
> > > > To: Wood Scott-B07421
> > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > > > Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > >
> > > >
> > > > Regards,
> > > > Igal Liberman.
> > > >
> > > > > -----Original Message-----
> > > > > From: Wood Scott-B07421
> > > > > Sent: Friday, April 17, 2015 8:41 AM
> > > > > To: Liberman Igal-B31950
> > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > > clock mux
> > > > >
> > > > > On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> > > > > >
> > > > > >
> > > > > > Regards,
> > > > > > Igal Liberman.
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Wood Scott-B07421
> > > > > > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > > > > > To: Liberman Igal-B31950
> > > > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlazAvgg39JiuA@public.gmane.org.org
> > > > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for
> > > > > > > FMan clock mux
> > > > > > >
> > > > > > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > > > > > From: Igal Liberman <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > > > > > >
> > > > > > > > v3: Addressed feedback from Scott:
> > > > > > > > 	- Removed clock specifier description.
> > > > > > > >
> > > > > > > > v2: Addressed feedback from Scott:
> > > > > > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > > > > > 	  under "clocks" property.
> > > > > > > >
> > > > > > > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > > > > ---
> > > > > > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> > > > > +++++++++++++++--
> > > > > > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > > > > >
> > > > > > > > diff --git
> > > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > > index b0d7b73..2bb3b38 100644
> > > > > > > > ---
> > > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.tx
> > > > > > > > +++ t
> > > > > > > > @@ -65,9 +65,10 @@ Required properties:
> > > > > > > >  		It takes parent's clock-frequency as its clock.
> > > > > > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > > > > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock
> > > > > > > > (v2.0)
> > > > > > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > > > > > >  - #clock-cells: From common clock binding. The number of cells in
> > a
> > > > > > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > > > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > > > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > and
> > > > > > > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-
> > > > [1,2].0".
> > > > > > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > > > > > >  	clock-specifier cell may take the following values:
> > > > > > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@
> > > > Example
> > > > > > > > for clock block and clock provider:
> > > > > > > >  			clocks = <&sysclk>;
> > > > > > > >  			clock-output-names = "platform-pll",
> > > > "platform-pll-
> > > > > > > div2";
> > > > > > > >  		};
> > > > > > > > +
> > > > > > > > +		fm0clk: fm0-clk-mux {
> > > > > > > > +			#clock-cells = <0>;
> > > > > > > > +			reg = <0x10 4>
> > > > > > > > +			compatible = "fsl,fman-clk-mux";
> > > > > > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> > > > <&pll0 3>,
> > > > > > > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1
> > > > 2>;
> > > > > > > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > > > > > > +				      "pll0-div4", "platform-pll", "pll1-
> > > > div2",
> > > > > > > > +				      "pll1-div3";
> > > > > > > > +			clock-output-names = "fm0-clk";
> > > > > > > > +		};
> > > > > > > >  	};
> > > > > > > >  };
> > > > > > > >
> > > > > > >
> > > > > > > I don't see this register in the manuals for older DPAA chips,
> > > > > > > such as
> > > > > > > p4080 or p3041.  Is it present but undocumented?  Should I be
> > > > > > > looking somewhere other than "Clocking Memory Map"?
> > > > > > >
> > > > > >
> > > > > > It's available only in part of the new chips (T4, T2, B4).
> > > > > > In T1024/T1040 there's only one option for FMan clock so this
> > > > > > register is not
> > > > > available.
> > > > >
> > > > > So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.
> > > > > Who knows what we may see in the future.
> > > > >
> > > >
> > > > OK,
> > > > We can go with "fsl,fman-clk-mux-1/2-0.".
> > > > In that case, we need to update FMan nodes and the clock driver:
> > > > https://patchwork.ozlabs.org/patch/443973/
> > > > https://patchwork.ozlabs.org/patch/461813/
> > > > I will update those patches separately.
> > > >
> > >
> > > Scott,
> > > There are 2 options:
> > > Use "fsl,fman-clk-mux-1.0" for SoC without CLKCGnHWACSR register.
> > > Use "fsl,fman-clk-mux-2.0" for SoC with CLKCGnHWACSR register.
> > > Or
> > > Use "fsl,fman-clk-mux-1.0" for SoC which support FMan V2 (Pxxxx) Use
> > > "fsl,fman-clk-mux-2.0" for SoC which support FMan V3 (B/T)
> > 
> > 1.0/2.0 in the clockgen node refers to chassis version.  It has nothing to do
> > with FMan version.
> > 
> 
> I know. However there's a match: 1.0 chassis used in SoC with FMan v2 and 2.0 chassis in SoC with FMan v3.
> 
> > In fact, fman should not be in the compatible because, now that I found the
> > documentation for this, I see that it's more generic than that.
> > "fman-clk-mux" should be replaced with "qoriq-hwacsr".
> > 
> > > Using the 1st option might be confusing because core pll/mux 2.0
> > represents B/T devices and 1.0 represent Pxxxx.
> > > In this case, T1040 uses "fsl,qoriq-core-pll/mux-2.0" and "fsl,fman-clk-mux-
> > 1.0".
> > > On the other hand, the second option doesn't distinguishes between T4
> > and T1 (for example), as T1 doesn't have reg property while T4 has.
> > 
> > How would t1040 have a so-called "fman-clk-mux" node at all if it doesn't
> > have this register?
> > 
> > I think we've made a mess of the clock bindings and this is only going to make
> > it worse.  We need to stay compatible with the mess we've made, but I'm
> > inclined to say that we shouldn't add more nodes to it.
> > 
> > Instead, have the toplevel clockgen node have a chip-based compatible in
> > addition to version (e.g. compatible = "fsl,t4240-clockgen",
> > "fsl,qoriq-clockgen-2.0") and have the toplevel node export whatever clocks
> > are needed.  Put the logic to deal with all the different dividers, register
> > values, and such in code, not the device tree.  The binding should be focused
> > on how to encode the specifier of the exported clocks.
> > 
> 
> We have 2 cases:
> 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx devices have many options, T1 has only one option)
> 
> For the first group, we can have " qoriq-hwacsr" property in the clock node.

No, we're not going to describe every register with its own property.
Describe the chip and let the driver be the place with the knowledge of
what each chip is like.

> Currently T4 FMan clock mux node is the following:
> 	fm1clk: fm1-clk-mux {
> 		#clock-cells = <0>;
> 		compatible = "fsl,fman-clk-mux";
> 		clocks = <&pll1 1>, <&pll1 2>, <&pll1 3>,
> 			 <&platform_pll 0>, <&pll0 1>, <&pll0 2>;
> 		clock-names = "pll1-div2", "pll1-div3", "pll1-div4",
> 			      "platform-pll", "pll0-div2", "pll0-div3";
> 		clock-output-names = "fm1-clk";
> 	};
> As far as I understand we need to move the node to the top level clock node.
> In addition we need to add reg property and change the name of the node and the compatible.
> In that case, the driver can read this register instead of parsing the RCW.

I'm having a hard time following.  What I'm suggesting is eliminating
the above and having the clockgen node itself (which already has a reg
property) be a clock source with a clock specifier encoding that
distinguishes the fman clock from other clocks.

> What about the devices of the second group?
> In this case we don't have a register to determine the source clock. So we need access to guts registers, 

I never suggested taking away access to the guts registers.

> like we have currently.
> The suggestion above doesn’t suit for those devices. 

How is the clock determined on those chips?

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, April 21, 2015 3:52 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> > Yuantian-B29983
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Mon, 2015-04-20 at 06:40 -0500, Liberman Igal-B31950 wrote:
> > >
> > >
> > > Regards,
> > > Igal Liberman.
> > >
> > > > -----Original Message-----
> > > > From: Liberman Igal-B31950
> > > > Sent: Monday, April 20, 2015 2:07 PM
> > > > To: Wood Scott-B07421
> > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > >
> > > >
> > > > Regards,
> > > > Igal Liberman.
> > > >
> > > > > -----Original Message-----
> > > > > From: Wood Scott-B07421
> > > > > Sent: Friday, April 17, 2015 8:41 AM
> > > > > To: Liberman Igal-B31950
> > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > > clock mux
> > > > >
> > > > > On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> > > > > >
> > > > > >
> > > > > > Regards,
> > > > > > Igal Liberman.
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Wood Scott-B07421
> > > > > > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > > > > > To: Liberman Igal-B31950
> > > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for
> > > > > > > FMan clock mux
> > > > > > >
> > > > > > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > > > > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > > > >
> > > > > > > > v3: Addressed feedback from Scott:
> > > > > > > > 	- Removed clock specifier description.
> > > > > > > >
> > > > > > > > v2: Addressed feedback from Scott:
> > > > > > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > > > > > 	  under "clocks" property.
> > > > > > > >
> > > > > > > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > > > > ---
> > > > > > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> > > > > +++++++++++++++--
> > > > > > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > > > > >
> > > > > > > > diff --git
> > > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > > index b0d7b73..2bb3b38 100644
> > > > > > > > ---
> > > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > > > > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.tx
> > > > > > > > +++ t
> > > > > > > > @@ -65,9 +65,10 @@ Required properties:
> > > > > > > >  		It takes parent's clock-frequency as its clock.
> > > > > > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > > > > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock
> > > > > > > > (v2.0)
> > > > > > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > > > > > >  - #clock-cells: From common clock binding. The number of cells in
> > a
> > > > > > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > > > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > > > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > and
> > > > > > > > +	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-
> > > > [1,2].0".
> > > > > > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > > > > > >  	clock-specifier cell may take the following values:
> > > > > > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@
> > > > Example
> > > > > > > > for clock block and clock provider:
> > > > > > > >  			clocks = <&sysclk>;
> > > > > > > >  			clock-output-names = "platform-pll",
> > > > "platform-pll-
> > > > > > > div2";
> > > > > > > >  		};
> > > > > > > > +
> > > > > > > > +		fm0clk: fm0-clk-mux {
> > > > > > > > +			#clock-cells = <0>;
> > > > > > > > +			reg = <0x10 4>
> > > > > > > > +			compatible = "fsl,fman-clk-mux";
> > > > > > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> > > > <&pll0 3>,
> > > > > > > > +				 <&platform_pll 0>, <&pll1 1>, <&pll1
> > > > 2>;
> > > > > > > > +			clock-names = "pll0", "pll0-div2", "pll0-div3",
> > > > > > > > +				      "pll0-div4", "platform-pll", "pll1-
> > > > div2",
> > > > > > > > +				      "pll1-div3";
> > > > > > > > +			clock-output-names = "fm0-clk";
> > > > > > > > +		};
> > > > > > > >  	};
> > > > > > > >  };
> > > > > > > >
> > > > > > >
> > > > > > > I don't see this register in the manuals for older DPAA chips,
> > > > > > > such as
> > > > > > > p4080 or p3041.  Is it present but undocumented?  Should I be
> > > > > > > looking somewhere other than "Clocking Memory Map"?
> > > > > > >
> > > > > >
> > > > > > It's available only in part of the new chips (T4, T2, B4).
> > > > > > In T1024/T1040 there's only one option for FMan clock so this
> > > > > > register is not
> > > > > available.
> > > > >
> > > > > So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.
> > > > > Who knows what we may see in the future.
> > > > >
> > > >
> > > > OK,
> > > > We can go with "fsl,fman-clk-mux-1/2-0.".
> > > > In that case, we need to update FMan nodes and the clock driver:
> > > > https://patchwork.ozlabs.org/patch/443973/
> > > > https://patchwork.ozlabs.org/patch/461813/
> > > > I will update those patches separately.
> > > >
> > >
> > > Scott,
> > > There are 2 options:
> > > Use "fsl,fman-clk-mux-1.0" for SoC without CLKCGnHWACSR register.
> > > Use "fsl,fman-clk-mux-2.0" for SoC with CLKCGnHWACSR register.
> > > Or
> > > Use "fsl,fman-clk-mux-1.0" for SoC which support FMan V2 (Pxxxx) Use
> > > "fsl,fman-clk-mux-2.0" for SoC which support FMan V3 (B/T)
> > 
> > 1.0/2.0 in the clockgen node refers to chassis version.  It has nothing to do
> > with FMan version.
> > 
> 
> I know. However there's a match: 1.0 chassis used in SoC with FMan v2 and 2.0 chassis in SoC with FMan v3.
> 
> > In fact, fman should not be in the compatible because, now that I found the
> > documentation for this, I see that it's more generic than that.
> > "fman-clk-mux" should be replaced with "qoriq-hwacsr".
> > 
> > > Using the 1st option might be confusing because core pll/mux 2.0
> > represents B/T devices and 1.0 represent Pxxxx.
> > > In this case, T1040 uses "fsl,qoriq-core-pll/mux-2.0" and "fsl,fman-clk-mux-
> > 1.0".
> > > On the other hand, the second option doesn't distinguishes between T4
> > and T1 (for example), as T1 doesn't have reg property while T4 has.
> > 
> > How would t1040 have a so-called "fman-clk-mux" node at all if it doesn't
> > have this register?
> > 
> > I think we've made a mess of the clock bindings and this is only going to make
> > it worse.  We need to stay compatible with the mess we've made, but I'm
> > inclined to say that we shouldn't add more nodes to it.
> > 
> > Instead, have the toplevel clockgen node have a chip-based compatible in
> > addition to version (e.g. compatible = "fsl,t4240-clockgen",
> > "fsl,qoriq-clockgen-2.0") and have the toplevel node export whatever clocks
> > are needed.  Put the logic to deal with all the different dividers, register
> > values, and such in code, not the device tree.  The binding should be focused
> > on how to encode the specifier of the exported clocks.
> > 
> 
> We have 2 cases:
> 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx devices have many options, T1 has only one option)
> 
> For the first group, we can have " qoriq-hwacsr" property in the clock node.

No, we're not going to describe every register with its own property.
Describe the chip and let the driver be the place with the knowledge of
what each chip is like.

> Currently T4 FMan clock mux node is the following:
> 	fm1clk: fm1-clk-mux {
> 		#clock-cells = <0>;
> 		compatible = "fsl,fman-clk-mux";
> 		clocks = <&pll1 1>, <&pll1 2>, <&pll1 3>,
> 			 <&platform_pll 0>, <&pll0 1>, <&pll0 2>;
> 		clock-names = "pll1-div2", "pll1-div3", "pll1-div4",
> 			      "platform-pll", "pll0-div2", "pll0-div3";
> 		clock-output-names = "fm1-clk";
> 	};
> As far as I understand we need to move the node to the top level clock node.
> In addition we need to add reg property and change the name of the node and the compatible.
> In that case, the driver can read this register instead of parsing the RCW.

I'm having a hard time following.  What I'm suggesting is eliminating
the above and having the clockgen node itself (which already has a reg
property) be a clock source with a clock specifier encoding that
distinguishes the fman clock from other clocks.

> What about the devices of the second group?
> In this case we don't have a register to determine the source clock. So we need access to guts registers, 

I never suggested taking away access to the guts registers.

> like we have currently.
> The suggestion above doesn’t suit for those devices. 

How is the clock determined on those chips?

-Scott

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman-KZfg59tc24xl57MIdRCFDg]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, April 30, 2015 3:31 AM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> Yuantian-B29983
> Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> >
> >
> > Regards,
> > Igal Liberman.
> >
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Tuesday, April 21, 2015 3:52 AM
> > > To: Liberman Igal-B31950
> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> > > Yuantian-B29983
> > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > clock mux
> > >
> > > On Mon, 2015-04-20 at 06:40 -0500, Liberman Igal-B31950 wrote:
> > > >
> > > >
> > > > Regards,
> > > > Igal Liberman.
> > > >
> > > > > -----Original Message-----
> > > > > From: Liberman Igal-B31950
> > > > > Sent: Monday, April 20, 2015 2:07 PM
> > > > > To: Wood Scott-B07421
> > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > > Subject: RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > > clock mux
> > > > >
> > > > >
> > > > >
> > > > > Regards,
> > > > > Igal Liberman.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Friday, April 17, 2015 8:41 AM
> > > > > > To: Liberman Igal-B31950
> > > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for
> > > > > > FMan clock mux
> > > > > >
> > > > > > On Thu, 2015-04-16 at 01:11 -0500, Liberman Igal-B31950 wrote:
> > > > > > >
> > > > > > >
> > > > > > > Regards,
> > > > > > > Igal Liberman.
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Wood Scott-B07421
> > > > > > > > Sent: Wednesday, April 15, 2015 8:36 PM
> > > > > > > > To: Liberman Igal-B31950
> > > > > > > > Cc: devicetree@vger.kernel.org;
> > > > > > > > linuxppc-dev@lists.ozlabs.org
> > > > > > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding
> > > > > > > > for FMan clock mux
> > > > > > > >
> > > > > > > > On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote:
> > > > > > > > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > > > > > > > >
> > > > > > > > > v3: Addressed feedback from Scott:
> > > > > > > > > 	- Removed clock specifier description.
> > > > > > > > >
> > > > > > > > > v2: Addressed feedback from Scott:
> > > > > > > > > 	- Moved the "fman-clk-mux" clock provider details
> > > > > > > > > 	  under "clocks" property.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Igal Liberman
> > > > > > > > > <Igal.Liberman@freescale.com>
> > > > > > > > > ---
> > > > > > > > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   17
> > > > > > +++++++++++++++--
> > > > > > > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git
> > > > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.tx
> > > > > > > > > t
> > > > > > > > > b/Documentation/devicetree/bindings/clock/qoriq-clock.tx
> > > > > > > > > t index b0d7b73..2bb3b38 100644
> > > > > > > > > ---
> > > > > > > > > a/Documentation/devicetree/bindings/clock/qoriq-clock.tx
> > > > > > > > > t
> > > > > > > > > +++ b/Documentation/devicetree/bindings/clock/qoriq-cloc
> > > > > > > > > +++ k.tx
> > > > > > > > > +++ t
> > > > > > > > > @@ -65,9 +65,10 @@ Required properties:
> > > > > > > > >  		It takes parent's clock-frequency as its clock.
> > > > > > > > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > > > > > > > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL
> > > > > > > > > clock
> > > > > > > > > (v2.0)
> > > > > > > > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > > > > > > > >  - #clock-cells: From common clock binding. The number
> > > > > > > > > of cells in
> > > a
> > > > > > > > > -	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> > > > > > > > > -	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > > > > > > > > +	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-
> [1,2].0"
> > > > > and
> > > > > > > > > +	"fsl,fman-clk-mux" clocks or <1> for
> > > > > > > > > +"fsl,qoriq-core-pll-
> > > > > [1,2].0".
> > > > > > > > >  	For "fsl,qoriq-core-pll-1.0" clocks, the single
> > > > > > > > >  	clock-specifier cell may take the following values:
> > > > > > > > >  	* 0 - equal to the PLL frequency @@ -145,6 +146,18 @@
> > > > > Example
> > > > > > > > > for clock block and clock provider:
> > > > > > > > >  			clocks = <&sysclk>;
> > > > > > > > >  			clock-output-names = "platform-pll",
> > > > > "platform-pll-
> > > > > > > > div2";
> > > > > > > > >  		};
> > > > > > > > > +
> > > > > > > > > +		fm0clk: fm0-clk-mux {
> > > > > > > > > +			#clock-cells = <0>;
> > > > > > > > > +			reg = <0x10 4>
> > > > > > > > > +			compatible = "fsl,fman-clk-mux";
> > > > > > > > > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0
> 2>,
> > > > > <&pll0 3>,
> > > > > > > > > +				 <&platform_pll 0>, <&pll1 1>,
> <&pll1
> > > > > 2>;
> > > > > > > > > +			clock-names = "pll0", "pll0-div2",
> "pll0-div3",
> > > > > > > > > +				      "pll0-div4", "platform-pll",
> "pll1-
> > > > > div2",
> > > > > > > > > +				      "pll1-div3";
> > > > > > > > > +			clock-output-names = "fm0-clk";
> > > > > > > > > +		};
> > > > > > > > >  	};
> > > > > > > > >  };
> > > > > > > > >
> > > > > > > >
> > > > > > > > I don't see this register in the manuals for older DPAA
> > > > > > > > chips, such as
> > > > > > > > p4080 or p3041.  Is it present but undocumented?  Should I
> > > > > > > > be looking somewhere other than "Clocking Memory Map"?
> > > > > > > >
> > > > > > >
> > > > > > > It's available only in part of the new chips (T4, T2, B4).
> > > > > > > In T1024/T1040 there's only one option for FMan clock so
> > > > > > > this register is not
> > > > > > available.
> > > > > >
> > > > > > So it's part of the 2.0 chassis?  I'd stick a 2.0 in there, then.
> > > > > > Who knows what we may see in the future.
> > > > > >
> > > > >
> > > > > OK,
> > > > > We can go with "fsl,fman-clk-mux-1/2-0.".
> > > > > In that case, we need to update FMan nodes and the clock driver:
> > > > > https://patchwork.ozlabs.org/patch/443973/
> > > > > https://patchwork.ozlabs.org/patch/461813/
> > > > > I will update those patches separately.
> > > > >
> > > >
> > > > Scott,
> > > > There are 2 options:
> > > > Use "fsl,fman-clk-mux-1.0" for SoC without CLKCGnHWACSR register.
> > > > Use "fsl,fman-clk-mux-2.0" for SoC with CLKCGnHWACSR register.
> > > > Or
> > > > Use "fsl,fman-clk-mux-1.0" for SoC which support FMan V2 (Pxxxx)
> > > > Use "fsl,fman-clk-mux-2.0" for SoC which support FMan V3 (B/T)
> > >
> > > 1.0/2.0 in the clockgen node refers to chassis version.  It has
> > > nothing to do with FMan version.
> > >
> >
> > I know. However there's a match: 1.0 chassis used in SoC with FMan v2 and
> 2.0 chassis in SoC with FMan v3.
> >
> > > In fact, fman should not be in the compatible because, now that I
> > > found the documentation for this, I see that it's more generic than that.
> > > "fman-clk-mux" should be replaced with "qoriq-hwacsr".
> > >
> > > > Using the 1st option might be confusing because core pll/mux 2.0
> > > represents B/T devices and 1.0 represent Pxxxx.
> > > > In this case, T1040 uses "fsl,qoriq-core-pll/mux-2.0" and
> > > > "fsl,fman-clk-mux-
> > > 1.0".
> > > > On the other hand, the second option doesn't distinguishes between
> > > > T4
> > > and T1 (for example), as T1 doesn't have reg property while T4 has.
> > >
> > > How would t1040 have a so-called "fman-clk-mux" node at all if it
> > > doesn't have this register?
> > >
> > > I think we've made a mess of the clock bindings and this is only
> > > going to make it worse.  We need to stay compatible with the mess
> > > we've made, but I'm inclined to say that we shouldn't add more nodes to
> it.
> > >
> > > Instead, have the toplevel clockgen node have a chip-based
> > > compatible in addition to version (e.g. compatible =
> > > "fsl,t4240-clockgen",
> > > "fsl,qoriq-clockgen-2.0") and have the toplevel node export whatever
> > > clocks are needed.  Put the logic to deal with all the different
> > > dividers, register values, and such in code, not the device tree.
> > > The binding should be focused on how to encode the specifier of the
> exported clocks.
> > >
> >
> > We have 2 cases:
> > 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> > 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx
> devices
> > have many options, T1 has only one option)
> >
> > For the first group, we can have " qoriq-hwacsr" property in the clock node.
> 
> No, we're not going to describe every register with its own property.
> Describe the chip and let the driver be the place with the knowledge of what
> each chip is like.
> 

I think that FMan clock mux (as we defined it) is similar to other muxes available in our SoC.
If we take T4 as example, it has 3 muxes defined in the device tree (mux0, mux1 and mux2).
Each mux has its own reg property (and clock providers).
	mux2: mux2@40 {
		#clock-cells = <0>;
		reg = <0x40 0x4>;
		compatible = "fsl,qoriq-core-mux-2.0";
		clocks = <&pll3 0>, <&pll3 1>, <&pll3 2>,
			<&pll4 0>, <&pll4 1>, <&pll4 2>;
		clock-names = "pll3", "pll3-div2", "pll3-div4",
			"pll4", "pll4-div2", "pll4-div4";
		clock-output-names = "cmux2";
	};

I agree that "fm1-clk-mux" need to be moved from the "guts" node to "clockgen" node.
However, I'm not sure which changes you want to perform in the node (beside adding reg property for SoC which has it for FMan clock).

> > Currently T4 FMan clock mux node is the following:
> > 	fm1clk: fm1-clk-mux {
> > 		#clock-cells = <0>;
> > 		compatible = "fsl,fman-clk-mux";
> > 		clocks = <&pll1 1>, <&pll1 2>, <&pll1 3>,
> > 			 <&platform_pll 0>, <&pll0 1>, <&pll0 2>;
> > 		clock-names = "pll1-div2", "pll1-div3", "pll1-div4",
> > 			      "platform-pll", "pll0-div2", "pll0-div3";
> > 		clock-output-names = "fm1-clk";
> > 	};
> > As far as I understand we need to move the node to the top level clock
> node.
> > In addition we need to add reg property and change the name of the node
> and the compatible.
> > In that case, the driver can read this register instead of parsing the RCW.
> 
> I'm having a hard time following.  What I'm suggesting is eliminating the
> above and having the clockgen node itself (which already has a reg
> property) be a clock source with a clock specifier encoding that distinguishes
> the fman clock from other clocks.
> 
> > What about the devices of the second group?
> > In this case we don't have a register to determine the source clock.
> > So we need access to guts registers,
> 
> I never suggested taking away access to the guts registers.
> 

I didn't mention that you want to remove them.
Just tried to explain that for Pxxxx devices, we need to use the current method (explained later).

> > like we have currently.
> > The suggestion above doesn’t suit for those devices.
> 
> How is the clock determined on those chips?
> 

In those chips (and currently others), currently, in the device tree we have all optional FMan clock providers (different between each SoC).
The clock driver reads the RCW in order to determine the clock provider and saves the index, later get_fm_clk_parent returns the index.

> -Scott
> 

Igal

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFRodXJzZGF5LCBBcHJpbCAz
MCwgMjAxNSAzOjMxIEFNDQo+IFRvOiBMaWJlcm1hbiBJZ2FsLUIzMTk1MA0KPiBDYzogZGV2aWNl
dHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBUYW5n
DQo+IFl1YW50aWFuLUIyOTk4Mw0KPiBTdWJqZWN0OiBSZTogW3YzXSBkdC9iaW5kaW5nczogcW9y
aXEtY2xvY2s6IEFkZCBiaW5kaW5nIGZvciBGTWFuIGNsb2NrIG11eA0KPiANCj4gT24gV2VkLCAy
MDE1LTA0LTIyIGF0IDA1OjQ3IC0wNTAwLCBMaWJlcm1hbiBJZ2FsLUIzMTk1MCB3cm90ZToNCj4g
Pg0KPiA+DQo+ID4gUmVnYXJkcywNCj4gPiBJZ2FsIExpYmVybWFuLg0KPiA+DQo+ID4gPiAtLS0t
LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4g
PiA+IFNlbnQ6IFR1ZXNkYXksIEFwcmlsIDIxLCAyMDE1IDM6NTIgQU0NCj4gPiA+IFRvOiBMaWJl
cm1hbiBJZ2FsLUIzMTk1MA0KPiA+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBs
aW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsgVGFuZw0KPiA+ID4gWXVhbnRpYW4tQjI5OTgz
DQo+ID4gPiBTdWJqZWN0OiBSZTogW3YzXSBkdC9iaW5kaW5nczogcW9yaXEtY2xvY2s6IEFkZCBi
aW5kaW5nIGZvciBGTWFuDQo+ID4gPiBjbG9jayBtdXgNCj4gPiA+DQo+ID4gPiBPbiBNb24sIDIw
MTUtMDQtMjAgYXQgMDY6NDAgLTA1MDAsIExpYmVybWFuIElnYWwtQjMxOTUwIHdyb3RlOg0KPiA+
ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiBSZWdhcmRzLA0KPiA+ID4gPiBJZ2FsIExpYmVybWFuLg0K
PiA+ID4gPg0KPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+ID4g
RnJvbTogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gPiA+ID4gPiBTZW50OiBNb25kYXksIEFwcmls
IDIwLCAyMDE1IDI6MDcgUE0NCj4gPiA+ID4gPiBUbzogV29vZCBTY290dC1CMDc0MjENCj4gPiA+
ID4gPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5v
emxhYnMub3JnDQo+ID4gPiA+ID4gU3ViamVjdDogUkU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlx
LWNsb2NrOiBBZGQgYmluZGluZyBmb3IgRk1hbg0KPiA+ID4gPiA+IGNsb2NrIG11eA0KPiA+ID4g
PiA+DQo+ID4gPiA+ID4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFJlZ2FyZHMsDQo+ID4gPiA+ID4g
SWdhbCBMaWJlcm1hbi4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCj4gPiA+ID4gPiA+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiA+ID4g
PiBTZW50OiBGcmlkYXksIEFwcmlsIDE3LCAyMDE1IDg6NDEgQU0NCj4gPiA+ID4gPiA+IFRvOiBM
aWJlcm1hbiBJZ2FsLUIzMTk1MA0KPiA+ID4gPiA+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJu
ZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiA+ID4gPiA+ID4gU3ViamVj
dDogUmU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlxLWNsb2NrOiBBZGQgYmluZGluZyBmb3INCj4g
PiA+ID4gPiA+IEZNYW4gY2xvY2sgbXV4DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gT24gVGh1
LCAyMDE1LTA0LTE2IGF0IDAxOjExIC0wNTAwLCBMaWJlcm1hbiBJZ2FsLUIzMTk1MCB3cm90ZToN
Cj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gUmVnYXJkcywNCj4g
PiA+ID4gPiA+ID4gSWdhbCBMaWJlcm1hbi4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiA+ID4gPiA+IEZyb206IFdvb2Qg
U2NvdHQtQjA3NDIxDQo+ID4gPiA+ID4gPiA+ID4gU2VudDogV2VkbmVzZGF5LCBBcHJpbCAxNSwg
MjAxNSA4OjM2IFBNDQo+ID4gPiA+ID4gPiA+ID4gVG86IExpYmVybWFuIElnYWwtQjMxOTUwDQo+
ID4gPiA+ID4gPiA+ID4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOw0KPiA+ID4gPiA+
ID4gPiA+IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+ID4gPiA+ID4gPiA+ID4gU3Vi
amVjdDogUmU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlxLWNsb2NrOiBBZGQgYmluZGluZw0KPiA+
ID4gPiA+ID4gPiA+IGZvciBGTWFuIGNsb2NrIG11eA0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+
ID4gPiA+ID4gT24gVHVlLCAyMDE1LTA0LTE0IGF0IDEzOjU2ICswMzAwLCBJZ2FsLkxpYmVybWFu
IHdyb3RlOg0KPiA+ID4gPiA+ID4gPiA+ID4gRnJvbTogSWdhbCBMaWJlcm1hbiA8SWdhbC5MaWJl
cm1hbkBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+
IHYzOiBBZGRyZXNzZWQgZmVlZGJhY2sgZnJvbSBTY290dDoNCj4gPiA+ID4gPiA+ID4gPiA+IAkt
IFJlbW92ZWQgY2xvY2sgc3BlY2lmaWVyIGRlc2NyaXB0aW9uLg0KPiA+ID4gPiA+ID4gPiA+ID4N
Cj4gPiA+ID4gPiA+ID4gPiA+IHYyOiBBZGRyZXNzZWQgZmVlZGJhY2sgZnJvbSBTY290dDoNCj4g
PiA+ID4gPiA+ID4gPiA+IAktIE1vdmVkIHRoZSAiZm1hbi1jbGstbXV4IiBjbG9jayBwcm92aWRl
ciBkZXRhaWxzDQo+ID4gPiA+ID4gPiA+ID4gPiAJICB1bmRlciAiY2xvY2tzIiBwcm9wZXJ0eS4N
Cj4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBJZ2Fs
IExpYmVybWFuDQo+ID4gPiA+ID4gPiA+ID4gPiA8SWdhbC5MaWJlcm1hbkBmcmVlc2NhbGUuY29t
Pg0KPiA+ID4gPiA+ID4gPiA+ID4gLS0tDQo+ID4gPiA+ID4gPiA+ID4gPiAgLi4uL2RldmljZXRy
ZWUvYmluZGluZ3MvY2xvY2svcW9yaXEtY2xvY2sudHh0ICAgICAgfCAgIDE3DQo+ID4gPiA+ID4g
PiArKysrKysrKysrKysrKystLQ0KPiA+ID4gPiA+ID4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAx
NSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+
ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQNCj4gPiA+ID4gPiA+ID4gPiA+IGEvRG9jdW1lbnRhdGlv
bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3FvcmlxLWNsb2NrLnR4DQo+ID4gPiA+ID4gPiA+
ID4gPiB0DQo+ID4gPiA+ID4gPiA+ID4gPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k
aW5ncy9jbG9jay9xb3JpcS1jbG9jay50eA0KPiA+ID4gPiA+ID4gPiA+ID4gdCBpbmRleCBiMGQ3
YjczLi4yYmIzYjM4IDEwMDY0NA0KPiA+ID4gPiA+ID4gPiA+ID4gLS0tDQo+ID4gPiA+ID4gPiA+
ID4gPiBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9xb3JpcS1jbG9j
ay50eA0KPiA+ID4gPiA+ID4gPiA+ID4gdA0KPiA+ID4gPiA+ID4gPiA+ID4gKysrIGIvRG9jdW1l
bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3FvcmlxLWNsb2MNCj4gPiA+ID4gPiA+
ID4gPiA+ICsrKyBrLnR4DQo+ID4gPiA+ID4gPiA+ID4gPiArKysgdA0KPiA+ID4gPiA+ID4gPiA+
ID4gQEAgLTY1LDkgKzY1LDEwIEBAIFJlcXVpcmVkIHByb3BlcnRpZXM6DQo+ID4gPiA+ID4gPiA+
ID4gPiAgCQlJdCB0YWtlcyBwYXJlbnQncyBjbG9jay1mcmVxdWVuY3kgYXMgaXRzIGNsb2NrLg0K
PiA+ID4gPiA+ID4gPiA+ID4gIAkqICJmc2wscW9yaXEtcGxhdGZvcm0tcGxsLTEuMCIgZm9yIHRo
ZSBwbGF0Zm9ybSBQTEwgY2xvY2sgKHYxLjApDQo+ID4gPiA+ID4gPiA+ID4gPiAgCSogImZzbCxx
b3JpcS1wbGF0Zm9ybS1wbGwtMi4wIiBmb3IgdGhlIHBsYXRmb3JtIFBMTA0KPiA+ID4gPiA+ID4g
PiA+ID4gY2xvY2sNCj4gPiA+ID4gPiA+ID4gPiA+ICh2Mi4wKQ0KPiA+ID4gPiA+ID4gPiA+ID4g
KwkqICJmc2wsZm1hbi1jbGstbXV4IiBmb3IgdGhlIEZyYW1lIE1hbmFnZXIgY2xvY2suDQo+ID4g
PiA+ID4gPiA+ID4gPiAgLSAjY2xvY2stY2VsbHM6IEZyb20gY29tbW9uIGNsb2NrIGJpbmRpbmcu
IFRoZSBudW1iZXINCj4gPiA+ID4gPiA+ID4gPiA+IG9mIGNlbGxzIGluDQo+ID4gPiBhDQo+ID4g
PiA+ID4gPiA+ID4gPiAtCWNsb2NrLXNwZWNpZmllci4gU2hvdWxkIGJlIDwwPiBmb3IgImZzbCxx
b3JpcS1zeXNjbGstWzEsMl0uMCINCj4gPiA+ID4gPiA+ID4gPiA+IC0JY2xvY2tzLCBvciA8MT4g
Zm9yICJmc2wscW9yaXEtY29yZS1wbGwtWzEsMl0uMCIgY2xvY2tzLg0KPiA+ID4gPiA+ID4gPiA+
ID4gKwljbG9jay1zcGVjaWZpZXIuIFNob3VsZCBiZSA8MD4gZm9yICJmc2wscW9yaXEtc3lzY2xr
LQ0KPiBbMSwyXS4wIg0KPiA+ID4gPiA+IGFuZA0KPiA+ID4gPiA+ID4gPiA+ID4gKwkiZnNsLGZt
YW4tY2xrLW11eCIgY2xvY2tzIG9yIDwxPiBmb3INCj4gPiA+ID4gPiA+ID4gPiA+ICsiZnNsLHFv
cmlxLWNvcmUtcGxsLQ0KPiA+ID4gPiA+IFsxLDJdLjAiLg0KPiA+ID4gPiA+ID4gPiA+ID4gIAlG
b3IgImZzbCxxb3JpcS1jb3JlLXBsbC0xLjAiIGNsb2NrcywgdGhlIHNpbmdsZQ0KPiA+ID4gPiA+
ID4gPiA+ID4gIAljbG9jay1zcGVjaWZpZXIgY2VsbCBtYXkgdGFrZSB0aGUgZm9sbG93aW5nIHZh
bHVlczoNCj4gPiA+ID4gPiA+ID4gPiA+ICAJKiAwIC0gZXF1YWwgdG8gdGhlIFBMTCBmcmVxdWVu
Y3kgQEAgLTE0NSw2ICsxNDYsMTggQEANCj4gPiA+ID4gPiBFeGFtcGxlDQo+ID4gPiA+ID4gPiA+
ID4gPiBmb3IgY2xvY2sgYmxvY2sgYW5kIGNsb2NrIHByb3ZpZGVyOg0KPiA+ID4gPiA+ID4gPiA+
ID4gIAkJCWNsb2NrcyA9IDwmc3lzY2xrPjsNCj4gPiA+ID4gPiA+ID4gPiA+ICAJCQljbG9jay1v
dXRwdXQtbmFtZXMgPSAicGxhdGZvcm0tcGxsIiwNCj4gPiA+ID4gPiAicGxhdGZvcm0tcGxsLQ0K
PiA+ID4gPiA+ID4gPiA+IGRpdjIiOw0KPiA+ID4gPiA+ID4gPiA+ID4gIAkJfTsNCj4gPiA+ID4g
PiA+ID4gPiA+ICsNCj4gPiA+ID4gPiA+ID4gPiA+ICsJCWZtMGNsazogZm0wLWNsay1tdXggew0K
PiA+ID4gPiA+ID4gPiA+ID4gKwkJCSNjbG9jay1jZWxscyA9IDwwPjsNCj4gPiA+ID4gPiA+ID4g
PiA+ICsJCQlyZWcgPSA8MHgxMCA0Pg0KPiA+ID4gPiA+ID4gPiA+ID4gKwkJCWNvbXBhdGlibGUg
PSAiZnNsLGZtYW4tY2xrLW11eCI7DQo+ID4gPiA+ID4gPiA+ID4gPiArCQkJY2xvY2tzID0gPCZw
bGwwIDA+LCA8JnBsbDAgMT4sIDwmcGxsMA0KPiAyPiwNCj4gPiA+ID4gPiA8JnBsbDAgMz4sDQo+
ID4gPiA+ID4gPiA+ID4gPiArCQkJCSA8JnBsYXRmb3JtX3BsbCAwPiwgPCZwbGwxIDE+LA0KPiA8
JnBsbDENCj4gPiA+ID4gPiAyPjsNCj4gPiA+ID4gPiA+ID4gPiA+ICsJCQljbG9jay1uYW1lcyA9
ICJwbGwwIiwgInBsbDAtZGl2MiIsDQo+ICJwbGwwLWRpdjMiLA0KPiA+ID4gPiA+ID4gPiA+ID4g
KwkJCQkgICAgICAicGxsMC1kaXY0IiwgInBsYXRmb3JtLXBsbCIsDQo+ICJwbGwxLQ0KPiA+ID4g
PiA+IGRpdjIiLA0KPiA+ID4gPiA+ID4gPiA+ID4gKwkJCQkgICAgICAicGxsMS1kaXYzIjsNCj4g
PiA+ID4gPiA+ID4gPiA+ICsJCQljbG9jay1vdXRwdXQtbmFtZXMgPSAiZm0wLWNsayI7DQo+ID4g
PiA+ID4gPiA+ID4gPiArCQl9Ow0KPiA+ID4gPiA+ID4gPiA+ID4gIAl9Ow0KPiA+ID4gPiA+ID4g
PiA+ID4gIH07DQo+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g
PiA+ID4gSSBkb24ndCBzZWUgdGhpcyByZWdpc3RlciBpbiB0aGUgbWFudWFscyBmb3Igb2xkZXIg
RFBBQQ0KPiA+ID4gPiA+ID4gPiA+IGNoaXBzLCBzdWNoIGFzDQo+ID4gPiA+ID4gPiA+ID4gcDQw
ODAgb3IgcDMwNDEuICBJcyBpdCBwcmVzZW50IGJ1dCB1bmRvY3VtZW50ZWQ/ICBTaG91bGQgSQ0K
PiA+ID4gPiA+ID4gPiA+IGJlIGxvb2tpbmcgc29tZXdoZXJlIG90aGVyIHRoYW4gIkNsb2NraW5n
IE1lbW9yeSBNYXAiPw0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g
PiA+IEl0J3MgYXZhaWxhYmxlIG9ubHkgaW4gcGFydCBvZiB0aGUgbmV3IGNoaXBzIChUNCwgVDIs
IEI0KS4NCj4gPiA+ID4gPiA+ID4gSW4gVDEwMjQvVDEwNDAgdGhlcmUncyBvbmx5IG9uZSBvcHRp
b24gZm9yIEZNYW4gY2xvY2sgc28NCj4gPiA+ID4gPiA+ID4gdGhpcyByZWdpc3RlciBpcyBub3QN
Cj4gPiA+ID4gPiA+IGF2YWlsYWJsZS4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBTbyBpdCdz
IHBhcnQgb2YgdGhlIDIuMCBjaGFzc2lzPyAgSSdkIHN0aWNrIGEgMi4wIGluIHRoZXJlLCB0aGVu
Lg0KPiA+ID4gPiA+ID4gV2hvIGtub3dzIHdoYXQgd2UgbWF5IHNlZSBpbiB0aGUgZnV0dXJlLg0K
PiA+ID4gPiA+ID4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IE9LLA0KPiA+ID4gPiA+IFdlIGNhbiBn
byB3aXRoICJmc2wsZm1hbi1jbGstbXV4LTEvMi0wLiIuDQo+ID4gPiA+ID4gSW4gdGhhdCBjYXNl
LCB3ZSBuZWVkIHRvIHVwZGF0ZSBGTWFuIG5vZGVzIGFuZCB0aGUgY2xvY2sgZHJpdmVyOg0KPiA+
ID4gPiA+IGh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvNDQzOTczLw0KPiA+ID4g
PiA+IGh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvNDYxODEzLw0KPiA+ID4gPiA+
IEkgd2lsbCB1cGRhdGUgdGhvc2UgcGF0Y2hlcyBzZXBhcmF0ZWx5Lg0KPiA+ID4gPiA+DQo+ID4g
PiA+DQo+ID4gPiA+IFNjb3R0LA0KPiA+ID4gPiBUaGVyZSBhcmUgMiBvcHRpb25zOg0KPiA+ID4g
PiBVc2UgImZzbCxmbWFuLWNsay1tdXgtMS4wIiBmb3IgU29DIHdpdGhvdXQgQ0xLQ0duSFdBQ1NS
IHJlZ2lzdGVyLg0KPiA+ID4gPiBVc2UgImZzbCxmbWFuLWNsay1tdXgtMi4wIiBmb3IgU29DIHdp
dGggQ0xLQ0duSFdBQ1NSIHJlZ2lzdGVyLg0KPiA+ID4gPiBPcg0KPiA+ID4gPiBVc2UgImZzbCxm
bWFuLWNsay1tdXgtMS4wIiBmb3IgU29DIHdoaWNoIHN1cHBvcnQgRk1hbiBWMiAoUHh4eHgpDQo+
ID4gPiA+IFVzZSAiZnNsLGZtYW4tY2xrLW11eC0yLjAiIGZvciBTb0Mgd2hpY2ggc3VwcG9ydCBG
TWFuIFYzIChCL1QpDQo+ID4gPg0KPiA+ID4gMS4wLzIuMCBpbiB0aGUgY2xvY2tnZW4gbm9kZSBy
ZWZlcnMgdG8gY2hhc3NpcyB2ZXJzaW9uLiAgSXQgaGFzDQo+ID4gPiBub3RoaW5nIHRvIGRvIHdp
dGggRk1hbiB2ZXJzaW9uLg0KPiA+ID4NCj4gPg0KPiA+IEkga25vdy4gSG93ZXZlciB0aGVyZSdz
IGEgbWF0Y2g6IDEuMCBjaGFzc2lzIHVzZWQgaW4gU29DIHdpdGggRk1hbiB2MiBhbmQNCj4gMi4w
IGNoYXNzaXMgaW4gU29DIHdpdGggRk1hbiB2My4NCj4gPg0KPiA+ID4gSW4gZmFjdCwgZm1hbiBz
aG91bGQgbm90IGJlIGluIHRoZSBjb21wYXRpYmxlIGJlY2F1c2UsIG5vdyB0aGF0IEkNCj4gPiA+
IGZvdW5kIHRoZSBkb2N1bWVudGF0aW9uIGZvciB0aGlzLCBJIHNlZSB0aGF0IGl0J3MgbW9yZSBn
ZW5lcmljIHRoYW4gdGhhdC4NCj4gPiA+ICJmbWFuLWNsay1tdXgiIHNob3VsZCBiZSByZXBsYWNl
ZCB3aXRoICJxb3JpcS1od2Fjc3IiLg0KPiA+ID4NCj4gPiA+ID4gVXNpbmcgdGhlIDFzdCBvcHRp
b24gbWlnaHQgYmUgY29uZnVzaW5nIGJlY2F1c2UgY29yZSBwbGwvbXV4IDIuMA0KPiA+ID4gcmVw
cmVzZW50cyBCL1QgZGV2aWNlcyBhbmQgMS4wIHJlcHJlc2VudCBQeHh4eC4NCj4gPiA+ID4gSW4g
dGhpcyBjYXNlLCBUMTA0MCB1c2VzICJmc2wscW9yaXEtY29yZS1wbGwvbXV4LTIuMCIgYW5kDQo+
ID4gPiA+ICJmc2wsZm1hbi1jbGstbXV4LQ0KPiA+ID4gMS4wIi4NCj4gPiA+ID4gT24gdGhlIG90
aGVyIGhhbmQsIHRoZSBzZWNvbmQgb3B0aW9uIGRvZXNuJ3QgZGlzdGluZ3Vpc2hlcyBiZXR3ZWVu
DQo+ID4gPiA+IFQ0DQo+ID4gPiBhbmQgVDEgKGZvciBleGFtcGxlKSwgYXMgVDEgZG9lc24ndCBo
YXZlIHJlZyBwcm9wZXJ0eSB3aGlsZSBUNCBoYXMuDQo+ID4gPg0KPiA+ID4gSG93IHdvdWxkIHQx
MDQwIGhhdmUgYSBzby1jYWxsZWQgImZtYW4tY2xrLW11eCIgbm9kZSBhdCBhbGwgaWYgaXQNCj4g
PiA+IGRvZXNuJ3QgaGF2ZSB0aGlzIHJlZ2lzdGVyPw0KPiA+ID4NCj4gPiA+IEkgdGhpbmsgd2Un
dmUgbWFkZSBhIG1lc3Mgb2YgdGhlIGNsb2NrIGJpbmRpbmdzIGFuZCB0aGlzIGlzIG9ubHkNCj4g
PiA+IGdvaW5nIHRvIG1ha2UgaXQgd29yc2UuICBXZSBuZWVkIHRvIHN0YXkgY29tcGF0aWJsZSB3
aXRoIHRoZSBtZXNzDQo+ID4gPiB3ZSd2ZSBtYWRlLCBidXQgSSdtIGluY2xpbmVkIHRvIHNheSB0
aGF0IHdlIHNob3VsZG4ndCBhZGQgbW9yZSBub2RlcyB0bw0KPiBpdC4NCj4gPiA+DQo+ID4gPiBJ
bnN0ZWFkLCBoYXZlIHRoZSB0b3BsZXZlbCBjbG9ja2dlbiBub2RlIGhhdmUgYSBjaGlwLWJhc2Vk
DQo+ID4gPiBjb21wYXRpYmxlIGluIGFkZGl0aW9uIHRvIHZlcnNpb24gKGUuZy4gY29tcGF0aWJs
ZSA9DQo+ID4gPiAiZnNsLHQ0MjQwLWNsb2NrZ2VuIiwNCj4gPiA+ICJmc2wscW9yaXEtY2xvY2tn
ZW4tMi4wIikgYW5kIGhhdmUgdGhlIHRvcGxldmVsIG5vZGUgZXhwb3J0IHdoYXRldmVyDQo+ID4g
PiBjbG9ja3MgYXJlIG5lZWRlZC4gIFB1dCB0aGUgbG9naWMgdG8gZGVhbCB3aXRoIGFsbCB0aGUg
ZGlmZmVyZW50DQo+ID4gPiBkaXZpZGVycywgcmVnaXN0ZXIgdmFsdWVzLCBhbmQgc3VjaCBpbiBj
b2RlLCBub3QgdGhlIGRldmljZSB0cmVlLg0KPiA+ID4gVGhlIGJpbmRpbmcgc2hvdWxkIGJlIGZv
Y3VzZWQgb24gaG93IHRvIGVuY29kZSB0aGUgc3BlY2lmaWVyIG9mIHRoZQ0KPiBleHBvcnRlZCBj
bG9ja3MuDQo+ID4gPg0KPiA+DQo+ID4gV2UgaGF2ZSAyIGNhc2VzOg0KPiA+IAktIERldmljZXMg
KFQyL1Q0L0I0KSB3aXRoIENMS0NHMUhXQUNTUiByZWdpc3Rlci4NCj4gPiAJLSBEZXZpY2VzIChQ
eHh4eCwgVDEpIHdpdGhvdXQgQ0xLQ0cxSFdBQ1NSIHJlZ2lzdGVyIChQeHh4eA0KPiBkZXZpY2Vz
DQo+ID4gaGF2ZSBtYW55IG9wdGlvbnMsIFQxIGhhcyBvbmx5IG9uZSBvcHRpb24pDQo+ID4NCj4g
PiBGb3IgdGhlIGZpcnN0IGdyb3VwLCB3ZSBjYW4gaGF2ZSAiIHFvcmlxLWh3YWNzciIgcHJvcGVy
dHkgaW4gdGhlIGNsb2NrIG5vZGUuDQo+IA0KPiBObywgd2UncmUgbm90IGdvaW5nIHRvIGRlc2Ny
aWJlIGV2ZXJ5IHJlZ2lzdGVyIHdpdGggaXRzIG93biBwcm9wZXJ0eS4NCj4gRGVzY3JpYmUgdGhl
IGNoaXAgYW5kIGxldCB0aGUgZHJpdmVyIGJlIHRoZSBwbGFjZSB3aXRoIHRoZSBrbm93bGVkZ2Ug
b2Ygd2hhdA0KPiBlYWNoIGNoaXAgaXMgbGlrZS4NCj4gDQoNCkkgdGhpbmsgdGhhdCBGTWFuIGNs
b2NrIG11eCAoYXMgd2UgZGVmaW5lZCBpdCkgaXMgc2ltaWxhciB0byBvdGhlciBtdXhlcyBhdmFp
bGFibGUgaW4gb3VyIFNvQy4NCklmIHdlIHRha2UgVDQgYXMgZXhhbXBsZSwgaXQgaGFzIDMgbXV4
ZXMgZGVmaW5lZCBpbiB0aGUgZGV2aWNlIHRyZWUgKG11eDAsIG11eDEgYW5kIG11eDIpLg0KRWFj
aCBtdXggaGFzIGl0cyBvd24gcmVnIHByb3BlcnR5IChhbmQgY2xvY2sgcHJvdmlkZXJzKS4NCglt
dXgyOiBtdXgyQDQwIHsNCgkJI2Nsb2NrLWNlbGxzID0gPDA+Ow0KCQlyZWcgPSA8MHg0MCAweDQ+
Ow0KCQljb21wYXRpYmxlID0gImZzbCxxb3JpcS1jb3JlLW11eC0yLjAiOw0KCQljbG9ja3MgPSA8
JnBsbDMgMD4sIDwmcGxsMyAxPiwgPCZwbGwzIDI+LA0KCQkJPCZwbGw0IDA+LCA8JnBsbDQgMT4s
IDwmcGxsNCAyPjsNCgkJY2xvY2stbmFtZXMgPSAicGxsMyIsICJwbGwzLWRpdjIiLCAicGxsMy1k
aXY0IiwNCgkJCSJwbGw0IiwgInBsbDQtZGl2MiIsICJwbGw0LWRpdjQiOw0KCQljbG9jay1vdXRw
dXQtbmFtZXMgPSAiY211eDIiOw0KCX07DQoNCkkgYWdyZWUgdGhhdCAiZm0xLWNsay1tdXgiIG5l
ZWQgdG8gYmUgbW92ZWQgZnJvbSB0aGUgImd1dHMiIG5vZGUgdG8gImNsb2NrZ2VuIiBub2RlLg0K
SG93ZXZlciwgSSdtIG5vdCBzdXJlIHdoaWNoIGNoYW5nZXMgeW91IHdhbnQgdG8gcGVyZm9ybSBp
biB0aGUgbm9kZSAoYmVzaWRlIGFkZGluZyByZWcgcHJvcGVydHkgZm9yIFNvQyB3aGljaCBoYXMg
aXQgZm9yIEZNYW4gY2xvY2spLg0KDQo+ID4gQ3VycmVudGx5IFQ0IEZNYW4gY2xvY2sgbXV4IG5v
ZGUgaXMgdGhlIGZvbGxvd2luZzoNCj4gPiAJZm0xY2xrOiBmbTEtY2xrLW11eCB7DQo+ID4gCQkj
Y2xvY2stY2VsbHMgPSA8MD47DQo+ID4gCQljb21wYXRpYmxlID0gImZzbCxmbWFuLWNsay1tdXgi
Ow0KPiA+IAkJY2xvY2tzID0gPCZwbGwxIDE+LCA8JnBsbDEgMj4sIDwmcGxsMSAzPiwNCj4gPiAJ
CQkgPCZwbGF0Zm9ybV9wbGwgMD4sIDwmcGxsMCAxPiwgPCZwbGwwIDI+Ow0KPiA+IAkJY2xvY2st
bmFtZXMgPSAicGxsMS1kaXYyIiwgInBsbDEtZGl2MyIsICJwbGwxLWRpdjQiLA0KPiA+IAkJCSAg
ICAgICJwbGF0Zm9ybS1wbGwiLCAicGxsMC1kaXYyIiwgInBsbDAtZGl2MyI7DQo+ID4gCQljbG9j
ay1vdXRwdXQtbmFtZXMgPSAiZm0xLWNsayI7DQo+ID4gCX07DQo+ID4gQXMgZmFyIGFzIEkgdW5k
ZXJzdGFuZCB3ZSBuZWVkIHRvIG1vdmUgdGhlIG5vZGUgdG8gdGhlIHRvcCBsZXZlbCBjbG9jaw0K
PiBub2RlLg0KPiA+IEluIGFkZGl0aW9uIHdlIG5lZWQgdG8gYWRkIHJlZyBwcm9wZXJ0eSBhbmQg
Y2hhbmdlIHRoZSBuYW1lIG9mIHRoZSBub2RlDQo+IGFuZCB0aGUgY29tcGF0aWJsZS4NCj4gPiBJ
biB0aGF0IGNhc2UsIHRoZSBkcml2ZXIgY2FuIHJlYWQgdGhpcyByZWdpc3RlciBpbnN0ZWFkIG9m
IHBhcnNpbmcgdGhlIFJDVy4NCj4gDQo+IEknbSBoYXZpbmcgYSBoYXJkIHRpbWUgZm9sbG93aW5n
LiAgV2hhdCBJJ20gc3VnZ2VzdGluZyBpcyBlbGltaW5hdGluZyB0aGUNCj4gYWJvdmUgYW5kIGhh
dmluZyB0aGUgY2xvY2tnZW4gbm9kZSBpdHNlbGYgKHdoaWNoIGFscmVhZHkgaGFzIGEgcmVnDQo+
IHByb3BlcnR5KSBiZSBhIGNsb2NrIHNvdXJjZSB3aXRoIGEgY2xvY2sgc3BlY2lmaWVyIGVuY29k
aW5nIHRoYXQgZGlzdGluZ3Vpc2hlcw0KPiB0aGUgZm1hbiBjbG9jayBmcm9tIG90aGVyIGNsb2Nr
cy4NCj4gDQo+ID4gV2hhdCBhYm91dCB0aGUgZGV2aWNlcyBvZiB0aGUgc2Vjb25kIGdyb3VwPw0K
PiA+IEluIHRoaXMgY2FzZSB3ZSBkb24ndCBoYXZlIGEgcmVnaXN0ZXIgdG8gZGV0ZXJtaW5lIHRo
ZSBzb3VyY2UgY2xvY2suDQo+ID4gU28gd2UgbmVlZCBhY2Nlc3MgdG8gZ3V0cyByZWdpc3RlcnMs
DQo+IA0KPiBJIG5ldmVyIHN1Z2dlc3RlZCB0YWtpbmcgYXdheSBhY2Nlc3MgdG8gdGhlIGd1dHMg
cmVnaXN0ZXJzLg0KPiANCg0KSSBkaWRuJ3QgbWVudGlvbiB0aGF0IHlvdSB3YW50IHRvIHJlbW92
ZSB0aGVtLg0KSnVzdCB0cmllZCB0byBleHBsYWluIHRoYXQgZm9yIFB4eHh4IGRldmljZXMsIHdl
IG5lZWQgdG8gdXNlIHRoZSBjdXJyZW50IG1ldGhvZCAoZXhwbGFpbmVkIGxhdGVyKS4NCg0KPiA+
IGxpa2Ugd2UgaGF2ZSBjdXJyZW50bHkuDQo+ID4gVGhlIHN1Z2dlc3Rpb24gYWJvdmUgZG9lc27i
gJl0IHN1aXQgZm9yIHRob3NlIGRldmljZXMuDQo+IA0KPiBIb3cgaXMgdGhlIGNsb2NrIGRldGVy
bWluZWQgb24gdGhvc2UgY2hpcHM/DQo+IA0KDQpJbiB0aG9zZSBjaGlwcyAoYW5kIGN1cnJlbnRs
eSBvdGhlcnMpLCBjdXJyZW50bHksIGluIHRoZSBkZXZpY2UgdHJlZSB3ZSBoYXZlIGFsbCBvcHRp
b25hbCBGTWFuIGNsb2NrIHByb3ZpZGVycyAoZGlmZmVyZW50IGJldHdlZW4gZWFjaCBTb0MpLg0K
VGhlIGNsb2NrIGRyaXZlciByZWFkcyB0aGUgUkNXIGluIG9yZGVyIHRvIGRldGVybWluZSB0aGUg
Y2xvY2sgcHJvdmlkZXIgYW5kIHNhdmVzIHRoZSBpbmRleCwgbGF0ZXIgZ2V0X2ZtX2Nsa19wYXJl
bnQgcmV0dXJucyB0aGUgaW5kZXguDQoNCj4gLVNjb3R0DQo+IA0KDQpJZ2FsDQoNCg==

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Thu, 2015-04-30 at 09:28 -0500, Liberman Igal-B31950 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, April 30, 2015 3:31 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Tang
> > Yuantian-B29983
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> > > We have 2 cases:
> > > 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> > > 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx
> > devices
> > > have many options, T1 has only one option)
> > >
> > > For the first group, we can have " qoriq-hwacsr" property in the clock node.
> > 
> > No, we're not going to describe every register with its own property.
> > Describe the chip and let the driver be the place with the knowledge of what
> > each chip is like.
> > 
> 
> I think that FMan clock mux (as we defined it) is similar to other muxes available in our SoC.

I realize that.  I'm saying the way we described existing muxes seems to
be a mistake.  We're putting too much complexity in the device tree.
Better to put the complexity in a place that isn't stable ABI.

> If we take T4 as example, it has 3 muxes defined in the device tree (mux0, mux1 and mux2).
> Each mux has its own reg property (and clock providers).
> 	mux2: mux2@40 {
> 		#clock-cells = <0>;
> 		reg = <0x40 0x4>;
> 		compatible = "fsl,qoriq-core-mux-2.0";
> 		clocks = <&pll3 0>, <&pll3 1>, <&pll3 2>,
> 			<&pll4 0>, <&pll4 1>, <&pll4 2>;
> 		clock-names = "pll3", "pll3-div2", "pll3-div4",
> 			"pll4", "pll4-div2", "pll4-div4";
> 		clock-output-names = "cmux2";
> 	};
> 
> I agree that "fm1-clk-mux" need to be moved from the "guts" node to "clockgen" node.

That's not what I was saying.  I'm saying get rid of the node entirely,
in favor of having the clockgen node itself be a clock source with
multiple post-mux outputs.

> However, I'm not sure which changes you want to perform in the node (beside adding reg property for SoC which has it for FMan clock).

Again, the clockgen node already has a reg property.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Thu, 2015-04-30 at 09:28 -0500, Liberman Igal-B31950 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, April 30, 2015 3:31 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> > Yuantian-B29983
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> > > We have 2 cases:
> > > 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> > > 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx
> > devices
> > > have many options, T1 has only one option)
> > >
> > > For the first group, we can have " qoriq-hwacsr" property in the clock node.
> > 
> > No, we're not going to describe every register with its own property.
> > Describe the chip and let the driver be the place with the knowledge of what
> > each chip is like.
> > 
> 
> I think that FMan clock mux (as we defined it) is similar to other muxes available in our SoC.

I realize that.  I'm saying the way we described existing muxes seems to
be a mistake.  We're putting too much complexity in the device tree.
Better to put the complexity in a place that isn't stable ABI.

> If we take T4 as example, it has 3 muxes defined in the device tree (mux0, mux1 and mux2).
> Each mux has its own reg property (and clock providers).
> 	mux2: mux2@40 {
> 		#clock-cells = <0>;
> 		reg = <0x40 0x4>;
> 		compatible = "fsl,qoriq-core-mux-2.0";
> 		clocks = <&pll3 0>, <&pll3 1>, <&pll3 2>,
> 			<&pll4 0>, <&pll4 1>, <&pll4 2>;
> 		clock-names = "pll3", "pll3-div2", "pll3-div4",
> 			"pll4", "pll4-div2", "pll4-div4";
> 		clock-output-names = "cmux2";
> 	};
> 
> I agree that "fm1-clk-mux" need to be moved from the "guts" node to "clockgen" node.

That's not what I was saying.  I'm saying get rid of the node entirely,
in favor of having the clockgen node itself be a clock source with
multiple post-mux outputs.

> However, I'm not sure which changes you want to perform in the node (beside adding reg property for SoC which has it for FMan clock).

Again, the clockgen node already has a reg property.

-Scott

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman-KZfg59tc24xl57MIdRCFDg]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, May 02, 2015 2:43 AM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> Yuantian-B29983
> Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> On Thu, 2015-04-30 at 09:28 -0500, Liberman Igal-B31950 wrote:
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Thursday, April 30, 2015 3:31 AM
> > > To: Liberman Igal-B31950
> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> > > Yuantian-B29983
> > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > clock mux
> > >
> > > On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> > > > We have 2 cases:
> > > > 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> > > > 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx
> > > devices
> > > > have many options, T1 has only one option)
> > > >
> > > > For the first group, we can have " qoriq-hwacsr" property in the clock
> node.
> > >
> > > No, we're not going to describe every register with its own property.
> > > Describe the chip and let the driver be the place with the knowledge
> > > of what each chip is like.
> > >
> >
> > I think that FMan clock mux (as we defined it) is similar to other muxes
> available in our SoC.
> 
> I realize that.  I'm saying the way we described existing muxes seems to be a
> mistake.  We're putting too much complexity in the device tree.
> Better to put the complexity in a place that isn't stable ABI.
> 
> > If we take T4 as example, it has 3 muxes defined in the device tree (mux0,
> mux1 and mux2).
> > Each mux has its own reg property (and clock providers).
> > 	mux2: mux2@40 {
> > 		#clock-cells = <0>;
> > 		reg = <0x40 0x4>;
> > 		compatible = "fsl,qoriq-core-mux-2.0";
> > 		clocks = <&pll3 0>, <&pll3 1>, <&pll3 2>,
> > 			<&pll4 0>, <&pll4 1>, <&pll4 2>;
> > 		clock-names = "pll3", "pll3-div2", "pll3-div4",
> > 			"pll4", "pll4-div2", "pll4-div4";
> > 		clock-output-names = "cmux2";
> > 	};
> >
> > I agree that "fm1-clk-mux" need to be moved from the "guts" node to
> "clockgen" node.
> 
> That's not what I was saying.  I'm saying get rid of the node entirely, in favor
> of having the clockgen node itself be a clock source with multiple post-mux
> outputs.
> 

Scott,
Currently the clockgen node has a number of sub nodes (platform clock, sysclock, PLLs and muxes, the number of muxes/PLLs is SoC dependent).
The clockgen node has reg property, however, all other nodes have reg property too (The clockgen points to the clocking block address and the sub nodes point to the specific register in the clock block).
Do you want to change this structure completely?
I'm not sure I understand the exact way you want see those nodes (in the final state).

> > However, I'm not sure which changes you want to perform in the node
> (beside adding reg property for SoC which has it for FMan clock).
> 
> Again, the clockgen node already has a reg property.
> 
> -Scott
> 

RE: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFNhdHVyZGF5LCBNYXkgMDIs
IDIwMTUgMjo0MyBBTQ0KPiBUbzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gQ2M6IGRldmljZXRy
ZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsgVGFuZw0K
PiBZdWFudGlhbi1CMjk5ODMNCj4gU3ViamVjdDogUmU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlx
LWNsb2NrOiBBZGQgYmluZGluZyBmb3IgRk1hbiBjbG9jayBtdXgNCj4gDQo+IE9uIFRodSwgMjAx
NS0wNC0zMCBhdCAwOToyOCAtMDUwMCwgTGliZXJtYW4gSWdhbC1CMzE5NTAgd3JvdGU6DQo+ID4g
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gPiA+IFNlbnQ6IFRodXJzZGF5LCBBcHJpbCAzMCwgMjAxNSAzOjMxIEFNDQo+ID4gPiBU
bzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gPiA+IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVs
Lm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IFRhbmcNCj4gPiA+IFl1YW50aWFu
LUIyOTk4Mw0KPiA+ID4gU3ViamVjdDogUmU6IFt2M10gZHQvYmluZGluZ3M6IHFvcmlxLWNsb2Nr
OiBBZGQgYmluZGluZyBmb3IgRk1hbg0KPiA+ID4gY2xvY2sgbXV4DQo+ID4gPg0KPiA+ID4gT24g
V2VkLCAyMDE1LTA0LTIyIGF0IDA1OjQ3IC0wNTAwLCBMaWJlcm1hbiBJZ2FsLUIzMTk1MCB3cm90
ZToNCj4gPiA+ID4gV2UgaGF2ZSAyIGNhc2VzOg0KPiA+ID4gPiAJLSBEZXZpY2VzIChUMi9UNC9C
NCkgd2l0aCBDTEtDRzFIV0FDU1IgcmVnaXN0ZXIuDQo+ID4gPiA+IAktIERldmljZXMgKFB4eHh4
LCBUMSkgd2l0aG91dCBDTEtDRzFIV0FDU1IgcmVnaXN0ZXIgKFB4eHh4DQo+ID4gPiBkZXZpY2Vz
DQo+ID4gPiA+IGhhdmUgbWFueSBvcHRpb25zLCBUMSBoYXMgb25seSBvbmUgb3B0aW9uKQ0KPiA+
ID4gPg0KPiA+ID4gPiBGb3IgdGhlIGZpcnN0IGdyb3VwLCB3ZSBjYW4gaGF2ZSAiIHFvcmlxLWh3
YWNzciIgcHJvcGVydHkgaW4gdGhlIGNsb2NrDQo+IG5vZGUuDQo+ID4gPg0KPiA+ID4gTm8sIHdl
J3JlIG5vdCBnb2luZyB0byBkZXNjcmliZSBldmVyeSByZWdpc3RlciB3aXRoIGl0cyBvd24gcHJv
cGVydHkuDQo+ID4gPiBEZXNjcmliZSB0aGUgY2hpcCBhbmQgbGV0IHRoZSBkcml2ZXIgYmUgdGhl
IHBsYWNlIHdpdGggdGhlIGtub3dsZWRnZQ0KPiA+ID4gb2Ygd2hhdCBlYWNoIGNoaXAgaXMgbGlr
ZS4NCj4gPiA+DQo+ID4NCj4gPiBJIHRoaW5rIHRoYXQgRk1hbiBjbG9jayBtdXggKGFzIHdlIGRl
ZmluZWQgaXQpIGlzIHNpbWlsYXIgdG8gb3RoZXIgbXV4ZXMNCj4gYXZhaWxhYmxlIGluIG91ciBT
b0MuDQo+IA0KPiBJIHJlYWxpemUgdGhhdC4gIEknbSBzYXlpbmcgdGhlIHdheSB3ZSBkZXNjcmli
ZWQgZXhpc3RpbmcgbXV4ZXMgc2VlbXMgdG8gYmUgYQ0KPiBtaXN0YWtlLiAgV2UncmUgcHV0dGlu
ZyB0b28gbXVjaCBjb21wbGV4aXR5IGluIHRoZSBkZXZpY2UgdHJlZS4NCj4gQmV0dGVyIHRvIHB1
dCB0aGUgY29tcGxleGl0eSBpbiBhIHBsYWNlIHRoYXQgaXNuJ3Qgc3RhYmxlIEFCSS4NCj4gDQo+
ID4gSWYgd2UgdGFrZSBUNCBhcyBleGFtcGxlLCBpdCBoYXMgMyBtdXhlcyBkZWZpbmVkIGluIHRo
ZSBkZXZpY2UgdHJlZSAobXV4MCwNCj4gbXV4MSBhbmQgbXV4MikuDQo+ID4gRWFjaCBtdXggaGFz
IGl0cyBvd24gcmVnIHByb3BlcnR5IChhbmQgY2xvY2sgcHJvdmlkZXJzKS4NCj4gPiAJbXV4Mjog
bXV4MkA0MCB7DQo+ID4gCQkjY2xvY2stY2VsbHMgPSA8MD47DQo+ID4gCQlyZWcgPSA8MHg0MCAw
eDQ+Ow0KPiA+IAkJY29tcGF0aWJsZSA9ICJmc2wscW9yaXEtY29yZS1tdXgtMi4wIjsNCj4gPiAJ
CWNsb2NrcyA9IDwmcGxsMyAwPiwgPCZwbGwzIDE+LCA8JnBsbDMgMj4sDQo+ID4gCQkJPCZwbGw0
IDA+LCA8JnBsbDQgMT4sIDwmcGxsNCAyPjsNCj4gPiAJCWNsb2NrLW5hbWVzID0gInBsbDMiLCAi
cGxsMy1kaXYyIiwgInBsbDMtZGl2NCIsDQo+ID4gCQkJInBsbDQiLCAicGxsNC1kaXYyIiwgInBs
bDQtZGl2NCI7DQo+ID4gCQljbG9jay1vdXRwdXQtbmFtZXMgPSAiY211eDIiOw0KPiA+IAl9Ow0K
PiA+DQo+ID4gSSBhZ3JlZSB0aGF0ICJmbTEtY2xrLW11eCIgbmVlZCB0byBiZSBtb3ZlZCBmcm9t
IHRoZSAiZ3V0cyIgbm9kZSB0bw0KPiAiY2xvY2tnZW4iIG5vZGUuDQo+IA0KPiBUaGF0J3Mgbm90
IHdoYXQgSSB3YXMgc2F5aW5nLiAgSSdtIHNheWluZyBnZXQgcmlkIG9mIHRoZSBub2RlIGVudGly
ZWx5LCBpbiBmYXZvcg0KPiBvZiBoYXZpbmcgdGhlIGNsb2NrZ2VuIG5vZGUgaXRzZWxmIGJlIGEg
Y2xvY2sgc291cmNlIHdpdGggbXVsdGlwbGUgcG9zdC1tdXgNCj4gb3V0cHV0cy4NCj4gDQoNClNj
b3R0LA0KQ3VycmVudGx5IHRoZSBjbG9ja2dlbiBub2RlIGhhcyBhIG51bWJlciBvZiBzdWIgbm9k
ZXMgKHBsYXRmb3JtIGNsb2NrLCBzeXNjbG9jaywgUExMcyBhbmQgbXV4ZXMsIHRoZSBudW1iZXIg
b2YgbXV4ZXMvUExMcyBpcyBTb0MgZGVwZW5kZW50KS4NClRoZSBjbG9ja2dlbiBub2RlIGhhcyBy
ZWcgcHJvcGVydHksIGhvd2V2ZXIsIGFsbCBvdGhlciBub2RlcyBoYXZlIHJlZyBwcm9wZXJ0eSB0
b28gKFRoZSBjbG9ja2dlbiBwb2ludHMgdG8gdGhlIGNsb2NraW5nIGJsb2NrIGFkZHJlc3MgYW5k
IHRoZSBzdWIgbm9kZXMgcG9pbnQgdG8gdGhlIHNwZWNpZmljIHJlZ2lzdGVyIGluIHRoZSBjbG9j
ayBibG9jaykuDQpEbyB5b3Ugd2FudCB0byBjaGFuZ2UgdGhpcyBzdHJ1Y3R1cmUgY29tcGxldGVs
eT8NCkknbSBub3Qgc3VyZSBJIHVuZGVyc3RhbmQgdGhlIGV4YWN0IHdheSB5b3Ugd2FudCBzZWUg
dGhvc2Ugbm9kZXMgKGluIHRoZSBmaW5hbCBzdGF0ZSkuDQoNCj4gPiBIb3dldmVyLCBJJ20gbm90
IHN1cmUgd2hpY2ggY2hhbmdlcyB5b3Ugd2FudCB0byBwZXJmb3JtIGluIHRoZSBub2RlDQo+IChi
ZXNpZGUgYWRkaW5nIHJlZyBwcm9wZXJ0eSBmb3IgU29DIHdoaWNoIGhhcyBpdCBmb3IgRk1hbiBj
bG9jaykuDQo+IA0KPiBBZ2FpbiwgdGhlIGNsb2NrZ2VuIG5vZGUgYWxyZWFkeSBoYXMgYSByZWcg
cHJvcGVydHkuDQo+IA0KPiAtU2NvdHQNCj4gDQoNCg==

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Tue, 2015-05-05 at 16:02 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, May 02, 2015 2:43 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Tang
> > Yuantian-B29983
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Thu, 2015-04-30 at 09:28 -0500, Liberman Igal-B31950 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, April 30, 2015 3:31 AM
> > > > To: Liberman Igal-B31950
> > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Tang
> > > > Yuantian-B29983
> > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > > On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> > > > > We have 2 cases:
> > > > > 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> > > > > 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx
> > > > devices
> > > > > have many options, T1 has only one option)
> > > > >
> > > > > For the first group, we can have " qoriq-hwacsr" property in the clock
> > node.
> > > >
> > > > No, we're not going to describe every register with its own property.
> > > > Describe the chip and let the driver be the place with the knowledge
> > > > of what each chip is like.
> > > >
> > >
> > > I think that FMan clock mux (as we defined it) is similar to other muxes
> > available in our SoC.
> > 
> > I realize that.  I'm saying the way we described existing muxes seems to be a
> > mistake.  We're putting too much complexity in the device tree.
> > Better to put the complexity in a place that isn't stable ABI.
> > 
> > > If we take T4 as example, it has 3 muxes defined in the device tree (mux0,
> > mux1 and mux2).
> > > Each mux has its own reg property (and clock providers).
> > > 	mux2: mux2@40 {
> > > 		#clock-cells = <0>;
> > > 		reg = <0x40 0x4>;
> > > 		compatible = "fsl,qoriq-core-mux-2.0";
> > > 		clocks = <&pll3 0>, <&pll3 1>, <&pll3 2>,
> > > 			<&pll4 0>, <&pll4 1>, <&pll4 2>;
> > > 		clock-names = "pll3", "pll3-div2", "pll3-div4",
> > > 			"pll4", "pll4-div2", "pll4-div4";
> > > 		clock-output-names = "cmux2";
> > > 	};
> > >
> > > I agree that "fm1-clk-mux" need to be moved from the "guts" node to
> > "clockgen" node.
> > 
> > That's not what I was saying.  I'm saying get rid of the node entirely, in favor
> > of having the clockgen node itself be a clock source with multiple post-mux
> > outputs.
> > 
> 
> Scott,
> Currently the clockgen node has a number of sub nodes (platform clock, sysclock, PLLs and muxes, the number of muxes/PLLs is SoC dependent).
> The clockgen node has reg property, however, all other nodes have reg property too (The clockgen points to the clocking block address and the sub nodes point to the specific register in the clock block).
> Do you want to change this structure completely?

Yes, I want to change it completely (while ensuring the kernel still
works, albeit without new functionality, with older device trees).

> I'm not sure I understand the exact way you want see those nodes (in the final state).

Something like:

clockgen: global-utilities@e1000 {
	compatible = "fsl,<whatever>-clockgen";
	clock-frequency = <...>;
	reg = <0xe1000 0x1000>;
	#clock-cells = <2>;
};

cpu0: PowerPC,e6500@0 {
	device_type = "cpu";
	reg = <0 1>;
	clocks = <&clockgen 0 0>;
	next-level-cache = <&L2_1>;
	fsl,portid-mapping = <0x80000000>;
};


cpu4: PowerPC,e6500@0 {
	device_type = "cpu";
	reg = <4 5>;
	clocks = <&clockgen 0 1>;
	next-level-cache = <&L2_1>;
	fsl,portid-mapping = <0x80000000>;
};

fman@... {
	...
	clocks = <&clockgen 1 0>;
	...
};

...with the clockgen binding explaining the format of the clock
specifier, and the clockgen driver containing the chip-specific muxing
details.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Tue, 2015-05-05 at 16:02 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, May 02, 2015 2:43 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> > Yuantian-B29983
> > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Thu, 2015-04-30 at 09:28 -0500, Liberman Igal-B31950 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, April 30, 2015 3:31 AM
> > > > To: Liberman Igal-B31950
> > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Tang
> > > > Yuantian-B29983
> > > > Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > > On Wed, 2015-04-22 at 05:47 -0500, Liberman Igal-B31950 wrote:
> > > > > We have 2 cases:
> > > > > 	- Devices (T2/T4/B4) with CLKCG1HWACSR register.
> > > > > 	- Devices (Pxxxx, T1) without CLKCG1HWACSR register (Pxxxx
> > > > devices
> > > > > have many options, T1 has only one option)
> > > > >
> > > > > For the first group, we can have " qoriq-hwacsr" property in the clock
> > node.
> > > >
> > > > No, we're not going to describe every register with its own property.
> > > > Describe the chip and let the driver be the place with the knowledge
> > > > of what each chip is like.
> > > >
> > >
> > > I think that FMan clock mux (as we defined it) is similar to other muxes
> > available in our SoC.
> > 
> > I realize that.  I'm saying the way we described existing muxes seems to be a
> > mistake.  We're putting too much complexity in the device tree.
> > Better to put the complexity in a place that isn't stable ABI.
> > 
> > > If we take T4 as example, it has 3 muxes defined in the device tree (mux0,
> > mux1 and mux2).
> > > Each mux has its own reg property (and clock providers).
> > > 	mux2: mux2@40 {
> > > 		#clock-cells = <0>;
> > > 		reg = <0x40 0x4>;
> > > 		compatible = "fsl,qoriq-core-mux-2.0";
> > > 		clocks = <&pll3 0>, <&pll3 1>, <&pll3 2>,
> > > 			<&pll4 0>, <&pll4 1>, <&pll4 2>;
> > > 		clock-names = "pll3", "pll3-div2", "pll3-div4",
> > > 			"pll4", "pll4-div2", "pll4-div4";
> > > 		clock-output-names = "cmux2";
> > > 	};
> > >
> > > I agree that "fm1-clk-mux" need to be moved from the "guts" node to
> > "clockgen" node.
> > 
> > That's not what I was saying.  I'm saying get rid of the node entirely, in favor
> > of having the clockgen node itself be a clock source with multiple post-mux
> > outputs.
> > 
> 
> Scott,
> Currently the clockgen node has a number of sub nodes (platform clock, sysclock, PLLs and muxes, the number of muxes/PLLs is SoC dependent).
> The clockgen node has reg property, however, all other nodes have reg property too (The clockgen points to the clocking block address and the sub nodes point to the specific register in the clock block).
> Do you want to change this structure completely?

Yes, I want to change it completely (while ensuring the kernel still
works, albeit without new functionality, with older device trees).

> I'm not sure I understand the exact way you want see those nodes (in the final state).

Something like:

clockgen: global-utilities@e1000 {
	compatible = "fsl,<whatever>-clockgen";
	clock-frequency = <...>;
	reg = <0xe1000 0x1000>;
	#clock-cells = <2>;
};

cpu0: PowerPC,e6500@0 {
	device_type = "cpu";
	reg = <0 1>;
	clocks = <&clockgen 0 0>;
	next-level-cache = <&L2_1>;
	fsl,portid-mapping = <0x80000000>;
};


cpu4: PowerPC,e6500@0 {
	device_type = "cpu";
	reg = <4 5>;
	clocks = <&clockgen 0 1>;
	next-level-cache = <&L2_1>;
	fsl,portid-mapping = <0x80000000>;
};

fman@... {
	...
	clocks = <&clockgen 1 0>;
	...
};

...with the clockgen binding explaining the format of the clock
specifier, and the clockgen driver containing the chip-specific muxing
details.

-Scott