From: "Rafael J. Wysocki" <rjw@rjwysocki.net> To: Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>, Len Brown <len.brown@intel.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-pm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [FOR DISCUSSION 0/9] Dove PMU support Date: Fri, 20 Mar 2015 13:44:30 +0100 [thread overview] Message-ID: <1466359.8taRhRkKWI@vostro.rjw.lan> (raw) In-Reply-To: <20150320121659.GJ8656@n2100.arm.linux.org.uk> On Friday, March 20, 2015 12:16:59 PM Russell King - ARM Linux wrote: > On Thu, Mar 19, 2015 at 11:02:35PM +0100, Rafael J. Wysocki wrote: > > On Thursday, March 19, 2015 10:59:20 PM Rafael J. Wysocki wrote: > > > On Thursday, March 12, 2015 06:30:21 PM Russell King - ARM Linux wrote: > > > > This is a re-posting of the patch set which I posted almost 10 months > > > > ago to support the Dove PMU, with a few additional changes. This set > > > > is based upon 3.19. > > > > > > > > In this set are: > > > > > > > > * two patches which Rafael originally acked, but there was indecision > > > > last time around how to handle them due to potential conflicts with > > > > work that Ulf was doing. These patches have been updated to apply > > > > cleanly to 3.19. I don't know if people want to take these as > > > > fixes to the PM domain code or not (hence why I'm posting this > > > > series during the merge window - if it weren't for this, I'd hold > > > > it off.) > > > > > > > > * what I regard as a fix to the PM domain code; as a result of a > > > > previous commit, the PM domain code mismatches the runtime PM state, > > > > which leads to the PM domain being unexpectedly left on. This patch > > > > has been re-worked to try an alternative approach, syncing the PM > > > > domain state with the runtime PM state after the probe has completed. > > > > > > > > * the addition of the core Dove PMU driver, which consists of a reset, > > > > IRQ controller, and power domains. The reset and power domain code > > > > has to be closely related due to the power up/down requirements of > > > > the GPU/VPU subsystems needing to be performed atomically. (This > > > > requirement prevents it using the MFD infrastructure, because we > > > > would need to hold spinlocks while calling several different > > > > sub-drivers.) > > > > > > > > * addition of the RTC interrupt, so we can now receive and act on > > > > alarms generated by the Dove RTC. > > > > > > > > * addition of the DT descriptions for the GPU and VPU power domains. > > > > These patches do not themselves add the DT descriptions for these > > > > units, so these patches serve as illustrations how these should be > > > > described. > > > > > > > > > > I can apply patches [1-3/9] from this series if that helps. > > > > I mean from the next version of it ([FOR DISCUSSION 0/10] Dove PMU support). > > Kevin had some comments on patch 2 which I think ought to be addressed. > He's quite right that dev_to_genpd() should be hidden from view and > replaced with the safer pm_genpd_lookup_dev() version - even though > pm_genpd_lookup_dev() itself is not fully safe against the domain > on a device changing beneath it. > > If you want to hold on, I'll respin with his comments there addressed, > or if you prefer to merge them as-is and fix Kevin's comments afterwards, > that's also fine by me. Both work for me, actually. I think that Kevin has ACKed the patch despite the comments, so it would be fine to apply it I guess. > I'd just be happy to see some progress on this series. :) Sure.
WARNING: multiple messages have this Message-ID (diff)
From: rjw@rjwysocki.net (Rafael J. Wysocki) To: linux-arm-kernel@lists.infradead.org Subject: [FOR DISCUSSION 0/9] Dove PMU support Date: Fri, 20 Mar 2015 13:44:30 +0100 [thread overview] Message-ID: <1466359.8taRhRkKWI@vostro.rjw.lan> (raw) In-Reply-To: <20150320121659.GJ8656@n2100.arm.linux.org.uk> On Friday, March 20, 2015 12:16:59 PM Russell King - ARM Linux wrote: > On Thu, Mar 19, 2015 at 11:02:35PM +0100, Rafael J. Wysocki wrote: > > On Thursday, March 19, 2015 10:59:20 PM Rafael J. Wysocki wrote: > > > On Thursday, March 12, 2015 06:30:21 PM Russell King - ARM Linux wrote: > > > > This is a re-posting of the patch set which I posted almost 10 months > > > > ago to support the Dove PMU, with a few additional changes. This set > > > > is based upon 3.19. > > > > > > > > In this set are: > > > > > > > > * two patches which Rafael originally acked, but there was indecision > > > > last time around how to handle them due to potential conflicts with > > > > work that Ulf was doing. These patches have been updated to apply > > > > cleanly to 3.19. I don't know if people want to take these as > > > > fixes to the PM domain code or not (hence why I'm posting this > > > > series during the merge window - if it weren't for this, I'd hold > > > > it off.) > > > > > > > > * what I regard as a fix to the PM domain code; as a result of a > > > > previous commit, the PM domain code mismatches the runtime PM state, > > > > which leads to the PM domain being unexpectedly left on. This patch > > > > has been re-worked to try an alternative approach, syncing the PM > > > > domain state with the runtime PM state after the probe has completed. > > > > > > > > * the addition of the core Dove PMU driver, which consists of a reset, > > > > IRQ controller, and power domains. The reset and power domain code > > > > has to be closely related due to the power up/down requirements of > > > > the GPU/VPU subsystems needing to be performed atomically. (This > > > > requirement prevents it using the MFD infrastructure, because we > > > > would need to hold spinlocks while calling several different > > > > sub-drivers.) > > > > > > > > * addition of the RTC interrupt, so we can now receive and act on > > > > alarms generated by the Dove RTC. > > > > > > > > * addition of the DT descriptions for the GPU and VPU power domains. > > > > These patches do not themselves add the DT descriptions for these > > > > units, so these patches serve as illustrations how these should be > > > > described. > > > > > > > > > > I can apply patches [1-3/9] from this series if that helps. > > > > I mean from the next version of it ([FOR DISCUSSION 0/10] Dove PMU support). > > Kevin had some comments on patch 2 which I think ought to be addressed. > He's quite right that dev_to_genpd() should be hidden from view and > replaced with the safer pm_genpd_lookup_dev() version - even though > pm_genpd_lookup_dev() itself is not fully safe against the domain > on a device changing beneath it. > > If you want to hold on, I'll respin with his comments there addressed, > or if you prefer to merge them as-is and fix Kevin's comments afterwards, > that's also fine by me. Both work for me, actually. I think that Kevin has ACKed the patch despite the comments, so it would be fine to apply it I guess. > I'd just be happy to see some progress on this series. :) Sure.
next prev parent reply other threads:[~2015-03-20 12:44 UTC|newest] Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-12 18:30 [FOR DISCUSSION 0/9] Dove PMU support Russell King - ARM Linux 2015-03-12 18:30 ` Russell King - ARM Linux 2015-03-12 18:30 ` [PATCH 1/9] pm: domains: quieten down generic pm domains Russell King 2015-03-13 8:46 ` Ulf Hansson 2015-03-13 15:57 ` Kevin Hilman 2015-03-12 18:31 ` [PATCH 2/9] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-13 8:56 ` Ulf Hansson 2015-03-13 9:20 ` Russell King - ARM Linux 2015-03-13 12:45 ` Geert Uytterhoeven 2015-03-14 1:27 ` Rafael J. Wysocki 2015-03-13 13:23 ` Russell King - ARM Linux 2015-03-13 16:33 ` Kevin Hilman 2015-03-13 16:58 ` Russell King - ARM Linux 2015-03-12 18:31 ` [PATCH 3/9] pm: domains: sync runtime PM status with PM domains after probe Russell King 2015-03-12 23:25 ` Rafael J. Wysocki 2015-03-13 9:30 ` Ulf Hansson 2015-03-13 10:14 ` Russell King - ARM Linux 2015-03-13 10:42 ` Ulf Hansson 2015-03-13 13:39 ` Russell King - ARM Linux 2015-03-13 16:45 ` Kevin Hilman 2015-03-12 18:31 ` [PATCH 5/9] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets Russell King 2015-03-13 12:07 ` Arnd Bergmann 2015-03-13 12:29 ` Russell King - ARM Linux 2015-03-13 12:42 ` Arnd Bergmann 2015-03-13 12:47 ` Russell King - ARM Linux 2015-03-13 15:08 ` Arnd Bergmann 2015-03-13 15:28 ` Russell King - ARM Linux 2015-03-13 15:36 ` Arnd Bergmann 2015-03-13 12:59 ` Russell King - ARM Linux 2015-03-13 16:22 ` [FOR DISCUSSION 0/10] Dove PMU support Russell King - ARM Linux 2015-03-13 16:23 ` [PATCH 01/10] pm: domains: quieten down generic pm domains Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:10 ` Kevin Hilman 2015-03-13 17:10 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 02/10] pm: domains: factor out code to get the generic PM domain from a struct device Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:20 ` Kevin Hilman 2015-03-13 17:20 ` Kevin Hilman 2015-03-13 17:35 ` Russell King - ARM Linux 2015-03-13 17:35 ` Russell King - ARM Linux 2015-03-13 16:23 ` [PATCH 03/10] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:28 ` Kevin Hilman 2015-03-13 17:28 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 06/10] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets Russell King [not found] ` <20150312183020.GU8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2015-03-12 18:31 ` [PATCH 4/9] dt-bindings: add Marvell PMU documentation Russell King [not found] ` <E1YW7t0-0003mE-My-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-12 21:32 ` Rob Herring [not found] ` <CAL_Jsq+R70GVsuig7Ebo49_MeneD_RZ=E0haTVsb_xFhTR7-pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-03-12 21:42 ` Russell King - ARM Linux 2015-03-13 12:02 ` Arnd Bergmann 2015-03-12 18:31 ` [PATCH 6/9] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Russell King 2015-03-12 18:31 ` Russell King [not found] ` <E1YW7tB-0003mM-1L-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-13 12:30 ` Thomas Petazzoni 2015-03-13 12:30 ` Thomas Petazzoni [not found] ` <20150313133038.0a3ae8d1-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-03-13 12:33 ` Russell King - ARM Linux 2015-03-13 12:33 ` Russell King - ARM Linux 2015-03-16 18:27 ` Gregory CLEMENT 2015-03-16 18:27 ` Gregory CLEMENT [not found] ` <55072092.9040207-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-03-17 13:43 ` Russell King - ARM Linux 2015-03-17 13:43 ` Russell King - ARM Linux [not found] ` <20150317134335.GV8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2015-03-17 15:09 ` Sebastian Hesselbarth 2015-03-17 15:09 ` Sebastian Hesselbarth [not found] ` <5508439F.4000507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-03-17 15:15 ` Russell King - ARM Linux 2015-03-17 15:15 ` Russell King - ARM Linux 2015-03-25 8:25 ` Linus Walleij 2015-03-25 8:25 ` Linus Walleij 2015-03-12 18:31 ` [PATCH 7/9] ARM: dt: dove: wire up RTC interrupt Russell King 2015-03-12 18:31 ` Russell King 2015-03-12 18:31 ` [PATCH 8/9] ARM: dt: dove: add video decoder power domain description Russell King 2015-03-12 18:31 ` Russell King 2015-03-12 18:31 ` [PATCH 9/9] ARM: dt: dove: add GPU " Russell King 2015-03-12 18:31 ` Russell King 2015-03-13 11:57 ` [FOR DISCUSSION 0/9] Dove PMU support Arnd Bergmann 2015-03-13 11:57 ` Arnd Bergmann 2015-03-13 12:11 ` Russell King - ARM Linux 2015-03-13 12:11 ` Russell King - ARM Linux 2015-03-13 12:26 ` Arnd Bergmann 2015-03-13 12:26 ` Arnd Bergmann 2015-03-13 12:32 ` Russell King - ARM Linux 2015-03-13 12:32 ` Russell King - ARM Linux 2015-03-13 12:47 ` Arnd Bergmann 2015-03-13 12:47 ` Arnd Bergmann 2015-03-13 16:23 ` [PATCH 04/10] pm: domains: sync runtime PM status with PM domains after probe Russell King 2015-03-13 16:23 ` Russell King [not found] ` <E1YWSN5-0006G5-Ld-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-13 17:33 ` Kevin Hilman 2015-03-13 17:33 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 05/10] dt-bindings: add Marvell PMU documentation Russell King 2015-03-13 16:23 ` Russell King [not found] ` <E1YWSNA-0006G9-Rr-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-17 0:28 ` Rob Herring 2015-03-17 0:28 ` Rob Herring 2015-03-13 16:23 ` [PATCH 07/10] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 16:23 ` [PATCH 08/10] ARM: dt: dove: wire up RTC interrupt Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 16:24 ` [PATCH 09/10] ARM: dt: dove: add video decoder power domain description Russell King 2015-03-13 16:24 ` Russell King 2015-03-13 16:24 ` [PATCH 10/10] ARM: dt: dove: add GPU " Russell King 2015-03-13 16:24 ` Russell King 2015-03-19 21:59 ` [FOR DISCUSSION 0/9] Dove PMU support Rafael J. Wysocki 2015-03-19 21:59 ` Rafael J. Wysocki 2015-03-19 22:02 ` Rafael J. Wysocki 2015-03-19 22:02 ` Rafael J. Wysocki 2015-03-20 12:16 ` Russell King - ARM Linux 2015-03-20 12:16 ` Russell King - ARM Linux 2015-03-20 12:44 ` Rafael J. Wysocki [this message] 2015-03-20 12:44 ` Rafael J. Wysocki 2015-03-20 17:19 ` Russell King - ARM Linux 2015-03-20 17:19 ` Russell King - ARM Linux 2015-03-20 17:20 ` [PATCH 1/3] pm: domains: quieten down generic pm domains Russell King 2015-03-20 17:20 ` Russell King 2015-03-20 17:20 ` [PATCH 2/3] pm: domains: factor out code to get the generic PM domain from a struct device Russell King 2015-03-20 17:20 ` Russell King 2015-03-23 13:28 ` Ulf Hansson 2015-03-23 13:28 ` Ulf Hansson 2015-03-23 15:17 ` Russell King - ARM Linux 2015-03-23 15:17 ` Russell King - ARM Linux 2015-03-24 0:29 ` Rafael J. Wysocki 2015-03-24 0:29 ` Rafael J. Wysocki 2015-03-26 15:20 ` Russell King - ARM Linux 2015-03-26 15:20 ` Russell King - ARM Linux 2015-03-26 16:00 ` Russell King - ARM Linux 2015-03-26 16:00 ` Russell King - ARM Linux 2015-03-20 17:20 ` [PATCH 3/3] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-20 17:20 ` Russell King 2015-03-23 13:32 ` Ulf Hansson 2015-03-23 13:32 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1466359.8taRhRkKWI@vostro.rjw.lan \ --to=rjw@rjwysocki.net \ --cc=andrew@lunn.ch \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=gregkh@linuxfoundation.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jason@lakedaemon.net \ --cc=len.brown@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.