From: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>, Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [PATCH 6/9] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Date: Tue, 17 Mar 2015 16:09:19 +0100 [thread overview] Message-ID: <5508439F.4000507@gmail.com> (raw) In-Reply-To: <20150317134335.GV8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> On 03/17/2015 02:43 PM, Russell King - ARM Linux wrote: > On Mon, Mar 16, 2015 at 07:27:30PM +0100, Gregory CLEMENT wrote: >>> + pmu: power-management@d0000 { >>> + compatible = "marvell,dove-pmu"; >>> + reg = <0xd0000 0x8000>, <0xd8000 0x8000>; >> >> Here you overlap some other nodes such as the thermal one (from 0xd001c >> to 0xd0028), the clock gate one (from 0xd0038 to 0xd003c), the gpio one, >> the pinctrl one ... > > Yes, I'm well aware of that, but here's the thing... > > I'm describing the hardware here. > > The real problem is that Dove (etc) went down the path of breaking up > the PMU device into multiple smaller devices each specifying a sub-set > of the register range. By doing that, Dove moved away from describing Russell, I totally agree that from today's point-of-view having a single pmu node with sub-nodes would have been the better approach. > the hardware - instead, we've described the Linux _implementation_ with > its separate (sub-)devices - its the implementation's choice that we'd > break up the PMU into these separate devices, almost to the point of > specifying each individual register. > > What could be done to work around this oversight is to mvoe these > devices beneath the PMU node, which IMHO makes complete sense as these > are sub-devices of the PMU/PMC rather than separate devices. If we do this, we should have a look at syscon and potentially also simple-mfd which will allow us to share the registers and register platform_devices for the sub-nodes. The current pmu power/reset/irq can still use the extra locking and directly access MMIO registers - but for the others we should really look into using regmaps. The only thing here is that power domain descriptions are also encoded as direct sub-nodes of the pmu node, right? Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/9] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Date: Tue, 17 Mar 2015 16:09:19 +0100 [thread overview] Message-ID: <5508439F.4000507@gmail.com> (raw) In-Reply-To: <20150317134335.GV8656@n2100.arm.linux.org.uk> On 03/17/2015 02:43 PM, Russell King - ARM Linux wrote: > On Mon, Mar 16, 2015 at 07:27:30PM +0100, Gregory CLEMENT wrote: >>> + pmu: power-management at d0000 { >>> + compatible = "marvell,dove-pmu"; >>> + reg = <0xd0000 0x8000>, <0xd8000 0x8000>; >> >> Here you overlap some other nodes such as the thermal one (from 0xd001c >> to 0xd0028), the clock gate one (from 0xd0038 to 0xd003c), the gpio one, >> the pinctrl one ... > > Yes, I'm well aware of that, but here's the thing... > > I'm describing the hardware here. > > The real problem is that Dove (etc) went down the path of breaking up > the PMU device into multiple smaller devices each specifying a sub-set > of the register range. By doing that, Dove moved away from describing Russell, I totally agree that from today's point-of-view having a single pmu node with sub-nodes would have been the better approach. > the hardware - instead, we've described the Linux _implementation_ with > its separate (sub-)devices - its the implementation's choice that we'd > break up the PMU into these separate devices, almost to the point of > specifying each individual register. > > What could be done to work around this oversight is to mvoe these > devices beneath the PMU node, which IMHO makes complete sense as these > are sub-devices of the PMU/PMC rather than separate devices. If we do this, we should have a look at syscon and potentially also simple-mfd which will allow us to share the registers and register platform_devices for the sub-nodes. The current pmu power/reset/irq can still use the extra locking and directly access MMIO registers - but for the others we should really look into using regmaps. The only thing here is that power domain descriptions are also encoded as direct sub-nodes of the pmu node, right? Sebastian
next prev parent reply other threads:[~2015-03-17 15:09 UTC|newest] Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-12 18:30 [FOR DISCUSSION 0/9] Dove PMU support Russell King - ARM Linux 2015-03-12 18:30 ` Russell King - ARM Linux 2015-03-12 18:30 ` [PATCH 1/9] pm: domains: quieten down generic pm domains Russell King 2015-03-13 8:46 ` Ulf Hansson 2015-03-13 15:57 ` Kevin Hilman 2015-03-12 18:31 ` [PATCH 2/9] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-13 8:56 ` Ulf Hansson 2015-03-13 9:20 ` Russell King - ARM Linux 2015-03-13 12:45 ` Geert Uytterhoeven 2015-03-14 1:27 ` Rafael J. Wysocki 2015-03-13 13:23 ` Russell King - ARM Linux 2015-03-13 16:33 ` Kevin Hilman 2015-03-13 16:58 ` Russell King - ARM Linux 2015-03-12 18:31 ` [PATCH 3/9] pm: domains: sync runtime PM status with PM domains after probe Russell King 2015-03-12 23:25 ` Rafael J. Wysocki 2015-03-13 9:30 ` Ulf Hansson 2015-03-13 10:14 ` Russell King - ARM Linux 2015-03-13 10:42 ` Ulf Hansson 2015-03-13 13:39 ` Russell King - ARM Linux 2015-03-13 16:45 ` Kevin Hilman 2015-03-12 18:31 ` [PATCH 5/9] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets Russell King 2015-03-13 12:07 ` Arnd Bergmann 2015-03-13 12:29 ` Russell King - ARM Linux 2015-03-13 12:42 ` Arnd Bergmann 2015-03-13 12:47 ` Russell King - ARM Linux 2015-03-13 15:08 ` Arnd Bergmann 2015-03-13 15:28 ` Russell King - ARM Linux 2015-03-13 15:36 ` Arnd Bergmann 2015-03-13 12:59 ` Russell King - ARM Linux 2015-03-13 16:22 ` [FOR DISCUSSION 0/10] Dove PMU support Russell King - ARM Linux 2015-03-13 16:23 ` [PATCH 01/10] pm: domains: quieten down generic pm domains Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:10 ` Kevin Hilman 2015-03-13 17:10 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 02/10] pm: domains: factor out code to get the generic PM domain from a struct device Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:20 ` Kevin Hilman 2015-03-13 17:20 ` Kevin Hilman 2015-03-13 17:35 ` Russell King - ARM Linux 2015-03-13 17:35 ` Russell King - ARM Linux 2015-03-13 16:23 ` [PATCH 03/10] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:28 ` Kevin Hilman 2015-03-13 17:28 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 06/10] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets Russell King [not found] ` <20150312183020.GU8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2015-03-12 18:31 ` [PATCH 4/9] dt-bindings: add Marvell PMU documentation Russell King [not found] ` <E1YW7t0-0003mE-My-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-12 21:32 ` Rob Herring [not found] ` <CAL_Jsq+R70GVsuig7Ebo49_MeneD_RZ=E0haTVsb_xFhTR7-pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-03-12 21:42 ` Russell King - ARM Linux 2015-03-13 12:02 ` Arnd Bergmann 2015-03-12 18:31 ` [PATCH 6/9] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Russell King 2015-03-12 18:31 ` Russell King [not found] ` <E1YW7tB-0003mM-1L-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-13 12:30 ` Thomas Petazzoni 2015-03-13 12:30 ` Thomas Petazzoni [not found] ` <20150313133038.0a3ae8d1-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-03-13 12:33 ` Russell King - ARM Linux 2015-03-13 12:33 ` Russell King - ARM Linux 2015-03-16 18:27 ` Gregory CLEMENT 2015-03-16 18:27 ` Gregory CLEMENT [not found] ` <55072092.9040207-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-03-17 13:43 ` Russell King - ARM Linux 2015-03-17 13:43 ` Russell King - ARM Linux [not found] ` <20150317134335.GV8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2015-03-17 15:09 ` Sebastian Hesselbarth [this message] 2015-03-17 15:09 ` Sebastian Hesselbarth [not found] ` <5508439F.4000507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-03-17 15:15 ` Russell King - ARM Linux 2015-03-17 15:15 ` Russell King - ARM Linux 2015-03-25 8:25 ` Linus Walleij 2015-03-25 8:25 ` Linus Walleij 2015-03-12 18:31 ` [PATCH 7/9] ARM: dt: dove: wire up RTC interrupt Russell King 2015-03-12 18:31 ` Russell King 2015-03-12 18:31 ` [PATCH 8/9] ARM: dt: dove: add video decoder power domain description Russell King 2015-03-12 18:31 ` Russell King 2015-03-12 18:31 ` [PATCH 9/9] ARM: dt: dove: add GPU " Russell King 2015-03-12 18:31 ` Russell King 2015-03-13 11:57 ` [FOR DISCUSSION 0/9] Dove PMU support Arnd Bergmann 2015-03-13 11:57 ` Arnd Bergmann 2015-03-13 12:11 ` Russell King - ARM Linux 2015-03-13 12:11 ` Russell King - ARM Linux 2015-03-13 12:26 ` Arnd Bergmann 2015-03-13 12:26 ` Arnd Bergmann 2015-03-13 12:32 ` Russell King - ARM Linux 2015-03-13 12:32 ` Russell King - ARM Linux 2015-03-13 12:47 ` Arnd Bergmann 2015-03-13 12:47 ` Arnd Bergmann 2015-03-13 16:23 ` [PATCH 04/10] pm: domains: sync runtime PM status with PM domains after probe Russell King 2015-03-13 16:23 ` Russell King [not found] ` <E1YWSN5-0006G5-Ld-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-13 17:33 ` Kevin Hilman 2015-03-13 17:33 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 05/10] dt-bindings: add Marvell PMU documentation Russell King 2015-03-13 16:23 ` Russell King [not found] ` <E1YWSNA-0006G9-Rr-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-17 0:28 ` Rob Herring 2015-03-17 0:28 ` Rob Herring 2015-03-13 16:23 ` [PATCH 07/10] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 16:23 ` [PATCH 08/10] ARM: dt: dove: wire up RTC interrupt Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 16:24 ` [PATCH 09/10] ARM: dt: dove: add video decoder power domain description Russell King 2015-03-13 16:24 ` Russell King 2015-03-13 16:24 ` [PATCH 10/10] ARM: dt: dove: add GPU " Russell King 2015-03-13 16:24 ` Russell King 2015-03-19 21:59 ` [FOR DISCUSSION 0/9] Dove PMU support Rafael J. Wysocki 2015-03-19 21:59 ` Rafael J. Wysocki 2015-03-19 22:02 ` Rafael J. Wysocki 2015-03-19 22:02 ` Rafael J. Wysocki 2015-03-20 12:16 ` Russell King - ARM Linux 2015-03-20 12:16 ` Russell King - ARM Linux 2015-03-20 12:44 ` Rafael J. Wysocki 2015-03-20 12:44 ` Rafael J. Wysocki 2015-03-20 17:19 ` Russell King - ARM Linux 2015-03-20 17:19 ` Russell King - ARM Linux 2015-03-20 17:20 ` [PATCH 1/3] pm: domains: quieten down generic pm domains Russell King 2015-03-20 17:20 ` Russell King 2015-03-20 17:20 ` [PATCH 2/3] pm: domains: factor out code to get the generic PM domain from a struct device Russell King 2015-03-20 17:20 ` Russell King 2015-03-23 13:28 ` Ulf Hansson 2015-03-23 13:28 ` Ulf Hansson 2015-03-23 15:17 ` Russell King - ARM Linux 2015-03-23 15:17 ` Russell King - ARM Linux 2015-03-24 0:29 ` Rafael J. Wysocki 2015-03-24 0:29 ` Rafael J. Wysocki 2015-03-26 15:20 ` Russell King - ARM Linux 2015-03-26 15:20 ` Russell King - ARM Linux 2015-03-26 16:00 ` Russell King - ARM Linux 2015-03-26 16:00 ` Russell King - ARM Linux 2015-03-20 17:20 ` [PATCH 3/3] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-20 17:20 ` Russell King 2015-03-23 13:32 ` Ulf Hansson 2015-03-23 13:32 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5508439F.4000507@gmail.com \ --to=sebastian.hesselbarth-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=andrew-g2DYL2Zd6BY@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \ --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \ --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \ --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.