From: Kevin Hilman <khilman@kernel.org> To: Russell King <rmk+kernel@arm.linux.org.uk> Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, linux-arm-kernel@lists.infradead.org, Len Brown <len.brown@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-pm@vger.kernel.org Subject: Re: [PATCH 03/10] pm: domains: avoid potential oops in pm_genpd_remove_device() Date: Fri, 13 Mar 2015 10:28:38 -0700 [thread overview] Message-ID: <7ha8zgrem1.fsf@deeprootsystems.com> (raw) In-Reply-To: <E1YWSN0-0006G1-I1@rmk-PC.arm.linux.org.uk> (Russell King's message of "Fri, 13 Mar 2015 16:23:30 +0000") Russell King <rmk+kernel@arm.linux.org.uk> writes: > pm_genpd_remove_device() tries hard to validate the generic PM domain > passed to it, but the validation is not complete. > > dev->pm_domain contains a struct dev_pm_domain, which is the "base > class" of generic PM domains. Other users of dev_pm_domains include > stuff like vga_switheroo. Hence, a device could have a generic PM > domain or a vga_switcheroo PM domain in dev->pm_domain. > > We need ot be certain that the PM domain is actually valid before we > try to remove it. nit: We need to be certain that the PM domain is a valid genpd before we try to remove the device. > We can do this easily as we have a way to get the > current validated generic PM domain for a struct device. This must > match the generic PM domain being requested for removal. > > Convert the code to use this alternative validation method instead. > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Otherwise, Acked-by: Kevin Hilman <khilman@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/10] pm: domains: avoid potential oops in pm_genpd_remove_device() Date: Fri, 13 Mar 2015 10:28:38 -0700 [thread overview] Message-ID: <7ha8zgrem1.fsf@deeprootsystems.com> (raw) In-Reply-To: <E1YWSN0-0006G1-I1@rmk-PC.arm.linux.org.uk> (Russell King's message of "Fri, 13 Mar 2015 16:23:30 +0000") Russell King <rmk+kernel@arm.linux.org.uk> writes: > pm_genpd_remove_device() tries hard to validate the generic PM domain > passed to it, but the validation is not complete. > > dev->pm_domain contains a struct dev_pm_domain, which is the "base > class" of generic PM domains. Other users of dev_pm_domains include > stuff like vga_switheroo. Hence, a device could have a generic PM > domain or a vga_switcheroo PM domain in dev->pm_domain. > > We need ot be certain that the PM domain is actually valid before we > try to remove it. nit: We need to be certain that the PM domain is a valid genpd before we try to remove the device. > We can do this easily as we have a way to get the > current validated generic PM domain for a struct device. This must > match the generic PM domain being requested for removal. > > Convert the code to use this alternative validation method instead. > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Otherwise, Acked-by: Kevin Hilman <khilman@linaro.org>
next prev parent reply other threads:[~2015-03-13 17:28 UTC|newest] Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-12 18:30 [FOR DISCUSSION 0/9] Dove PMU support Russell King - ARM Linux 2015-03-12 18:30 ` Russell King - ARM Linux 2015-03-12 18:30 ` [PATCH 1/9] pm: domains: quieten down generic pm domains Russell King 2015-03-13 8:46 ` Ulf Hansson 2015-03-13 15:57 ` Kevin Hilman 2015-03-12 18:31 ` [PATCH 2/9] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-13 8:56 ` Ulf Hansson 2015-03-13 9:20 ` Russell King - ARM Linux 2015-03-13 12:45 ` Geert Uytterhoeven 2015-03-14 1:27 ` Rafael J. Wysocki 2015-03-13 13:23 ` Russell King - ARM Linux 2015-03-13 16:33 ` Kevin Hilman 2015-03-13 16:58 ` Russell King - ARM Linux 2015-03-12 18:31 ` [PATCH 3/9] pm: domains: sync runtime PM status with PM domains after probe Russell King 2015-03-12 23:25 ` Rafael J. Wysocki 2015-03-13 9:30 ` Ulf Hansson 2015-03-13 10:14 ` Russell King - ARM Linux 2015-03-13 10:42 ` Ulf Hansson 2015-03-13 13:39 ` Russell King - ARM Linux 2015-03-13 16:45 ` Kevin Hilman 2015-03-12 18:31 ` [PATCH 5/9] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets Russell King 2015-03-13 12:07 ` Arnd Bergmann 2015-03-13 12:29 ` Russell King - ARM Linux 2015-03-13 12:42 ` Arnd Bergmann 2015-03-13 12:47 ` Russell King - ARM Linux 2015-03-13 15:08 ` Arnd Bergmann 2015-03-13 15:28 ` Russell King - ARM Linux 2015-03-13 15:36 ` Arnd Bergmann 2015-03-13 12:59 ` Russell King - ARM Linux 2015-03-13 16:22 ` [FOR DISCUSSION 0/10] Dove PMU support Russell King - ARM Linux 2015-03-13 16:23 ` [PATCH 01/10] pm: domains: quieten down generic pm domains Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:10 ` Kevin Hilman 2015-03-13 17:10 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 02/10] pm: domains: factor out code to get the generic PM domain from a struct device Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:20 ` Kevin Hilman 2015-03-13 17:20 ` Kevin Hilman 2015-03-13 17:35 ` Russell King - ARM Linux 2015-03-13 17:35 ` Russell King - ARM Linux 2015-03-13 16:23 ` [PATCH 03/10] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 17:28 ` Kevin Hilman [this message] 2015-03-13 17:28 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 06/10] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets Russell King [not found] ` <20150312183020.GU8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2015-03-12 18:31 ` [PATCH 4/9] dt-bindings: add Marvell PMU documentation Russell King [not found] ` <E1YW7t0-0003mE-My-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-12 21:32 ` Rob Herring [not found] ` <CAL_Jsq+R70GVsuig7Ebo49_MeneD_RZ=E0haTVsb_xFhTR7-pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-03-12 21:42 ` Russell King - ARM Linux 2015-03-13 12:02 ` Arnd Bergmann 2015-03-12 18:31 ` [PATCH 6/9] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Russell King 2015-03-12 18:31 ` Russell King [not found] ` <E1YW7tB-0003mM-1L-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-13 12:30 ` Thomas Petazzoni 2015-03-13 12:30 ` Thomas Petazzoni [not found] ` <20150313133038.0a3ae8d1-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-03-13 12:33 ` Russell King - ARM Linux 2015-03-13 12:33 ` Russell King - ARM Linux 2015-03-16 18:27 ` Gregory CLEMENT 2015-03-16 18:27 ` Gregory CLEMENT [not found] ` <55072092.9040207-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-03-17 13:43 ` Russell King - ARM Linux 2015-03-17 13:43 ` Russell King - ARM Linux [not found] ` <20150317134335.GV8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2015-03-17 15:09 ` Sebastian Hesselbarth 2015-03-17 15:09 ` Sebastian Hesselbarth [not found] ` <5508439F.4000507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-03-17 15:15 ` Russell King - ARM Linux 2015-03-17 15:15 ` Russell King - ARM Linux 2015-03-25 8:25 ` Linus Walleij 2015-03-25 8:25 ` Linus Walleij 2015-03-12 18:31 ` [PATCH 7/9] ARM: dt: dove: wire up RTC interrupt Russell King 2015-03-12 18:31 ` Russell King 2015-03-12 18:31 ` [PATCH 8/9] ARM: dt: dove: add video decoder power domain description Russell King 2015-03-12 18:31 ` Russell King 2015-03-12 18:31 ` [PATCH 9/9] ARM: dt: dove: add GPU " Russell King 2015-03-12 18:31 ` Russell King 2015-03-13 11:57 ` [FOR DISCUSSION 0/9] Dove PMU support Arnd Bergmann 2015-03-13 11:57 ` Arnd Bergmann 2015-03-13 12:11 ` Russell King - ARM Linux 2015-03-13 12:11 ` Russell King - ARM Linux 2015-03-13 12:26 ` Arnd Bergmann 2015-03-13 12:26 ` Arnd Bergmann 2015-03-13 12:32 ` Russell King - ARM Linux 2015-03-13 12:32 ` Russell King - ARM Linux 2015-03-13 12:47 ` Arnd Bergmann 2015-03-13 12:47 ` Arnd Bergmann 2015-03-13 16:23 ` [PATCH 04/10] pm: domains: sync runtime PM status with PM domains after probe Russell King 2015-03-13 16:23 ` Russell King [not found] ` <E1YWSN5-0006G5-Ld-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-13 17:33 ` Kevin Hilman 2015-03-13 17:33 ` Kevin Hilman 2015-03-13 16:23 ` [PATCH 05/10] dt-bindings: add Marvell PMU documentation Russell King 2015-03-13 16:23 ` Russell King [not found] ` <E1YWSNA-0006G9-Rr-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> 2015-03-17 0:28 ` Rob Herring 2015-03-17 0:28 ` Rob Herring 2015-03-13 16:23 ` [PATCH 07/10] ARM: dt: dove: add Dove PMU DT entry to dove.dtsi Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 16:23 ` [PATCH 08/10] ARM: dt: dove: wire up RTC interrupt Russell King 2015-03-13 16:23 ` Russell King 2015-03-13 16:24 ` [PATCH 09/10] ARM: dt: dove: add video decoder power domain description Russell King 2015-03-13 16:24 ` Russell King 2015-03-13 16:24 ` [PATCH 10/10] ARM: dt: dove: add GPU " Russell King 2015-03-13 16:24 ` Russell King 2015-03-19 21:59 ` [FOR DISCUSSION 0/9] Dove PMU support Rafael J. Wysocki 2015-03-19 21:59 ` Rafael J. Wysocki 2015-03-19 22:02 ` Rafael J. Wysocki 2015-03-19 22:02 ` Rafael J. Wysocki 2015-03-20 12:16 ` Russell King - ARM Linux 2015-03-20 12:16 ` Russell King - ARM Linux 2015-03-20 12:44 ` Rafael J. Wysocki 2015-03-20 12:44 ` Rafael J. Wysocki 2015-03-20 17:19 ` Russell King - ARM Linux 2015-03-20 17:19 ` Russell King - ARM Linux 2015-03-20 17:20 ` [PATCH 1/3] pm: domains: quieten down generic pm domains Russell King 2015-03-20 17:20 ` Russell King 2015-03-20 17:20 ` [PATCH 2/3] pm: domains: factor out code to get the generic PM domain from a struct device Russell King 2015-03-20 17:20 ` Russell King 2015-03-23 13:28 ` Ulf Hansson 2015-03-23 13:28 ` Ulf Hansson 2015-03-23 15:17 ` Russell King - ARM Linux 2015-03-23 15:17 ` Russell King - ARM Linux 2015-03-24 0:29 ` Rafael J. Wysocki 2015-03-24 0:29 ` Rafael J. Wysocki 2015-03-26 15:20 ` Russell King - ARM Linux 2015-03-26 15:20 ` Russell King - ARM Linux 2015-03-26 16:00 ` Russell King - ARM Linux 2015-03-26 16:00 ` Russell King - ARM Linux 2015-03-20 17:20 ` [PATCH 3/3] pm: domains: avoid potential oops in pm_genpd_remove_device() Russell King 2015-03-20 17:20 ` Russell King 2015-03-23 13:32 ` Ulf Hansson 2015-03-23 13:32 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7ha8zgrem1.fsf@deeprootsystems.com \ --to=khilman@kernel.org \ --cc=andrew@lunn.ch \ --cc=gregkh@linuxfoundation.org \ --cc=jason@lakedaemon.net \ --cc=len.brown@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=rmk+kernel@arm.linux.org.uk \ --cc=sebastian.hesselbarth@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.