All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kaiser <martin@kaiser.cx>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH] video: imxfb: remove the macros for initializing the DMACR
Date: Mon, 28 Nov 2016 23:43:09 +0100	[thread overview]
Message-ID: <1480372989-6413-1-git-send-email-martin@kaiser.cx> (raw)
In-Reply-To: <20161125084303.GA14156@botnar.kaiser.cx>

The current definitions of DMACR_HM() and DMACR_TM() are correct only
for imx1, they're wrong for imx21.

The macros are meant for legacy board files only, they're not applicable
for boards using device tree.

At the moment, there are no boards are using the macros. So it should be
safe to drop them rather than making them work for both imx1 and imx21,
which would require a change in the platform data struct.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
 include/linux/platform_data/video-imxfb.h |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h
index 18e9083..a5c0a71 100644
--- a/include/linux/platform_data/video-imxfb.h
+++ b/include/linux/platform_data/video-imxfb.h
@@ -47,10 +47,6 @@
 #define LSCR1_GRAY2(x)            (((x) & 0xf) << 4)
 #define LSCR1_GRAY1(x)            (((x) & 0xf))
 
-#define DMACR_BURST	(1 << 31)
-#define DMACR_HM(x)	(((x) & 0xf) << 16)
-#define DMACR_TM(x)	((x) & 0xf)
-
 struct imx_fb_videomode {
 	struct fb_videomode mode;
 	u32 pcr;
-- 
1.7.10.4

WARNING: multiple messages have this Message-ID (diff)
From: Martin Kaiser <martin@kaiser.cx>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH] video: imxfb: remove the macros for initializing the DMACR
Date: Mon, 28 Nov 2016 22:43:09 +0000	[thread overview]
Message-ID: <1480372989-6413-1-git-send-email-martin@kaiser.cx> (raw)
In-Reply-To: <20161125084303.GA14156@botnar.kaiser.cx>

The current definitions of DMACR_HM() and DMACR_TM() are correct only
for imx1, they're wrong for imx21.

The macros are meant for legacy board files only, they're not applicable
for boards using device tree.

At the moment, there are no boards are using the macros. So it should be
safe to drop them rather than making them work for both imx1 and imx21,
which would require a change in the platform data struct.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
 include/linux/platform_data/video-imxfb.h |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h
index 18e9083..a5c0a71 100644
--- a/include/linux/platform_data/video-imxfb.h
+++ b/include/linux/platform_data/video-imxfb.h
@@ -47,10 +47,6 @@
 #define LSCR1_GRAY2(x)            (((x) & 0xf) << 4)
 #define LSCR1_GRAY1(x)            (((x) & 0xf))
 
-#define DMACR_BURST	(1 << 31)
-#define DMACR_HM(x)	(((x) & 0xf) << 16)
-#define DMACR_TM(x)	((x) & 0xf)
-
 struct imx_fb_videomode {
 	struct fb_videomode mode;
 	u32 pcr;
-- 
1.7.10.4


  reply	other threads:[~2016-11-28 22:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  7:54 [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser
2016-11-22  7:54 ` Martin Kaiser
2016-11-22  8:42 ` Uwe Kleine-König
2016-11-22  8:42   ` Uwe Kleine-König
2016-11-23  9:31   ` Martin Kaiser
2016-11-23  9:31     ` Martin Kaiser
2016-11-23  9:50     ` Uwe Kleine-König
2016-11-23  9:50       ` Uwe Kleine-König
2016-11-25  8:43       ` Martin Kaiser
2016-11-25  8:43         ` Martin Kaiser
2016-11-28 22:43         ` Martin Kaiser [this message]
2016-11-28 22:43           ` [PATCH] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser
2016-11-29  7:49           ` Uwe Kleine-König
2016-11-29  7:49             ` Uwe Kleine-König
2016-11-29 19:50             ` [PATCH v2] " Martin Kaiser
2016-11-29 19:50               ` Martin Kaiser
2016-11-29 19:57               ` Uwe Kleine-König
2016-11-29 19:57                 ` Uwe Kleine-König
     [not found]                 ` <CGME20170111124006epcas5p138afe03766a09b68eac3f93a9047ee27@epcas5p1.samsung.com>
2017-01-11 12:39                   ` Bartlomiej Zolnierkiewicz
2017-01-11 12:39                     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480372989-6413-1-git-send-email-martin@kaiser.cx \
    --to=martin@kaiser.cx \
    --cc=kernel@pengutronix.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.