All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kaiser <martin@kaiser.cx>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM
Date: Fri, 25 Nov 2016 09:43:03 +0100	[thread overview]
Message-ID: <20161125084303.GA14156@botnar.kaiser.cx> (raw)
In-Reply-To: <20161123095052.u63j26ixgc54qhkd@pengutronix.de>

Thus wrote Uwe Kleine-König (u.kleine-koenig@pengutronix.de):

> > ok, understood. I wasn't able to dig up an imx1 specification. Do you
> > know if it's publicly available?

> http://www.nxp.com/assets/documents/data/en/reference-manuals/MC9328MX1RM.pdf

Thanks.

> So you put the values to use in the device tree? Then the right thing to
> do is to check the device type in the driver and mask accordingly when
> the values are written to the hardware.

Device tree and platform data contain the entire register, not the
individual components. The macros are provided to build the register
value from the components, but nobody's using them.

> IMHO dropping the macros is the right thing to do.

Ok, I'll submit a patch for this.

Best regards,
Martin

WARNING: multiple messages have this Message-ID (diff)
From: Martin Kaiser <martin@kaiser.cx>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM
Date: Fri, 25 Nov 2016 08:43:03 +0000	[thread overview]
Message-ID: <20161125084303.GA14156@botnar.kaiser.cx> (raw)
In-Reply-To: <20161123095052.u63j26ixgc54qhkd@pengutronix.de>

Thus wrote Uwe Kleine-König (u.kleine-koenig@pengutronix.de):

> > ok, understood. I wasn't able to dig up an imx1 specification. Do you
> > know if it's publicly available?

> http://www.nxp.com/assets/documents/data/en/reference-manuals/MC9328MX1RM.pdf

Thanks.

> So you put the values to use in the device tree? Then the right thing to
> do is to check the device type in the driver and mask accordingly when
> the values are written to the hardware.

Device tree and platform data contain the entire register, not the
individual components. The macros are provided to build the register
value from the components, but nobody's using them.

> IMHO dropping the macros is the right thing to do.

Ok, I'll submit a patch for this.

Best regards,
Martin

  reply	other threads:[~2016-11-25  8:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  7:54 [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser
2016-11-22  7:54 ` Martin Kaiser
2016-11-22  8:42 ` Uwe Kleine-König
2016-11-22  8:42   ` Uwe Kleine-König
2016-11-23  9:31   ` Martin Kaiser
2016-11-23  9:31     ` Martin Kaiser
2016-11-23  9:50     ` Uwe Kleine-König
2016-11-23  9:50       ` Uwe Kleine-König
2016-11-25  8:43       ` Martin Kaiser [this message]
2016-11-25  8:43         ` Martin Kaiser
2016-11-28 22:43         ` [PATCH] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser
2016-11-28 22:43           ` Martin Kaiser
2016-11-29  7:49           ` Uwe Kleine-König
2016-11-29  7:49             ` Uwe Kleine-König
2016-11-29 19:50             ` [PATCH v2] " Martin Kaiser
2016-11-29 19:50               ` Martin Kaiser
2016-11-29 19:57               ` Uwe Kleine-König
2016-11-29 19:57                 ` Uwe Kleine-König
     [not found]                 ` <CGME20170111124006epcas5p138afe03766a09b68eac3f93a9047ee27@epcas5p1.samsung.com>
2017-01-11 12:39                   ` Bartlomiej Zolnierkiewicz
2017-01-11 12:39                     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161125084303.GA14156@botnar.kaiser.cx \
    --to=martin@kaiser.cx \
    --cc=kernel@pengutronix.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.