All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM
Date: Tue, 22 Nov 2016 09:42:14 +0100	[thread overview]
Message-ID: <20161122084214.fxn26mfur7wwlgs2@pengutronix.de> (raw)
In-Reply-To: <1479801258-3765-1-git-send-email-martin@kaiser.cx>

On Tue, Nov 22, 2016 at 08:54:18AM +0100, Martin Kaiser wrote:
> The HM and TM fields in the LCDC DMA Control Register are 7 bits wide.
> Use the correct mask to allow setting all possible bits.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> 
> This bug was discovered on a board that uses DMACR_TM(16). We ended up
> with TM==0 in the register, the upper three bits were filtered out.
> 
> The LCD DMA Control Register is described in section 33.3.16 of the
> IMX25 reference manual.

For the MX1 which is also supported by this driver, the definitions are
right. So this needs a more sophisticated patch. Also I wonder why the
register definition is in include/linux/platform_data and not in the
driver directly.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM
Date: Tue, 22 Nov 2016 08:42:14 +0000	[thread overview]
Message-ID: <20161122084214.fxn26mfur7wwlgs2@pengutronix.de> (raw)
In-Reply-To: <1479801258-3765-1-git-send-email-martin@kaiser.cx>

On Tue, Nov 22, 2016 at 08:54:18AM +0100, Martin Kaiser wrote:
> The HM and TM fields in the LCDC DMA Control Register are 7 bits wide.
> Use the correct mask to allow setting all possible bits.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> 
> This bug was discovered on a board that uses DMACR_TM(16). We ended up
> with TM=0 in the register, the upper three bits were filtered out.
> 
> The LCD DMA Control Register is described in section 33.3.16 of the
> IMX25 reference manual.

For the MX1 which is also supported by this driver, the definitions are
right. So this needs a more sophisticated patch. Also I wonder why the
register definition is in include/linux/platform_data and not in the
driver directly.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2016-11-22  8:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  7:54 [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser
2016-11-22  7:54 ` Martin Kaiser
2016-11-22  8:42 ` Uwe Kleine-König [this message]
2016-11-22  8:42   ` Uwe Kleine-König
2016-11-23  9:31   ` Martin Kaiser
2016-11-23  9:31     ` Martin Kaiser
2016-11-23  9:50     ` Uwe Kleine-König
2016-11-23  9:50       ` Uwe Kleine-König
2016-11-25  8:43       ` Martin Kaiser
2016-11-25  8:43         ` Martin Kaiser
2016-11-28 22:43         ` [PATCH] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser
2016-11-28 22:43           ` Martin Kaiser
2016-11-29  7:49           ` Uwe Kleine-König
2016-11-29  7:49             ` Uwe Kleine-König
2016-11-29 19:50             ` [PATCH v2] " Martin Kaiser
2016-11-29 19:50               ` Martin Kaiser
2016-11-29 19:57               ` Uwe Kleine-König
2016-11-29 19:57                 ` Uwe Kleine-König
     [not found]                 ` <CGME20170111124006epcas5p138afe03766a09b68eac3f93a9047ee27@epcas5p1.samsung.com>
2017-01-11 12:39                   ` Bartlomiej Zolnierkiewicz
2017-01-11 12:39                     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161122084214.fxn26mfur7wwlgs2@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@kaiser.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.