* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-01-24 5:10 ` Bibby Hsieh
0 siblings, 0 replies; 21+ messages in thread
From: Bibby Hsieh @ 2017-01-24 5:10 UTC (permalink / raw)
To: David Airlie, Matthias Brugger, Daniel Vetter, dri-devel, linux-mediatek
Cc: Yingjoe Chen, Cawa Cheng, Daniel Kurtz, Bibby Hsieh,
Philipp Zabel, YT Shen, Thierry Reding, CK Hu, Mao Huang,
linux-arm-kernel, linux-kernel, Sascha Hauer
Current Mediatek DRM driver does not support interlaced mode, and
will hang if such resolution is used: Filter those to prevent
kernel hangs, until the DRM driver is fixed properly.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 0e8c4d9..e33678d 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
return MODE_BAD;
}
+ if (mode->flags & DRM_MODE_FLAG_INTERLACE)
+ return MODE_NO_INTERLACE;
if (mode->clock < 27000)
return MODE_CLOCK_LOW;
if (mode->clock > 297000)
--
1.9.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-01-24 5:10 ` Bibby Hsieh
0 siblings, 0 replies; 21+ messages in thread
From: Bibby Hsieh @ 2017-01-24 5:10 UTC (permalink / raw)
To: David Airlie, Matthias Brugger, Daniel Vetter, dri-devel, linux-mediatek
Cc: Yingjoe Chen, Cawa Cheng, Daniel Kurtz, Bibby Hsieh,
Philipp Zabel, YT Shen, Thierry Reding, CK Hu, Mao Huang,
linux-arm-kernel, linux-kernel, Sascha Hauer
Current Mediatek DRM driver does not support interlaced mode, and
will hang if such resolution is used: Filter those to prevent
kernel hangs, until the DRM driver is fixed properly.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 0e8c4d9..e33678d 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
return MODE_BAD;
}
+ if (mode->flags & DRM_MODE_FLAG_INTERLACE)
+ return MODE_NO_INTERLACE;
if (mode->clock < 27000)
return MODE_CLOCK_LOW;
if (mode->clock > 297000)
--
1.9.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-01-24 5:10 ` Bibby Hsieh
0 siblings, 0 replies; 21+ messages in thread
From: Bibby Hsieh @ 2017-01-24 5:10 UTC (permalink / raw)
To: linux-arm-kernel
Current Mediatek DRM driver does not support interlaced mode, and
will hang if such resolution is used: Filter those to prevent
kernel hangs, until the DRM driver is fixed properly.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 0e8c4d9..e33678d 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
return MODE_BAD;
}
+ if (mode->flags & DRM_MODE_FLAG_INTERLACE)
+ return MODE_NO_INTERLACE;
if (mode->clock < 27000)
return MODE_CLOCK_LOW;
if (mode->clock > 297000)
--
1.9.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
2017-01-24 5:10 ` Bibby Hsieh
(?)
@ 2017-01-24 6:12 ` CK Hu
-1 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-01-24 6:12 UTC (permalink / raw)
To: Bibby Hsieh
Cc: David Airlie, Matthias Brugger, Daniel Vetter, dri-devel,
linux-mediatek, Yingjoe Chen, Cawa Cheng, Daniel Kurtz,
Philipp Zabel, YT Shen, Thierry Reding, Mao Huang,
linux-arm-kernel, linux-kernel, Sascha Hauer
Hi, Bibby:
On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Acked-by: CK Hu <ck.hu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> return MODE_BAD;
> }
>
> + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> if (mode->clock < 27000)
> return MODE_CLOCK_LOW;
> if (mode->clock > 297000)
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-01-24 6:12 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-01-24 6:12 UTC (permalink / raw)
To: Bibby Hsieh
Cc: linux-kernel, Sascha Hauer, Daniel Vetter, Cawa Cheng, dri-devel,
Mao Huang, linux-mediatek, Matthias Brugger, Yingjoe Chen,
linux-arm-kernel
Hi, Bibby:
On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Acked-by: CK Hu <ck.hu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> return MODE_BAD;
> }
>
> + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> if (mode->clock < 27000)
> return MODE_CLOCK_LOW;
> if (mode->clock > 297000)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-01-24 6:12 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-01-24 6:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi, Bibby:
On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Acked-by: CK Hu <ck.hu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> return MODE_BAD;
> }
>
> + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> if (mode->clock < 27000)
> return MODE_CLOCK_LOW;
> if (mode->clock > 297000)
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
2017-01-24 5:10 ` Bibby Hsieh
(?)
@ 2017-05-23 9:28 ` CK Hu
-1 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-23 9:28 UTC (permalink / raw)
To: Bibby Hsieh
Cc: David Airlie, Matthias Brugger, Daniel Vetter, dri-devel,
linux-mediatek, Yingjoe Chen (陳英洲),
Cawa Cheng (鄭曄禧),
Daniel Kurtz, Philipp Zabel, YT Shen (沈岳霆),
Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel,
Sascha Hauer
Hi, Bibby:
I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
thanks.
Regards,
CK
On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> return MODE_BAD;
> }
>
> + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> if (mode->clock < 27000)
> return MODE_CLOCK_LOW;
> if (mode->clock > 297000)
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-23 9:28 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-23 9:28 UTC (permalink / raw)
To: Bibby Hsieh
Cc: linux-kernel, Sascha Hauer, Daniel Vetter,
Cawa Cheng (鄭曄禧),
dri-devel, Mao Huang, linux-mediatek, Matthias Brugger,
Yingjoe Chen (陳英洲),
linux-arm-kernel
Hi, Bibby:
I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
thanks.
Regards,
CK
On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> return MODE_BAD;
> }
>
> + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> if (mode->clock < 27000)
> return MODE_CLOCK_LOW;
> if (mode->clock > 297000)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-23 9:28 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-23 9:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi, Bibby:
I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
thanks.
Regards,
CK
On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> return MODE_BAD;
> }
>
> + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> if (mode->clock < 27000)
> return MODE_CLOCK_LOW;
> if (mode->clock > 297000)
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
2017-05-23 9:28 ` CK Hu
(?)
@ 2017-05-23 13:12 ` Daniel Vetter
-1 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2017-05-23 13:12 UTC (permalink / raw)
To: CK Hu
Cc: Bibby Hsieh, David Airlie, Matthias Brugger, Daniel Vetter,
dri-devel, linux-mediatek,
Yingjoe Chen (陳英洲),
Cawa Cheng (鄭曄禧),
Daniel Kurtz, Philipp Zabel, YT Shen (沈岳霆),
Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel,
Sascha Hauer
On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> Hi, Bibby:
>
> I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> thanks.
>
> Regards,
> CK
>
> On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > Current Mediatek DRM driver does not support interlaced mode, and
> > will hang if such resolution is used: Filter those to prevent
> > kernel hangs, until the DRM driver is fixed properly.
> >
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > index 0e8c4d9..e33678d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > return MODE_BAD;
> > }
> >
> > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > + return MODE_NO_INTERLACE;
> > if (mode->clock < 27000)
> > return MODE_CLOCK_LOW;
> > if (mode->clock > 297000)
You probably want to check out Jose's mode_valid work, since only
filtering in the connector's ->mode_valid callback isn't enough. You also
need to filter in ->mode_fixup (or some other place called at atomic_check
time).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-23 13:12 ` Daniel Vetter
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2017-05-23 13:12 UTC (permalink / raw)
To: CK Hu
Cc: Bibby Hsieh, David Airlie, Matthias Brugger, Daniel Vetter,
dri-devel, linux-mediatek,
Yingjoe Chen (陳英洲),
Cawa Cheng (鄭曄禧),
Daniel Kurtz, Philipp Zabel, YT Shen (沈岳霆),
Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel
On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> Hi, Bibby:
>
> I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> thanks.
>
> Regards,
> CK
>
> On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > Current Mediatek DRM driver does not support interlaced mode, and
> > will hang if such resolution is used: Filter those to prevent
> > kernel hangs, until the DRM driver is fixed properly.
> >
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > index 0e8c4d9..e33678d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > return MODE_BAD;
> > }
> >
> > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > + return MODE_NO_INTERLACE;
> > if (mode->clock < 27000)
> > return MODE_CLOCK_LOW;
> > if (mode->clock > 297000)
You probably want to check out Jose's mode_valid work, since only
filtering in the connector's ->mode_valid callback isn't enough. You also
need to filter in ->mode_fixup (or some other place called at atomic_check
time).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-23 13:12 ` Daniel Vetter
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2017-05-23 13:12 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> Hi, Bibby:
>
> I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> thanks.
>
> Regards,
> CK
>
> On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > Current Mediatek DRM driver does not support interlaced mode, and
> > will hang if such resolution is used: Filter those to prevent
> > kernel hangs, until the DRM driver is fixed properly.
> >
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > index 0e8c4d9..e33678d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > return MODE_BAD;
> > }
> >
> > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > + return MODE_NO_INTERLACE;
> > if (mode->clock < 27000)
> > return MODE_CLOCK_LOW;
> > if (mode->clock > 297000)
You probably want to check out Jose's mode_valid work, since only
filtering in the connector's ->mode_valid callback isn't enough. You also
need to filter in ->mode_fixup (or some other place called at atomic_check
time).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
2017-05-23 13:12 ` Daniel Vetter
(?)
@ 2017-05-24 9:20 ` CK Hu
-1 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-24 9:20 UTC (permalink / raw)
To: Daniel Vetter, Bibby Hsieh
Cc: David Airlie, Matthias Brugger, Daniel Vetter, dri-devel,
linux-mediatek, Yingjoe Chen (陳英洲),
Cawa Cheng (鄭曄禧),
Daniel Kurtz, Philipp Zabel, YT Shen (沈岳霆),
Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel,
Sascha Hauer
On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > Hi, Bibby:
> >
> > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > thanks.
> >
> > Regards,
> > CK
> >
> > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > Current Mediatek DRM driver does not support interlaced mode, and
> > > will hang if such resolution is used: Filter those to prevent
> > > kernel hangs, until the DRM driver is fixed properly.
> > >
> > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > ---
> > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > index 0e8c4d9..e33678d 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > return MODE_BAD;
> > > }
> > >
> > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > + return MODE_NO_INTERLACE;
> > > if (mode->clock < 27000)
> > > return MODE_CLOCK_LOW;
> > > if (mode->clock > 297000)
>
> You probably want to check out Jose's mode_valid work, since only
> filtering in the connector's ->mode_valid callback isn't enough. You also
> need to filter in ->mode_fixup (or some other place called at atomic_check
> time).
> -Daniel
Hi, Daniel:
Yes, I still need to filter in ->mode_fixup.
Hi, Bibby:
Because Jose's work plan to use mode_valid to replace mode_fixup, so
it's better to refine this patch after Jose's work is done. And I would
now remove this patch from my branch.
Regards,
CK
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-24 9:20 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-24 9:20 UTC (permalink / raw)
To: Daniel Vetter, Bibby Hsieh
Cc: linux-kernel, Sascha Hauer, Daniel Vetter,
Cawa Cheng (鄭曄禧),
dri-devel, Mao Huang, linux-mediatek, Matthias Brugger,
Yingjoe Chen (陳英洲),
linux-arm-kernel
On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > Hi, Bibby:
> >
> > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > thanks.
> >
> > Regards,
> > CK
> >
> > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > Current Mediatek DRM driver does not support interlaced mode, and
> > > will hang if such resolution is used: Filter those to prevent
> > > kernel hangs, until the DRM driver is fixed properly.
> > >
> > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > ---
> > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > index 0e8c4d9..e33678d 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > return MODE_BAD;
> > > }
> > >
> > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > + return MODE_NO_INTERLACE;
> > > if (mode->clock < 27000)
> > > return MODE_CLOCK_LOW;
> > > if (mode->clock > 297000)
>
> You probably want to check out Jose's mode_valid work, since only
> filtering in the connector's ->mode_valid callback isn't enough. You also
> need to filter in ->mode_fixup (or some other place called at atomic_check
> time).
> -Daniel
Hi, Daniel:
Yes, I still need to filter in ->mode_fixup.
Hi, Bibby:
Because Jose's work plan to use mode_valid to replace mode_fixup, so
it's better to refine this patch after Jose's work is done. And I would
now remove this patch from my branch.
Regards,
CK
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-24 9:20 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-24 9:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > Hi, Bibby:
> >
> > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > thanks.
> >
> > Regards,
> > CK
> >
> > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > Current Mediatek DRM driver does not support interlaced mode, and
> > > will hang if such resolution is used: Filter those to prevent
> > > kernel hangs, until the DRM driver is fixed properly.
> > >
> > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > ---
> > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > index 0e8c4d9..e33678d 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > return MODE_BAD;
> > > }
> > >
> > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > + return MODE_NO_INTERLACE;
> > > if (mode->clock < 27000)
> > > return MODE_CLOCK_LOW;
> > > if (mode->clock > 297000)
>
> You probably want to check out Jose's mode_valid work, since only
> filtering in the connector's ->mode_valid callback isn't enough. You also
> need to filter in ->mode_fixup (or some other place called at atomic_check
> time).
> -Daniel
Hi, Daniel:
Yes, I still need to filter in ->mode_fixup.
Hi, Bibby:
Because Jose's work plan to use mode_valid to replace mode_fixup, so
it's better to refine this patch after Jose's work is done. And I would
now remove this patch from my branch.
Regards,
CK
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
2017-05-24 9:20 ` CK Hu
(?)
@ 2017-05-24 12:24 ` Daniel Vetter
-1 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2017-05-24 12:24 UTC (permalink / raw)
To: CK Hu
Cc: Daniel Vetter, Bibby Hsieh, David Airlie, Matthias Brugger,
Daniel Vetter, dri-devel, linux-mediatek,
Yingjoe Chen (陳英洲),
Cawa Cheng (鄭曄禧),
Daniel Kurtz, Philipp Zabel, YT Shen (沈岳霆),
Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel,
Sascha Hauer
On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > Hi, Bibby:
> > >
> > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > > thanks.
> > >
> > > Regards,
> > > CK
> > >
> > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > > Current Mediatek DRM driver does not support interlaced mode, and
> > > > will hang if such resolution is used: Filter those to prevent
> > > > kernel hangs, until the DRM driver is fixed properly.
> > > >
> > > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > > ---
> > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > index 0e8c4d9..e33678d 100644
> > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > > return MODE_BAD;
> > > > }
> > > >
> > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > > + return MODE_NO_INTERLACE;
> > > > if (mode->clock < 27000)
> > > > return MODE_CLOCK_LOW;
> > > > if (mode->clock > 297000)
> >
> > You probably want to check out Jose's mode_valid work, since only
> > filtering in the connector's ->mode_valid callback isn't enough. You also
> > need to filter in ->mode_fixup (or some other place called at atomic_check
> > time).
> > -Daniel
>
> Hi, Daniel:
>
> Yes, I still need to filter in ->mode_fixup.
>
> Hi, Bibby:
>
> Because Jose's work plan to use mode_valid to replace mode_fixup, so
> it's better to refine this patch after Jose's work is done. And I would
> now remove this patch from my branch.
Btw if you have a revised version of your patch on top of Jose's series, a
tested-by on that would be awesome. The more people find it useful, the
faster it will land.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-24 12:24 ` Daniel Vetter
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2017-05-24 12:24 UTC (permalink / raw)
To: CK Hu
Cc: linux-kernel, Daniel Vetter,
Cawa Cheng (鄭曄禧),
dri-devel, Mao Huang, linux-mediatek, Matthias Brugger,
Yingjoe Chen (陳英洲),
Sascha Hauer, linux-arm-kernel
On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > Hi, Bibby:
> > >
> > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > > thanks.
> > >
> > > Regards,
> > > CK
> > >
> > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > > Current Mediatek DRM driver does not support interlaced mode, and
> > > > will hang if such resolution is used: Filter those to prevent
> > > > kernel hangs, until the DRM driver is fixed properly.
> > > >
> > > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > > ---
> > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > index 0e8c4d9..e33678d 100644
> > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > > return MODE_BAD;
> > > > }
> > > >
> > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > > + return MODE_NO_INTERLACE;
> > > > if (mode->clock < 27000)
> > > > return MODE_CLOCK_LOW;
> > > > if (mode->clock > 297000)
> >
> > You probably want to check out Jose's mode_valid work, since only
> > filtering in the connector's ->mode_valid callback isn't enough. You also
> > need to filter in ->mode_fixup (or some other place called at atomic_check
> > time).
> > -Daniel
>
> Hi, Daniel:
>
> Yes, I still need to filter in ->mode_fixup.
>
> Hi, Bibby:
>
> Because Jose's work plan to use mode_valid to replace mode_fixup, so
> it's better to refine this patch after Jose's work is done. And I would
> now remove this patch from my branch.
Btw if you have a revised version of your patch on top of Jose's series, a
tested-by on that would be awesome. The more people find it useful, the
faster it will land.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-24 12:24 ` Daniel Vetter
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2017-05-24 12:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > Hi, Bibby:
> > >
> > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > > thanks.
> > >
> > > Regards,
> > > CK
> > >
> > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > > Current Mediatek DRM driver does not support interlaced mode, and
> > > > will hang if such resolution is used: Filter those to prevent
> > > > kernel hangs, until the DRM driver is fixed properly.
> > > >
> > > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > > ---
> > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > index 0e8c4d9..e33678d 100644
> > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > > return MODE_BAD;
> > > > }
> > > >
> > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > > + return MODE_NO_INTERLACE;
> > > > if (mode->clock < 27000)
> > > > return MODE_CLOCK_LOW;
> > > > if (mode->clock > 297000)
> >
> > You probably want to check out Jose's mode_valid work, since only
> > filtering in the connector's ->mode_valid callback isn't enough. You also
> > need to filter in ->mode_fixup (or some other place called at atomic_check
> > time).
> > -Daniel
>
> Hi, Daniel:
>
> Yes, I still need to filter in ->mode_fixup.
>
> Hi, Bibby:
>
> Because Jose's work plan to use mode_valid to replace mode_fixup, so
> it's better to refine this patch after Jose's work is done. And I would
> now remove this patch from my branch.
Btw if you have a revised version of your patch on top of Jose's series, a
tested-by on that would be awesome. The more people find it useful, the
faster it will land.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
2017-05-24 12:24 ` Daniel Vetter
(?)
@ 2017-05-25 3:38 ` CK Hu
-1 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-25 3:38 UTC (permalink / raw)
To: Daniel Vetter
Cc: Bibby Hsieh, David Airlie, Matthias Brugger, Daniel Vetter,
dri-devel, linux-mediatek,
Yingjoe Chen (陳英洲),
Cawa Cheng (鄭曄禧),
Daniel Kurtz, Philipp Zabel, YT Shen (沈岳霆),
Thierry Reding, Mao Huang, linux-arm-kernel, linux-kernel,
Sascha Hauer
On Wed, 2017-05-24 at 14:24 +0200, Daniel Vetter wrote:
> On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> > On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > > Hi, Bibby:
> > > >
> > > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > > > thanks.
> > > >
> > > > Regards,
> > > > CK
> > > >
> > > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > > > Current Mediatek DRM driver does not support interlaced mode, and
> > > > > will hang if such resolution is used: Filter those to prevent
> > > > > kernel hangs, until the DRM driver is fixed properly.
> > > > >
> > > > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > > > ---
> > > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > index 0e8c4d9..e33678d 100644
> > > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > > > return MODE_BAD;
> > > > > }
> > > > >
> > > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > > > + return MODE_NO_INTERLACE;
> > > > > if (mode->clock < 27000)
> > > > > return MODE_CLOCK_LOW;
> > > > > if (mode->clock > 297000)
> > >
> > > You probably want to check out Jose's mode_valid work, since only
> > > filtering in the connector's ->mode_valid callback isn't enough. You also
> > > need to filter in ->mode_fixup (or some other place called at atomic_check
> > > time).
> > > -Daniel
> >
> > Hi, Daniel:
> >
> > Yes, I still need to filter in ->mode_fixup.
> >
> > Hi, Bibby:
> >
> > Because Jose's work plan to use mode_valid to replace mode_fixup, so
> > it's better to refine this patch after Jose's work is done. And I would
> > now remove this patch from my branch.
>
> Btw if you have a revised version of your patch on top of Jose's series, a
> tested-by on that would be awesome. The more people find it useful, the
> faster it will land.
> -Daniel
Hi, Daniel:
I understand.
Hi Bibby:
If you have time, please help to test Jose's patches with the problem
you have met. Otherwise, it would be a long process.
Regards,
CK
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-25 3:38 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-25 3:38 UTC (permalink / raw)
To: Daniel Vetter
Cc: linux-kernel, Daniel Vetter,
Cawa Cheng (鄭曄禧),
dri-devel, Mao Huang, linux-mediatek, Matthias Brugger,
Yingjoe Chen (陳英洲),
Sascha Hauer, linux-arm-kernel
On Wed, 2017-05-24 at 14:24 +0200, Daniel Vetter wrote:
> On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> > On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > > Hi, Bibby:
> > > >
> > > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > > > thanks.
> > > >
> > > > Regards,
> > > > CK
> > > >
> > > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > > > Current Mediatek DRM driver does not support interlaced mode, and
> > > > > will hang if such resolution is used: Filter those to prevent
> > > > > kernel hangs, until the DRM driver is fixed properly.
> > > > >
> > > > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > > > ---
> > > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > index 0e8c4d9..e33678d 100644
> > > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > > > return MODE_BAD;
> > > > > }
> > > > >
> > > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > > > + return MODE_NO_INTERLACE;
> > > > > if (mode->clock < 27000)
> > > > > return MODE_CLOCK_LOW;
> > > > > if (mode->clock > 297000)
> > >
> > > You probably want to check out Jose's mode_valid work, since only
> > > filtering in the connector's ->mode_valid callback isn't enough. You also
> > > need to filter in ->mode_fixup (or some other place called at atomic_check
> > > time).
> > > -Daniel
> >
> > Hi, Daniel:
> >
> > Yes, I still need to filter in ->mode_fixup.
> >
> > Hi, Bibby:
> >
> > Because Jose's work plan to use mode_valid to replace mode_fixup, so
> > it's better to refine this patch after Jose's work is done. And I would
> > now remove this patch from my branch.
>
> Btw if you have a revised version of your patch on top of Jose's series, a
> tested-by on that would be awesome. The more people find it useful, the
> faster it will land.
> -Daniel
Hi, Daniel:
I understand.
Hi Bibby:
If you have time, please help to test Jose's patches with the problem
you have met. Otherwise, it would be a long process.
Regards,
CK
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
@ 2017-05-25 3:38 ` CK Hu
0 siblings, 0 replies; 21+ messages in thread
From: CK Hu @ 2017-05-25 3:38 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 2017-05-24 at 14:24 +0200, Daniel Vetter wrote:
> On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> > On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > > Hi, Bibby:
> > > >
> > > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > > > thanks.
> > > >
> > > > Regards,
> > > > CK
> > > >
> > > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> > > > > Current Mediatek DRM driver does not support interlaced mode, and
> > > > > will hang if such resolution is used: Filter those to prevent
> > > > > kernel hangs, until the DRM driver is fixed properly.
> > > > >
> > > > > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > > > > ---
> > > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > index 0e8c4d9..e33678d 100644
> > > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
> > > > > return MODE_BAD;
> > > > > }
> > > > >
> > > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> > > > > + return MODE_NO_INTERLACE;
> > > > > if (mode->clock < 27000)
> > > > > return MODE_CLOCK_LOW;
> > > > > if (mode->clock > 297000)
> > >
> > > You probably want to check out Jose's mode_valid work, since only
> > > filtering in the connector's ->mode_valid callback isn't enough. You also
> > > need to filter in ->mode_fixup (or some other place called at atomic_check
> > > time).
> > > -Daniel
> >
> > Hi, Daniel:
> >
> > Yes, I still need to filter in ->mode_fixup.
> >
> > Hi, Bibby:
> >
> > Because Jose's work plan to use mode_valid to replace mode_fixup, so
> > it's better to refine this patch after Jose's work is done. And I would
> > now remove this patch from my branch.
>
> Btw if you have a revised version of your patch on top of Jose's series, a
> tested-by on that would be awesome. The more people find it useful, the
> faster it will land.
> -Daniel
Hi, Daniel:
I understand.
Hi Bibby:
If you have time, please help to test Jose's patches with the problem
you have met. Otherwise, it would be a long process.
Regards,
CK
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2017-05-25 3:38 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 5:10 [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions Bibby Hsieh
2017-01-24 5:10 ` Bibby Hsieh
2017-01-24 5:10 ` Bibby Hsieh
2017-01-24 6:12 ` CK Hu
2017-01-24 6:12 ` CK Hu
2017-01-24 6:12 ` CK Hu
2017-05-23 9:28 ` CK Hu
2017-05-23 9:28 ` CK Hu
2017-05-23 9:28 ` CK Hu
2017-05-23 13:12 ` Daniel Vetter
2017-05-23 13:12 ` Daniel Vetter
2017-05-23 13:12 ` Daniel Vetter
2017-05-24 9:20 ` CK Hu
2017-05-24 9:20 ` CK Hu
2017-05-24 9:20 ` CK Hu
2017-05-24 12:24 ` Daniel Vetter
2017-05-24 12:24 ` Daniel Vetter
2017-05-24 12:24 ` Daniel Vetter
2017-05-25 3:38 ` CK Hu
2017-05-25 3:38 ` CK Hu
2017-05-25 3:38 ` CK Hu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.