[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Srinivasan Shanmugam]

Removed warning from 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after running checkpatch.pl

Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index c0b501e..6b5e48c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
 
 union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
 
-static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame)
+static int validate_recv_mgnt_frame(struct adapter *padapter,
+				    union recv_frame *precv_frame)
 {
 	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
 
-- 
1.9.1

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Joe Perches]

On Wed, 2017-10-04 at 19:24 +0200, Srinivasan Shanmugam wrote:
> Removed warning from 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after running checkpatch.pl
> 
> Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index c0b501e..6b5e48c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
>  
>  union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
>  
> -static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame)
> +static int validate_recv_mgnt_frame(struct adapter *padapter,
> +				    union recv_frame *precv_frame)
>  {
>  	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
>  

This patch does not match the commit message.

This patch changes the return from sint to int and does
some 80 column wrapping.

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Srinivasan Shanmugam]

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"

Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index b4e3424..a6b8e0d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1227,7 +1227,7 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
 union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
 
 static sint validate_recv_mgnt_frame(struct adapter *padapter,
-				    union recv_frame *precv_frame)
+				     union recv_frame *precv_frame)
 {
 	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
 
-- 
1.9.1

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Joe Perches]

On Thu, 2017-10-05 at 13:28 +0200, Srinivasan Shanmugam wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"

Subject and commit message don't match

> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
[]
> @@ -1227,7 +1227,7 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
>  union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
>  
>  static sint validate_recv_mgnt_frame(struct adapter *padapter,
> -				    union recv_frame *precv_frame)
> +				     union recv_frame *precv_frame)
>  {
>  	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
>  

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Srinivasan Shanmugam]

Removed all the unnecessary extern from rtl8723bs

Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index c0b501e..6b5e48c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
 
 union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
 
-static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame)
+static int validate_recv_mgnt_frame(struct adapter *padapter,
+				    union recv_frame *precv_frame)
 {
 	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
 
-- 
1.9.1

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Greg KH]

On Wed, Oct 04, 2017 at 07:21:10PM +0200, Srinivasan Shanmugam wrote:
> Removed all the unnecessary extern from rtl8723bs

That's not what this patch does :(

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Srinivasan Shanmugam]

This patch fixes all the following checkpatch.pl warning in rtl8723bs
WARNING: externs should be avoided in .c files

Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 0b530ea..c66fed1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -17,12 +17,6 @@
 #include <drv_types.h>
 #include <rtw_debug.h>
 
-extern unsigned char RTW_WPA_OUI[];
-extern unsigned char WMM_OUI[];
-extern unsigned char WPS_OUI[];
-extern unsigned char P2P_OUI[];
-extern unsigned char WFD_OUI[];
-
 void init_mlme_ap_info(struct adapter *padapter)
 {
 	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
-- 
1.9.1

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Srinivasan Shanmugam]

This patch fixes the following checkpatch.pl warning.
WARNING: externs should be avoided in .c files

Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 0b530ea..c66fed1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -17,12 +17,6 @@
 #include <drv_types.h>
 #include <rtw_debug.h>
 
-extern unsigned char RTW_WPA_OUI[];
-extern unsigned char WMM_OUI[];
-extern unsigned char WPS_OUI[];
-extern unsigned char P2P_OUI[];
-extern unsigned char WFD_OUI[];
-
 void init_mlme_ap_info(struct adapter *padapter)
 {
 	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
-- 
1.9.1

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Joe Perches]

On Wed, 2017-10-04 at 11:00 +0200, Srinivasan Shanmugam wrote:
> This patch fixes the following checkpatch.pl warning.
> WARNING: externs should be avoided in .c files

Nope.

> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
[]
> @@ -17,12 +17,6 @@
>  #include <drv_types.h>
>  #include <rtw_debug.h>
>  
> -extern unsigned char RTW_WPA_OUI[];
> -extern unsigned char WMM_OUI[];
> -extern unsigned char WPS_OUI[];
> -extern unsigned char P2P_OUI[];
> -extern unsigned char WFD_OUT[];
> -
>  void init_mlme_ap_info(struct adapter *padapter)
>  {
>  	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

Please compile any files modified by your proposed
changes _before_ you
submit them.

For instance:

$ git grep -w RTW_WPA_OUI drivers/staging/rtl8723bs/core/rtw_ap.c
drivers/staging/rtl8723bs/core/rtw_ap.c:extern unsigned char RTW_WPA_OUI[];
drivers/staging/rtl8723bs/core/rtw_ap.c:        if (!memcmp(RTW_WPA_OUI, oui, 4))

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

[Joe Perches]

On Wed, 2017-10-04 at 13:53 +0200, srinivasan wrote:
> Hi Joe,
> 
> Thanks for your responses. I have already compiled and the below is the
> logs for the same
> 
> Please let me know if am I missing/doing wrong

Your commit message is incomplete.

checkpatch is a guide, but it's not what you should be
describing here.

What whould be in the commit message is that these externs
are unnecessary as they are done via #include of
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h

Also, your patch is not comprehensive.
Please remove the unnecessary externs from all uses:

drivers/staging/rtl8723bs/core/rtw_wlan_util.c:extern unsigned char RTW_WPA_OUI[];

And that file has the odd and conflicting

static unsigned char WPA_TKIP_CIPHER[4] = {0x00, 0x50, 0xf2, 0x02};
[]
extern unsigned char WPA_TKIP_CIPHER[4];

Where the extern is also unnecessary.

cheers, Joe