From: David Woodhouse <dwmw2@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
tglx@linutronix.de, x86@kernel.org, kvm@vger.kernel.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
arjan.van.de.ven@intel.com, dave.hansen@intel.com
Subject: Re: [PATCH 2/2] x86/speculation: Support "Enhanced IBRS" on future CPUs
Date: Tue, 13 Feb 2018 08:15:08 +0000 [thread overview]
Message-ID: <1518509708.12890.33.camel@infradead.org> (raw)
In-Reply-To: <7e2e5ad1-49b6-1fdb-4a62-8ad6aefc30a0@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On Tue, 2018-02-13 at 09:02 +0100, Paolo Bonzini wrote:
> > --- a/arch/x86/kvm/vmx.c
> > +++ b/arch/x86/kvm/vmx.c
> > @@ -3419,13 +3419,14 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> >
> > vmx->spec_ctrl = data;
> >
> > - if (!data)
> > + if (!data && !spectre_v2_ibrs_all())
> > break;
> This should check the value of IBRS_ALL in the VM, not in the host.
No, it's host we want. If IBRS_ALL is set in the host, we set the
actual hardware MSR once at boot time and never touch it again. The
SPEC_CTRL MSR we expose to guests is purely a no-op fiction.
If spectre_v2_ibrs_all() is true then KVM should *never* actually pass
through or touch the real MSR.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
next prev parent reply other threads:[~2018-02-13 8:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 15:27 [PATCH 1/2] x86/speculation: Correct Speculation Control microcode blacklist again David Woodhouse
2018-02-12 15:27 ` [PATCH 2/2] x86/speculation: Support "Enhanced IBRS" on future CPUs David Woodhouse
2018-02-13 7:47 ` Ingo Molnar
2018-02-13 8:12 ` David Woodhouse
2018-02-13 8:02 ` Paolo Bonzini
2018-02-13 8:15 ` David Woodhouse [this message]
2018-02-13 9:58 ` Paolo Bonzini
2018-02-13 10:21 ` David Woodhouse
2018-02-13 10:36 ` David Woodhouse
2018-02-13 10:41 ` Paolo Bonzini
2018-02-13 10:53 ` David Woodhouse
2018-02-13 10:55 ` Paolo Bonzini
2018-02-16 9:58 ` David Woodhouse
2018-02-16 10:08 ` Paolo Bonzini
2018-02-16 10:21 ` David Woodhouse
2018-02-16 11:04 ` Paolo Bonzini
2018-02-16 12:10 ` David Woodhouse
2018-02-19 23:37 ` Jon Masters
2018-02-19 23:42 ` Van De Ven, Arjan
2018-02-19 23:53 ` valdis.kletnieks
2018-02-20 0:00 ` Van De Ven, Arjan
2018-02-20 0:13 ` Alan Cox
2018-02-20 0:43 ` Linus Torvalds
2018-02-20 1:03 ` Alan Cox
2018-02-20 1:08 ` Van De Ven, Arjan
2018-02-20 8:52 ` Thomas Gleixner
2018-02-20 11:43 ` Paolo Bonzini
2018-02-20 14:08 ` Van De Ven, Arjan
2018-02-20 14:46 ` Paolo Bonzini
2018-02-20 14:59 ` Van De Ven, Arjan
2018-02-20 15:09 ` Paolo Bonzini
2018-02-23 18:12 ` Is: RSB Alternative bit in IA32_ARCH_CAPABILITIES Was:Re: " Konrad Rzeszutek Wilk
2018-02-23 18:18 ` Van De Ven, Arjan
2018-02-15 15:21 ` Pavel Machek
2018-02-13 8:57 ` [tip:x86/pti] x86/speculation: Correct Speculation Control microcode blacklist again tip-bot for David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518509708.12890.33.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=arjan.van.de.ven@intel.com \
--cc=dave.hansen@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.