* [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx
@ 2019-01-17 11:20 Toshiaki Makita
0 siblings, 0 replies; 6+ messages in thread
From: Toshiaki Makita @ 2019-01-17 11:20 UTC (permalink / raw)
To: David S. Miller, Michael S. Tsirkin, Jason Wang
Cc: netdev, Willem de Bruijn, virtualization, Jesper Dangaard Brouer
While I'm looking into how to account standard tx counters on XDP tx
processing, I found several bugs around XDP tx and napi_tx.
Patch1: Fix oops on error path. Patch2 depends on this.
Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled.
Patch3: Minor fix patch5 depends on.
Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled.
Also patch5 depends on this.
Patch5: Fix memory corruption on processing xdp_frames while XDP is being
disabled.
Patch6: Minor fix patch7 depends on.
Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal
queue is reused for XDP and vise versa.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Toshiaki Makita (7):
virtio_net: Don't enable NAPI when interface is down
virtio_net: Don't call free_old_xmit_skbs for xdp_frames
virtio_net: Fix not restoring real_num_rx_queues
virtio_net: Fix out of bounds access of sq
virtio_net: Don't process redirected XDP frames when XDP is disabled
virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
virtio_net: Differentiate sk_buff and xdp_frame on freeing
drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++--------------
1 file changed, 109 insertions(+), 45 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx
2019-01-17 14:55 ` Michael S. Tsirkin
@ 2019-01-18 2:01 ` Toshiaki Makita
2019-01-18 2:01 ` Toshiaki Makita
1 sibling, 0 replies; 6+ messages in thread
From: Toshiaki Makita @ 2019-01-18 2:01 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: David S. Miller, Jason Wang, netdev, virtualization,
Willem de Bruijn, Jesper Dangaard Brouer
On 2019/01/17 23:55, Michael S. Tsirkin wrote:
> On Thu, Jan 17, 2019 at 08:20:38PM +0900, Toshiaki Makita wrote:
>> While I'm looking into how to account standard tx counters on XDP tx
>> processing, I found several bugs around XDP tx and napi_tx.
>>
>> Patch1: Fix oops on error path. Patch2 depends on this.
>> Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled.
>> Patch3: Minor fix patch5 depends on.
>> Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled.
>> Also patch5 depends on this.
>> Patch5: Fix memory corruption on processing xdp_frames while XDP is being
>> disabled.
>> Patch6: Minor fix patch7 depends on.
>> Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal
>> queue is reused for XDP and vise versa.
>>
>> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
>
> Series:
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Thanks for the review.
>
> I guess we need this stuff on stable?
I think so.
> I'm especially happy with Patch7 as it makes my BQL
> work a bit easier.
>
>> Toshiaki Makita (7):
>> virtio_net: Don't enable NAPI when interface is down
>> virtio_net: Don't call free_old_xmit_skbs for xdp_frames
>> virtio_net: Fix not restoring real_num_rx_queues
>> virtio_net: Fix out of bounds access of sq
>> virtio_net: Don't process redirected XDP frames when XDP is disabled
>> virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
>> virtio_net: Differentiate sk_buff and xdp_frame on freeing
>>
>> drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++--------------
>> 1 file changed, 109 insertions(+), 45 deletions(-)
>>
>> --
>> 1.8.3.1
>>
>
>
--
Toshiaki Makita
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx
2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-18 2:01 ` Toshiaki Makita
@ 2019-01-18 2:01 ` Toshiaki Makita
1 sibling, 0 replies; 6+ messages in thread
From: Toshiaki Makita @ 2019-01-18 2:01 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Willem de Bruijn, netdev, virtualization, Jesper Dangaard Brouer,
David S. Miller
On 2019/01/17 23:55, Michael S. Tsirkin wrote:
> On Thu, Jan 17, 2019 at 08:20:38PM +0900, Toshiaki Makita wrote:
>> While I'm looking into how to account standard tx counters on XDP tx
>> processing, I found several bugs around XDP tx and napi_tx.
>>
>> Patch1: Fix oops on error path. Patch2 depends on this.
>> Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled.
>> Patch3: Minor fix patch5 depends on.
>> Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled.
>> Also patch5 depends on this.
>> Patch5: Fix memory corruption on processing xdp_frames while XDP is being
>> disabled.
>> Patch6: Minor fix patch7 depends on.
>> Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal
>> queue is reused for XDP and vise versa.
>>
>> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
>
> Series:
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Thanks for the review.
>
> I guess we need this stuff on stable?
I think so.
> I'm especially happy with Patch7 as it makes my BQL
> work a bit easier.
>
>> Toshiaki Makita (7):
>> virtio_net: Don't enable NAPI when interface is down
>> virtio_net: Don't call free_old_xmit_skbs for xdp_frames
>> virtio_net: Fix not restoring real_num_rx_queues
>> virtio_net: Fix out of bounds access of sq
>> virtio_net: Don't process redirected XDP frames when XDP is disabled
>> virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
>> virtio_net: Differentiate sk_buff and xdp_frame on freeing
>>
>> drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++--------------
>> 1 file changed, 109 insertions(+), 45 deletions(-)
>>
>> --
>> 1.8.3.1
>>
>
>
--
Toshiaki Makita
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx
2019-01-17 11:20 Toshiaki Makita
2019-01-17 14:55 ` Michael S. Tsirkin
@ 2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-18 2:01 ` Toshiaki Makita
2019-01-18 2:01 ` Toshiaki Makita
1 sibling, 2 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-01-17 14:55 UTC (permalink / raw)
To: Toshiaki Makita
Cc: David S. Miller, Jason Wang, netdev, virtualization,
Willem de Bruijn, Jesper Dangaard Brouer
On Thu, Jan 17, 2019 at 08:20:38PM +0900, Toshiaki Makita wrote:
> While I'm looking into how to account standard tx counters on XDP tx
> processing, I found several bugs around XDP tx and napi_tx.
>
> Patch1: Fix oops on error path. Patch2 depends on this.
> Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled.
> Patch3: Minor fix patch5 depends on.
> Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled.
> Also patch5 depends on this.
> Patch5: Fix memory corruption on processing xdp_frames while XDP is being
> disabled.
> Patch6: Minor fix patch7 depends on.
> Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal
> queue is reused for XDP and vise versa.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Series:
Acked-by: Michael S. Tsirkin <mst@redhat.com>
I guess we need this stuff on stable?
I'm especially happy with Patch7 as it makes my BQL
work a bit easier.
> Toshiaki Makita (7):
> virtio_net: Don't enable NAPI when interface is down
> virtio_net: Don't call free_old_xmit_skbs for xdp_frames
> virtio_net: Fix not restoring real_num_rx_queues
> virtio_net: Fix out of bounds access of sq
> virtio_net: Don't process redirected XDP frames when XDP is disabled
> virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
> virtio_net: Differentiate sk_buff and xdp_frame on freeing
>
> drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++--------------
> 1 file changed, 109 insertions(+), 45 deletions(-)
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx
2019-01-17 11:20 Toshiaki Makita
@ 2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-17 14:55 ` Michael S. Tsirkin
1 sibling, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-01-17 14:55 UTC (permalink / raw)
To: Toshiaki Makita
Cc: Willem de Bruijn, netdev, virtualization, Jesper Dangaard Brouer,
David S. Miller
On Thu, Jan 17, 2019 at 08:20:38PM +0900, Toshiaki Makita wrote:
> While I'm looking into how to account standard tx counters on XDP tx
> processing, I found several bugs around XDP tx and napi_tx.
>
> Patch1: Fix oops on error path. Patch2 depends on this.
> Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled.
> Patch3: Minor fix patch5 depends on.
> Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled.
> Also patch5 depends on this.
> Patch5: Fix memory corruption on processing xdp_frames while XDP is being
> disabled.
> Patch6: Minor fix patch7 depends on.
> Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal
> queue is reused for XDP and vise versa.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Series:
Acked-by: Michael S. Tsirkin <mst@redhat.com>
I guess we need this stuff on stable?
I'm especially happy with Patch7 as it makes my BQL
work a bit easier.
> Toshiaki Makita (7):
> virtio_net: Don't enable NAPI when interface is down
> virtio_net: Don't call free_old_xmit_skbs for xdp_frames
> virtio_net: Fix not restoring real_num_rx_queues
> virtio_net: Fix out of bounds access of sq
> virtio_net: Don't process redirected XDP frames when XDP is disabled
> virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
> virtio_net: Differentiate sk_buff and xdp_frame on freeing
>
> drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++--------------
> 1 file changed, 109 insertions(+), 45 deletions(-)
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx
@ 2019-01-17 11:20 Toshiaki Makita
2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-17 14:55 ` Michael S. Tsirkin
0 siblings, 2 replies; 6+ messages in thread
From: Toshiaki Makita @ 2019-01-17 11:20 UTC (permalink / raw)
To: David S. Miller, Michael S. Tsirkin, Jason Wang
Cc: Toshiaki Makita, netdev, virtualization, Willem de Bruijn,
Jesper Dangaard Brouer
While I'm looking into how to account standard tx counters on XDP tx
processing, I found several bugs around XDP tx and napi_tx.
Patch1: Fix oops on error path. Patch2 depends on this.
Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled.
Patch3: Minor fix patch5 depends on.
Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled.
Also patch5 depends on this.
Patch5: Fix memory corruption on processing xdp_frames while XDP is being
disabled.
Patch6: Minor fix patch7 depends on.
Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal
queue is reused for XDP and vise versa.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Toshiaki Makita (7):
virtio_net: Don't enable NAPI when interface is down
virtio_net: Don't call free_old_xmit_skbs for xdp_frames
virtio_net: Fix not restoring real_num_rx_queues
virtio_net: Fix out of bounds access of sq
virtio_net: Don't process redirected XDP frames when XDP is disabled
virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs
virtio_net: Differentiate sk_buff and xdp_frame on freeing
drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++--------------
1 file changed, 109 insertions(+), 45 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-18 2:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 11:20 [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx Toshiaki Makita
2019-01-17 11:20 Toshiaki Makita
2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-17 14:55 ` Michael S. Tsirkin
2019-01-18 2:01 ` Toshiaki Makita
2019-01-18 2:01 ` Toshiaki Makita
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.