* [PATCH 0/4] Add RZ/G2M DU support
@ 2019-04-11 14:34 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, dri-devel, Biju Das, linux-renesas-soc,
Kieran Bingham, Laurent Pinchart
This patch series aims to add binding/driver support for
R8A774A1(a.k.a RZ/G2M) DU (which is very similar to the R8A7796 DU);
it has one RGB output, one LVDS output and one HDMI output.
This patchset is based on linux_next next-20190411 branch.
Biju Das (4):
dt-bindings: display: renesas: du: Document the r8a774a1 bindings
dt-bindings: display: renesas: lvds: Document r8a774a1 bindings
drm: rcar-du: Add R8A774A1 support
drm: rcar-du: lvds: Add r8a774a1 support
Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
4 files changed, 5 insertions(+)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 0/4] Add RZ/G2M DU support
@ 2019-04-11 14:34 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
This patch series aims to add binding/driver support for
R8A774A1(a.k.a RZ/G2M) DU (which is very similar to the R8A7796 DU);
it has one RGB output, one LVDS output and one HDMI output.
This patchset is based on linux_next next-20190411 branch.
Biju Das (4):
dt-bindings: display: renesas: du: Document the r8a774a1 bindings
dt-bindings: display: renesas: lvds: Document r8a774a1 bindings
drm: rcar-du: Add R8A774A1 support
drm: rcar-du: lvds: Add r8a774a1 support
Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
4 files changed, 5 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings
2019-04-11 14:34 ` Biju Das
@ 2019-04-11 14:34 ` Biju Das
-1 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, dri-devel, Biju Das, linux-renesas-soc,
Kieran Bingham, Laurent Pinchart
Document the RZ/G2M (R8A774A1) SoC in the R-Car DU bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index aedb22b..c97dfac 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -7,6 +7,7 @@ Required Properties:
- "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
- "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
+ - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
- "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
- "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
@@ -58,6 +59,7 @@ corresponding to each DU output.
R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
+ R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings
@ 2019-04-11 14:34 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Document the RZ/G2M (R8A774A1) SoC in the R-Car DU bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index aedb22b..c97dfac 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -7,6 +7,7 @@ Required Properties:
- "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
- "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
+ - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
- "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
- "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
@@ -58,6 +59,7 @@ corresponding to each DU output.
R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
+ R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 2/4] dt-bindings: display: renesas: lvds: Document r8a774a1 bindings
2019-04-11 14:34 ` Biju Das
@ 2019-04-11 14:34 ` Biju Das
-1 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, dri-devel, Biju Das, linux-renesas-soc,
Kieran Bingham, Laurent Pinchart
Document the RZ/G2M (R8A774A1) LVDS bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
index 900a884..86a691a 100644
--- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
+++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
@@ -9,6 +9,7 @@ Required properties:
- compatible : Shall contain one of
- "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
- "renesas,r8a7744-lvds" for R8A7744 (RZ/G1N) compatible LVDS encoders
+ - "renesas,r8a774a1-lvds" for R8A774A1 (RZ/G2M) compatible LVDS encoders
- "renesas,r8a774c0-lvds" for R8A774C0 (RZ/G2E) compatible LVDS encoders
- "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
- "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 2/4] dt-bindings: display: renesas: lvds: Document r8a774a1 bindings
@ 2019-04-11 14:34 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Document the RZ/G2M (R8A774A1) LVDS bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
index 900a884..86a691a 100644
--- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
+++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
@@ -9,6 +9,7 @@ Required properties:
- compatible : Shall contain one of
- "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
- "renesas,r8a7744-lvds" for R8A7744 (RZ/G1N) compatible LVDS encoders
+ - "renesas,r8a774a1-lvds" for R8A774A1 (RZ/G2M) compatible LVDS encoders
- "renesas,r8a774c0-lvds" for R8A774C0 (RZ/G2E) compatible LVDS encoders
- "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
- "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
2019-04-11 14:34 ` Biju Das
@ 2019-04-11 14:34 ` Biju Das
-1 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU);
it has one RGB output, one LVDS output and one HDMI output.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 75ab17a..f7a5314 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
+ { .compatible = "renesas,du-r8a774a1", .data = &rcar_du_r8a7796_info },
{ .compatible = "renesas,du-r8a774c0", .data = &rcar_du_r8a774c0_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
@ 2019-04-11 14:34 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: Fabrizio Castro, Chris Paterson, Geert Uytterhoeven,
Kieran Bingham, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, Laurent Pinchart
Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU);
it has one RGB output, one LVDS output and one HDMI output.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 75ab17a..f7a5314 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
+ { .compatible = "renesas,du-r8a774a1", .data = &rcar_du_r8a7796_info },
{ .compatible = "renesas,du-r8a774c0", .data = &rcar_du_r8a774c0_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support
2019-04-11 14:34 ` Biju Das
@ 2019-04-11 14:34 ` Biju Das
-1 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
The LVDS encoders on RZ/G2M SoC is similar to R-Car M3-W. Add support for
RZ/G2M (R8A774A1) SoC to the LVDS encoder driver.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 7ef97b2..819561e 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -857,6 +857,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
static const struct of_device_id rcar_lvds_of_table[] = {
{ .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
{ .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
+ { .compatible = "renesas,r8a774a1-lvds", .data = &rcar_lvds_gen3_info },
{ .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
{ .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
{ .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support
@ 2019-04-11 14:34 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-11 14:34 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: Fabrizio Castro, Chris Paterson, Geert Uytterhoeven,
Kieran Bingham, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, Laurent Pinchart
The LVDS encoders on RZ/G2M SoC is similar to R-Car M3-W. Add support for
RZ/G2M (R8A774A1) SoC to the LVDS encoder driver.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 7ef97b2..819561e 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -857,6 +857,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
static const struct of_device_id rcar_lvds_of_table[] = {
{ .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
{ .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
+ { .compatible = "renesas,r8a774a1-lvds", .data = &rcar_lvds_gen3_info },
{ .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
{ .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
{ .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings
2019-04-11 14:34 ` Biju Das
@ 2019-04-12 9:54 ` Kieran Bingham
-1 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 9:54 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Geert Uytterhoeven,
dri-devel, linux-renesas-soc, Simon Horman, Laurent Pinchart
Hi Biju,
On 11/04/2019 15:34, Biju Das wrote:
> Document the RZ/G2M (R8A774A1) SoC in the R-Car DU bindings.
Based on the expectation that this is equivalent to the M3-W, then this
looks good to me.
Are the RZ/G datasheets available publicly somewhere? If not I'll see if
I can source it through my Renesas NDA channels.
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
> index aedb22b..c97dfac 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -7,6 +7,7 @@ Required Properties:
> - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> + - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
> - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> @@ -58,6 +59,7 @@ corresponding to each DU output.
> R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> + R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
> R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings
@ 2019-04-12 9:54 ` Kieran Bingham
0 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 9:54 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Laurent Pinchart, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Hi Biju,
On 11/04/2019 15:34, Biju Das wrote:
> Document the RZ/G2M (R8A774A1) SoC in the R-Car DU bindings.
Based on the expectation that this is equivalent to the M3-W, then this
looks good to me.
Are the RZ/G datasheets available publicly somewhere? If not I'll see if
I can source it through my Renesas NDA channels.
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
> index aedb22b..c97dfac 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -7,6 +7,7 @@ Required Properties:
> - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> + - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
> - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> @@ -58,6 +59,7 @@ corresponding to each DU output.
> R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> + R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
> R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings
2019-04-12 9:54 ` Kieran Bingham
@ 2019-04-12 10:06 ` Biju Das
-1 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-12 10:06 UTC (permalink / raw)
To: kieran.bingham+renesas, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Geert Uytterhoeven,
dri-devel, linux-renesas-soc, Simon Horman, Laurent Pinchart
Hi Kieran,
Thanks for the feedback.
> Subject: Re: [PATCH 1/4] dt-bindings: display: renesas: du: Document the
> r8a774a1 bindings
>
> Hi Biju,
>
> On 11/04/2019 15:34, Biju Das wrote:
> > Document the RZ/G2M (R8A774A1) SoC in the R-Car DU bindings.
>
> Based on the expectation that this is equivalent to the M3-W, then this looks
> good to me.
>
> Are the RZ/G datasheets available publicly somewhere? If not I'll see if I can
> source it through my Renesas NDA channels.
Currently It is not publicly available. Chris Paterson will provide you the details.
An overview doc is available here.
https://www.renesas.com/eu/en/products/microcontrollers-microprocessors/rz/rzg/rzg2m.html#documents
regards,
Biju
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>
>
>
> > ---
> > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> > b/Documentation/devicetree/bindings/display/renesas,du.txt
> > index aedb22b..c97dfac 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> > @@ -7,6 +7,7 @@ Required Properties:
> > - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
> > - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> > - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> > + - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
> > - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
> > - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> > - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU @@
> > -58,6 +59,7 @@ corresponding to each DU output.
> > R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
> > R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
> > R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> > + R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
> > R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
> > R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> > R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings
@ 2019-04-12 10:06 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-12 10:06 UTC (permalink / raw)
To: kieran.bingham+renesas, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland
Cc: Laurent Pinchart, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Hi Kieran,
Thanks for the feedback.
> Subject: Re: [PATCH 1/4] dt-bindings: display: renesas: du: Document the
> r8a774a1 bindings
>
> Hi Biju,
>
> On 11/04/2019 15:34, Biju Das wrote:
> > Document the RZ/G2M (R8A774A1) SoC in the R-Car DU bindings.
>
> Based on the expectation that this is equivalent to the M3-W, then this looks
> good to me.
>
> Are the RZ/G datasheets available publicly somewhere? If not I'll see if I can
> source it through my Renesas NDA channels.
Currently It is not publicly available. Chris Paterson will provide you the details.
An overview doc is available here.
https://www.renesas.com/eu/en/products/microcontrollers-microprocessors/rz/rzg/rzg2m.html#documents
regards,
Biju
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>
>
>
> > ---
> > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> > b/Documentation/devicetree/bindings/display/renesas,du.txt
> > index aedb22b..c97dfac 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> > @@ -7,6 +7,7 @@ Required Properties:
> > - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
> > - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> > - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> > + - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
> > - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
> > - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> > - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU @@
> > -58,6 +59,7 @@ corresponding to each DU output.
> > R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
> > R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
> > R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> > + R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
> > R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
> > R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> > R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
> >
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/4] dt-bindings: display: renesas: lvds: Document r8a774a1 bindings
2019-04-11 14:34 ` Biju Das
@ 2019-04-12 10:33 ` Kieran Bingham
-1 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 10:33 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Geert Uytterhoeven,
dri-devel, linux-renesas-soc, Simon Horman, Laurent Pinchart
Hi Biju,
Thank you for the patch,
On 11/04/2019 15:34, Biju Das wrote:
> Document the RZ/G2M (R8A774A1) LVDS bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
This looks good.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> index 900a884..86a691a 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -9,6 +9,7 @@ Required properties:
> - compatible : Shall contain one of
> - "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
> - "renesas,r8a7744-lvds" for R8A7744 (RZ/G1N) compatible LVDS encoders
> + - "renesas,r8a774a1-lvds" for R8A774A1 (RZ/G2M) compatible LVDS encoders
> - "renesas,r8a774c0-lvds" for R8A774C0 (RZ/G2E) compatible LVDS encoders
> - "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
> - "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/4] dt-bindings: display: renesas: lvds: Document r8a774a1 bindings
@ 2019-04-12 10:33 ` Kieran Bingham
0 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 10:33 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter, Rob Herring, Mark Rutland
Cc: Laurent Pinchart, dri-devel, linux-renesas-soc, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Hi Biju,
Thank you for the patch,
On 11/04/2019 15:34, Biju Das wrote:
> Document the RZ/G2M (R8A774A1) LVDS bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
This looks good.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> index 900a884..86a691a 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -9,6 +9,7 @@ Required properties:
> - compatible : Shall contain one of
> - "renesas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
> - "renesas,r8a7744-lvds" for R8A7744 (RZ/G1N) compatible LVDS encoders
> + - "renesas,r8a774a1-lvds" for R8A774A1 (RZ/G2M) compatible LVDS encoders
> - "renesas,r8a774c0-lvds" for R8A774C0 (RZ/G2E) compatible LVDS encoders
> - "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
> - "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
2019-04-11 14:34 ` Biju Das
@ 2019-04-12 11:47 ` Kieran Bingham
-1 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 11:47 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter
Cc: Laurent Pinchart, dri-devel, linux-renesas-soc, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Hi Biju,
On 11/04/2019 15:34, Biju Das wrote:
> Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU);
> it has one RGB output, one LVDS output and one HDMI output.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
I see Figure 35.1b across the two datasheets does show some differences
between these two parts, but the layout defined by the
rcar_du_r8a7796_info structure is compatible based on the current state
of the driver...
However, if support for the TCON/CMM is added to the DU driver - then I
think this will need to be separated.
I have seen patches this month which are trying to upstream a CMM
implementation.
With that in mind - perhaps it would be worth creating a new structure
for this part?
Otherwise the CMM would end up being enabled when it doesn't exist and
could cause problems.
--
Regards
Kieran
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 75ab17a..f7a5314 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> + { .compatible = "renesas,du-r8a774a1", .data = &rcar_du_r8a7796_info },
> { .compatible = "renesas,du-r8a774c0", .data = &rcar_du_r8a774c0_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
@ 2019-04-12 11:47 ` Kieran Bingham
0 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 11:47 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter
Cc: Fabrizio Castro, Chris Paterson, Geert Uytterhoeven, dri-devel,
linux-renesas-soc, Simon Horman, Laurent Pinchart
Hi Biju,
On 11/04/2019 15:34, Biju Das wrote:
> Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU);
> it has one RGB output, one LVDS output and one HDMI output.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
I see Figure 35.1b across the two datasheets does show some differences
between these two parts, but the layout defined by the
rcar_du_r8a7796_info structure is compatible based on the current state
of the driver...
However, if support for the TCON/CMM is added to the DU driver - then I
think this will need to be separated.
I have seen patches this month which are trying to upstream a CMM
implementation.
With that in mind - perhaps it would be worth creating a new structure
for this part?
Otherwise the CMM would end up being enabled when it doesn't exist and
could cause problems.
--
Regards
Kieran
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 75ab17a..f7a5314 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> + { .compatible = "renesas,du-r8a774a1", .data = &rcar_du_r8a7796_info },
> { .compatible = "renesas,du-r8a774c0", .data = &rcar_du_r8a774c0_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
2019-04-12 11:47 ` Kieran Bingham
@ 2019-04-12 12:03 ` Biju Das
-1 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-12 12:03 UTC (permalink / raw)
To: kieran.bingham+renesas, David Airlie, Daniel Vetter
Cc: Laurent Pinchart, dri-devel, linux-renesas-soc, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Hi Kieran,
Thanks for the feedback.
> Subject: Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
>
> Hi Biju,
>
> On 11/04/2019 15:34, Biju Das wrote:
> > Add support for the R8A774A1 DU (which is very similar to the R8A7796
> > DU); it has one RGB output, one LVDS output and one HDMI output.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> I see Figure 35.1b across the two datasheets does show some differences
> between these two parts, but the layout defined by the
> rcar_du_r8a7796_info structure is compatible based on the current state of
> the driver...
>
> However, if support for the TCON/CMM is added to the DU driver - then I
> think this will need to be separated.
OK. I will send V2 with separate data structure " rcar_du_r8a774a1_info"
for RZ/G2M.
Regards,
Biju
> I have seen patches this month which are trying to upstream a CMM
> implementation.
>
> With that in mind - perhaps it would be worth creating a new structure for
> this part?
>
> Otherwise the CMM would end up being enabled when it doesn't exist and
> could cause problems.
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > index 75ab17a..f7a5314 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[]
> = {
> > { .compatible = "renesas,du-r8a7744", .data =
> &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data =
> &rzg1_du_r8a7745_info },
> > { .compatible = "renesas,du-r8a77470", .data =
> > &rzg1_du_r8a77470_info },
> > + { .compatible = "renesas,du-r8a774a1", .data =
> &rcar_du_r8a7796_info
> > +},
> > { .compatible = "renesas,du-r8a774c0", .data =
> &rcar_du_r8a774c0_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info
> },
> > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info
> > },
> >
^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
@ 2019-04-12 12:03 ` Biju Das
0 siblings, 0 replies; 22+ messages in thread
From: Biju Das @ 2019-04-12 12:03 UTC (permalink / raw)
To: kieran.bingham+renesas, David Airlie, Daniel Vetter
Cc: Fabrizio Castro, Chris Paterson, Geert Uytterhoeven, dri-devel,
linux-renesas-soc, Simon Horman, Laurent Pinchart
Hi Kieran,
Thanks for the feedback.
> Subject: Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
>
> Hi Biju,
>
> On 11/04/2019 15:34, Biju Das wrote:
> > Add support for the R8A774A1 DU (which is very similar to the R8A7796
> > DU); it has one RGB output, one LVDS output and one HDMI output.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> I see Figure 35.1b across the two datasheets does show some differences
> between these two parts, but the layout defined by the
> rcar_du_r8a7796_info structure is compatible based on the current state of
> the driver...
>
> However, if support for the TCON/CMM is added to the DU driver - then I
> think this will need to be separated.
OK. I will send V2 with separate data structure " rcar_du_r8a774a1_info"
for RZ/G2M.
Regards,
Biju
> I have seen patches this month which are trying to upstream a CMM
> implementation.
>
> With that in mind - perhaps it would be worth creating a new structure for
> this part?
>
> Otherwise the CMM would end up being enabled when it doesn't exist and
> could cause problems.
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > index 75ab17a..f7a5314 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[]
> = {
> > { .compatible = "renesas,du-r8a7744", .data =
> &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data =
> &rzg1_du_r8a7745_info },
> > { .compatible = "renesas,du-r8a77470", .data =
> > &rzg1_du_r8a77470_info },
> > + { .compatible = "renesas,du-r8a774a1", .data =
> &rcar_du_r8a7796_info
> > +},
> > { .compatible = "renesas,du-r8a774c0", .data =
> &rcar_du_r8a774c0_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info
> },
> > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info
> > },
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support
2019-04-11 14:34 ` Biju Das
@ 2019-04-12 12:06 ` Kieran Bingham
-1 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 12:06 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter
Cc: Laurent Pinchart, dri-devel, linux-renesas-soc, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Hi Biju,
On 11/04/2019 15:34, Biju Das wrote:
> The LVDS encoders on RZ/G2M SoC is similar to R-Car M3-W. Add support for
> RZ/G2M (R8A774A1) SoC to the LVDS encoder driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
This one seems to be ok using the gen3 as far as I can tell, the PLL
configuration and layout match.
We're lacking the TCON, but that's not supported currently anyway, and
shouldn't matter here.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 7ef97b2..819561e 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -857,6 +857,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
> static const struct of_device_id rcar_lvds_of_table[] = {
> { .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
> { .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
> + { .compatible = "renesas,r8a774a1-lvds", .data = &rcar_lvds_gen3_info },
> { .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
> { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
> { .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support
@ 2019-04-12 12:06 ` Kieran Bingham
0 siblings, 0 replies; 22+ messages in thread
From: Kieran Bingham @ 2019-04-12 12:06 UTC (permalink / raw)
To: Biju Das, David Airlie, Daniel Vetter
Cc: Fabrizio Castro, Chris Paterson, Geert Uytterhoeven, dri-devel,
linux-renesas-soc, Simon Horman, Laurent Pinchart
Hi Biju,
On 11/04/2019 15:34, Biju Das wrote:
> The LVDS encoders on RZ/G2M SoC is similar to R-Car M3-W. Add support for
> RZ/G2M (R8A774A1) SoC to the LVDS encoder driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
This one seems to be ok using the gen3 as far as I can tell, the PLL
configuration and layout match.
We're lacking the TCON, but that's not supported currently anyway, and
shouldn't matter here.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 7ef97b2..819561e 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -857,6 +857,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
> static const struct of_device_id rcar_lvds_of_table[] = {
> { .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
> { .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
> + { .compatible = "renesas,r8a774a1-lvds", .data = &rcar_lvds_gen3_info },
> { .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
> { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
> { .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2019-04-12 12:06 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-11 14:34 [PATCH 0/4] Add RZ/G2M DU support Biju Das
2019-04-11 14:34 ` Biju Das
2019-04-11 14:34 ` [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings Biju Das
2019-04-11 14:34 ` Biju Das
2019-04-12 9:54 ` Kieran Bingham
2019-04-12 9:54 ` Kieran Bingham
2019-04-12 10:06 ` Biju Das
2019-04-12 10:06 ` Biju Das
2019-04-11 14:34 ` [PATCH 2/4] dt-bindings: display: renesas: lvds: Document " Biju Das
2019-04-11 14:34 ` Biju Das
2019-04-12 10:33 ` Kieran Bingham
2019-04-12 10:33 ` Kieran Bingham
2019-04-11 14:34 ` [PATCH 3/4] drm: rcar-du: Add R8A774A1 support Biju Das
2019-04-11 14:34 ` Biju Das
2019-04-12 11:47 ` Kieran Bingham
2019-04-12 11:47 ` Kieran Bingham
2019-04-12 12:03 ` Biju Das
2019-04-12 12:03 ` Biju Das
2019-04-11 14:34 ` [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support Biju Das
2019-04-11 14:34 ` Biju Das
2019-04-12 12:06 ` Kieran Bingham
2019-04-12 12:06 ` Kieran Bingham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.