* [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind
@ 2019-05-29 10:25 ` Hsin-Yi Wang
0 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
Matthias Brugger, linux-mediatek, Daniel Vetter, CK Hu
There are some errors when unbinding and rebinding mediatek drm, dsi,
and disp-* drivers. This series is to fix those errors and warnings.
Hsin-Yi Wang (4):
drm: mediatek: fix unbind functions
drm: mediatek: unbind components in mtk_drm_unbind()
drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
drm: mediatek: clear num_pipes when unbind driver
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++-----
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 1/4] drm: mediatek: fix unbind functions
2019-05-29 10:25 ` Hsin-Yi Wang
@ 2019-05-29 10:25 ` Hsin-Yi Wang
-1 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: CK Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
attach it again.
Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
change log v1->v2:
* mipi_dsi_host_unregister() should be fixed in another patch on the list.
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index b00eb2d2e086..1ae3be99e0ff 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
/* Skip connector cleanup if creation was delegated to the bridge */
if (dsi->conn.dev)
drm_connector_cleanup(&dsi->conn);
+ if (dsi->panel)
+ drm_panel_detach(dsi->panel);
}
static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH v2 1/4] drm: mediatek: fix unbind functions
@ 2019-05-29 10:25 ` Hsin-Yi Wang
0 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
Matthias Brugger, linux-mediatek, Daniel Vetter, CK Hu
detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
attach it again.
Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
change log v1->v2:
* mipi_dsi_host_unregister() should be fixed in another patch on the list.
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index b00eb2d2e086..1ae3be99e0ff 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
/* Skip connector cleanup if creation was delegated to the bridge */
if (dsi->conn.dev)
drm_connector_cleanup(&dsi->conn);
+ if (dsi->panel)
+ drm_panel_detach(dsi->panel);
}
static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH v2 1/4] drm: mediatek: fix unbind functions
2019-05-29 10:25 ` Hsin-Yi Wang
(?)
@ 2019-05-30 2:13 ` CK Hu
-1 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:13 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
> attach it again.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> change log v1->v2:
> * mipi_dsi_host_unregister() should be fixed in another patch on the list.
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index b00eb2d2e086..1ae3be99e0ff 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
> /* Skip connector cleanup if creation was delegated to the bridge */
> if (dsi->conn.dev)
> drm_connector_cleanup(&dsi->conn);
> + if (dsi->panel)
> + drm_panel_detach(dsi->panel);
> }
>
> static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 1/4] drm: mediatek: fix unbind functions
@ 2019-05-30 2:13 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:13 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Daniel Vetter, Matthias Brugger,
linux-arm-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
> attach it again.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> change log v1->v2:
> * mipi_dsi_host_unregister() should be fixed in another patch on the list.
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index b00eb2d2e086..1ae3be99e0ff 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
> /* Skip connector cleanup if creation was delegated to the bridge */
> if (dsi->conn.dev)
> drm_connector_cleanup(&dsi->conn);
> + if (dsi->panel)
> + drm_panel_detach(dsi->panel);
> }
>
> static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 1/4] drm: mediatek: fix unbind functions
@ 2019-05-30 2:13 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:13 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
> attach it again.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> change log v1->v2:
> * mipi_dsi_host_unregister() should be fixed in another patch on the list.
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index b00eb2d2e086..1ae3be99e0ff 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
> /* Skip connector cleanup if creation was delegated to the bridge */
> if (dsi->conn.dev)
> drm_connector_cleanup(&dsi->conn);
> + if (dsi->panel)
> + drm_panel_detach(dsi->panel);
> }
>
> static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind()
2019-05-29 10:25 ` Hsin-Yi Wang
@ 2019-05-29 10:25 ` Hsin-Yi Wang
-1 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: CK Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Unbinding components (i.e. mtk_dsi and mtk_disp_ovl/rdma/color) will
trigger master(mtk_drm)'s .unbind(), and currently mtk_drm's unbind
won't actually unbind components. During the next bind,
mtk_drm_kms_init() is called, and the components are added back.
.unbind() should call mtk_drm_kms_deinit() to unbind components.
And since component_master_del() in .remove() will trigger .unbind(),
which will also unregister device, it's fine to remove original functions
called here.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
change log v1->v2:
* separate another 2 fixes to other patches.
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 57ce4708ef1b..e7362bdafa82 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -397,6 +397,7 @@ static void mtk_drm_unbind(struct device *dev)
struct mtk_drm_private *private = dev_get_drvdata(dev);
drm_dev_unregister(private->drm);
+ mtk_drm_kms_deinit(private->drm);
drm_dev_put(private->drm);
private->drm = NULL;
}
@@ -568,13 +569,8 @@ static int mtk_drm_probe(struct platform_device *pdev)
static int mtk_drm_remove(struct platform_device *pdev)
{
struct mtk_drm_private *private = platform_get_drvdata(pdev);
- struct drm_device *drm = private->drm;
int i;
- drm_dev_unregister(drm);
- mtk_drm_kms_deinit(drm);
- drm_dev_put(drm);
-
component_master_del(&pdev->dev, &mtk_drm_ops);
pm_runtime_disable(&pdev->dev);
of_node_put(private->mutex_node);
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind()
@ 2019-05-29 10:25 ` Hsin-Yi Wang
0 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
Matthias Brugger, linux-mediatek, Daniel Vetter, CK Hu
Unbinding components (i.e. mtk_dsi and mtk_disp_ovl/rdma/color) will
trigger master(mtk_drm)'s .unbind(), and currently mtk_drm's unbind
won't actually unbind components. During the next bind,
mtk_drm_kms_init() is called, and the components are added back.
.unbind() should call mtk_drm_kms_deinit() to unbind components.
And since component_master_del() in .remove() will trigger .unbind(),
which will also unregister device, it's fine to remove original functions
called here.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
change log v1->v2:
* separate another 2 fixes to other patches.
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 57ce4708ef1b..e7362bdafa82 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -397,6 +397,7 @@ static void mtk_drm_unbind(struct device *dev)
struct mtk_drm_private *private = dev_get_drvdata(dev);
drm_dev_unregister(private->drm);
+ mtk_drm_kms_deinit(private->drm);
drm_dev_put(private->drm);
private->drm = NULL;
}
@@ -568,13 +569,8 @@ static int mtk_drm_probe(struct platform_device *pdev)
static int mtk_drm_remove(struct platform_device *pdev)
{
struct mtk_drm_private *private = platform_get_drvdata(pdev);
- struct drm_device *drm = private->drm;
int i;
- drm_dev_unregister(drm);
- mtk_drm_kms_deinit(drm);
- drm_dev_put(drm);
-
component_master_del(&pdev->dev, &mtk_drm_ops);
pm_runtime_disable(&pdev->dev);
of_node_put(private->mutex_node);
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind()
2019-05-29 10:25 ` Hsin-Yi Wang
(?)
@ 2019-05-30 2:17 ` CK Hu
-1 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:17 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> Unbinding components (i.e. mtk_dsi and mtk_disp_ovl/rdma/color) will
> trigger master(mtk_drm)'s .unbind(), and currently mtk_drm's unbind
> won't actually unbind components. During the next bind,
> mtk_drm_kms_init() is called, and the components are added back.
>
> .unbind() should call mtk_drm_kms_deinit() to unbind components.
>
> And since component_master_del() in .remove() will trigger .unbind(),
> which will also unregister device, it's fine to remove original functions
> called here.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> change log v1->v2:
> * separate another 2 fixes to other patches.
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 57ce4708ef1b..e7362bdafa82 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -397,6 +397,7 @@ static void mtk_drm_unbind(struct device *dev)
> struct mtk_drm_private *private = dev_get_drvdata(dev);
>
> drm_dev_unregister(private->drm);
> + mtk_drm_kms_deinit(private->drm);
> drm_dev_put(private->drm);
> private->drm = NULL;
> }
> @@ -568,13 +569,8 @@ static int mtk_drm_probe(struct platform_device *pdev)
> static int mtk_drm_remove(struct platform_device *pdev)
> {
> struct mtk_drm_private *private = platform_get_drvdata(pdev);
> - struct drm_device *drm = private->drm;
> int i;
>
> - drm_dev_unregister(drm);
> - mtk_drm_kms_deinit(drm);
> - drm_dev_put(drm);
> -
> component_master_del(&pdev->dev, &mtk_drm_ops);
> pm_runtime_disable(&pdev->dev);
> of_node_put(private->mutex_node);
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind()
@ 2019-05-30 2:17 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:17 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Daniel Vetter, Matthias Brugger,
linux-arm-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> Unbinding components (i.e. mtk_dsi and mtk_disp_ovl/rdma/color) will
> trigger master(mtk_drm)'s .unbind(), and currently mtk_drm's unbind
> won't actually unbind components. During the next bind,
> mtk_drm_kms_init() is called, and the components are added back.
>
> .unbind() should call mtk_drm_kms_deinit() to unbind components.
>
> And since component_master_del() in .remove() will trigger .unbind(),
> which will also unregister device, it's fine to remove original functions
> called here.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> change log v1->v2:
> * separate another 2 fixes to other patches.
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 57ce4708ef1b..e7362bdafa82 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -397,6 +397,7 @@ static void mtk_drm_unbind(struct device *dev)
> struct mtk_drm_private *private = dev_get_drvdata(dev);
>
> drm_dev_unregister(private->drm);
> + mtk_drm_kms_deinit(private->drm);
> drm_dev_put(private->drm);
> private->drm = NULL;
> }
> @@ -568,13 +569,8 @@ static int mtk_drm_probe(struct platform_device *pdev)
> static int mtk_drm_remove(struct platform_device *pdev)
> {
> struct mtk_drm_private *private = platform_get_drvdata(pdev);
> - struct drm_device *drm = private->drm;
> int i;
>
> - drm_dev_unregister(drm);
> - mtk_drm_kms_deinit(drm);
> - drm_dev_put(drm);
> -
> component_master_del(&pdev->dev, &mtk_drm_ops);
> pm_runtime_disable(&pdev->dev);
> of_node_put(private->mutex_node);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind()
@ 2019-05-30 2:17 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:17 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: David Airlie, linux-kernel, dri-devel, linux-mediatek,
Matthias Brugger, linux-arm-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> Unbinding components (i.e. mtk_dsi and mtk_disp_ovl/rdma/color) will
> trigger master(mtk_drm)'s .unbind(), and currently mtk_drm's unbind
> won't actually unbind components. During the next bind,
> mtk_drm_kms_init() is called, and the components are added back.
>
> .unbind() should call mtk_drm_kms_deinit() to unbind components.
>
> And since component_master_del() in .remove() will trigger .unbind(),
> which will also unregister device, it's fine to remove original functions
> called here.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> change log v1->v2:
> * separate another 2 fixes to other patches.
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 57ce4708ef1b..e7362bdafa82 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -397,6 +397,7 @@ static void mtk_drm_unbind(struct device *dev)
> struct mtk_drm_private *private = dev_get_drvdata(dev);
>
> drm_dev_unregister(private->drm);
> + mtk_drm_kms_deinit(private->drm);
> drm_dev_put(private->drm);
> private->drm = NULL;
> }
> @@ -568,13 +569,8 @@ static int mtk_drm_probe(struct platform_device *pdev)
> static int mtk_drm_remove(struct platform_device *pdev)
> {
> struct mtk_drm_private *private = platform_get_drvdata(pdev);
> - struct drm_device *drm = private->drm;
> int i;
>
> - drm_dev_unregister(drm);
> - mtk_drm_kms_deinit(drm);
> - drm_dev_put(drm);
> -
> component_master_del(&pdev->dev, &mtk_drm_ops);
> pm_runtime_disable(&pdev->dev);
> of_node_put(private->mutex_node);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
2019-05-29 10:25 ` Hsin-Yi Wang
@ 2019-05-29 10:25 ` Hsin-Yi Wang
-1 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: CK Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
shutdown all CRTC when unbinding drm driver.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index e7362bdafa82..8718d123ccaa 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -311,6 +311,7 @@ static int mtk_drm_kms_init(struct drm_device *drm)
static void mtk_drm_kms_deinit(struct drm_device *drm)
{
drm_kms_helper_poll_fini(drm);
+ drm_atomic_helper_shutdown(drm);
component_unbind_all(drm->dev, drm);
drm_mode_config_cleanup(drm);
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
@ 2019-05-29 10:25 ` Hsin-Yi Wang
0 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
Matthias Brugger, linux-mediatek, Daniel Vetter, CK Hu
shutdown all CRTC when unbinding drm driver.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index e7362bdafa82..8718d123ccaa 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -311,6 +311,7 @@ static int mtk_drm_kms_init(struct drm_device *drm)
static void mtk_drm_kms_deinit(struct drm_device *drm)
{
drm_kms_helper_poll_fini(drm);
+ drm_atomic_helper_shutdown(drm);
component_unbind_all(drm->dev, drm);
drm_mode_config_cleanup(drm);
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
2019-05-29 10:25 ` Hsin-Yi Wang
(?)
@ 2019-05-30 2:22 ` CK Hu
-1 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:22 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> shutdown all CRTC when unbinding drm driver.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index e7362bdafa82..8718d123ccaa 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -311,6 +311,7 @@ static int mtk_drm_kms_init(struct drm_device *drm)
> static void mtk_drm_kms_deinit(struct drm_device *drm)
> {
> drm_kms_helper_poll_fini(drm);
> + drm_atomic_helper_shutdown(drm);
>
> component_unbind_all(drm->dev, drm);
> drm_mode_config_cleanup(drm);
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
@ 2019-05-30 2:22 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:22 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Daniel Vetter, Matthias Brugger,
linux-arm-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> shutdown all CRTC when unbinding drm driver.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index e7362bdafa82..8718d123ccaa 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -311,6 +311,7 @@ static int mtk_drm_kms_init(struct drm_device *drm)
> static void mtk_drm_kms_deinit(struct drm_device *drm)
> {
> drm_kms_helper_poll_fini(drm);
> + drm_atomic_helper_shutdown(drm);
>
> component_unbind_all(drm->dev, drm);
> drm_mode_config_cleanup(drm);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
@ 2019-05-30 2:22 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:22 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> shutdown all CRTC when unbinding drm driver.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index e7362bdafa82..8718d123ccaa 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -311,6 +311,7 @@ static int mtk_drm_kms_init(struct drm_device *drm)
> static void mtk_drm_kms_deinit(struct drm_device *drm)
> {
> drm_kms_helper_poll_fini(drm);
> + drm_atomic_helper_shutdown(drm);
>
> component_unbind_all(drm->dev, drm);
> drm_mode_config_cleanup(drm);
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver
2019-05-29 10:25 ` Hsin-Yi Wang
@ 2019-05-29 10:25 ` Hsin-Yi Wang
-1 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: CK Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
num_pipes is used for mutex created in mtk_drm_crtc_create(). If we
don't clear num_pipes count, when rebinding driver, the count will
be accumulated. From mtk_disp_mutex_get(), there can only be at most
10 mutex id. Clear this number so it starts from 0 in every rebind.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 8718d123ccaa..bbfe3a464aea 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev)
drm_dev_unregister(private->drm);
mtk_drm_kms_deinit(private->drm);
drm_dev_put(private->drm);
+ private->num_pipes = 0;
private->drm = NULL;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver
@ 2019-05-29 10:25 ` Hsin-Yi Wang
0 siblings, 0 replies; 25+ messages in thread
From: Hsin-Yi Wang @ 2019-05-29 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
Matthias Brugger, linux-mediatek, Daniel Vetter, CK Hu
num_pipes is used for mutex created in mtk_drm_crtc_create(). If we
don't clear num_pipes count, when rebinding driver, the count will
be accumulated. From mtk_disp_mutex_get(), there can only be at most
10 mutex id. Clear this number so it starts from 0 in every rebind.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 8718d123ccaa..bbfe3a464aea 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev)
drm_dev_unregister(private->drm);
mtk_drm_kms_deinit(private->drm);
drm_dev_put(private->drm);
+ private->num_pipes = 0;
private->drm = NULL;
}
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver
2019-05-29 10:25 ` Hsin-Yi Wang
(?)
@ 2019-05-30 2:28 ` CK Hu
-1 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:28 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> num_pipes is used for mutex created in mtk_drm_crtc_create(). If we
> don't clear num_pipes count, when rebinding driver, the count will
> be accumulated. From mtk_disp_mutex_get(), there can only be at most
> 10 mutex id. Clear this number so it starts from 0 in every rebind.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 8718d123ccaa..bbfe3a464aea 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev)
> drm_dev_unregister(private->drm);
> mtk_drm_kms_deinit(private->drm);
> drm_dev_put(private->drm);
> + private->num_pipes = 0;
> private->drm = NULL;
> }
>
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver
@ 2019-05-30 2:28 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:28 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Daniel Vetter, Matthias Brugger,
linux-arm-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> num_pipes is used for mutex created in mtk_drm_crtc_create(). If we
> don't clear num_pipes count, when rebinding driver, the count will
> be accumulated. From mtk_disp_mutex_get(), there can only be at most
> 10 mutex id. Clear this number so it starts from 0 in every rebind.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 8718d123ccaa..bbfe3a464aea 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev)
> drm_dev_unregister(private->drm);
> mtk_drm_kms_deinit(private->drm);
> drm_dev_put(private->drm);
> + private->num_pipes = 0;
> private->drm = NULL;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver
@ 2019-05-30 2:28 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-05-30 2:28 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> num_pipes is used for mutex created in mtk_drm_crtc_create(). If we
> don't clear num_pipes count, when rebinding driver, the count will
> be accumulated. From mtk_disp_mutex_get(), there can only be at most
> 10 mutex id. Clear this number so it starts from 0 in every rebind.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 8718d123ccaa..bbfe3a464aea 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev)
> drm_dev_unregister(private->drm);
> mtk_drm_kms_deinit(private->drm);
> drm_dev_put(private->drm);
> + private->num_pipes = 0;
> private->drm = NULL;
> }
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind
2019-05-29 10:25 ` Hsin-Yi Wang
(?)
@ 2019-06-04 1:33 ` CK Hu
-1 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-06-04 1:33 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> There are some errors when unbinding and rebinding mediatek drm, dsi,
> and disp-* drivers. This series is to fix those errors and warnings.
>
> Hsin-Yi Wang (4):
> drm: mediatek: fix unbind functions
> drm: mediatek: unbind components in mtk_drm_unbind()
> drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
> drm: mediatek: clear num_pipes when unbind driver
For this series with some title modification, applied to
mediatek-drm-fixes-5.2 [1], thanks.
[1]
https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.2
Regards,
CK
>
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++-----
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind
@ 2019-06-04 1:33 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-06-04 1:33 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Philipp Zabel, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Daniel Vetter, Matthias Brugger,
linux-arm-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> There are some errors when unbinding and rebinding mediatek drm, dsi,
> and disp-* drivers. This series is to fix those errors and warnings.
>
> Hsin-Yi Wang (4):
> drm: mediatek: fix unbind functions
> drm: mediatek: unbind components in mtk_drm_unbind()
> drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
> drm: mediatek: clear num_pipes when unbind driver
For this series with some title modification, applied to
mediatek-drm-fixes-5.2 [1], thanks.
[1]
https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.2
Regards,
CK
>
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++-----
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind
@ 2019-06-04 1:33 ` CK Hu
0 siblings, 0 replies; 25+ messages in thread
From: CK Hu @ 2019-06-04 1:33 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: David Airlie, linux-kernel, dri-devel, linux-mediatek,
Matthias Brugger, linux-arm-kernel
Hi, Hsin-Yi:
On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote:
> There are some errors when unbinding and rebinding mediatek drm, dsi,
> and disp-* drivers. This series is to fix those errors and warnings.
>
> Hsin-Yi Wang (4):
> drm: mediatek: fix unbind functions
> drm: mediatek: unbind components in mtk_drm_unbind()
> drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver
> drm: mediatek: clear num_pipes when unbind driver
For this series with some title modification, applied to
mediatek-drm-fixes-5.2 [1], thanks.
[1]
https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.2
Regards,
CK
>
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++-----
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 25+ messages in thread