* [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
@ 2022-05-19 7:33 Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 2/3] rpmsg: qcom: glink: remove unused name Krzysztof Kozlowski
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-19 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Stephen Boyd, Krzysztof Kozlowski
The use of strncpy() is considered deprecated for NUL-terminated
strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
In function ‘qcom_glink_rx_close’,
inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Split series per subsystem.
---
drivers/rpmsg/qcom_glink_native.c | 2 +-
drivers/rpmsg/qcom_smd.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 07586514991f..5bc5a0a6a8a7 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1546,7 +1546,7 @@ static void qcom_glink_rx_close(struct qcom_glink *glink, unsigned int rcid)
cancel_work_sync(&channel->intent_work);
if (channel->rpdev) {
- strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
+ strscpy_pad(chinfo.name, channel->name, sizeof(chinfo.name));
chinfo.src = RPMSG_ADDR_ANY;
chinfo.dst = RPMSG_ADDR_ANY;
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 6ccfa12abd10..7c8c29f6c91d 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1089,7 +1089,7 @@ static int qcom_smd_create_device(struct qcom_smd_channel *channel)
/* Assign public information to the rpmsg_device */
rpdev = &qsdev->rpdev;
- strncpy(rpdev->id.name, channel->name, RPMSG_NAME_SIZE);
+ strscpy_pad(rpdev->id.name, channel->name, RPMSG_NAME_SIZE);
rpdev->src = RPMSG_ADDR_ANY;
rpdev->dst = RPMSG_ADDR_ANY;
@@ -1323,7 +1323,7 @@ static void qcom_channel_state_worker(struct work_struct *work)
spin_unlock_irqrestore(&edge->channels_lock, flags);
- strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
+ strscpy_pad(chinfo.name, channel->name, sizeof(chinfo.name));
chinfo.src = RPMSG_ADDR_ANY;
chinfo.dst = RPMSG_ADDR_ANY;
rpmsg_unregister_device(&edge->dev, &chinfo);
--
2.32.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/3] rpmsg: qcom: glink: remove unused name
2022-05-19 7:33 [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
@ 2022-05-19 7:33 ` Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 3/3] rpmsg: qcom: correct kerneldoc Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-19 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Stephen Boyd, Krzysztof Kozlowski
The qcom_glink.name is read from DTS but never used further, never
referenced, so drop it. This also fixes kerneldoc warning:
drivers/rpmsg/qcom_glink_native.c:125:
warning: Function parameter or member 'name' not described in 'qcom_glink'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
---
Changes since v1:
1. Split series per subsystem.
2. Add tag.
---
drivers/rpmsg/qcom_glink_native.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 5bc5a0a6a8a7..72a1c0fd091d 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -98,8 +98,6 @@ struct glink_core_rx_intent {
struct qcom_glink {
struct device *dev;
- const char *name;
-
struct mbox_client mbox_client;
struct mbox_chan *mbox_chan;
@@ -1755,10 +1753,6 @@ struct qcom_glink *qcom_glink_native_probe(struct device *dev,
if (ret)
dev_err(dev, "failed to add groups\n");
- ret = of_property_read_string(dev->of_node, "label", &glink->name);
- if (ret < 0)
- glink->name = dev->of_node->name;
-
glink->mbox_client.dev = dev;
glink->mbox_client.knows_txdone = true;
glink->mbox_chan = mbox_request_channel(&glink->mbox_client, 0);
--
2.32.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] rpmsg: qcom: correct kerneldoc
2022-05-19 7:33 [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 2/3] rpmsg: qcom: glink: remove unused name Krzysztof Kozlowski
@ 2022-05-19 7:33 ` Krzysztof Kozlowski
2022-05-19 22:13 ` [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Stephen Boyd
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-19 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Stephen Boyd, Krzysztof Kozlowski
Correct kerneldoc warnings like:
drivers/rpmsg/qcom_glink_ssr.c:45:
warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() instead
Also fix meaning of 'flag' argument.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
---
Changes since v1:
1. Split series per subsystem.
2. Add tag.
---
drivers/rpmsg/qcom_glink_ssr.c | 2 +-
drivers/rpmsg/qcom_smd.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
index dea929c6045d..776d64446879 100644
--- a/drivers/rpmsg/qcom_glink_ssr.c
+++ b/drivers/rpmsg/qcom_glink_ssr.c
@@ -39,7 +39,7 @@ struct cleanup_done_msg {
__le32 seq_num;
};
-/**
+/*
* G-Link SSR protocol commands
*/
#define GLINK_SSR_DO_CLEANUP 0
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 7c8c29f6c91d..7c9ede6c7d18 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -729,11 +729,11 @@ static int qcom_smd_write_fifo(struct qcom_smd_channel *channel,
}
/**
- * qcom_smd_send - write data to smd channel
+ * __qcom_smd_send - write data to smd channel
* @channel: channel handle
* @data: buffer of data to write
* @len: number of bytes to write
- * @wait: flag to indicate if write has ca wait
+ * @wait: flag to indicate if write can wait
*
* This is a blocking write of len bytes into the channel's tx ring buffer and
* signal the remote end. It will sleep until there is enough space available
--
2.32.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
2022-05-19 7:33 [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 2/3] rpmsg: qcom: glink: remove unused name Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 3/3] rpmsg: qcom: correct kerneldoc Krzysztof Kozlowski
@ 2022-05-19 22:13 ` Stephen Boyd
2022-06-09 8:56 ` Krzysztof Kozlowski
2022-07-18 22:59 ` Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Stephen Boyd @ 2022-05-19 22:13 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Krzysztof Kozlowski,
Mathieu Poirier, linux-arm-msm, linux-kernel, linux-remoteproc
Cc: Krzysztof Kozlowski
Quoting Krzysztof Kozlowski (2022-05-19 00:33:28)
> The use of strncpy() is considered deprecated for NUL-terminated
> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
>
> In function ‘qcom_glink_rx_close’,
> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
2022-05-19 7:33 [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-05-19 22:13 ` [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Stephen Boyd
@ 2022-06-09 8:56 ` Krzysztof Kozlowski
2022-06-20 18:37 ` Krzysztof Kozlowski
2022-07-18 22:59 ` Bjorn Andersson
4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-09 8:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Stephen Boyd
On 19/05/2022 09:33, Krzysztof Kozlowski wrote:
> The use of strncpy() is considered deprecated for NUL-terminated
> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
>
> In function ‘qcom_glink_rx_close’,
> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Split series per subsystem.
Any comments on these?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
2022-06-09 8:56 ` Krzysztof Kozlowski
@ 2022-06-20 18:37 ` Krzysztof Kozlowski
2022-07-05 12:14 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-20 18:37 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Stephen Boyd
On 09/06/2022 10:56, Krzysztof Kozlowski wrote:
> On 19/05/2022 09:33, Krzysztof Kozlowski wrote:
>> The use of strncpy() is considered deprecated for NUL-terminated
>> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
>> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
>> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
>>
>> In function ‘qcom_glink_rx_close’,
>> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
>> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
>> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Changes since v1:
>> 1. Split series per subsystem.
>
> Any comments on these?
I sent first iteration in May, then on 19th of May. There is review from
Stephen.
On 9th of June I pinged but the patchset is still waiting. Anyone minds
me taking these?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
2022-06-20 18:37 ` Krzysztof Kozlowski
@ 2022-07-05 12:14 ` Krzysztof Kozlowski
2022-07-05 15:06 ` Mathieu Poirier
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-05 12:14 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Stephen Boyd
On 20/06/2022 20:37, Krzysztof Kozlowski wrote:
> On 09/06/2022 10:56, Krzysztof Kozlowski wrote:
>> On 19/05/2022 09:33, Krzysztof Kozlowski wrote:
>>> The use of strncpy() is considered deprecated for NUL-terminated
>>> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
>>> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
>>> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
>>>
>>> In function ‘qcom_glink_rx_close’,
>>> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
>>> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
>>> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
>>>
>>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Split series per subsystem.
>>
>> Any comments on these?
>
> I sent first iteration in May, then on 19th of May. There is review from
> Stephen.
>
> On 9th of June I pinged but the patchset is still waiting. Anyone minds
> me taking these?
Hmmm... These are all fixes but wait for quite a long time. Shall we
make the rpmsg subsystem orphaned?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
2022-07-05 12:14 ` Krzysztof Kozlowski
@ 2022-07-05 15:06 ` Mathieu Poirier
0 siblings, 0 replies; 9+ messages in thread
From: Mathieu Poirier @ 2022-07-05 15:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, linux-arm-msm, linux-remoteproc,
linux-kernel, Stephen Boyd
On Tue, 5 Jul 2022 at 06:14, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/06/2022 20:37, Krzysztof Kozlowski wrote:
> > On 09/06/2022 10:56, Krzysztof Kozlowski wrote:
> >> On 19/05/2022 09:33, Krzysztof Kozlowski wrote:
> >>> The use of strncpy() is considered deprecated for NUL-terminated
> >>> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
> >>> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
> >>> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
> >>>
> >>> In function ‘qcom_glink_rx_close’,
> >>> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
> >>> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
> >>> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
> >>>
> >>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>
> >>> ---
> >>>
> >>> Changes since v1:
> >>> 1. Split series per subsystem.
> >>
> >> Any comments on these?
> >
> > I sent first iteration in May, then on 19th of May. There is review from
> > Stephen.
> >
> > On 9th of June I pinged but the patchset is still waiting. Anyone minds
> > me taking these?
>
> Hmmm... These are all fixes but wait for quite a long time. Shall we
> make the rpmsg subsystem orphaned?
Bjorn handles all Qcom patches for the remoteproc/rpmsg subsystems.
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
2022-05-19 7:33 [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-06-09 8:56 ` Krzysztof Kozlowski
@ 2022-07-18 22:59 ` Bjorn Andersson
4 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2022-07-18 22:59 UTC (permalink / raw)
To: linux-kernel, krzysztof.kozlowski, agross, mathieu.poirier,
linux-remoteproc, linux-arm-msm
Cc: sboyd
On Thu, 19 May 2022 09:33:28 +0200, Krzysztof Kozlowski wrote:
> The use of strncpy() is considered deprecated for NUL-terminated
> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
>
> In function ‘qcom_glink_rx_close’,
> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
>
> [...]
Applied, thanks!
[1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
commit: 766279a8f85df32345dbda03b102ca1ee3d5ddea
[2/3] rpmsg: qcom: glink: remove unused name
commit: 6c3ebc96ffefbc48297d7c2fd266e9cb78e6941e
[3/3] rpmsg: qcom: correct kerneldoc
commit: 101042f4c0eb2daa331b4f7ce32c6d547114830a
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-07-18 22:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 7:33 [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 2/3] rpmsg: qcom: glink: remove unused name Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 3/3] rpmsg: qcom: correct kerneldoc Krzysztof Kozlowski
2022-05-19 22:13 ` [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Stephen Boyd
2022-06-09 8:56 ` Krzysztof Kozlowski
2022-06-20 18:37 ` Krzysztof Kozlowski
2022-07-05 12:14 ` Krzysztof Kozlowski
2022-07-05 15:06 ` Mathieu Poirier
2022-07-18 22:59 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.