From: Richard Henderson <richard.henderson@linaro.org>
To: Dave Martin <Dave.Martin@arm.com>, linux-kernel@vger.kernel.org
Cc: "Andrew Jones" <drjones@redhat.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Eugene Syromiatnikov" <esyr@redhat.com>,
"Florian Weimer" <fweimer@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>, "Jann Horn" <jannh@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Kristina Martšenko" <kristina.martsenko@arm.com>,
"Mark Brown" <broonie@kernel.org>,
"Paul Elliott" <paul.elliott@arm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Sudakshina Das" <sudi.das@arm.com>,
"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Will Deacon" <will.deacon@arm.com>,
"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
"Amit Kachhap" <amit.kachhap@arm.com>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/12] arm64: BTI: Decode BYTPE bits when printing PSTATE
Date: Fri, 11 Oct 2019 11:31:02 -0400 [thread overview]
Message-ID: <18c9318c-d122-b534-b526-318935d9e2cc@linaro.org> (raw)
In-Reply-To: <1570733080-21015-9-git-send-email-Dave.Martin@arm.com>
On 10/10/19 2:44 PM, Dave Martin wrote:
> #define PSR_IL_BIT (1 << 20)
> -#define PSR_BTYPE_CALL (2 << PSR_BTYPE_SHIFT)
> +
> +/* Convenience names for the values of PSTATE.BTYPE */
> +#define PSR_BTYPE_NONE (0b00 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_JC (0b01 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_C (0b10 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_J (0b11 << PSR_BTYPE_SHIFT)
It'd be nice to sort this patch earlier, so that ...
> diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c
> index 4a3bd32..452ac5b 100644
> --- a/arch/arm64/kernel/signal.c
> +++ b/arch/arm64/kernel/signal.c
> @@ -732,7 +732,7 @@ static void setup_return(struct pt_regs *regs, struct k_sigaction *ka,
>
> if (system_supports_bti()) {
> regs->pstate &= ~PSR_BTYPE_MASK;
> - regs->pstate |= PSR_BTYPE_CALL;
> + regs->pstate |= PSR_BTYPE_C;
> }
>
> if (ka->sa.sa_flags & SA_RESTORER)
... setup_return does not need to be adjusted a second time.
I don't see any other conflicts vs patch 5.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: Dave Martin <Dave.Martin@arm.com>, linux-kernel@vger.kernel.org
Cc: "Andrew Jones" <drjones@redhat.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Eugene Syromiatnikov" <esyr@redhat.com>,
"Florian Weimer" <fweimer@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>, "Jann Horn" <jannh@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Kristina Martšenko" <kristina.martsenko@arm.com>,
"Mark Brown" <broonie@kernel.org>,
"Paul Elliott" <paul.elliott@arm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Sudakshina Das" <sudi.das@arm.com>,
"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Will Deacon" <will.deacon@arm.com>,
"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
"Amit Kachhap" <amit.kachhap@arm.com>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
linux-arch@vger.kernel.orglinux
Subject: Re: [PATCH v2 08/12] arm64: BTI: Decode BYTPE bits when printing PSTATE
Date: Fri, 11 Oct 2019 11:31:02 -0400 [thread overview]
Message-ID: <18c9318c-d122-b534-b526-318935d9e2cc@linaro.org> (raw)
In-Reply-To: <1570733080-21015-9-git-send-email-Dave.Martin@arm.com>
On 10/10/19 2:44 PM, Dave Martin wrote:
> #define PSR_IL_BIT (1 << 20)
> -#define PSR_BTYPE_CALL (2 << PSR_BTYPE_SHIFT)
> +
> +/* Convenience names for the values of PSTATE.BTYPE */
> +#define PSR_BTYPE_NONE (0b00 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_JC (0b01 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_C (0b10 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_J (0b11 << PSR_BTYPE_SHIFT)
It'd be nice to sort this patch earlier, so that ...
> diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c
> index 4a3bd32..452ac5b 100644
> --- a/arch/arm64/kernel/signal.c
> +++ b/arch/arm64/kernel/signal.c
> @@ -732,7 +732,7 @@ static void setup_return(struct pt_regs *regs, struct k_sigaction *ka,
>
> if (system_supports_bti()) {
> regs->pstate &= ~PSR_BTYPE_MASK;
> - regs->pstate |= PSR_BTYPE_CALL;
> + regs->pstate |= PSR_BTYPE_C;
> }
>
> if (ka->sa.sa_flags & SA_RESTORER)
... setup_return does not need to be adjusted a second time.
I don't see any other conflicts vs patch 5.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: Dave Martin <Dave.Martin@arm.com>, linux-kernel@vger.kernel.org
Cc: "Florian Weimer" <fweimer@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
"Andrew Jones" <drjones@redhat.com>,
"Kees Cook" <keescook@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Eugene Syromiatnikov" <esyr@redhat.com>,
"Kristina Martšenko" <kristina.martsenko@arm.com>,
"Szabolcs Nagy" <szabolcs.nagy@arm.com>,
"Mark Brown" <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
"Amit Kachhap" <amit.kachhap@arm.com>,
"Paul Elliott" <paul.elliott@arm.com>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Sudakshina Das" <sudi.das@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Yu-cheng Yu" <yu-cheng.yu@intel.com>
Subject: Re: [PATCH v2 08/12] arm64: BTI: Decode BYTPE bits when printing PSTATE
Date: Fri, 11 Oct 2019 11:31:02 -0400 [thread overview]
Message-ID: <18c9318c-d122-b534-b526-318935d9e2cc@linaro.org> (raw)
In-Reply-To: <1570733080-21015-9-git-send-email-Dave.Martin@arm.com>
On 10/10/19 2:44 PM, Dave Martin wrote:
> #define PSR_IL_BIT (1 << 20)
> -#define PSR_BTYPE_CALL (2 << PSR_BTYPE_SHIFT)
> +
> +/* Convenience names for the values of PSTATE.BTYPE */
> +#define PSR_BTYPE_NONE (0b00 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_JC (0b01 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_C (0b10 << PSR_BTYPE_SHIFT)
> +#define PSR_BTYPE_J (0b11 << PSR_BTYPE_SHIFT)
It'd be nice to sort this patch earlier, so that ...
> diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c
> index 4a3bd32..452ac5b 100644
> --- a/arch/arm64/kernel/signal.c
> +++ b/arch/arm64/kernel/signal.c
> @@ -732,7 +732,7 @@ static void setup_return(struct pt_regs *regs, struct k_sigaction *ka,
>
> if (system_supports_bti()) {
> regs->pstate &= ~PSR_BTYPE_MASK;
> - regs->pstate |= PSR_BTYPE_CALL;
> + regs->pstate |= PSR_BTYPE_C;
> }
>
> if (ka->sa.sa_flags & SA_RESTORER)
... setup_return does not need to be adjusted a second time.
I don't see any other conflicts vs patch 5.
r~
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-11 15:31 UTC|newest]
Thread overview: 145+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 18:44 [PATCH v2 00/12] arm64: ARMv8.5-A: Branch Target Identification support Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 01/12] ELF: UAPI and Kconfig additions for ELF program properties Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 02/12] ELF: Add ELF program property parsing support Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 03/12] mm: Reserve asm-generic prot flag 0x10 for arch use Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 04/12] arm64: docs: cpu-feature-registers: Document ID_AA64PFR1_EL1 Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-11 13:19 ` Alex Bennée
2019-10-11 13:19 ` Alex Bennée
2019-10-11 13:19 ` Alex Bennée
2019-10-11 14:51 ` Dave Martin
2019-10-11 14:51 ` Dave Martin
2019-10-11 14:51 ` Dave Martin
2019-10-21 19:18 ` Mark Brown
2019-10-21 19:18 ` Mark Brown
2019-10-21 19:18 ` Mark Brown
2019-10-22 10:32 ` Will Deacon
2019-10-22 10:32 ` Will Deacon
2019-10-22 10:32 ` Will Deacon
2019-10-10 18:44 ` [PATCH v2 05/12] arm64: Basic Branch Target Identification support Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-11 15:06 ` [FIXUP 0/2] Fixups to patch 5 Dave Martin
2019-10-11 15:06 ` Dave Martin
2019-10-11 15:06 ` Dave Martin
2019-10-11 15:06 ` [FIXUP 1/2] squash! arm64: Basic Branch Target Identification support Dave Martin
2019-10-11 15:06 ` Dave Martin
2019-10-11 15:06 ` Dave Martin
2019-10-11 15:06 ` [FIXUP 2/2] " Dave Martin
2019-10-11 15:06 ` Dave Martin
2019-10-11 15:06 ` Dave Martin
2019-10-11 15:10 ` [PATCH v2 05/12] " Mark Rutland
2019-10-11 15:10 ` Mark Rutland
2019-10-11 15:10 ` Mark Rutland
2019-10-11 15:25 ` Richard Henderson
2019-10-11 15:25 ` Richard Henderson
2019-10-11 15:25 ` Richard Henderson
2019-10-11 15:32 ` Dave Martin
2019-10-11 15:32 ` Dave Martin
2019-10-11 15:32 ` Dave Martin
2019-10-11 15:40 ` Mark Rutland
2019-10-11 15:40 ` Mark Rutland
2019-10-11 15:40 ` Mark Rutland
2019-10-11 15:44 ` Dave Martin
2019-10-11 15:44 ` Dave Martin
2019-10-11 15:44 ` Dave Martin
2019-10-11 16:01 ` Dave Martin
2019-10-11 16:01 ` Dave Martin
2019-10-11 16:01 ` Dave Martin
2019-10-11 16:42 ` Dave Martin
2019-10-11 16:42 ` Dave Martin
2019-10-11 16:42 ` Dave Martin
2019-10-18 11:05 ` Mark Rutland
2019-10-18 11:05 ` Mark Rutland
2019-10-18 11:05 ` Mark Rutland
2019-10-18 13:36 ` Dave Martin
2019-10-18 13:36 ` Dave Martin
2019-10-18 13:36 ` Dave Martin
2019-10-11 17:20 ` Dave Martin
2019-10-11 17:20 ` Dave Martin
2019-10-11 17:20 ` Dave Martin
2019-10-18 11:10 ` Mark Rutland
2019-10-18 11:10 ` Mark Rutland
2019-10-18 11:10 ` Mark Rutland
2019-10-18 13:37 ` Dave Martin
2019-10-18 13:37 ` Dave Martin
2019-10-18 13:37 ` Dave Martin
2019-10-18 11:16 ` Mark Rutland
2019-10-18 11:16 ` Mark Rutland
2019-10-18 11:16 ` Mark Rutland
2019-10-18 11:16 ` Mark Rutland
2019-10-18 13:40 ` Dave Martin
2019-10-18 13:40 ` Dave Martin
2019-10-18 13:40 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 06/12] elf: Allow arch to tweak initial mmap prot flags Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 07/12] arm64: elf: Enable BTI at exec based on ELF program properties Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 08/12] arm64: BTI: Decode BYTPE bits when printing PSTATE Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-11 15:31 ` Richard Henderson [this message]
2019-10-11 15:31 ` Richard Henderson
2019-10-11 15:31 ` Richard Henderson
2019-10-11 15:33 ` Dave Martin
2019-10-11 15:33 ` Dave Martin
2019-10-11 15:33 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 09/12] arm64: traps: Fix inconsistent faulting instruction skipping Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-11 15:24 ` Mark Rutland
2019-10-11 15:24 ` Mark Rutland
2019-10-11 15:24 ` Mark Rutland
2019-10-15 15:21 ` Dave Martin
2019-10-15 15:21 ` Dave Martin
2019-10-15 15:21 ` Dave Martin
2019-10-15 16:42 ` Mark Rutland
2019-10-15 16:42 ` Mark Rutland
2019-10-15 16:42 ` Mark Rutland
2019-10-15 16:49 ` Dave Martin
2019-10-15 16:49 ` Dave Martin
2019-10-15 16:49 ` Dave Martin
2019-10-18 16:40 ` Dave Martin
2019-10-18 16:40 ` Dave Martin
2019-10-18 16:40 ` Dave Martin
2019-10-22 11:09 ` Robin Murphy
2019-10-22 11:09 ` Robin Murphy
2019-10-22 11:09 ` Robin Murphy
2019-10-10 18:44 ` [PATCH v2 10/12] arm64: traps: Shuffle code to eliminate forward declarations Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 11/12] arm64: BTI: Reset BTYPE when skipping emulated instructions Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-11 14:21 ` Mark Rutland
2019-10-11 14:21 ` Mark Rutland
2019-10-11 14:21 ` Mark Rutland
2019-10-11 14:47 ` Dave Martin
2019-10-11 14:47 ` Dave Martin
2019-10-11 14:47 ` Dave Martin
2019-10-18 11:04 ` Mark Rutland
2019-10-18 11:04 ` Mark Rutland
2019-10-18 11:04 ` Mark Rutland
2019-10-18 14:49 ` Dave Martin
2019-10-18 14:49 ` Dave Martin
2019-10-18 14:49 ` Dave Martin
2019-10-10 18:44 ` [PATCH v2 12/12] KVM: " Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-10 18:44 ` Dave Martin
2019-10-11 14:24 ` Mark Rutland
2019-10-11 14:24 ` Mark Rutland
2019-10-11 14:24 ` Mark Rutland
2019-10-11 14:44 ` Dave Martin
2019-10-11 14:44 ` Dave Martin
2019-10-11 14:44 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18c9318c-d122-b534-b526-318935d9e2cc@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Dave.Martin@arm.com \
--cc=amit.kachhap@arm.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=drjones@redhat.com \
--cc=esyr@redhat.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kristina.martsenko@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.elliott@arm.com \
--cc=peterz@infradead.org \
--cc=sudi.das@arm.com \
--cc=szabolcs.nagy@arm.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.