From: Florian Fainelli <f.fainelli@gmail.com> To: "Andreas Färber" <afaerber@suse.de>, linux-arm-kernel@lists.infradead.org Cc: support@lemaker.org, 张天益 <tyzhang@actions-semi.com>, "Jason Cooper" <jason@lakedaemon.net>, "Arnd Bergmann" <arnd@arndb.de>, 梅利 <harrymei@actions-semi.com>, "Neil Armstrong" <narmstrong@baylibre.com>, linux-kernel@vger.kernel.org, "Thomas Liau" <thomas.liau@actions-semi.com>, "Russell King" <linux@armlinux.org.uk>, support@cubietech.com, lee@cubietech.com, "Andrew Lunn" <andrew@lunn.ch>, 张东风 <zhangdf@actions-semi.com>, 刘炜 <liuwei@actions-semi.com>, "Gregory Clement" <gregory.clement@free-electrons.com>, "Alexandre Belloni" <alexandre.belloni@free-electrons.com>, "Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com> Subject: Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Date: Sun, 9 Jul 2017 21:27:37 -0700 [thread overview] Message-ID: <1c790718-657e-e860-e03e-473b5ddba6a3@gmail.com> (raw) In-Reply-To: <1fd52467-48fc-5283-6b48-5d653105ba19@suse.de> On 07/09/2017 02:55 PM, Andreas Färber wrote: > Am 06.07.2017 um 19:17 schrieb Andreas Färber: >> Am 05.07.2017 um 04:36 schrieb Florian Fainelli: >>> On July 4, 2017 4:32:18 PM PDT, "Andreas Färber" <afaerber@suse.de> wrote: >>>> - writel(virt_to_phys(owl_secondary_startup), >>>> + writel(virt_to_phys(secondary_startup), >>>> timer_base_addr + OWL_CPU1_ADDR + (cpu - 1) * 4); >>> >>> This is a kernel symbol so please use __pa_symbol() here, also you might want to build with CONFIG_DEBUG_VIRTUAL and see if you get other warnings about using virt_to_phys() in the owl platform code (I did not check if there are other uses) > > Florian, I don't spot any build or runtime warning for this > virt_to_phys() with CONFIG_DEBUG_VIRTUAL=y on Guitar/S500: You would only see run time warnings, not build time warnings for this, but in fact, no, see below. > > [ 0.062765] CPU: Testing write buffer coherency: ok > [ 0.063468] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 > [ 0.100856] Setting up static identity map for 0x100000 - 0x100060 > [ 0.120864] Hierarchical SRCU implementation. > [ 0.161092] smp: Bringing up secondary CPUs ... > [ 0.291654] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001 > [ 0.422226] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002 > [ 0.552798] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003 > [ 0.553074] smp: Brought up 1 node, 4 CPUs > [ 0.553388] SMP: Total of 4 processors activated (1629.38 BogoMIPS). > [ 0.553477] CPU: All CPU(s) started in SVC mode. > > I've tested that __pa_symbol() works as well, but I'd like to understand > this for commit message and future testing. Am I missing other options? After re-checking the implementation you would get a warning only if you were using virt_to_phys() against a part of the kernel that is not in the linear map, similarly you would get a warning if __pa_symbol() was used against symbols outside of the kernel image, this is obviously not the case here. You should use __pa_symbol() just for correctness, no warning would be produced, sorry for misleading you with that. -- Florian
WARNING: multiple messages have this Message-ID (diff)
From: f.fainelli@gmail.com (Florian Fainelli) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Date: Sun, 9 Jul 2017 21:27:37 -0700 [thread overview] Message-ID: <1c790718-657e-e860-e03e-473b5ddba6a3@gmail.com> (raw) In-Reply-To: <1fd52467-48fc-5283-6b48-5d653105ba19@suse.de> On 07/09/2017 02:55 PM, Andreas F?rber wrote: > Am 06.07.2017 um 19:17 schrieb Andreas F?rber: >> Am 05.07.2017 um 04:36 schrieb Florian Fainelli: >>> On July 4, 2017 4:32:18 PM PDT, "Andreas F?rber" <afaerber@suse.de> wrote: >>>> - writel(virt_to_phys(owl_secondary_startup), >>>> + writel(virt_to_phys(secondary_startup), >>>> timer_base_addr + OWL_CPU1_ADDR + (cpu - 1) * 4); >>> >>> This is a kernel symbol so please use __pa_symbol() here, also you might want to build with CONFIG_DEBUG_VIRTUAL and see if you get other warnings about using virt_to_phys() in the owl platform code (I did not check if there are other uses) > > Florian, I don't spot any build or runtime warning for this > virt_to_phys() with CONFIG_DEBUG_VIRTUAL=y on Guitar/S500: You would only see run time warnings, not build time warnings for this, but in fact, no, see below. > > [ 0.062765] CPU: Testing write buffer coherency: ok > [ 0.063468] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 > [ 0.100856] Setting up static identity map for 0x100000 - 0x100060 > [ 0.120864] Hierarchical SRCU implementation. > [ 0.161092] smp: Bringing up secondary CPUs ... > [ 0.291654] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001 > [ 0.422226] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002 > [ 0.552798] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003 > [ 0.553074] smp: Brought up 1 node, 4 CPUs > [ 0.553388] SMP: Total of 4 processors activated (1629.38 BogoMIPS). > [ 0.553477] CPU: All CPU(s) started in SVC mode. > > I've tested that __pa_symbol() works as well, but I'd like to understand > this for commit message and future testing. Am I missing other options? After re-checking the implementation you would get a warning only if you were using virt_to_phys() against a part of the kernel that is not in the linear map, similarly you would get a warning if __pa_symbol() was used against symbols outside of the kernel image, this is obviously not the case here. You should use __pa_symbol() just for correctness, no warning would be produced, sorry for misleading you with that. -- Florian
next prev parent reply other threads:[~2017-07-10 4:27 UTC|newest] Thread overview: 222+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-06 0:53 [PATCH v4 00/28] ARM: Initial Actions Semi S500 and S900 enablement Andreas Färber 2017-06-06 0:53 ` Andreas Färber 2017-06-06 0:53 ` Andreas Färber 2017-06-06 0:53 ` [PATCH v4 01/28] dt-bindings: Add vendor prefix for Actions Semi Andreas Färber 2017-06-06 0:53 ` Andreas Färber 2017-06-06 0:53 ` Andreas Färber 2017-06-18 18:46 ` Andreas Färber 2017-06-18 18:46 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 02/28] dt-bindings: arm: Document Actions Semi S500 Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 18:48 ` Andreas Färber 2017-06-18 18:48 ` Andreas Färber 2017-06-18 18:48 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 03/28] dt-bindings: timer: Document Owl timer Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 20:18 ` Andreas Färber 2017-06-18 20:18 ` Andreas Färber 2017-06-18 20:18 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 04/28] clocksource: Add " Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 16:33 ` Daniel Lezcano 2017-06-06 16:33 ` Daniel Lezcano 2017-06-18 20:43 ` Andreas Färber 2017-06-18 20:43 ` Andreas Färber 2017-06-19 13:53 ` Daniel Lezcano 2017-06-19 13:53 ` Daniel Lezcano 2017-06-19 14:31 ` Andreas Färber 2017-06-19 14:31 ` Andreas Färber 2017-06-21 11:57 ` Daniel Lezcano 2017-06-21 11:57 ` Daniel Lezcano 2017-06-06 0:54 ` [PATCH v4 05/28] clocksource: owl: Add S900 support Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 16:34 ` Daniel Lezcano 2017-06-06 16:34 ` Daniel Lezcano 2017-06-18 20:50 ` Andreas Färber 2017-06-18 20:50 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 06/28] ARM: Prepare Actions Semi S500 Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 21:21 ` Andreas Färber 2017-06-18 21:21 ` Andreas Färber 2017-07-01 21:41 ` [PATCH] ARM: owl: Drop custom machine Andreas Färber 2017-07-01 21:41 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 07/28] ARM64: Prepare Actions Semi S900 Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-11 13:04 ` Andreas Färber 2017-06-11 13:04 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 08/28] dt-bindings: serial: Document Actions Semi Owl UARTs Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 09/28] tty: serial: Add Actions Semi Owl UART earlycon Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 21:45 ` Andreas Färber 2017-06-18 21:45 ` Andreas Färber 2017-06-19 1:16 ` Greg Kroah-Hartman 2017-06-19 1:16 ` Greg Kroah-Hartman 2017-06-19 1:24 ` Andreas Färber 2017-06-19 1:24 ` Andreas Färber 2017-06-19 1:46 ` [PATCH v5 07/26] dt-bindings: serial: Document Actions Semi Owl UARTs Andreas Färber 2017-06-19 1:46 ` Andreas Färber 2017-06-19 1:46 ` Andreas Färber 2017-06-19 1:46 ` [PATCH v5 08/26] tty: serial: Add Actions Semi Owl UART earlycon Andreas Färber 2017-06-19 1:46 ` Andreas Färber 2017-06-19 2:12 ` [PATCH v4 09/28] " Greg Kroah-Hartman 2017-06-19 2:12 ` Greg Kroah-Hartman 2017-06-19 2:26 ` Andreas Färber 2017-06-19 2:26 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 10/28] Documentation: kernel-parameters: Document owl earlycon Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 11/28] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 22:10 ` Andreas Färber 2017-06-18 22:10 ` Andreas Färber 2017-06-18 22:10 ` Andreas Färber 2017-06-19 1:08 ` [PATCH v5 10/27] " Andreas Färber 2017-06-19 1:08 ` Andreas Färber 2017-06-19 1:08 ` Andreas Färber 2017-06-19 2:01 ` Andreas Färber 2017-06-19 2:01 ` Andreas Färber 2017-06-19 2:01 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 12/28] dt-bindings: Add vendor prefix for uCRobotics Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 22:19 ` Andreas Färber 2017-06-18 22:19 ` Andreas Färber 2017-06-18 22:19 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 13/28] dt-bindings: arm: Document Actions Semi S900 Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 22:29 ` Andreas Färber 2017-06-18 22:29 ` Andreas Färber 2017-06-18 22:29 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 14/28] ARM64: dts: Add Actions Semi S900 and Bubblegum-96 Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 22:40 ` Andreas Färber 2017-06-18 22:40 ` Andreas Färber 2017-06-18 22:40 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 15/28] MAINTAINERS: Add Actions Semi Owl section Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-18 22:49 ` Andreas Färber 2017-06-18 22:49 ` Andreas Färber 2017-06-19 2:44 ` [PATCH v5 13/26] " Andreas Färber 2017-06-19 2:44 ` Andreas Färber 2017-06-26 6:56 ` 答复: " 张天益 2017-06-26 6:56 ` 张天益 2017-06-06 0:54 ` [PATCH v4 16/28] tty: serial: owl: Implement console driver Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-06 13:34 ` Alan Cox 2017-06-06 13:34 ` Alan Cox 2017-06-06 13:34 ` Alan Cox 2017-07-02 20:27 ` Andreas Färber 2017-07-02 20:27 ` Andreas Färber 2017-06-07 14:37 ` Andy Shevchenko 2017-06-07 14:37 ` Andy Shevchenko 2017-06-07 14:37 ` Andy Shevchenko 2017-07-02 22:36 ` Andreas Färber 2017-07-02 22:36 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 17/28] ARM64: dts: actions: s900-bubblegum-96: Add fake uart5 clock Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-09-05 21:29 ` Andreas Färber 2017-09-05 21:29 ` Andreas Färber 2017-09-05 21:29 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 18/28] ARM: dts: s500-guitar-bb-rev-b: Add fake uart3 clock Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-09-05 21:37 ` Andreas Färber 2017-09-05 21:37 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 19/28] dt-bindings: arm: cpus: Add S500 enable-method Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 2:09 ` Andreas Färber 2017-06-19 2:09 ` Andreas Färber 2017-06-19 2:09 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 2:11 ` Andreas Färber 2017-06-19 2:11 ` Andreas Färber 2017-06-21 8:16 ` Arnd Bergmann 2017-06-21 8:16 ` Arnd Bergmann 2017-06-21 10:25 ` Arnd Bergmann 2017-06-21 10:25 ` Arnd Bergmann 2017-06-21 16:48 ` Andreas Färber 2017-06-21 16:48 ` Andreas Färber 2017-06-21 18:02 ` Arnd Bergmann 2017-06-21 18:02 ` Arnd Bergmann 2017-06-29 15:07 ` Arnd Bergmann 2017-06-29 15:07 ` Arnd Bergmann 2017-06-29 15:22 ` Andreas Färber 2017-06-29 15:22 ` Andreas Färber 2017-06-29 15:50 ` Arnd Bergmann 2017-06-29 15:50 ` Arnd Bergmann 2017-07-01 21:29 ` [PATCH] ARM: owl: smp: Drop bogus holding pen Andreas Färber 2017-07-01 21:29 ` Andreas Färber 2017-07-03 12:35 ` Arnd Bergmann 2017-07-03 12:35 ` Arnd Bergmann 2017-07-01 4:42 ` 答复: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 刘炜 2017-07-01 4:42 ` 刘炜 2017-07-01 19:56 ` Andreas Färber 2017-07-01 19:56 ` Andreas Färber 2017-07-03 8:13 ` 刘炜 2017-07-03 8:13 ` 刘炜 2017-07-04 23:32 ` [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Andreas Färber 2017-07-04 23:32 ` Andreas Färber 2017-07-05 2:36 ` Florian Fainelli 2017-07-05 2:36 ` Florian Fainelli 2017-07-06 17:17 ` Andreas Färber 2017-07-06 17:17 ` Andreas Färber 2017-07-06 17:38 ` Alexandre Belloni 2017-07-06 17:38 ` Alexandre Belloni 2017-07-06 19:47 ` Florian Fainelli 2017-07-06 19:47 ` Florian Fainelli 2017-07-07 7:34 ` Gregory CLEMENT 2017-07-07 7:34 ` Gregory CLEMENT 2017-07-07 17:32 ` Florian Fainelli 2017-07-07 17:32 ` Florian Fainelli 2017-07-06 17:39 ` Mark Rutland 2017-07-06 17:39 ` Mark Rutland 2017-07-06 21:16 ` Florian Fainelli 2017-07-06 21:16 ` Florian Fainelli 2017-07-09 21:55 ` Andreas Färber 2017-07-09 21:55 ` Andreas Färber 2017-07-10 4:27 ` Florian Fainelli [this message] 2017-07-10 4:27 ` Florian Fainelli 2017-06-06 0:54 ` [PATCH v4 21/28] ARM: dts: s500: Set CPU enable-method Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 2:09 ` Andreas Färber 2017-06-19 2:09 ` Andreas Färber 2017-06-19 2:09 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 22/28] dt-bindings: power: Add Owl SPS power domains Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 3:36 ` [PATCH v5 20/26] " Andreas Färber 2017-06-19 3:36 ` Andreas Färber 2017-06-19 3:36 ` Andreas Färber 2017-06-19 3:57 ` Andreas Färber 2017-06-19 3:57 ` Andreas Färber 2017-06-19 3:57 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 23/28] soc: actions: Add Owl SPS Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 3:40 ` [PATCH v5 21/26] " Andreas Färber 2017-06-19 3:40 ` Andreas Färber 2017-06-19 3:59 ` Andreas Färber 2017-06-19 3:59 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 24/28] MAINTAINERS: Update Actions Semi section with SPS Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 3:44 ` [PATCH v5 22/26] " Andreas Färber 2017-06-19 3:44 ` Andreas Färber 2017-06-19 4:00 ` Andreas Färber 2017-06-19 4:00 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 25/28] ARM: dts: s500: Add SPS node Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 4:01 ` Andreas Färber 2017-06-19 4:01 ` Andreas Färber 2017-06-19 4:01 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 26/28] ARM: dts: s500: Set power domains for CPU2 and CPU3 Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-07-27 20:58 ` Andreas Färber 2017-07-27 20:58 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 27/28] soc: actions: owl-sps: Factor out owl_sps_set_pg() for power-gating Andreas Färber 2017-06-06 0:54 ` Andreas Färber 2017-06-19 4:12 ` Andreas Färber 2017-06-19 4:12 ` Andreas Färber 2017-06-06 0:54 ` [PATCH v4 28/28] ARM: owl: smp: Implement SPS power-gating for CPU2 and CPU3 Andreas Färber 2017-06-06 0:54 ` Andreas Färber
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1c790718-657e-e860-e03e-473b5ddba6a3@gmail.com \ --to=f.fainelli@gmail.com \ --cc=afaerber@suse.de \ --cc=alexandre.belloni@free-electrons.com \ --cc=andrew@lunn.ch \ --cc=arnd@arndb.de \ --cc=gregory.clement@free-electrons.com \ --cc=harrymei@actions-semi.com \ --cc=jason@lakedaemon.net \ --cc=lee@cubietech.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=liuwei@actions-semi.com \ --cc=narmstrong@baylibre.com \ --cc=sebastian.hesselbarth@gmail.com \ --cc=support@cubietech.com \ --cc=support@lemaker.org \ --cc=thomas.liau@actions-semi.com \ --cc=tyzhang@actions-semi.com \ --cc=zhangdf@actions-semi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.