All of lore.kernel.org
 help / color / mirror / Atom feed
From: 刘炜 <liuwei@actions-semi.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Thomas Liau" <thomas.liau@actions-semi.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	mp-cs <mp-cs@actions-semi.com>, 张东风 <zhangdf@actions-semi.com>,
	张天益 <tyzhang@actions-semi.com>,
	96boards@ucrobotics.com, support@lemaker.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Russell King" <linux@armlinux.org.uk>
Subject: RE: RE: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500
Date: Mon, 3 Jul 2017 16:13:34 +0800	[thread overview]
Message-ID: <DC4E6E803E914F4B8AFE57F1456019F10364478E@srv-mail-02.actions.com.cn> (raw)
In-Reply-To: <a7360245-5a65-7146-f295-0e90fb428173@suse.de>

Hi, Andreas

Actually the owl_v7_invalidate_l1 is not needed, and the headsmp-owl.S file can be removed if pen release staff is not used. The CPUx can jump to secondary_startup directly by setting OWL_CPUx_ADDR register.

Because S900 is aarch64 architecture, it cannot boot CPUx simply by setting SPS register. It depends on the low-level arm-trusted-firmware. Linux kernel can boot up CPUx by PSCI interface, and the arm-trusted-firmware will power on CPUx, initialize EL3 register and jump to EL2 entry in Linux kernel.

Best Regards,
David Liu

-----Original Message-----
From: Andreas Färber [mailto:afaerber@suse.de] 
Sent: Sunday, July 02, 2017 3:57 AM
To: 刘炜
Cc: Arnd Bergmann; Thomas Liau; Linux ARM; mp-cs; 张东风; 张天益; 96boards@ucrobotics.com; support@lemaker.org; Linux Kernel Mailing List; Russell King
Subject: Re: 答复: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500

Hi David,

Am 01.07.2017 um 06:42 schrieb 刘炜:
> OWL_CPUx_ADDR is the physical address of CPUx wakeup function.
> OWL_CPUx_FLAG is a valid flag of OWL_CPUx_ADDR. 
> 
> After CPUxs are wakeuped by SEV instruction, they will check their own OWL_CPUx_FLAG register. If the register vlaue is 0x55aa, CPUx will jump to OWL_CPUx_ADDR to boot up, otherwize go to sleep by WFE.
> 
> So the pen release staff is not necessary, you can remove these code safely.

Thank you for the quick confirmation!

I have just tested a patch, and it appears to work.

Is owl_v7_invalidate_l1 necessary? mach-sunxi (that Arnd pointed to as
example) uses secondary_startup directly, without custom assembler code.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/mach-actions/headsmp.S

> BTW: CPU2/3 must exit the power gate state before wakeup, and CPU1 is always power on and has no power gate control.

Yes, the S500 SPS was luckily documented in the manual. The power-gating
for CPU2/3 is already implemented:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/mach-actions/platsmp.c

For S900 however SPS is sadly not documented... If you know who at
Actions Semi could help there, please also take a look at:
https://github.com/96boards/documentation/issues/59

Best regards,

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

WARNING: multiple messages have this Message-ID (diff)
From: liuwei@actions-semi.com (刘炜)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500
Date: Mon, 3 Jul 2017 16:13:34 +0800	[thread overview]
Message-ID: <DC4E6E803E914F4B8AFE57F1456019F10364478E@srv-mail-02.actions.com.cn> (raw)
In-Reply-To: <a7360245-5a65-7146-f295-0e90fb428173@suse.de>

Hi, Andreas

Actually the owl_v7_invalidate_l1 is not needed, and the headsmp-owl.S file can be removed if pen release staff is not used. The CPUx can jump to secondary_startup directly by setting OWL_CPUx_ADDR register.

Because S900 is aarch64 architecture, it cannot boot CPUx simply by setting SPS register. It depends on the low-level arm-trusted-firmware. Linux kernel can boot up CPUx by PSCI interface, and the arm-trusted-firmware will power on CPUx, initialize EL3 register and jump to EL2 entry in Linux kernel.

Best Regards,
David Liu

-----Original Message-----
From: Andreas F?rber [mailto:afaerber at suse.de] 
Sent: Sunday, July 02, 2017 3:57 AM
To: ??
Cc: Arnd Bergmann; Thomas Liau; Linux ARM; mp-cs; ???; ???; 96boards at ucrobotics.com; support at lemaker.org; Linux Kernel Mailing List; Russell King
Subject: Re: ??: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500

Hi David,

Am 01.07.2017 um 06:42 schrieb ??:
> OWL_CPUx_ADDR is the physical address of CPUx wakeup function.
> OWL_CPUx_FLAG is a valid flag of OWL_CPUx_ADDR. 
> 
> After CPUxs are wakeuped by SEV instruction, they will check their own OWL_CPUx_FLAG register. If the register vlaue is 0x55aa, CPUx will jump to OWL_CPUx_ADDR to boot up, otherwize go to sleep by WFE.
> 
> So the pen release staff is not necessary, you can remove these code safely.

Thank you for the quick confirmation!

I have just tested a patch, and it appears to work.

Is owl_v7_invalidate_l1 necessary? mach-sunxi (that Arnd pointed to as
example) uses secondary_startup directly, without custom assembler code.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/mach-actions/headsmp.S

> BTW: CPU2/3 must exit the power gate state before wakeup, and CPU1 is always power on and has no power gate control.

Yes, the S500 SPS was luckily documented in the manual. The power-gating
for CPU2/3 is already implemented:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/mach-actions/platsmp.c

For S900 however SPS is sadly not documented... If you know who at
Actions Semi could help there, please also take a look at:
https://github.com/96boards/documentation/issues/59

Best regards,

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

  reply	other threads:[~2017-07-03  8:13 UTC|newest]

Thread overview: 222+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06  0:53 [PATCH v4 00/28] ARM: Initial Actions Semi S500 and S900 enablement Andreas Färber
2017-06-06  0:53 ` Andreas Färber
2017-06-06  0:53 ` Andreas Färber
2017-06-06  0:53 ` [PATCH v4 01/28] dt-bindings: Add vendor prefix for Actions Semi Andreas Färber
2017-06-06  0:53   ` Andreas Färber
2017-06-06  0:53   ` Andreas Färber
2017-06-18 18:46   ` Andreas Färber
2017-06-18 18:46     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 02/28] dt-bindings: arm: Document Actions Semi S500 Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 18:48   ` Andreas Färber
2017-06-18 18:48     ` Andreas Färber
2017-06-18 18:48     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 03/28] dt-bindings: timer: Document Owl timer Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 20:18   ` Andreas Färber
2017-06-18 20:18     ` Andreas Färber
2017-06-18 20:18     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 04/28] clocksource: Add " Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06 16:33   ` Daniel Lezcano
2017-06-06 16:33     ` Daniel Lezcano
2017-06-18 20:43     ` Andreas Färber
2017-06-18 20:43       ` Andreas Färber
2017-06-19 13:53       ` Daniel Lezcano
2017-06-19 13:53         ` Daniel Lezcano
2017-06-19 14:31         ` Andreas Färber
2017-06-19 14:31           ` Andreas Färber
2017-06-21 11:57           ` Daniel Lezcano
2017-06-21 11:57             ` Daniel Lezcano
2017-06-06  0:54 ` [PATCH v4 05/28] clocksource: owl: Add S900 support Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06 16:34   ` Daniel Lezcano
2017-06-06 16:34     ` Daniel Lezcano
2017-06-18 20:50     ` Andreas Färber
2017-06-18 20:50       ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 06/28] ARM: Prepare Actions Semi S500 Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 21:21   ` Andreas Färber
2017-06-18 21:21     ` Andreas Färber
2017-07-01 21:41     ` [PATCH] ARM: owl: Drop custom machine Andreas Färber
2017-07-01 21:41       ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 07/28] ARM64: Prepare Actions Semi S900 Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-11 13:04   ` Andreas Färber
2017-06-11 13:04     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 08/28] dt-bindings: serial: Document Actions Semi Owl UARTs Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 09/28] tty: serial: Add Actions Semi Owl UART earlycon Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 21:45   ` Andreas Färber
2017-06-18 21:45     ` Andreas Färber
2017-06-19  1:16     ` Greg Kroah-Hartman
2017-06-19  1:16       ` Greg Kroah-Hartman
2017-06-19  1:24       ` Andreas Färber
2017-06-19  1:24         ` Andreas Färber
2017-06-19  1:46         ` [PATCH v5 07/26] dt-bindings: serial: Document Actions Semi Owl UARTs Andreas Färber
2017-06-19  1:46           ` Andreas Färber
2017-06-19  1:46           ` Andreas Färber
2017-06-19  1:46           ` [PATCH v5 08/26] tty: serial: Add Actions Semi Owl UART earlycon Andreas Färber
2017-06-19  1:46             ` Andreas Färber
2017-06-19  2:12         ` [PATCH v4 09/28] " Greg Kroah-Hartman
2017-06-19  2:12           ` Greg Kroah-Hartman
2017-06-19  2:26           ` Andreas Färber
2017-06-19  2:26             ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 10/28] Documentation: kernel-parameters: Document owl earlycon Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 11/28] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 22:10   ` Andreas Färber
2017-06-18 22:10     ` Andreas Färber
2017-06-18 22:10     ` Andreas Färber
2017-06-19  1:08     ` [PATCH v5 10/27] " Andreas Färber
2017-06-19  1:08       ` Andreas Färber
2017-06-19  1:08       ` Andreas Färber
2017-06-19  2:01       ` Andreas Färber
2017-06-19  2:01         ` Andreas Färber
2017-06-19  2:01         ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 12/28] dt-bindings: Add vendor prefix for uCRobotics Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 22:19   ` Andreas Färber
2017-06-18 22:19     ` Andreas Färber
2017-06-18 22:19     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 13/28] dt-bindings: arm: Document Actions Semi S900 Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 22:29   ` Andreas Färber
2017-06-18 22:29     ` Andreas Färber
2017-06-18 22:29     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 14/28] ARM64: dts: Add Actions Semi S900 and Bubblegum-96 Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 22:40   ` Andreas Färber
2017-06-18 22:40     ` Andreas Färber
2017-06-18 22:40     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 15/28] MAINTAINERS: Add Actions Semi Owl section Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-18 22:49   ` Andreas Färber
2017-06-18 22:49     ` Andreas Färber
2017-06-19  2:44     ` [PATCH v5 13/26] " Andreas Färber
2017-06-19  2:44       ` Andreas Färber
2017-06-26  6:56       ` 答复: " 张天益
2017-06-26  6:56         ` 张天益
2017-06-06  0:54 ` [PATCH v4 16/28] tty: serial: owl: Implement console driver Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-06 13:34   ` Alan Cox
2017-06-06 13:34     ` Alan Cox
2017-06-06 13:34     ` Alan Cox
2017-07-02 20:27     ` Andreas Färber
2017-07-02 20:27       ` Andreas Färber
2017-06-07 14:37   ` Andy Shevchenko
2017-06-07 14:37     ` Andy Shevchenko
2017-06-07 14:37     ` Andy Shevchenko
2017-07-02 22:36     ` Andreas Färber
2017-07-02 22:36       ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 17/28] ARM64: dts: actions: s900-bubblegum-96: Add fake uart5 clock Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-09-05 21:29   ` Andreas Färber
2017-09-05 21:29     ` Andreas Färber
2017-09-05 21:29     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 18/28] ARM: dts: s500-guitar-bb-rev-b: Add fake uart3 clock Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-09-05 21:37   ` Andreas Färber
2017-09-05 21:37     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 19/28] dt-bindings: arm: cpus: Add S500 enable-method Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  2:09   ` Andreas Färber
2017-06-19  2:09     ` Andreas Färber
2017-06-19  2:09     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  2:11   ` Andreas Färber
2017-06-19  2:11     ` Andreas Färber
2017-06-21  8:16   ` Arnd Bergmann
2017-06-21  8:16     ` Arnd Bergmann
2017-06-21 10:25     ` Arnd Bergmann
2017-06-21 10:25       ` Arnd Bergmann
2017-06-21 16:48       ` Andreas Färber
2017-06-21 16:48         ` Andreas Färber
2017-06-21 18:02         ` Arnd Bergmann
2017-06-21 18:02           ` Arnd Bergmann
2017-06-29 15:07     ` Arnd Bergmann
2017-06-29 15:07       ` Arnd Bergmann
2017-06-29 15:22       ` Andreas Färber
2017-06-29 15:22         ` Andreas Färber
2017-06-29 15:50         ` Arnd Bergmann
2017-06-29 15:50           ` Arnd Bergmann
2017-07-01 21:29           ` [PATCH] ARM: owl: smp: Drop bogus holding pen Andreas Färber
2017-07-01 21:29             ` Andreas Färber
2017-07-03 12:35             ` Arnd Bergmann
2017-07-03 12:35               ` Arnd Bergmann
2017-07-01  4:42         ` 答复: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 刘炜
2017-07-01  4:42           ` 刘炜
2017-07-01 19:56           ` Andreas Färber
2017-07-01 19:56             ` Andreas Färber
2017-07-03  8:13             ` 刘炜 [this message]
2017-07-03  8:13               ` 刘炜
2017-07-04 23:32               ` [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Andreas Färber
2017-07-04 23:32                 ` Andreas Färber
2017-07-05  2:36                 ` Florian Fainelli
2017-07-05  2:36                   ` Florian Fainelli
2017-07-06 17:17                   ` Andreas Färber
2017-07-06 17:17                     ` Andreas Färber
2017-07-06 17:38                     ` Alexandre Belloni
2017-07-06 17:38                       ` Alexandre Belloni
2017-07-06 19:47                       ` Florian Fainelli
2017-07-06 19:47                         ` Florian Fainelli
2017-07-07  7:34                         ` Gregory CLEMENT
2017-07-07  7:34                           ` Gregory CLEMENT
2017-07-07 17:32                           ` Florian Fainelli
2017-07-07 17:32                             ` Florian Fainelli
2017-07-06 17:39                     ` Mark Rutland
2017-07-06 17:39                       ` Mark Rutland
2017-07-06 21:16                       ` Florian Fainelli
2017-07-06 21:16                         ` Florian Fainelli
2017-07-09 21:55                     ` Andreas Färber
2017-07-09 21:55                       ` Andreas Färber
2017-07-10  4:27                       ` Florian Fainelli
2017-07-10  4:27                         ` Florian Fainelli
2017-06-06  0:54 ` [PATCH v4 21/28] ARM: dts: s500: Set CPU enable-method Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  2:09   ` Andreas Färber
2017-06-19  2:09     ` Andreas Färber
2017-06-19  2:09     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 22/28] dt-bindings: power: Add Owl SPS power domains Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  3:36   ` [PATCH v5 20/26] " Andreas Färber
2017-06-19  3:36     ` Andreas Färber
2017-06-19  3:36     ` Andreas Färber
2017-06-19  3:57     ` Andreas Färber
2017-06-19  3:57       ` Andreas Färber
2017-06-19  3:57       ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 23/28] soc: actions: Add Owl SPS Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  3:40   ` [PATCH v5 21/26] " Andreas Färber
2017-06-19  3:40     ` Andreas Färber
2017-06-19  3:59     ` Andreas Färber
2017-06-19  3:59       ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 24/28] MAINTAINERS: Update Actions Semi section with SPS Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  3:44   ` [PATCH v5 22/26] " Andreas Färber
2017-06-19  3:44     ` Andreas Färber
2017-06-19  4:00     ` Andreas Färber
2017-06-19  4:00       ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 25/28] ARM: dts: s500: Add SPS node Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  4:01   ` Andreas Färber
2017-06-19  4:01     ` Andreas Färber
2017-06-19  4:01     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 26/28] ARM: dts: s500: Set power domains for CPU2 and CPU3 Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-07-27 20:58   ` Andreas Färber
2017-07-27 20:58     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 27/28] soc: actions: owl-sps: Factor out owl_sps_set_pg() for power-gating Andreas Färber
2017-06-06  0:54   ` Andreas Färber
2017-06-19  4:12   ` Andreas Färber
2017-06-19  4:12     ` Andreas Färber
2017-06-06  0:54 ` [PATCH v4 28/28] ARM: owl: smp: Implement SPS power-gating for CPU2 and CPU3 Andreas Färber
2017-06-06  0:54   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DC4E6E803E914F4B8AFE57F1456019F10364478E@srv-mail-02.actions.com.cn \
    --to=liuwei@actions-semi.com \
    --cc=96boards@ucrobotics.com \
    --cc=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mp-cs@actions-semi.com \
    --cc=support@lemaker.org \
    --cc=thomas.liau@actions-semi.com \
    --cc=tyzhang@actions-semi.com \
    --cc=zhangdf@actions-semi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.