From: "Rafael J. Wysocki" <rjw@sisk.pl> To: nigel@nigel.suspend2.net Cc: Arjan van de Ven <arjan@infradead.org>, LKML <linux-kernel@vger.kernel.org>, pm list <linux-pm@lists.osdl.org> Subject: Re: NAK new drivers without proper power management? Date: Sat, 10 Feb 2007 01:12:23 +0100 [thread overview] Message-ID: <200702100112.24341.rjw@sisk.pl> (raw) In-Reply-To: <1171063690.1484.113.camel@nigel.suspend2.net> On Saturday, 10 February 2007 00:28, Nigel Cunningham wrote: > Hi. > > On Sat, 2007-02-10 at 00:12 +0100, Rafael J. Wysocki wrote: > > > > I think if CONFIG_PM_DEBUG is set, the core should warn about drivers not > > > > having .suspend or .resume routines. > > > > > > The only problem with that is, not everyone turns on CONFIG_PM_DEBUG. > > > CONFIG_PM instead? > > > > Well, I can imagine a driver that doesn't need a .suspend routine, for example, > > and I don't think we should make the kernel always complain about that. > > How about... > > #ifdef CONFIG_PM_PARANOIA > static int empty_suspend_routine(struct device *dev, pm_message_t state) > { > return 0; > } > #define empty_suspend empty_suspend_routine > #else > #define empty_suspend NULL > #endif > > ... > > .suspend = empty_suspend; > ... > > > Then CONFIG_PM_PARANOIA can be enabled by default for now, and when we > eventually device it's not needed anymore, someone can submit a patch > replacing either turning off the CONFIG by default or removing the whole > mechanism. I think that would be tempting people to abuse it, for example by defining or undefining things just to quieten the warning. In my opinion the only way to make the warning go away should be to define a non-NULL .suspend (.resume) routine and that's why I don't think the warning should be mandatory. > > I think if someone doesn't set CONFIG_PM_DEBUG, we can ask him to set it > > and report back. > > We can, but the whole point to the suggestion was to make your life and > mine easier, as well as those of our users. > > Making it dependent on CONFIG_PM instead achieves that by: > - Saving you, I and distro people from having to tell their users to > enable the option (and how to) I think the distro people can patch their kernels to fit their needs. > - Saving the users the problem of going through all the steps, making > mistakes, potentially ending up with unbootable systems because they > make mistakes and so on. > > This way, they just need to look in dmesg. Well, IMO, if someone doesn't know how to compile and install the kernel, he'll be using a distro kernel anyway and then see above. Otherwise we can safely ask him to turn on whatever debugging options we need. Greetings, Rafael -- If you don't have the time to read, you don't have the time or the tools to write. - Stephen King
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl> To: nigel@nigel.suspend2.net Cc: pm list <linux-pm@lists.osdl.org>, LKML <linux-kernel@vger.kernel.org>, Arjan van de Ven <arjan@infradead.org> Subject: Re: NAK new drivers without proper power management? Date: Sat, 10 Feb 2007 01:12:23 +0100 [thread overview] Message-ID: <200702100112.24341.rjw@sisk.pl> (raw) In-Reply-To: <1171063690.1484.113.camel@nigel.suspend2.net> On Saturday, 10 February 2007 00:28, Nigel Cunningham wrote: > Hi. > > On Sat, 2007-02-10 at 00:12 +0100, Rafael J. Wysocki wrote: > > > > I think if CONFIG_PM_DEBUG is set, the core should warn about drivers not > > > > having .suspend or .resume routines. > > > > > > The only problem with that is, not everyone turns on CONFIG_PM_DEBUG. > > > CONFIG_PM instead? > > > > Well, I can imagine a driver that doesn't need a .suspend routine, for example, > > and I don't think we should make the kernel always complain about that. > > How about... > > #ifdef CONFIG_PM_PARANOIA > static int empty_suspend_routine(struct device *dev, pm_message_t state) > { > return 0; > } > #define empty_suspend empty_suspend_routine > #else > #define empty_suspend NULL > #endif > > ... > > .suspend = empty_suspend; > ... > > > Then CONFIG_PM_PARANOIA can be enabled by default for now, and when we > eventually device it's not needed anymore, someone can submit a patch > replacing either turning off the CONFIG by default or removing the whole > mechanism. I think that would be tempting people to abuse it, for example by defining or undefining things just to quieten the warning. In my opinion the only way to make the warning go away should be to define a non-NULL .suspend (.resume) routine and that's why I don't think the warning should be mandatory. > > I think if someone doesn't set CONFIG_PM_DEBUG, we can ask him to set it > > and report back. > > We can, but the whole point to the suggestion was to make your life and > mine easier, as well as those of our users. > > Making it dependent on CONFIG_PM instead achieves that by: > - Saving you, I and distro people from having to tell their users to > enable the option (and how to) I think the distro people can patch their kernels to fit their needs. > - Saving the users the problem of going through all the steps, making > mistakes, potentially ending up with unbootable systems because they > make mistakes and so on. > > This way, they just need to look in dmesg. Well, IMO, if someone doesn't know how to compile and install the kernel, he'll be using a distro kernel anyway and then see above. Otherwise we can safely ask him to turn on whatever debugging options we need. Greetings, Rafael -- If you don't have the time to read, you don't have the time or the tools to write. - Stephen King
next prev parent reply other threads:[~2007-02-10 0:14 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-09 21:57 NAK new drivers without proper power management? Nigel Cunningham 2007-02-09 22:17 ` Arjan van de Ven 2007-02-09 22:26 ` Nigel Cunningham 2007-02-09 22:44 ` Rafael J. Wysocki 2007-02-09 22:44 ` Rafael J. Wysocki 2007-02-09 22:51 ` Nigel Cunningham 2007-02-09 22:51 ` Nigel Cunningham 2007-02-09 23:12 ` Rafael J. Wysocki 2007-02-09 23:12 ` Rafael J. Wysocki 2007-02-09 23:28 ` Nigel Cunningham 2007-02-09 23:28 ` Nigel Cunningham 2007-02-10 0:12 ` Rafael J. Wysocki [this message] 2007-02-10 0:12 ` Rafael J. Wysocki 2007-02-10 0:25 ` Jeff Garzik 2007-02-10 6:43 ` Willy Tarreau 2007-02-10 23:52 ` Tilman Schmidt 2007-02-10 7:15 ` Arjan van de Ven 2007-02-10 19:38 ` Pavel Machek 2007-02-10 22:20 ` Rafael J. Wysocki 2007-02-10 22:37 ` Nigel Cunningham 2007-02-10 23:45 ` Tilman Schmidt 2007-02-11 0:27 ` Rafael J. Wysocki 2007-02-11 22:41 ` Nigel Cunningham 2007-02-13 15:55 ` Mark Lord 2007-02-13 16:06 ` Christoph Hellwig 2007-02-11 22:37 ` Nigel Cunningham 2007-02-12 0:10 ` Tilman Schmidt 2007-02-12 0:20 ` Rafael J. Wysocki 2007-02-12 4:08 ` Nigel Cunningham 2007-02-12 20:06 ` Rafael J. Wysocki 2007-02-12 22:38 ` Nigel Cunningham 2007-03-03 22:48 ` Suspend/resume semantics for ISDN drivers (was: NAK new drivers without proper power management?) Tilman Schmidt 2007-03-04 19:04 ` Rafael J. Wysocki 2007-03-08 23:35 ` Pavel Machek 2007-02-11 6:46 ` NAK new drivers without proper power management? Willy Tarreau 2007-02-11 13:04 ` Rafael J. Wysocki 2007-02-11 22:47 ` Nigel Cunningham 2007-02-11 22:57 ` Manu Abraham 2007-02-11 23:20 ` Nigel Cunningham 2007-02-11 23:25 ` Manu Abraham 2007-02-11 23:29 ` Pavel Machek 2007-02-11 23:33 ` Nigel Cunningham 2007-02-12 16:52 ` Pavel Machek 2007-02-12 20:31 ` Rafael J. Wysocki 2007-02-12 20:58 ` Pavel Machek 2007-02-12 21:01 ` Rafael J. Wysocki 2007-02-12 21:24 ` Nigel Cunningham 2007-02-12 21:43 ` Rafael J. Wysocki 2007-02-13 9:42 ` Tilman Schmidt 2007-02-13 19:24 ` Rafael J. Wysocki 2007-02-14 23:45 ` Stefan Richter 2007-02-12 9:45 ` Arjan van de Ven 2007-02-12 12:59 ` Gerhard Mack 2007-02-12 20:20 ` Willy Tarreau 2007-02-13 15:23 ` Brad Campbell 2007-02-12 20:46 ` Rafael J. Wysocki 2007-02-12 13:51 ` Tino Keitel 2007-02-11 19:42 ` Pavel Machek 2007-02-11 21:02 ` Alan 2007-02-11 23:04 ` Rafael J. Wysocki 2007-02-12 0:28 ` Alan 2007-02-12 0:24 ` Rafael J. Wysocki 2007-02-11 23:10 ` Nigel Cunningham 2007-02-11 23:16 ` Rafael J. Wysocki 2007-02-11 23:22 ` Nigel Cunningham 2007-02-11 23:23 ` Pavel Machek 2007-02-11 23:21 ` Pavel Machek 2007-02-11 23:29 ` Nigel Cunningham 2007-02-11 22:21 ` Tilman Schmidt 2007-02-12 8:49 ` Geert Uytterhoeven 2007-02-12 15:04 ` Pavel Machek 2007-02-12 15:57 ` Geert Uytterhoeven 2007-02-12 16:55 ` Pavel Machek 2007-02-12 20:38 ` Nigel Cunningham 2007-02-13 10:02 ` Tilman Schmidt 2007-02-10 3:42 ` Matthew Garrett 2007-02-10 4:42 ` Nigel Cunningham [not found] <fa.xSKPgY66Q+DPCZ1pszFFfdrJ0To@ifi.uio.no> [not found] ` <fa.FzHdYYYH5Ru57c8/yRxLylpH0Kk@ifi.uio.no> [not found] ` <fa.DuG12yQo+RR4jIjJTnoOwtKM0Ao@ifi.uio.no> [not found] ` <fa.Jy0FJQtASvVEpsy8Q96uoHtyEVA@ifi.uio.no> 2007-02-10 1:50 ` Robert Hancock 2007-02-10 1:59 ` Lee Revell 2007-02-10 2:09 ` Nigel Cunningham 2007-02-10 2:22 ` Lee Revell 2007-02-10 3:21 ` Kevin Fox 2007-02-10 20:40 ` Adrian Bunk 2007-02-10 4:35 ` Joseph Fannin 2007-02-13 21:08 ` Pavel Machek 2007-02-10 12:47 ` Stefan Richter 2007-02-10 2:05 ` Nigel Cunningham 2007-02-10 3:27 ` Dmitry Torokhov 2007-02-10 4:18 ` Nigel Cunningham [not found] ` <fa.DhkemAgVI60diqZy0t9GzpwyLmk@ifi.uio.no> [not found] ` <fa.E/NjHlgg0HqDg5CgZjnCHFi2AMM@ifi.uio.no> [not found] ` <fa.kop49l/7yexJoUGrzk6vVeIP934@ifi.uio.no> 2007-02-10 23:20 ` Robert Hancock 2007-02-11 0:44 ` Rafael J. Wysocki 2007-02-11 17:01 ` Pavel Machek 2007-02-11 22:40 ` Nigel Cunningham 2007-02-11 23:29 ` Rafael J. Wysocki 2007-02-11 23:40 ` Nigel Cunningham [not found] ` <fa.EgQN5JpU6xrZSLyOY0kWjJ26hUM@ifi.uio.no> 2007-02-11 18:31 ` Robert Hancock 2007-02-11 21:52 ` Willy Tarreau 2007-02-11 22:26 ` Nigel Cunningham 2007-02-11 22:46 ` Willy Tarreau 2007-02-11 23:18 ` Nigel Cunningham 2007-02-11 23:38 ` Willy Tarreau 2007-02-11 23:45 ` Nigel Cunningham 2007-02-12 0:26 ` Alan 2007-02-12 5:19 ` Willy Tarreau 2007-02-12 20:20 ` Rafael J. Wysocki 2007-02-12 22:36 ` Nigel Cunningham 2007-02-11 23:23 ` Alan 2007-02-11 23:38 ` Rafael J. Wysocki 2007-02-11 23:41 ` Rafael J. Wysocki 2007-02-11 23:47 ` Nigel Cunningham 2007-02-11 23:50 ` Rafael J. Wysocki 2007-02-11 23:55 ` Nigel Cunningham 2007-02-12 0:09 ` Rafael J. Wysocki 2007-02-12 0:15 ` Nigel Cunningham 2007-02-12 12:19 ` Pavel Machek [not found] ` <fa.O1YH4k5KtBGCNs5i2yB17bPvPGw@ifi.uio.no> [not found] ` <fa.RfzClbTP/7B79AoEbQLNj3ABfIk@ifi.uio.no> [not found] ` <fa.AaJ/ugmiUmPO8uC+y1rS9JLuuMc@ifi.uio.no> 2007-02-12 0:59 ` Robert Hancock
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=200702100112.24341.rjw@sisk.pl \ --to=rjw@sisk.pl \ --cc=arjan@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@lists.osdl.org \ --cc=nigel@nigel.suspend2.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.