All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: nigel@nigel.suspend2.net
Cc: Daniel Barkalow <barkalow@iabervon.org>, Willy Tarreau <w@1wt.eu>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Robert Hancock <hancockr@shaw.ca>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jeff Garzik <jeff@garzik.org>, Pavel Machek <pavel@ucw.cz>,
	pm list <linux-pm@lists.osdl.org>
Subject: Re: [PATCH] Re: NAK new drivers without proper power management?
Date: Mon, 12 Feb 2007 00:10:11 +0100	[thread overview]
Message-ID: <200702120010.13996.rjw@sisk.pl> (raw)
In-Reply-To: <1171235166.4493.100.camel@nigel.suspend2.net>

On Monday, 12 February 2007 00:06, Nigel Cunningham wrote:
> Hi.
> 
> On Sun, 2007-02-11 at 19:53 +0100, Rafael J. Wysocki wrote:
> > > Having drivers explicitly marked as to whether they are safe is a good kernel
> > > feature; what to do if they're not is policy.
> > 
> > That's true, but I assume that the people who opt for doing that are also
> > willing to take part in the review of the drivers. :-)
> 
> Absolutely :)
> 
> > Well, I don't think so.  Let's estimate the number of drivers that define
> > .resume() right now:
> > 
> > $ grep -I -l -r '.resume =' linux-2.6.20/drivers/ | wc
> >     102     102    4169
> 
> I think the '.resume =' doesn't help - some have tabs. I ran '\.resume'
> and got 351.

Ah, good catch.  I have searched for ".resume" only and got 612, but this
is the number of files, not the number of drivers.  And it is not exactly
large. ;-)

> It would be interesting to see how many struct pci_driver etc instances
> lack resume methods.

Yes, I'll try to invent a test.

Greetings,
Rafael

WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: nigel@nigel.suspend2.net
Cc: Robert Hancock <hancockr@shaw.ca>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Pavel Machek <pavel@ucw.cz>, Jeff Garzik <jeff@garzik.org>,
	Daniel Barkalow <barkalow@iabervon.org>,
	pm list <linux-pm@lists.osdl.org>, Willy Tarreau <w@1wt.eu>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Re: NAK new drivers without proper power management?
Date: Mon, 12 Feb 2007 00:10:11 +0100	[thread overview]
Message-ID: <200702120010.13996.rjw@sisk.pl> (raw)
In-Reply-To: <1171235166.4493.100.camel@nigel.suspend2.net>

On Monday, 12 February 2007 00:06, Nigel Cunningham wrote:
> Hi.
> 
> On Sun, 2007-02-11 at 19:53 +0100, Rafael J. Wysocki wrote:
> > > Having drivers explicitly marked as to whether they are safe is a good kernel
> > > feature; what to do if they're not is policy.
> > 
> > That's true, but I assume that the people who opt for doing that are also
> > willing to take part in the review of the drivers. :-)
> 
> Absolutely :)
> 
> > Well, I don't think so.  Let's estimate the number of drivers that define
> > .resume() right now:
> > 
> > $ grep -I -l -r '.resume =' linux-2.6.20/drivers/ | wc
> >     102     102    4169
> 
> I think the '.resume =' doesn't help - some have tabs. I ran '\.resume'
> and got 351.

Ah, good catch.  I have searched for ".resume" only and got 612, but this
is the number of files, not the number of drivers.  And it is not exactly
large. ;-)

> It would be interesting to see how many struct pci_driver etc instances
> lack resume methods.

Yes, I'll try to invent a test.

Greetings,
Rafael

  reply	other threads:[~2007-02-11 23:12 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.xSKPgY66Q+DPCZ1pszFFfdrJ0To@ifi.uio.no>
     [not found] ` <fa.FzHdYYYH5Ru57c8/yRxLylpH0Kk@ifi.uio.no>
     [not found]   ` <fa.DuG12yQo+RR4jIjJTnoOwtKM0Ao@ifi.uio.no>
     [not found]     ` <fa.Jy0FJQtASvVEpsy8Q96uoHtyEVA@ifi.uio.no>
2007-02-10  1:50       ` NAK new drivers without proper power management? Robert Hancock
2007-02-10  1:59         ` Lee Revell
2007-02-10  2:09           ` Nigel Cunningham
2007-02-10  2:22             ` Lee Revell
2007-02-10  3:21               ` Kevin Fox
2007-02-10 20:40               ` Adrian Bunk
2007-02-10  4:35           ` Joseph Fannin
2007-02-13 21:08             ` Pavel Machek
2007-02-10 12:47           ` Stefan Richter
2007-02-10  2:05         ` Nigel Cunningham
2007-02-10  3:27           ` Dmitry Torokhov
2007-02-10  4:18             ` Nigel Cunningham
2007-02-10  3:02         ` [PATCH] " Nigel Cunningham
2007-02-10  9:34           ` Rafael J. Wysocki
2007-02-10  9:34             ` Rafael J. Wysocki
2007-02-10 10:02             ` Nigel Cunningham
2007-02-10 10:30               ` Rafael J. Wysocki
2007-02-10 10:30                 ` Rafael J. Wysocki
2007-02-10 17:52                 ` Daniel Barkalow
2007-02-10 17:52                   ` Daniel Barkalow
2007-02-10 19:50                   ` Rafael J. Wysocki
2007-02-10 19:50                     ` Rafael J. Wysocki
2007-02-11  6:54                     ` Willy Tarreau
2007-02-11  6:54                       ` Willy Tarreau
2007-02-11 12:13                       ` Matthew Garrett
2007-02-11 13:09                         ` Willy Tarreau
2007-02-11 13:09                           ` Willy Tarreau
2007-02-11 13:19                           ` Matthew Garrett
2007-02-11 13:37                             ` Willy Tarreau
2007-02-11 13:37                               ` Willy Tarreau
2007-02-11 13:50                               ` Rafael J. Wysocki
2007-02-11 13:50                                 ` Rafael J. Wysocki
2007-02-11 13:57                                 ` Willy Tarreau
2007-02-11 13:57                                   ` Willy Tarreau
2007-02-11 14:36                                   ` Rafael J. Wysocki
2007-02-11 14:36                                     ` Rafael J. Wysocki
2007-02-11 15:19                                     ` Pekka Enberg
2007-02-11 15:19                                       ` Pekka Enberg
2007-02-11 18:31                                       ` Rafael J. Wysocki
2007-02-11 18:31                                         ` Rafael J. Wysocki
2007-02-11 17:27                                     ` Daniel Barkalow
2007-02-11 18:53                                       ` Rafael J. Wysocki
2007-02-11 18:53                                         ` Rafael J. Wysocki
2007-02-11 23:06                                         ` Nigel Cunningham
2007-02-11 23:06                                           ` Nigel Cunningham
2007-02-11 23:10                                           ` Rafael J. Wysocki [this message]
2007-02-11 23:10                                             ` Rafael J. Wysocki
2007-02-11 21:04                                     ` Stefan Richter
2007-02-11 21:04                                       ` Stefan Richter
2007-02-11 21:10                           ` Pavel Machek
2007-02-11 17:36                         ` Robert Hancock
2007-02-11 22:49                         ` Nigel Cunningham
2007-02-11 19:37                   ` Pavel Machek
2007-02-11 19:37                     ` Pavel Machek
     [not found]   ` <fa.DhkemAgVI60diqZy0t9GzpwyLmk@ifi.uio.no>
     [not found]     ` <fa.E/NjHlgg0HqDg5CgZjnCHFi2AMM@ifi.uio.no>
     [not found]       ` <fa.kop49l/7yexJoUGrzk6vVeIP934@ifi.uio.no>
2007-02-10 23:20         ` Robert Hancock
2007-02-11  0:44           ` Rafael J. Wysocki
2007-02-11 17:01             ` Pavel Machek
2007-02-11 22:40             ` Nigel Cunningham
2007-02-11 23:29               ` Rafael J. Wysocki
2007-02-11 23:40                 ` Nigel Cunningham
     [not found]         ` <fa.EgQN5JpU6xrZSLyOY0kWjJ26hUM@ifi.uio.no>
2007-02-11 18:31           ` Robert Hancock
2007-02-11 21:52             ` Willy Tarreau
2007-02-11 22:26               ` Nigel Cunningham
2007-02-11 22:46                 ` Willy Tarreau
2007-02-11 23:18                   ` Nigel Cunningham
2007-02-11 23:38                     ` Willy Tarreau
2007-02-11 23:45                       ` Nigel Cunningham
2007-02-12  0:26                       ` Alan
2007-02-12  5:19                         ` Willy Tarreau
2007-02-12 20:20                           ` Rafael J. Wysocki
2007-02-12 22:36                           ` Nigel Cunningham
2007-02-11 23:23                   ` Alan
2007-02-11 23:38                   ` Rafael J. Wysocki
2007-02-11 23:41                 ` Rafael J. Wysocki
2007-02-11 23:47                   ` Nigel Cunningham
2007-02-11 23:50                     ` Rafael J. Wysocki
2007-02-11 23:55                       ` Nigel Cunningham
2007-02-12  0:09                         ` Rafael J. Wysocki
2007-02-12  0:15                           ` Nigel Cunningham
2007-02-12 12:19               ` Pavel Machek
     [not found]         ` <fa.O1YH4k5KtBGCNs5i2yB17bPvPGw@ifi.uio.no>
     [not found]           ` <fa.RfzClbTP/7B79AoEbQLNj3ABfIk@ifi.uio.no>
     [not found]             ` <fa.AaJ/ugmiUmPO8uC+y1rS9JLuuMc@ifi.uio.no>
2007-02-12  0:59               ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702120010.13996.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=barkalow@iabervon.org \
    --cc=hancockr@shaw.ca \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=nigel@nigel.suspend2.net \
    --cc=pavel@ucw.cz \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.