All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
	bcm43xx-dev@lists.berlios.de,
	wireless <linux-wireless@vger.kernel.org>,
	John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] bcm43xx: Fix loss of association after resume
Date: Mon, 12 Feb 2007 01:50:58 +0100	[thread overview]
Message-ID: <200702120150.59747.rjw@sisk.pl> (raw)
In-Reply-To: <45CF3D51.5050302@lwfinger.net>

On Sunday, 11 February 2007 16:59, Larry Finger wrote:
> Michael Buesch wrote:
> > On Sunday 11 February 2007 15:02, Rafael J. Wysocki wrote:
> >> PM: Removing info for No Bus:0000:30:00.0
> >> bcm43xx: IRQ_READY timeout
> >> bcm43xx: core_up for active 802.11 core failed (-19)
> > 
> > I never tried suspend to disk with the driver.
> 
> This implies that suspend to RAM works. Is that true?
> 
> > Larry, an idea why the microcode doesn't respond?
> 
> Is this code snippet supposed to keep the firmware loaded when the system is suspended?
> 
>                 bcm->firmware_norelease = 1;
>                 bcm43xx_free_board(bcm);
>                 bcm->firmware_norelease = 0;
> 
> If so, that may be the problem. What would force it to be reloaded when resuming after a suspend to
> disk and subsequent power off? That would certainly explain why a reload is successful. Is there a
> volatile location that would safely indicate that the firmware is not good? Perhaps, we need to bite
> the bullet and reload the firmware after every resume. The patch below should do that.
> 
> I am also working on a case where the user has troubles with a suspend to disk from Windows followed
> by a reboot to Linux, and warm reboots from Windows to Linux. In these cases, he gets a firmware
> file-format error; however, his firmware is fine from a cold boot.
> 
> Larry
> 
> Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> +++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> @@ -4296,6 +4297,7 @@ static int bcm43xx_resume(struct pci_dev
>  		printk(KERN_ERR PFX "Resume failed!\n");
>  		return err;
>  	}
> +	bcm43xx_request_firmware(bcm);
>  	netif_device_attach(net_dev);
> 
>  	dprintk(KERN_INFO PFX "Device resumed.\n");

It doesn't help in my case.  The behavior is similar to that without the patch,
but also with the patch it loses the association entirely.

Greetings,
Rafael

  parent reply	other threads:[~2007-02-12  0:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 16:18 Larry Finger
2007-02-09 16:18 ` Larry Finger
2007-02-09 16:53 ` Michael Buesch
2007-02-09 16:53   ` Michael Buesch
2007-02-10 17:11   ` Rafael J. Wysocki
2007-02-10 17:11     ` Rafael J. Wysocki
2007-02-10 20:33     ` Larry Finger
2007-02-11 12:56       ` Rafael J. Wysocki
2007-02-11 13:07         ` Michael Buesch
2007-02-11 14:02           ` Rafael J. Wysocki
2007-02-11 14:14             ` Michael Buesch
2007-02-11 14:41               ` Johannes Berg
2007-02-11 14:45                 ` Rafael J. Wysocki
2007-02-11 14:48                   ` Johannes Berg
2007-02-11 15:59               ` Larry Finger
2007-02-11 16:03                 ` Michael Buesch
2007-02-11 16:16                   ` Michael Buesch
2007-02-11 16:17                   ` Larry Finger
2007-02-12  0:50                 ` Rafael J. Wysocki [this message]
2007-02-12  1:18                   ` Larry Finger
2007-02-12 20:48                     ` Rafael J. Wysocki
2007-02-12 22:20                       ` Larry Finger
2007-02-12 23:08                         ` Rafael J. Wysocki
2007-02-12 23:18                           ` Larry Finger
2007-02-12 23:24                           ` Michael Buesch
2007-02-13 16:25                             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702120150.59747.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --subject='Re: [PATCH] bcm43xx: Fix loss of association after resume' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.