All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
	netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx: Fix loss of association after resume
Date: Fri, 9 Feb 2007 17:53:12 +0100	[thread overview]
Message-ID: <200702091753.12419.mb@bu3sch.de> (raw)
In-Reply-To: <45cc9ebb.+9O/IXvs/C9RyFnk%Larry.Finger@lwfinger.net>

On Friday 09 February 2007 17:18, Larry Finger wrote:
> After a suspend/resume cycle, bcm43xx-softmac has lost its association with
> the AP and requires manual intervention. This situation is fixed by making
> one of softmac's internal routines public and calling it.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Ack, this is good as workaround.

> 
> Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> +++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> @@ -4278,6 +4278,7 @@ static int bcm43xx_resume(struct pci_dev
>  {
>  	struct net_device *net_dev = pci_get_drvdata(pdev);
>  	struct bcm43xx_private *bcm = bcm43xx_priv(net_dev);
> +	struct ieee80211softmac_device *mac = ieee80211_priv(net_dev);
>  	int err = 0;
>  
>  	dprintk(KERN_INFO PFX "Resuming...\n");
> @@ -4299,6 +4300,9 @@ static int bcm43xx_resume(struct pci_dev
>  	}
>  	netif_device_attach(net_dev);
>  
> +	if (mac->associnfo.associated)
> +		ieee80211softmac_try_reassoc(mac);
> +
>  	dprintk(KERN_INFO PFX "Device resumed.\n");
>  
>  	return 0;
> Index: linux-2.6/include/net/ieee80211softmac.h
> ===================================================================
> --- linux-2.6.orig/include/net/ieee80211softmac.h
> +++ linux-2.6/include/net/ieee80211softmac.h
> @@ -254,6 +254,7 @@ struct ieee80211softmac_device {
>  };
>  
>  extern void ieee80211softmac_scan_finished(struct ieee80211softmac_device *sm);
> +extern void ieee80211softmac_try_reassoc(struct ieee80211softmac_device *mac);
>  
>  static inline void * ieee80211softmac_priv(struct net_device *dev)
>  {
> Index: linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> ===================================================================
> --- linux-2.6.orig/net/ieee80211/softmac/ieee80211softmac_assoc.c
> +++ linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> @@ -441,6 +441,7 @@ ieee80211softmac_try_reassoc(struct ieee
>  	schedule_delayed_work(&mac->associnfo.work, 0);
>  	spin_unlock_irqrestore(&mac->lock, flags);
>  }
> +EXPORT_SYMBOL_GPL(ieee80211softmac_try_reassoc);
>  
>  int
>  ieee80211softmac_handle_disassoc(struct net_device * dev,
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

-- 
Greetings Michael.

WARNING: multiple messages have this Message-ID
From: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
To: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	John Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Subject: Re: [PATCH] bcm43xx: Fix loss of association after resume
Date: Fri, 9 Feb 2007 17:53:12 +0100	[thread overview]
Message-ID: <200702091753.12419.mb@bu3sch.de> (raw)
In-Reply-To: <45cc9ebb.+9O/IXvs/C9RyFnk%Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>

On Friday 09 February 2007 17:18, Larry Finger wrote:
> After a suspend/resume cycle, bcm43xx-softmac has lost its association with
> the AP and requires manual intervention. This situation is fixed by making
> one of softmac's internal routines public and calling it.
> 
> Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>

Ack, this is good as workaround.

> 
> Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> +++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> @@ -4278,6 +4278,7 @@ static int bcm43xx_resume(struct pci_dev
>  {
>  	struct net_device *net_dev = pci_get_drvdata(pdev);
>  	struct bcm43xx_private *bcm = bcm43xx_priv(net_dev);
> +	struct ieee80211softmac_device *mac = ieee80211_priv(net_dev);
>  	int err = 0;
>  
>  	dprintk(KERN_INFO PFX "Resuming...\n");
> @@ -4299,6 +4300,9 @@ static int bcm43xx_resume(struct pci_dev
>  	}
>  	netif_device_attach(net_dev);
>  
> +	if (mac->associnfo.associated)
> +		ieee80211softmac_try_reassoc(mac);
> +
>  	dprintk(KERN_INFO PFX "Device resumed.\n");
>  
>  	return 0;
> Index: linux-2.6/include/net/ieee80211softmac.h
> ===================================================================
> --- linux-2.6.orig/include/net/ieee80211softmac.h
> +++ linux-2.6/include/net/ieee80211softmac.h
> @@ -254,6 +254,7 @@ struct ieee80211softmac_device {
>  };
>  
>  extern void ieee80211softmac_scan_finished(struct ieee80211softmac_device *sm);
> +extern void ieee80211softmac_try_reassoc(struct ieee80211softmac_device *mac);
>  
>  static inline void * ieee80211softmac_priv(struct net_device *dev)
>  {
> Index: linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> ===================================================================
> --- linux-2.6.orig/net/ieee80211/softmac/ieee80211softmac_assoc.c
> +++ linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> @@ -441,6 +441,7 @@ ieee80211softmac_try_reassoc(struct ieee
>  	schedule_delayed_work(&mac->associnfo.work, 0);
>  	spin_unlock_irqrestore(&mac->lock, flags);
>  }
> +EXPORT_SYMBOL_GPL(ieee80211softmac_try_reassoc);
>  
>  int
>  ieee80211softmac_handle_disassoc(struct net_device * dev,
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

-- 
Greetings Michael.

  reply	other threads:[~2007-02-09 16:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 16:18 Larry Finger
2007-02-09 16:18 ` Larry Finger
2007-02-09 16:53 ` Michael Buesch [this message]
2007-02-09 16:53   ` Michael Buesch
2007-02-10 17:11   ` Rafael J. Wysocki
2007-02-10 17:11     ` Rafael J. Wysocki
2007-02-10 20:33     ` Larry Finger
2007-02-11 12:56       ` Rafael J. Wysocki
2007-02-11 13:07         ` Michael Buesch
2007-02-11 14:02           ` Rafael J. Wysocki
2007-02-11 14:14             ` Michael Buesch
2007-02-11 14:41               ` Johannes Berg
2007-02-11 14:45                 ` Rafael J. Wysocki
2007-02-11 14:48                   ` Johannes Berg
2007-02-11 15:59               ` Larry Finger
2007-02-11 16:03                 ` Michael Buesch
2007-02-11 16:16                   ` Michael Buesch
2007-02-11 16:17                   ` Larry Finger
2007-02-12  0:50                 ` Rafael J. Wysocki
2007-02-12  1:18                   ` Larry Finger
2007-02-12 20:48                     ` Rafael J. Wysocki
2007-02-12 22:20                       ` Larry Finger
2007-02-12 23:08                         ` Rafael J. Wysocki
2007-02-12 23:18                           ` Larry Finger
2007-02-12 23:24                           ` Michael Buesch
2007-02-13 16:25                             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702091753.12419.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Bcm43xx-dev@lists.berlios.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH] bcm43xx: Fix loss of association after resume' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.