From: Dave Jones <davej@redhat.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Chuck Ebbert <cebbert@redhat.com>,
Rudolf Marek <r.marek@assembler.cz>,
linux-acpi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org
Subject: Re: Could the k8temp driver be interfering with ACPI?
Date: Mon, 2 Apr 2007 15:22:09 -0400 [thread overview]
Message-ID: <20070402192209.GB15810@redhat.com> (raw)
In-Reply-To: <20070402174859.80b74b05.khali@linux-fr.org>
On Mon, Apr 02, 2007 at 05:48:59PM +0200, Jean Delvare wrote:
> + u8 val;
> +#ifdef CONFIG_ACPI
> + acpi_ut_acquire_mutex(ACPI_MTX_INTERPRETER);
> +#endif
> outb(reg, data->addr + ADDR_REG_OFFSET);
> - return inb(data->addr + DATA_REG_OFFSET);
> + val = inb(data->addr + DATA_REG_OFFSET);
> +#ifdef CONFIG_ACPI
> + acpi_ut_release_mutex(ACPI_MTX_INTERPRETER);
> +#endif
> + return val;
> ... deletia, more of the same.
it'd probably end up a lot cleaner to #define them to empty macros
in the !ACPI case in acpi/acpi.h and just #include it unconditionally.
Dave
--
http://www.codemonkey.org.uk
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Chuck Ebbert <cebbert@redhat.com>,
Rudolf Marek <r.marek@assembler.cz>,
linux-acpi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] Could the k8temp driver be interfering with ACPI?
Date: Mon, 02 Apr 2007 19:22:09 +0000 [thread overview]
Message-ID: <20070402192209.GB15810@redhat.com> (raw)
In-Reply-To: <20070402174859.80b74b05.khali@linux-fr.org>
On Mon, Apr 02, 2007 at 05:48:59PM +0200, Jean Delvare wrote:
> + u8 val;
> +#ifdef CONFIG_ACPI
> + acpi_ut_acquire_mutex(ACPI_MTX_INTERPRETER);
> +#endif
> outb(reg, data->addr + ADDR_REG_OFFSET);
> - return inb(data->addr + DATA_REG_OFFSET);
> + val = inb(data->addr + DATA_REG_OFFSET);
> +#ifdef CONFIG_ACPI
> + acpi_ut_release_mutex(ACPI_MTX_INTERPRETER);
> +#endif
> + return val;
> ... deletia, more of the same.
it'd probably end up a lot cleaner to #define them to empty macros
in the !ACPI case in acpi/acpi.h and just #include it unconditionally.
Dave
--
http://www.codemonkey.org.uk
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-04-02 19:24 UTC|newest]
Thread overview: 207+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 17:31 Could the k8temp driver be interfering with ACPI? Chuck Ebbert
2007-02-16 17:31 ` [lm-sensors] " Chuck Ebbert
2007-02-16 17:57 ` Len Brown
2007-02-16 17:57 ` [lm-sensors] " Len Brown
2007-02-16 18:14 ` Chuck Ebbert
2007-02-16 18:14 ` [lm-sensors] " Chuck Ebbert
2007-02-16 19:59 ` Andi Kleen
2007-02-16 19:59 ` [lm-sensors] " Andi Kleen
2007-02-16 19:31 ` Chuck Ebbert
2007-02-16 19:31 ` [lm-sensors] " Chuck Ebbert
2007-02-18 17:32 ` Jean Delvare
2007-02-18 17:32 ` Jean Delvare
2007-02-18 23:22 ` Andi Kleen
2007-02-18 23:22 ` Andi Kleen
2007-02-17 10:49 ` Rudolf Marek
2007-02-17 10:49 ` [lm-sensors] " Rudolf Marek
2007-02-17 10:49 ` Rudolf Marek
2007-02-17 18:14 ` Chuck Ebbert
2007-02-17 18:14 ` Chuck Ebbert
2007-02-18 17:38 ` Jean Delvare
2007-02-18 17:38 ` Jean Delvare
2007-02-20 15:18 ` Matthew Garrett
2007-02-20 15:18 ` Matthew Garrett
2007-02-20 15:33 ` Luca Tettamanti
2007-02-20 15:33 ` Luca Tettamanti
2007-02-21 14:59 ` Jean Delvare
2007-02-21 14:59 ` Jean Delvare
2007-02-21 15:07 ` Jean Delvare
2007-02-21 15:07 ` Jean Delvare
2007-02-28 21:38 ` Pavel Machek
2007-02-28 21:38 ` Pavel Machek
2007-03-01 14:26 ` Jean Delvare
2007-03-01 14:26 ` [lm-sensors] " Jean Delvare
2007-03-01 14:26 ` Jean Delvare
2007-03-01 17:48 ` Dave Jones
2007-03-01 17:48 ` Dave Jones
2007-03-02 11:27 ` Jean Delvare
2007-03-02 11:27 ` Jean Delvare
2007-03-02 11:31 ` Pavel Machek
2007-03-02 11:31 ` Pavel Machek
2007-03-02 13:37 ` Jean Delvare
2007-03-02 13:37 ` Jean Delvare
2007-03-02 13:47 ` Henrique de Moraes Holschuh
2007-03-02 13:47 ` Henrique de Moraes Holschuh
2007-03-02 13:57 ` Pavel Machek
2007-03-02 13:57 ` Pavel Machek
2007-03-03 6:44 ` Jean Delvare
2007-03-03 6:44 ` Jean Delvare
2007-03-02 11:40 ` Pavel Machek
2007-03-02 11:40 ` Pavel Machek
2007-03-02 11:47 ` Matthew Garrett
2007-03-02 11:47 ` Matthew Garrett
2007-03-02 13:58 ` Pavel Machek
2007-03-02 13:58 ` Pavel Machek
2007-03-02 21:00 ` Jean Delvare
2007-03-02 21:00 ` Jean Delvare
2007-03-02 21:22 ` Henrique de Moraes Holschuh
2007-03-02 21:22 ` Henrique de Moraes Holschuh
2007-04-01 15:39 ` Pavel Machek
2007-04-01 15:39 ` Pavel Machek
2007-04-02 15:48 ` Jean Delvare
2007-04-02 15:48 ` [lm-sensors] " Jean Delvare
2007-04-02 19:22 ` Dave Jones [this message]
2007-04-02 19:22 ` Dave Jones
2007-04-03 5:49 ` Jean Delvare
2007-04-03 5:49 ` [lm-sensors] " Jean Delvare
2007-04-02 20:55 ` Moore, Robert
2007-04-02 20:55 ` [lm-sensors] " Moore, Robert
2007-04-02 20:55 ` Moore, Robert
2007-04-03 7:21 ` Jean Delvare
2007-04-03 7:21 ` [lm-sensors] " Jean Delvare
2007-04-03 7:21 ` Jean Delvare
2007-04-04 21:35 ` Moore, Robert
2007-04-04 21:35 ` [lm-sensors] " Moore, Robert
2007-04-04 21:35 ` Moore, Robert
2007-03-02 14:10 ` [lm-sensors] " Jean Delvare
2007-03-02 14:10 ` Jean Delvare
2007-03-02 14:18 ` Matthew Garrett
2007-03-02 14:18 ` Matthew Garrett
2007-03-02 21:04 ` Jean Delvare
2007-03-02 21:04 ` Jean Delvare
2007-03-02 21:12 ` Matthew Garrett
2007-03-02 21:12 ` Matthew Garrett
2007-03-03 9:53 ` Jean Delvare
2007-03-03 9:53 ` Jean Delvare
2007-03-03 15:47 ` David Hubbard
2007-03-03 15:47 ` David Hubbard
2007-03-03 15:50 ` Matthew Garrett
2007-03-03 15:50 ` Matthew Garrett
2007-03-03 17:08 ` Rudolf Marek
2007-03-03 17:08 ` Rudolf Marek
2007-03-04 17:29 ` Rudolf Marek
2007-03-04 17:29 ` Rudolf Marek
2007-03-05 21:16 ` Jean Delvare
2007-03-05 21:16 ` Jean Delvare
2007-03-05 21:35 ` David Hubbard
2007-03-05 21:35 ` David Hubbard
2007-03-06 15:10 ` Jean Delvare
2007-03-06 15:10 ` Jean Delvare
2007-03-04 10:54 ` Jean Delvare
2007-03-04 10:54 ` Jean Delvare
2007-03-05 22:25 ` Pavel Machek
2007-03-05 22:25 ` Pavel Machek
2007-03-06 7:55 ` Benny Amorsen
2007-03-06 7:55 ` Benny Amorsen
2007-03-06 15:26 ` Jean Delvare
2007-03-06 15:26 ` Jean Delvare
2007-03-06 20:07 ` Stefan Monnier
2007-03-06 20:07 ` Stefan Monnier
2007-03-06 20:07 ` Stefan Monnier
2007-03-06 21:20 ` Pavel Machek
2007-03-06 21:20 ` Pavel Machek
2007-03-06 21:25 ` Moore, Robert
2007-03-06 21:25 ` Moore, Robert
2007-03-06 21:25 ` Moore, Robert
2007-03-18 19:36 ` richardvoigt
2007-03-18 19:36 ` richardvoigt at gmail.com
2007-03-19 7:08 ` Jean Delvare
2007-03-19 7:08 ` Jean Delvare
2007-03-02 22:07 ` Moore, Robert
2007-03-02 22:07 ` Moore, Robert
2007-03-02 22:07 ` Moore, Robert
2007-03-09 7:18 ` Pavel Machek
2007-03-09 7:18 ` Pavel Machek
2007-03-09 10:24 ` Jean Delvare
2007-03-09 10:24 ` Jean Delvare
2007-03-09 10:39 ` Alexey Starikovskiy
2007-03-09 10:39 ` Alexey Starikovskiy
2007-03-09 11:21 ` Pavel Machek
2007-03-09 11:21 ` Pavel Machek
2007-03-09 17:23 ` Jean Delvare
2007-03-09 17:23 ` Jean Delvare
2007-03-09 17:35 ` Alexey Starikovskiy
2007-03-09 17:35 ` Alexey Starikovskiy
2007-03-09 21:03 ` Moore, Robert
2007-03-09 21:03 ` Moore, Robert
2007-03-09 21:03 ` Moore, Robert
2007-03-09 20:56 ` Moore, Robert
2007-03-09 20:56 ` Moore, Robert
2007-03-09 20:56 ` Moore, Robert
2007-03-02 14:22 ` Pavel Machek
2007-03-02 14:22 ` Pavel Machek
2007-03-02 14:03 ` Jean Delvare
2007-03-02 14:03 ` Jean Delvare
2007-03-02 14:24 ` Pavel Machek
2007-03-02 14:24 ` Pavel Machek
2007-03-02 14:57 ` Matthew Garrett
2007-03-02 14:57 ` Matthew Garrett
2007-03-02 21:41 ` Jean Delvare
2007-03-02 21:41 ` Jean Delvare
2007-03-02 21:46 ` Matthew Garrett
2007-03-02 21:46 ` Matthew Garrett
2007-03-06 21:28 ` Jean Delvare
2007-03-06 21:28 ` Jean Delvare
2007-04-13 18:18 ` Bjorn Helgaas
2007-04-13 18:18 ` Bjorn Helgaas
2007-04-13 20:07 ` Pavel Machek
2007-04-13 20:07 ` Pavel Machek
2007-04-13 20:59 ` Bjorn Helgaas
2007-04-13 20:59 ` Bjorn Helgaas
2007-04-15 9:41 ` Jean Delvare
2007-04-15 9:41 ` Jean Delvare
2007-04-15 20:31 ` Bjorn Helgaas
2007-04-15 20:31 ` Bjorn Helgaas
2007-04-15 20:59 ` Luca Tettamanti
2007-04-15 20:59 ` Luca Tettamanti
2007-04-16 0:57 ` Bjorn Helgaas
2007-04-16 0:57 ` Bjorn Helgaas
2007-04-16 21:14 ` Luca Tettamanti
2007-04-16 21:14 ` Luca Tettamanti
2007-04-16 22:28 ` Bjorn Helgaas
2007-04-16 22:28 ` Bjorn Helgaas
2007-04-17 23:50 ` Luca Tettamanti
2007-04-17 23:50 ` Luca Tettamanti
2007-04-22 16:55 ` Luca Tettamanti
2007-04-22 16:55 ` Luca Tettamanti
2007-04-17 10:03 ` Jean Delvare
2007-04-17 10:03 ` Jean Delvare
2007-02-18 22:43 ` Rudolf Marek
2007-02-18 22:43 ` Rudolf Marek
2007-02-20 15:08 ` Chuck Ebbert
2007-02-20 15:08 ` Chuck Ebbert
2007-02-20 19:11 ` Dave Jones
2007-02-20 19:11 ` Dave Jones
2007-02-21 16:17 ` Jean Delvare
2007-02-21 16:17 ` Jean Delvare
2007-02-21 17:37 ` Dave Jones
2007-02-21 17:37 ` Dave Jones
2007-02-21 20:19 ` Dave Jones
2007-02-21 20:19 ` Dave Jones
2007-02-22 16:37 ` Jean Delvare
2007-02-22 16:37 ` Jean Delvare
2007-02-23 7:13 ` Hans de Goede
2007-02-23 7:13 ` [lm-sensors] " Hans de Goede
2007-02-23 7:13 ` Hans de Goede
2007-02-23 7:47 ` Jean Delvare
2007-02-23 7:47 ` Jean Delvare
2007-02-21 14:54 ` Jean Delvare
2007-02-21 14:54 ` Jean Delvare
2007-02-21 16:03 ` Chuck Ebbert
2007-02-21 16:03 ` Chuck Ebbert
2007-02-21 16:22 ` Jean Delvare
2007-02-21 16:22 ` Jean Delvare
2007-02-23 8:08 ` Hans de Goede
2007-02-26 17:24 ` Jean Delvare
2007-02-26 19:03 ` Hans de Goede
2007-02-27 8:45 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070402192209.GB15810@redhat.com \
--to=davej@redhat.com \
--cc=cebbert@redhat.com \
--cc=khali@linux-fr.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mjg59@srcf.ucam.org \
--cc=pavel@ucw.cz \
--cc=r.marek@assembler.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.