From: "Michael S. Tsirkin" <mst@redhat.com> To: Blue Swirl <blauwirbel@gmail.com> Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Alex Williamson <alex.williamson@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>, Anthony Liguori <anthony@codemonkey.ws> Subject: Re: [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Wed, 5 Sep 2012 00:28:16 +0300 [thread overview] Message-ID: <20120904212816.GE3602@redhat.com> (raw) In-Reply-To: <CAAu8pHtMsKSbi3isEsgnXe5AJv=Y4fysejqCksqoEWKVCn_Bpg@mail.gmail.com> On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: > On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity <avi@redhat.com> wrote: > > On 09/03/2012 10:32 PM, Blue Swirl wrote: > >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity <avi@redhat.com> wrote: > >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: > >>>> > >>>> I don't see a point in making contributors avoid non-problems that might > >>>> conceivably become trivial problems some day. Especially when there's > >>>> no automated help with the avoiding. > >>> > >>> -Wpointer-arith > >> > >> +1 > > > > FWIW, I'm not in favour of enabling it, just pointing out that it > > exists. In general I prefer avoiding unnecessary use of extensions, but > > in this case the extension is trivial and improves readability. > > Void pointers are not so type safe as uint8_t pointers. casts are even worse. > There's also > little difference in readability between those in my opinion. here too, casts are worse for readability. > > > > > > -- > > error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Blue Swirl <blauwirbel@gmail.com> Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Alex Williamson <alex.williamson@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>, Anthony Liguori <anthony@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Wed, 5 Sep 2012 00:28:16 +0300 [thread overview] Message-ID: <20120904212816.GE3602@redhat.com> (raw) In-Reply-To: <CAAu8pHtMsKSbi3isEsgnXe5AJv=Y4fysejqCksqoEWKVCn_Bpg@mail.gmail.com> On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: > On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity <avi@redhat.com> wrote: > > On 09/03/2012 10:32 PM, Blue Swirl wrote: > >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity <avi@redhat.com> wrote: > >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: > >>>> > >>>> I don't see a point in making contributors avoid non-problems that might > >>>> conceivably become trivial problems some day. Especially when there's > >>>> no automated help with the avoiding. > >>> > >>> -Wpointer-arith > >> > >> +1 > > > > FWIW, I'm not in favour of enabling it, just pointing out that it > > exists. In general I prefer avoiding unnecessary use of extensions, but > > in this case the extension is trivial and improves readability. > > Void pointers are not so type safe as uint8_t pointers. casts are even worse. > There's also > little difference in readability between those in my opinion. here too, casts are worse for readability. > > > > > > -- > > error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-09-04 21:28 UTC|newest] Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-27 6:28 [PATCH 0/4] uq/master: Add classic PCI device assignment Jan Kiszka 2012-08-27 6:28 ` [Qemu-devel] " Jan Kiszka 2012-08-27 6:28 ` [PATCH 1/4] kvm: Introduce kvm_irqchip_update_msi_route Jan Kiszka 2012-08-27 6:28 ` [Qemu-devel] " Jan Kiszka 2012-08-27 6:28 ` [PATCH 2/4] kvm: Introduce kvm_has_intx_set_mask Jan Kiszka 2012-08-27 6:28 ` [Qemu-devel] " Jan Kiszka 2012-08-27 6:28 ` [PATCH 3/4] kvm: i386: Add services required for PCI device assignment Jan Kiszka 2012-08-27 6:28 ` [Qemu-devel] " Jan Kiszka 2012-08-27 6:28 ` [PATCH 4/4] kvm: i386: Add classic " Jan Kiszka 2012-08-27 6:28 ` [Qemu-devel] " Jan Kiszka 2012-08-27 12:07 ` Andreas Färber 2012-08-27 12:07 ` Andreas Färber 2012-08-27 12:15 ` Jan Kiszka 2012-08-27 12:15 ` [Qemu-devel] " Jan Kiszka 2012-08-28 21:26 ` Peter Maydell 2012-08-28 21:26 ` [Qemu-devel] " Peter Maydell 2012-08-29 8:47 ` Jan Kiszka 2012-08-29 8:47 ` [Qemu-devel] " Jan Kiszka 2012-08-29 8:49 ` Peter Maydell 2012-08-29 8:49 ` Peter Maydell 2012-08-29 8:50 ` Jan Kiszka 2012-08-29 8:50 ` Jan Kiszka 2012-09-03 15:59 ` Avi Kivity 2012-09-03 15:59 ` Avi Kivity 2012-09-04 3:31 ` Alex Williamson 2012-09-04 3:31 ` [Qemu-devel] " Alex Williamson 2012-08-28 12:57 ` Anthony Liguori 2012-08-28 12:57 ` Anthony Liguori 2012-08-29 14:08 ` Andreas Färber 2012-08-29 14:08 ` Andreas Färber 2012-08-29 18:32 ` Anthony Liguori 2012-08-29 18:32 ` [Qemu-devel] " Anthony Liguori 2012-09-04 21:00 ` Anthony Liguori 2012-09-04 21:00 ` [Qemu-devel] " Anthony Liguori 2012-09-05 15:26 ` Avi Kivity 2012-09-05 15:26 ` [Qemu-devel] " Avi Kivity 2012-09-05 15:29 ` Michael S. Tsirkin 2012-09-05 15:29 ` Michael S. Tsirkin 2012-09-05 15:41 ` Anthony Liguori 2012-09-05 15:41 ` Anthony Liguori 2012-09-05 15:52 ` Avi Kivity 2012-09-05 15:52 ` Avi Kivity 2012-09-05 19:04 ` Blue Swirl 2012-09-05 19:04 ` Blue Swirl 2012-09-05 19:22 ` Anthony Liguori 2012-09-05 19:22 ` Anthony Liguori 2012-09-05 19:38 ` Blue Swirl 2012-09-05 19:38 ` Blue Swirl 2012-09-05 20:46 ` Anthony Liguori 2012-09-05 20:46 ` [Qemu-devel] " Anthony Liguori 2012-09-10 15:33 ` Andreas Färber 2012-09-10 15:33 ` Andreas Färber 2012-09-06 3:42 ` [Qemu-ppc] " Alexander Graf 2012-09-06 3:42 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf 2012-09-08 7:54 ` [Qemu-ppc] [Qemu-devel] " Blue Swirl 2012-09-08 7:54 ` [Qemu-devel] [Qemu-ppc] " Blue Swirl 2012-09-05 19:24 ` Eric Blake 2012-09-05 19:24 ` [Qemu-devel] " Eric Blake 2012-09-05 19:43 ` Blue Swirl 2012-09-05 19:43 ` Blue Swirl 2012-09-06 8:44 ` Avi Kivity 2012-09-06 8:44 ` Avi Kivity 2012-09-08 8:06 ` Blue Swirl 2012-09-08 8:06 ` [Qemu-devel] " Blue Swirl 2012-09-08 9:28 ` [Qemu-ppc] " Alexander Graf 2012-09-08 9:28 ` [Qemu-devel] " Alexander Graf 2012-09-08 10:16 ` [Qemu-ppc] [Qemu-devel] " Blue Swirl 2012-09-08 10:16 ` [Qemu-devel] [Qemu-ppc] " Blue Swirl 2012-09-08 12:13 ` Alexander Graf 2012-09-08 12:13 ` [Qemu-devel] " Alexander Graf 2012-09-08 12:30 ` Blue Swirl 2012-09-08 12:30 ` [Qemu-devel] " Blue Swirl 2012-09-08 14:59 ` Alexander Graf 2012-09-08 14:59 ` [Qemu-devel] " Alexander Graf 2012-08-27 18:56 ` Blue Swirl 2012-08-27 18:56 ` [Qemu-devel] " Blue Swirl 2012-08-27 19:01 ` Michael S. Tsirkin 2012-08-27 19:01 ` Michael S. Tsirkin 2012-08-27 19:06 ` Blue Swirl 2012-08-27 19:06 ` [Qemu-devel] " Blue Swirl 2012-08-28 0:30 ` Jan Kiszka 2012-08-28 0:30 ` Jan Kiszka 2012-09-03 16:06 ` Avi Kivity 2012-09-03 16:06 ` Avi Kivity 2012-08-28 7:35 ` Michael Tokarev 2012-08-28 7:35 ` Michael Tokarev 2012-08-28 17:01 ` Blue Swirl 2012-08-28 17:01 ` Blue Swirl 2012-08-28 17:28 ` Michael S. Tsirkin 2012-08-28 17:28 ` Michael S. Tsirkin 2012-08-28 17:38 ` Blue Swirl 2012-08-28 17:38 ` Blue Swirl 2012-08-28 19:31 ` Anthony Liguori 2012-08-28 19:31 ` [Qemu-devel] " Anthony Liguori 2012-08-28 19:49 ` malc 2012-08-28 19:49 ` [Qemu-devel] " malc 2012-08-28 20:06 ` Blue Swirl 2012-08-28 20:06 ` Blue Swirl 2012-08-28 21:51 ` Anthony Liguori 2012-08-28 21:51 ` Anthony Liguori 2012-09-01 9:20 ` Blue Swirl 2012-09-01 9:20 ` [Qemu-devel] " Blue Swirl 2012-08-29 8:27 ` Markus Armbruster 2012-08-29 8:27 ` [Qemu-devel] " Markus Armbruster 2012-09-03 16:14 ` Avi Kivity 2012-09-03 16:14 ` [Qemu-devel] " Avi Kivity 2012-09-03 19:32 ` Blue Swirl 2012-09-03 19:32 ` [Qemu-devel] " Blue Swirl 2012-09-04 8:32 ` Avi Kivity 2012-09-04 8:32 ` Avi Kivity 2012-09-04 19:27 ` Blue Swirl 2012-09-04 19:27 ` Blue Swirl 2012-09-04 21:28 ` Michael S. Tsirkin [this message] 2012-09-04 21:28 ` Michael S. Tsirkin 2012-09-05 19:09 ` Blue Swirl 2012-09-05 19:09 ` Blue Swirl 2012-08-28 11:02 ` [PATCH v2 " Jan Kiszka 2012-08-28 11:02 ` [Qemu-devel] " Jan Kiszka 2012-08-28 21:49 ` Michael S. Tsirkin 2012-08-28 21:49 ` [Qemu-devel] " Michael S. Tsirkin 2012-08-29 8:44 ` Jan Kiszka 2012-08-29 8:44 ` [Qemu-devel] " Jan Kiszka 2012-08-29 10:35 ` Michael S. Tsirkin 2012-08-29 10:35 ` [Qemu-devel] " Michael S. Tsirkin 2012-08-30 18:30 ` [PATCH v3 " Jan Kiszka 2012-08-30 18:30 ` [Qemu-devel] " Jan Kiszka 2012-09-06 8:44 ` Jan Kiszka 2012-09-06 8:44 ` [Qemu-devel] " Jan Kiszka 2012-09-06 8:49 ` Michael S. Tsirkin 2012-09-06 8:49 ` [Qemu-devel] " Michael S. Tsirkin 2012-09-06 16:06 ` Andreas Färber 2012-09-06 16:06 ` [Qemu-devel] " Andreas Färber 2012-09-06 16:16 ` Jan Kiszka 2012-09-06 16:16 ` [Qemu-devel] " Jan Kiszka 2012-09-08 7:55 ` Blue Swirl 2012-09-08 7:55 ` [Qemu-devel] " Blue Swirl 2012-09-09 14:13 ` Avi Kivity 2012-09-09 14:13 ` [Qemu-devel] " Avi Kivity 2012-09-10 9:26 ` Jan Kiszka 2012-09-10 9:26 ` [Qemu-devel] " Jan Kiszka 2012-09-10 12:30 ` Avi Kivity 2012-09-10 12:30 ` [Qemu-devel] " Avi Kivity 2012-08-28 15:04 ` [PATCH " Michael S. Tsirkin 2012-08-28 15:04 ` [Qemu-devel] " Michael S. Tsirkin 2012-08-29 10:50 ` Jan Kiszka 2012-08-29 10:50 ` [Qemu-devel] " Jan Kiszka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120904212816.GE3602@redhat.com \ --to=mst@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=anthony@codemonkey.ws \ --cc=armbru@redhat.com \ --cc=avi@redhat.com \ --cc=blauwirbel@gmail.com \ --cc=jan.kiszka@web.de \ --cc=kvm@vger.kernel.org \ --cc=mjt@tls.msk.ru \ --cc=mtosatti@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.