From: Simon Horman <horms@verge.net.au> To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] ARM: mach-shmobile: r8a7779: Allow initialisation of GIC by DT Date: Fri, 01 Feb 2013 00:11:19 +0000 [thread overview] Message-ID: <20130201001119.GO10312@verge.net.au> (raw) In-Reply-To: <20130131123213.GB7235@e106331-lin.cambridge.arm.com> On Thu, Jan 31, 2013 at 12:32:13PM +0000, Mark Rutland wrote: > Hi Simon, > > On Thu, Jan 31, 2013 at 01:50:49AM +0000, Simon Horman wrote: > > This allows the GIC interrupt controller of the r8a7779 SoC to be > > initialised using a flattened device tree blob. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > arch/arm/boot/dts/r8a7779.dtsi | 40 ++++++++++++++++++++++++++ > > arch/arm/mach-shmobile/include/mach/common.h | 1 + > > arch/arm/mach-shmobile/intc-r8a7779.c | 27 +++++++++++++---- > > 3 files changed, 62 insertions(+), 6 deletions(-) > > create mode 100644 arch/arm/boot/dts/r8a7779.dtsi > > > > diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi > > new file mode 100644 > > index 0000000..eadc12e > > --- /dev/null > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > @@ -0,0 +1,40 @@ > > +/* > > + * Device Tree Source for Renesas r8a7740 > > + * > > + * Copyright (C) 2013 Renesas Solutions Corp. > > + * Copyright (C) 2013 Simon Horman > > + * > > + * This file is licensed under the terms of the GNU General Public License > > + * version 2. This program is licensed "as is" without any warranty of any > > + * kind, whether express or implied. > > + */ > > + > > +/include/ "skeleton.dtsi" > > + > > +/ { > > + compatible = "renesas,r8a7779"; > > + > > + cpus { > > + cpu@0 { > > + compatible = "arm,cortex-a9"; > > + }; > > + cpu@1 { > > + compatible = "arm,cortex-a9"; > > + }; > > + cpu@2 { > > + compatible = "arm,cortex-a9"; > > + }; > > + cpu@3 { > > + compatible = "arm,cortex-a9"; > > + }; > > + }; > > Sorry to sound like a broken record, but it'd be good to see reg and > device_type set here. Sure, will do. > > + > > + gic: interrupt-controller@f0001000 { > > + compatible = "arm,cortex-a9-gic"; > > + #interrupt-cells = <3>; > > + #address-cells = <1>; > > Why is #address-cells needed here (and without #size-cells)? I see it's in the > binding document example, but I can't figure out why. Its here because I copied the example. I will see about removing it from here. > > + interrupt-controller; > > + reg = <0xf0001000 0x1000>, > > + <0xf0000100 0x100>; > > + }; > > +}; > > [...] > > Thanks, > Mark. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] ARM: mach-shmobile: r8a7779: Allow initialisation of GIC by DT Date: Fri, 1 Feb 2013 09:11:19 +0900 [thread overview] Message-ID: <20130201001119.GO10312@verge.net.au> (raw) In-Reply-To: <20130131123213.GB7235@e106331-lin.cambridge.arm.com> On Thu, Jan 31, 2013 at 12:32:13PM +0000, Mark Rutland wrote: > Hi Simon, > > On Thu, Jan 31, 2013 at 01:50:49AM +0000, Simon Horman wrote: > > This allows the GIC interrupt controller of the r8a7779 SoC to be > > initialised using a flattened device tree blob. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > arch/arm/boot/dts/r8a7779.dtsi | 40 ++++++++++++++++++++++++++ > > arch/arm/mach-shmobile/include/mach/common.h | 1 + > > arch/arm/mach-shmobile/intc-r8a7779.c | 27 +++++++++++++---- > > 3 files changed, 62 insertions(+), 6 deletions(-) > > create mode 100644 arch/arm/boot/dts/r8a7779.dtsi > > > > diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi > > new file mode 100644 > > index 0000000..eadc12e > > --- /dev/null > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > @@ -0,0 +1,40 @@ > > +/* > > + * Device Tree Source for Renesas r8a7740 > > + * > > + * Copyright (C) 2013 Renesas Solutions Corp. > > + * Copyright (C) 2013 Simon Horman > > + * > > + * This file is licensed under the terms of the GNU General Public License > > + * version 2. This program is licensed "as is" without any warranty of any > > + * kind, whether express or implied. > > + */ > > + > > +/include/ "skeleton.dtsi" > > + > > +/ { > > + compatible = "renesas,r8a7779"; > > + > > + cpus { > > + cpu at 0 { > > + compatible = "arm,cortex-a9"; > > + }; > > + cpu at 1 { > > + compatible = "arm,cortex-a9"; > > + }; > > + cpu at 2 { > > + compatible = "arm,cortex-a9"; > > + }; > > + cpu at 3 { > > + compatible = "arm,cortex-a9"; > > + }; > > + }; > > Sorry to sound like a broken record, but it'd be good to see reg and > device_type set here. Sure, will do. > > + > > + gic: interrupt-controller at f0001000 { > > + compatible = "arm,cortex-a9-gic"; > > + #interrupt-cells = <3>; > > + #address-cells = <1>; > > Why is #address-cells needed here (and without #size-cells)? I see it's in the > binding document example, but I can't figure out why. Its here because I copied the example. I will see about removing it from here. > > + interrupt-controller; > > + reg = <0xf0001000 0x1000>, > > + <0xf0000100 0x100>; > > + }; > > +}; > > [...] > > Thanks, > Mark. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2013-02-01 0:11 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-31 1:50 ARM: mach-shmobile: r8a7779, marzen: Reference DT implementation Simon Horman 2013-01-31 1:50 ` Simon Horman 2013-01-31 1:50 ` [PATCH 1/4] ARM: mach-shmobile: marzen: defconfig: use regulators by default Simon Horman 2013-01-31 1:50 ` Simon Horman 2013-01-31 1:50 ` [PATCH 2/4] ARM: mach-shmobile: r8a7779: Allow initialisation of GIC by DT Simon Horman 2013-01-31 1:50 ` Simon Horman 2013-01-31 12:32 ` Mark Rutland 2013-01-31 12:32 ` Mark Rutland 2013-02-01 0:11 ` Simon Horman [this message] 2013-02-01 0:11 ` Simon Horman 2013-02-01 0:34 ` Simon Horman 2013-02-01 0:34 ` Simon Horman 2013-02-01 1:47 ` Simon Horman 2013-02-01 1:47 ` Simon Horman 2013-02-01 4:39 ` Simon Horman 2013-02-01 4:39 ` Simon Horman 2013-02-01 11:31 ` Mark Rutland 2013-02-01 11:31 ` Mark Rutland 2013-02-01 10:58 ` Mark Rutland 2013-02-01 10:58 ` Mark Rutland 2013-02-01 14:15 ` Rob Herring 2013-02-01 14:15 ` Rob Herring 2013-02-04 17:37 ` Mark Rutland 2013-02-04 17:37 ` Mark Rutland 2013-02-16 21:43 ` [PATCH 2/4] ARM: mach-shmobile: r8a7779: add SATA support Sergei Shtylyov 2013-02-16 22:43 ` Sergei Shtylyov 2013-02-18 1:23 ` Kuninori Morimoto 2013-02-18 1:23 ` Kuninori Morimoto 2013-02-18 14:07 ` Sergei Shtylyov 2013-02-18 14:07 ` Sergei Shtylyov 2013-02-18 14:21 ` Magnus Damm 2013-02-18 14:21 ` Magnus Damm 2013-02-19 0:40 ` Kuninori Morimoto 2013-02-19 0:40 ` Kuninori Morimoto 2013-02-19 1:26 ` Simon Horman 2013-02-19 1:26 ` Simon Horman 2013-02-19 14:26 ` Sergei Shtylyov 2013-02-19 14:26 ` Sergei Shtylyov 2013-02-19 1:25 ` Simon Horman 2013-02-19 1:25 ` Simon Horman 2013-01-31 1:50 ` [PATCH 3/4] ARM: mach-shmobile: r8a7779: Minimal setup using DT Simon Horman 2013-01-31 1:50 ` Simon Horman 2013-02-18 9:36 ` Magnus Damm 2013-02-18 9:36 ` Magnus Damm 2013-02-18 11:37 ` Simon Horman 2013-02-18 11:37 ` Simon Horman 2013-02-18 12:14 ` Magnus Damm 2013-02-18 12:14 ` Magnus Damm 2013-02-18 12:37 ` Simon Horman 2013-02-18 12:37 ` Simon Horman 2013-02-18 12:22 ` Magnus Damm 2013-02-18 12:22 ` Magnus Damm 2013-02-18 12:37 ` Simon Horman 2013-02-18 12:37 ` Simon Horman 2013-02-18 19:30 ` [PATCH 3/4] ARM: mach-shmobile: r8a7779: add SATA support Sergei Shtylyov 2013-02-18 20:31 ` Sergei Shtylyov 2013-01-31 1:50 ` [PATCH 4/4] ARM: mach-shmobile: marzen: Reference DT implementation Simon Horman 2013-01-31 1:50 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130201001119.GO10312@verge.net.au \ --to=horms@verge.net.au \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.