From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: mach-shmobile: r8a7779: add SATA support
Date: Mon, 18 Feb 2013 14:07:00 +0000 [thread overview]
Message-ID: <51223584.5080709@cogentembedded.com> (raw)
In-Reply-To: <874nhao1nx.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 18-02-2013 5:23, Kuninori Morimoto wrote:
>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Add SATA clock and platform device resources on r8a7779 SoC.
>> Add entry to r8a7779_auxdata_lookup[], so that devm_clk_get() in the driver
>> still works when we're using the device tree.
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> (snip)
>> /* MSTP32 clocks */
>> + CLKDEV_DEV_ID("sata_rcar", &mstp_clks[MSTP115]), /* SATA */
>> CLKDEV_DEV_ID("ehci-platform.1", &mstp_clks[MSTP101]), /* USB EHCI port2 */
>> CLKDEV_DEV_ID("ohci-platform.1", &mstp_clks[MSTP101]), /* USB OHCI port2 */
>> CLKDEV_DEV_ID("ehci-platform.0", &mstp_clks[MSTP100]), /* USB EHCI port0/1 */
> (snip)
>> static const struct of_dev_auxdata r8a7779_auxdata_lookup[] __initconst = {
>> + OF_DEV_AUXDATA("renesas,rcar-sata", 0xfc600000, "sata_rcar", NULL),
> ??
> Is this settings really required for DT ??
Yes, TTBOMK, it's the last resort measure used in exctly this case.
> I guess you can remove it, and add
> + CLKDEV_DEV_ID("sata_rcar", &mstp_clks[MSTP115]), // for platform
> + CLKDEV_DEV_ID("fc600000.sata_rcar", &mstp_clks[MSTP115]), // for DT
IMO, this neither looks nor scales well.
> And...
>> [1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration
>> [2/4] ARM: mach-shmobile: r8a7779: add SATA support
>> [3/4] libata: add R-Car SATA driver
>> [4/4] ARM: mach-shmobile: marzen: add SATA support
> I believe [3/4] patch should be base patch ?
You're probably right, I'll reorder the patches when posting V2.
> Best regards
> ---
> Kuninori Morimoto
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: mach-shmobile: r8a7779: add SATA support
Date: Mon, 18 Feb 2013 18:07:00 +0400 [thread overview]
Message-ID: <51223584.5080709@cogentembedded.com> (raw)
In-Reply-To: <874nhao1nx.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 18-02-2013 5:23, Kuninori Morimoto wrote:
>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Add SATA clock and platform device resources on r8a7779 SoC.
>> Add entry to r8a7779_auxdata_lookup[], so that devm_clk_get() in the driver
>> still works when we're using the device tree.
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> (snip)
>> /* MSTP32 clocks */
>> + CLKDEV_DEV_ID("sata_rcar", &mstp_clks[MSTP115]), /* SATA */
>> CLKDEV_DEV_ID("ehci-platform.1", &mstp_clks[MSTP101]), /* USB EHCI port2 */
>> CLKDEV_DEV_ID("ohci-platform.1", &mstp_clks[MSTP101]), /* USB OHCI port2 */
>> CLKDEV_DEV_ID("ehci-platform.0", &mstp_clks[MSTP100]), /* USB EHCI port0/1 */
> (snip)
>> static const struct of_dev_auxdata r8a7779_auxdata_lookup[] __initconst = {
>> + OF_DEV_AUXDATA("renesas,rcar-sata", 0xfc600000, "sata_rcar", NULL),
> ??
> Is this settings really required for DT ??
Yes, TTBOMK, it's the last resort measure used in exctly this case.
> I guess you can remove it, and add
> + CLKDEV_DEV_ID("sata_rcar", &mstp_clks[MSTP115]), // for platform
> + CLKDEV_DEV_ID("fc600000.sata_rcar", &mstp_clks[MSTP115]), // for DT
IMO, this neither looks nor scales well.
> And...
>> [1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration
>> [2/4] ARM: mach-shmobile: r8a7779: add SATA support
>> [3/4] libata: add R-Car SATA driver
>> [4/4] ARM: mach-shmobile: marzen: add SATA support
> I believe [3/4] patch should be base patch ?
You're probably right, I'll reorder the patches when posting V2.
> Best regards
> ---
> Kuninori Morimoto
WBR, Sergei
next prev parent reply other threads:[~2013-02-18 14:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 1:50 ARM: mach-shmobile: r8a7779, marzen: Reference DT implementation Simon Horman
2013-01-31 1:50 ` Simon Horman
2013-01-31 1:50 ` [PATCH 1/4] ARM: mach-shmobile: marzen: defconfig: use regulators by default Simon Horman
2013-01-31 1:50 ` Simon Horman
2013-01-31 1:50 ` [PATCH 2/4] ARM: mach-shmobile: r8a7779: Allow initialisation of GIC by DT Simon Horman
2013-01-31 1:50 ` Simon Horman
2013-01-31 12:32 ` Mark Rutland
2013-01-31 12:32 ` Mark Rutland
2013-02-01 0:11 ` Simon Horman
2013-02-01 0:11 ` Simon Horman
2013-02-01 0:34 ` Simon Horman
2013-02-01 0:34 ` Simon Horman
2013-02-01 1:47 ` Simon Horman
2013-02-01 1:47 ` Simon Horman
2013-02-01 4:39 ` Simon Horman
2013-02-01 4:39 ` Simon Horman
2013-02-01 11:31 ` Mark Rutland
2013-02-01 11:31 ` Mark Rutland
2013-02-01 10:58 ` Mark Rutland
2013-02-01 10:58 ` Mark Rutland
2013-02-01 14:15 ` Rob Herring
2013-02-01 14:15 ` Rob Herring
2013-02-04 17:37 ` Mark Rutland
2013-02-04 17:37 ` Mark Rutland
2013-02-16 21:43 ` [PATCH 2/4] ARM: mach-shmobile: r8a7779: add SATA support Sergei Shtylyov
2013-02-16 22:43 ` Sergei Shtylyov
2013-02-18 1:23 ` Kuninori Morimoto
2013-02-18 1:23 ` Kuninori Morimoto
2013-02-18 14:07 ` Sergei Shtylyov [this message]
2013-02-18 14:07 ` Sergei Shtylyov
2013-02-18 14:21 ` Magnus Damm
2013-02-18 14:21 ` Magnus Damm
2013-02-19 0:40 ` Kuninori Morimoto
2013-02-19 0:40 ` Kuninori Morimoto
2013-02-19 1:26 ` Simon Horman
2013-02-19 1:26 ` Simon Horman
2013-02-19 14:26 ` Sergei Shtylyov
2013-02-19 14:26 ` Sergei Shtylyov
2013-02-19 1:25 ` Simon Horman
2013-02-19 1:25 ` Simon Horman
2013-01-31 1:50 ` [PATCH 3/4] ARM: mach-shmobile: r8a7779: Minimal setup using DT Simon Horman
2013-01-31 1:50 ` Simon Horman
2013-02-18 9:36 ` Magnus Damm
2013-02-18 9:36 ` Magnus Damm
2013-02-18 11:37 ` Simon Horman
2013-02-18 11:37 ` Simon Horman
2013-02-18 12:14 ` Magnus Damm
2013-02-18 12:14 ` Magnus Damm
2013-02-18 12:37 ` Simon Horman
2013-02-18 12:37 ` Simon Horman
2013-02-18 12:22 ` Magnus Damm
2013-02-18 12:22 ` Magnus Damm
2013-02-18 12:37 ` Simon Horman
2013-02-18 12:37 ` Simon Horman
2013-02-18 19:30 ` [PATCH 3/4] ARM: mach-shmobile: r8a7779: add SATA support Sergei Shtylyov
2013-02-18 20:31 ` Sergei Shtylyov
2013-01-31 1:50 ` [PATCH 4/4] ARM: mach-shmobile: marzen: Reference DT implementation Simon Horman
2013-01-31 1:50 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51223584.5080709@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.